Commit fa10a299 authored by Juan Lang's avatar Juan Lang Committed by Alexandre Julliard

crypt32: Remove wrong test and parameter check.

parent 3c9e7a7f
...@@ -1920,12 +1920,6 @@ static PWINECRYPT_CERTSTORE CRYPT_FileNameOpenStoreW(HCRYPTPROV hCryptProv, ...@@ -1920,12 +1920,6 @@ static PWINECRYPT_CERTSTORE CRYPT_FileNameOpenStoreW(HCRYPTPROV hCryptProv,
SetLastError(ERROR_PATH_NOT_FOUND); SetLastError(ERROR_PATH_NOT_FOUND);
return NULL; return NULL;
} }
if (!(dwFlags & (CERT_FILE_STORE_COMMIT_ENABLE_FLAG |
CERT_STORE_READONLY_FLAG)))
{
SetLastError(ERROR_FILE_NOT_FOUND);
return NULL;
}
access = GENERIC_READ; access = GENERIC_READ;
if (dwFlags & CERT_FILE_STORE_COMMIT_ENABLE_FLAG) if (dwFlags & CERT_FILE_STORE_COMMIT_ENABLE_FLAG)
......
...@@ -1230,34 +1230,6 @@ static void testFileNameStore(void) ...@@ -1230,34 +1230,6 @@ static void testFileNameStore(void)
checkFileStoreFailure(filename, 0, checkFileStoreFailure(filename, 0,
CERT_FILE_STORE_COMMIT_ENABLE_FLAG | CERT_STORE_READONLY_FLAG, CERT_FILE_STORE_COMMIT_ENABLE_FLAG | CERT_STORE_READONLY_FLAG,
E_INVALIDARG); E_INVALIDARG);
/* Without an encoding type, these all fail */
checkFileStoreFailure(filename, 0, 0, ERROR_FILE_NOT_FOUND);
checkFileStoreFailure(filename, 0, CERT_STORE_OPEN_EXISTING_FLAG,
ERROR_FILE_NOT_FOUND);
checkFileStoreFailure(filename, 0, CERT_STORE_CREATE_NEW_FLAG,
ERROR_FILE_NOT_FOUND);
/* Without a message encoding type, these still fail */
checkFileStoreFailure(filename, X509_ASN_ENCODING, 0, ERROR_FILE_NOT_FOUND);
checkFileStoreFailure(filename, X509_ASN_ENCODING,
CERT_STORE_OPEN_EXISTING_FLAG, ERROR_FILE_NOT_FOUND);
checkFileStoreFailure(filename, X509_ASN_ENCODING,
CERT_STORE_CREATE_NEW_FLAG, ERROR_FILE_NOT_FOUND);
/* Without a cert encoding type, they still fail */
checkFileStoreFailure(filename, PKCS_7_ASN_ENCODING, 0,
ERROR_FILE_NOT_FOUND);
checkFileStoreFailure(filename, PKCS_7_ASN_ENCODING,
CERT_STORE_OPEN_EXISTING_FLAG, ERROR_FILE_NOT_FOUND);
checkFileStoreFailure(filename, PKCS_7_ASN_ENCODING,
CERT_STORE_CREATE_NEW_FLAG, ERROR_FILE_NOT_FOUND);
/* With both a message and cert encoding type, but without commit enabled,
* they still fail
*/
checkFileStoreFailure(filename, X509_ASN_ENCODING | PKCS_7_ASN_ENCODING, 0,
ERROR_FILE_NOT_FOUND);
checkFileStoreFailure(filename, X509_ASN_ENCODING | PKCS_7_ASN_ENCODING,
CERT_STORE_OPEN_EXISTING_FLAG, ERROR_FILE_NOT_FOUND);
checkFileStoreFailure(filename, X509_ASN_ENCODING | PKCS_7_ASN_ENCODING,
CERT_STORE_CREATE_NEW_FLAG, ERROR_FILE_NOT_FOUND);
/* In all of the following tests, the encoding type seems to be ignored */ /* In all of the following tests, the encoding type seems to be ignored */
if (initFileFromData(filename, bigCert, sizeof(bigCert))) if (initFileFromData(filename, bigCert, sizeof(bigCert)))
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment