mshtml: Don't assume that nsIDOMHTMLElement inherits from nsIDOMNode in…

mshtml: Don't assume that nsIDOMHTMLElement inherits from nsIDOMNode in HTMLDocument_createStyleSheet. This will change after the next Gecko update.

mshtml: Don't assume that nsIDOMHTMLElement inherits from nsIDOMNode in…
fc38aea9 · Jacek Caban · Alexandre Julliard · 07751840 · fc38aea9
Commit fc38aea9 authored Sep 30, 2014 by Jacek Caban Committed by Alexandre Julliard Sep 30, 2014
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 2 deletions

htmldoc.c dlls/mshtml/htmldoc.c +6 -2

No files found.
--- a/dlls/mshtml/htmldoc.c
+++ b/dlls/mshtml/htmldoc.c
@@ -1625,10 +1625,14 @@ static HRESULT WINAPI HTMLDocument_createStyleSheet(IHTMLDocument2 *iface, BSTR 

    nsres = nsIDOMHTMLDocument_GetHead(This->doc_node->nsdoc, &head_elem);
    if(NS_SUCCEEDED(nsres)) {
-        nsIDOMNode *tmp_node;
+        nsIDOMNode *head_node, *tmp_node;

-        nsres = nsIDOMHTMLHeadElement_AppendChild(head_elem, (nsIDOMNode*)elem->nselem, &tmp_node);
+        nsres = nsIDOMHTMLHeadElement_QueryInterface(head_elem, &IID_nsIDOMNode, (void**)&head_node);
        nsIDOMHTMLHeadElement_Release(head_elem);
+        assert(nsres == NS_OK);
+
+        nsres = nsIDOMNode_AppendChild(head_node, elem->node.nsnode, &tmp_node);
+        nsIDOMNode_Release(head_node);
        if(NS_SUCCEEDED(nsres) && tmp_node)
            nsIDOMNode_Release(tmp_node);
    }