Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
W
wine-winehq
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Registry
Registry
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
wine
wine-winehq
Commits
fe0f9457
Commit
fe0f9457
authored
Nov 16, 2013
by
Jacek Caban
Committed by
Alexandre Julliard
Nov 18, 2013
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
msxml3: Return NULL instead of empty string in IXMLElement::get_tagName.
parent
f3a2cb7b
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
3 deletions
+7
-3
xmldoc.c
dlls/msxml3/tests/xmldoc.c
+1
-1
xmlelem.c
dlls/msxml3/xmlelem.c
+6
-2
No files found.
dlls/msxml3/tests/xmldoc.c
View file @
fe0f9457
...
...
@@ -893,7 +893,7 @@ static void test_xmlelem(void)
hr
=
IXMLElement_get_tagName
(
element
,
&
str
);
EXPECT_HR
(
hr
,
S_OK
);
ok
(
lstrlenW
(
str
)
==
0
,
"Expected empty tag name
\n
"
);
ok
(
!
str
,
"Expected empty tag name, got %s
\n
"
,
wine_dbgstr_w
(
str
)
);
SysFreeString
(
str
);
parent
=
(
IXMLElement
*
)
0xdeadbeef
;
...
...
dlls/msxml3/xmlelem.c
View file @
fe0f9457
...
...
@@ -189,8 +189,12 @@ static HRESULT WINAPI xmlelem_get_tagName(IXMLElement *iface, BSTR *p)
if
(
!
p
)
return
E_INVALIDARG
;
*
p
=
bstr_from_xmlChar
(
This
->
node
->
name
);
CharUpperBuffW
(
*
p
,
SysStringLen
(
*
p
));
if
(
*
This
->
node
->
name
)
{
*
p
=
bstr_from_xmlChar
(
This
->
node
->
name
);
CharUpperBuffW
(
*
p
,
SysStringLen
(
*
p
));
}
else
{
*
p
=
NULL
;
}
TRACE
(
"returning %s
\n
"
,
debugstr_w
(
*
p
));
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment