Fixed a problem where when deleting an item using index -1 on an empty

listbox we would pass through an illegal negative index and cause problems.

Fixed a problem where when deleting an item using index -1 on an empty
fe9a0f09 · Aric Stewart · Alexandre Julliard · 1dc75536 · fe9a0f09
Commit fe9a0f09 authored Jan 04, 2001 by Aric Stewart Committed by Alexandre Julliard Jan 04, 2001
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

listbox.c controls/listbox.c +1 -1

No files found.
--- a/controls/listbox.c
+++ b/controls/listbox.c
@@ -1587,7 +1587,7 @@ static LRESULT LISTBOX_RemoveItem( WND *wnd, LB_DESCR *descr, INT index )
    LB_ITEMDATA *item;
    INT max_items;

-    if (index == -1) index = descr->nb_items - 1;
+    if ((index == -1) && (descr->nb_items > 0)) index = descr->nb_items - 1;
    else if ((index < 0) || (index >= descr->nb_items)) return LB_ERR;

    /* We need to invalidate the original rect instead of the updated one. */