Commits · bedd92ca068434eea7cb6b445a3fcf21b51acbaf · wine / wine-winehq

05 Jul, 2021 35 commits

server: Explicitly return whether a select request was immediately signaled. · bedd92ca

authored Jul 05, 2021

This fixes a regression introduced by 97afac46.

If we make a request on an asynchronous device handle, and the IRP handler
returns STATUS_PENDING, wait_async() will return STATUS_PENDING, as intended.
However, if the async object is signaled before the user has a chance to call
wait_async() [e.g. if get_next_device_request is called quickly enough], select
will return STATUS_PENDING immediately, which causes server_select() to think
the object is not signaled, and wait for a select reply forever.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51277
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51295Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

bedd92ca

server: Call the close_handle callback and release_object_from_handle() in the same loop. · a17469b1

authored Jul 05, 2021

Several server objects check if the last handle is being closed in their
close_handle callback. If a process holds the last two handles to an object,
this code path currently won't be triggered.
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

a17469b1

server: Don't check the user data for NULL in async_terminate(). · 3f04fdd8

authored Jul 05, 2021

This semantically reverts 48151717.

That commit was used to implement NtFlushBuffersFile, which at the time didn't
use a callback function. 9050b58f changed it to
use irp_completion(), since the result of a blocking flush needed to be taken
from the IOSB.

As of 97afac46 that's not true anymore, but on
the other hand it is theoretically possible for a device driver to touch the
Information member of the IOSB, and we don't seem to lose anything by making
all asyncs take a common path.

Since all asyncs pass user data and there's no clear reason for them not to,
let's get rid of a bit of extra code complexity that's no longer used.
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

3f04fdd8

wined3d: Use wined3d_mask_from_size() in wined3d_render_pass_vk_init(). · d888cbcb
Henri Verbeet authored Jul 05, 2021
```
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
d888cbcb
wined3d: Use wined3d_mask_from_size() in wined3d_context_vk_apply_draw_state(). · 76cef086
Henri Verbeet authored Jul 05, 2021
```
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
76cef086

wined3d: Use wined3d_mask_from_size() in state_stencil(). · 3ed5dd13

authored Jul 05, 2021

Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

3ed5dd13

d2d1: Do not clear the device context state in d2d_device_context_draw(). · da44bcc9

authored Jul 05, 2021

Clearing the state should no longer be needed now that we use
SwapDeviceContextState() and have our own dedicated state object.
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

da44bcc9

d3d11: Only complain once about d3d10 interface emulation in… · 78bdc84b

authored Jul 05, 2021

d3d11: Only complain once about d3d10 interface emulation in d3d11_device_context_SwapDeviceContextState().
Signed-off-by: Henri Verbeet <hverbeet@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

78bdc84b

uxtheme: Avoid memory leaks. · 6f00a298

authored Jul 05, 2021

A THEME_FILE struct and four global ATOMs are leaked when unloading uxtheme.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

6f00a298

user32: Call SCROLL_DrawScrollBar() to draw arrows in SCROLL_HandleScrollEvent(). · b5abd534

authored Jul 05, 2021

So that SCROLL_DrawScrollBar() can eventually be hooked by a themed scroll bar drawing function and
use a single function to draw scroll bars, instead of hooking multiple scroll bar drawing functions
that draw different parts.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

b5abd534

user32: Introduce a SCROLL_DrawNCScrollBar() to draw scroll bars in non-client area. · 5541cf32

authored Jul 05, 2021

Having a SCROLL_DrawNCScrollBar() in scroll.c enables it to access global variables there. So that
global variables access in SCROLL_DrawScrollBar() can be moved outside of it and
SCROLL_DrawScrollBar() can then be refactored into a function without access to global variables.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

5541cf32

user32: Modify SCROLL_MovingThumb outside of SCROLL_DrawMovingThumb(). · ac6817de

authored Jul 05, 2021

SCROLL_MovingThumb is a global variable. Gradually move it out of scroll bar drawing functions so
that those drawing functions can be refactored in a way that doesn't need access to global variables.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

ac6817de

user32: Remove SCROLL_DrawInterior_9x(). · d164f062

authored Jul 05, 2021

SCROLL_DrawInterior_9x() has the same functionality as SCROLL_DrawInterior().
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

d164f062

user32: Avoid unnecessary scroll bar drawing. · 4819ea85

authored Jul 05, 2021

These drawing operations are either overwritten by other drawing functions later or not needed at all.
Signed-off-by: Zhiyi Zhang <zzhang@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

4819ea85

gdi32: Move CreateDiscardableBitmap implementation to objects.c. · 0204ebbc

authored Jul 05, 2021

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

0204ebbc

gdi32: Use ntgdi names for bitmap functions. · 6b3c811c

authored Jul 05, 2021

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

6b3c811c

gdi32: Introduce NtGdiCreateBitmap. · 270f7bed

authored Jul 05, 2021

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

270f7bed

gdi32: Implement CreateBitmapIndirect on top of CreateBitmap. · 505a6b9c

authored Jul 05, 2021

Instead of the other way around.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

505a6b9c

gdi32: Introduce NtGdiCreatePen. · f5c117fb

authored Jul 05, 2021

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

f5c117fb

gdi32: Implement CreatePenIndirect on top of CreatePen. · 4590f6fb

authored Jul 05, 2021

Instead of the other way around.
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

4590f6fb

gdi32: Reimplement GetObjectA on top of GetObjectW. · 3dcb5db4

authored Jul 05, 2021

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

3dcb5db4

gdi32: Introduce NtGdiExtGetObjectW. · 14a39fcf

authored Jul 05, 2021

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

14a39fcf

ntdll: Get rid of the almost empty virtual.c. · 5d9586a6
Alexandre Julliard authored Jul 05, 2021
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
5d9586a6
ntdll: Get rid of the almost empty directory.c. · 73a28110
Alexandre Julliard authored Jul 05, 2021
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
73a28110
ntdll: Get rid of the almost empty nt.c. · d4509765
Alexandre Julliard authored Jul 05, 2021
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
d4509765
ntdll: Forward RtlGetNativeSystemInformation() to NtWow64GetNativeSystemInformation() on 32-bit. · 9a224788
Alexandre Julliard authored Jul 05, 2021
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
9a224788
ntdll: Implement NtWow64GetNativeSystemInformation(). · 04264305
Alexandre Julliard authored Jul 05, 2021
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
04264305
ntdll: Implement SystemEmulation* information classes. · 5071a287
Alexandre Julliard authored Jul 05, 2021
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
5071a287

shell32/tests: Fix the PathResolve() tests on Windows 8.1, early 10. · 0e64e056

authored Jul 04, 2021

Some Windows 8.1 and Windows 10 1507 versions return PATH_NOT_FOUND
instead of FILE_NOT_FOUND.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

0e64e056

shell32/tests: Use WineTest contexts to simplify shellpath. · 865029ae

authored Jul 04, 2021

Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

865029ae

shell32/test: Fix an ok() message. · d6d46299

authored Jul 04, 2021

Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

d6d46299

user32/tests: Fix the wording of an ok() message. · f593babf

authored Jul 04, 2021

Signed-off-by: Francois Gouget <fgouget@free.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

f593babf

user32/tests: Use WineTest contexts to simplify test_mdi(). · ce0b7342

authored Jul 04, 2021

This also fixes the many ok() calls that were missing context
information.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

ce0b7342

maintainers: Add a Network Store Interface section. · 151ae36a

authored Jul 05, 2021

Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

151ae36a

nsiproxy: Include netinet/in.h before if_ether.h. · cefe9f6b

authored Jul 03, 2021

Signed-off-by: Gerald Pfeifer <gerald@pfeifer.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

cefe9f6b

02 Jul, 2021 5 commits

Release 6.12. · 12d33d21
Alexandre Julliard authored Jul 02, 2021
```
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
12d33d21

wininet: Validate InternetGetLastResponseInfo() parameters. · 88e7ad5a

authored Jun 30, 2021

Signed-off-by: Damjan Jovanovic <damjan.jov@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

88e7ad5a

wininet: Improve InternetGetLastResponseInfo() logging. · 5605e63c

authored Jun 30, 2021

Signed-off-by: Damjan Jovanovic <damjan.jov@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

5605e63c

winedbg: Add helper in gdbproxy mode to get proper address width information. · 40587a62
Eric Pouech authored Jul 02, 2021
```
Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
40587a62

winedbg: Correct mapping read/write/execute information. · 6c91e61c

authored Jul 02, 2021

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

6c91e61c