- 04 Feb, 2022 1 commit
-
-
Bastien Orivel authored
According to MSDN [1], the `TCP_NODELAY` parameter should be of type `BOOL` which is 4 bytes. Due to a bug [2] in rustc passing a byte instead of an int, any program written in rust that tries to set that option on a socket will fail with a "Invalid parameter supplied" error. Turns out that setsockopt on linux does not want optlen to be less than 4 bytes [3]. Windows' behavior is the following: - For optlen <= 0, return SOCKET_ERROR and set last error to WSAEFAULT - For optlen > 0, ignore the optlen value and set the TCP_NODELAY value to one if the first byte of the given optvalue is not 0. This will fix any rust program using the hyper library to do HTTP requests. [1]: https://docs.microsoft.com/en-us/windows/win32/winsock/ipproto-tcp-socket-options [2]: https://github.com/rust-lang/rust/blob/44593aeb1387b1be355aeaf0040d5927bd80f060/library/std/src/sys/windows/net.rs#L470 [3]: https://github.com/torvalds/linux/blob/d58071a8a76d779eedab38033ae4c821c30295a5/net/ipv4/tcp.c#L3419-L3420Signed-off-by:
Bastien Orivel <eijebong@bananium.fr> Signed-off-by:
Zebediah Figura <zfigura@codeweavers.com> Signed-off-by:
Alexandre Julliard <julliard@winehq.org>
-
- 03 Feb, 2022 39 commits
-
-
Dmitry Timoshkov authored
Signed-off-by:
Dmitry Timoshkov <dmitry@baikal.ru> Signed-off-by:
-
Eric Pouech authored
Signed-off-by:
Eric Pouech <eric.pouech@gmail.com> Signed-off-by:
Henri Verbeet <hverbeet@codeweavers.com> Signed-off-by:
-
Eric Pouech authored
Signed-off-by:
-
Henri Verbeet authored
Signed-off-by:
-
Henri Verbeet authored
Signed-off-by:
-
Eric Pouech authored
Signed-off-by:
-
Eric Pouech authored
Signed-off-by:
Piotr Caban <piotr@codeweavers.com> Signed-off-by:
-
Eric Pouech authored
Signed-off-by:
-
Eric Pouech authored
Signed-off-by:
-
Eric Pouech authored
Signed-off-by:
-
Michael Stefaniuc authored
Signed-off-by:
Michael Stefaniuc <mstefani@winehq.org> Signed-off-by:
-
André Zwing authored
Signed-off-by:
André Zwing <nerv@dawncrow.de> Signed-off-by:
-
Nikolay Sivov authored
Signed-off-by:
Nikolay Sivov <nsivov@codeweavers.com> Signed-off-by:
-
Paul Gofman authored
Signed-off-by:
Paul Gofman <pgofman@codeweavers.com> Signed-off-by:
-
Paul Gofman authored
Signed-off-by:
-
Paul Gofman authored
Signed-off-by:
-
Paul Gofman authored
Signed-off-by:
-
Eric Pouech authored
Signed-off-by:
-
Eric Pouech authored
Signed-off-by:
Jacek Caban <jacek@codeweavers.com> Signed-off-by:
-
Eric Pouech authored
Signed-off-by:
-
Eric Pouech authored
Signed-off-by:
-
Eric Pouech authored
Signed-off-by:
-
Eric Pouech authored
Signed-off-by:
-
Eric Pouech authored
Signed-off-by:
-
Eric Pouech authored
Signed-off-by:
-
Eric Pouech authored
Signed-off-by:
-
Piotr Caban authored
Signed-off-by:
-
Alistair Leslie-Hughes authored
Signed-off-by:
Alistair Leslie-Hughes <leslie_alistair@hotmail.com> Signed-off-by:
-
Eric Pouech authored
Signed-off-by:
-
Eric Pouech authored
Signed-off-by:
-
Eric Pouech authored
Signed-off-by:
-
Paul Gofman authored
Signed-off-by:
Hans Leidekker <hans@codeweavers.com> Signed-off-by:
-
Zebediah Figura authored
Use clearer variable names, and simplify the error handling. Signed-off-by:
-
Zebediah Figura authored
These are already checked in the callers. Signed-off-by:
-
Zebediah Figura authored
Cycle detection is done by native quartz. Signed-off-by:
-
Zebediah Figura authored
Signed-off-by:
-
Zebediah Figura authored
Signed-off-by:
-
Zebediah Figura authored
Signed-off-by:
-
Zebediah Figura authored
Signed-off-by:
-
