Commits · ea93f283b500c59c56664ffdc7ad1d20dd45f659 · wine / wine-winehq

22 Dec, 2021 10 commits

dinput: Return DIERR_INVALIDPARAM instead of DIERR_INPUTLOST from Acquire. · ea93f283

authored Dec 22, 2021

MSDN states that the function can only return one of DIERR_INVALIDPARAM,
DIERR_NOTINITIALIZED, DIERR_OTHERAPPHASPRIO, on error, and DI_OK, or
DI_NOEFFECT, on success.

Some games will try to call Acquire again in a tight loop and block the
main thread if DIERR_INPUTLOST is returned. There's a small chance for
this to happen with Resident Evil 2, whenever a joystick is plugged,
then quickly unplugged.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

ea93f283

dinput: Update internal thread events list on every wake up. · ac442a78

authored Dec 22, 2021

Instead of message notifications only. We have to remove the events from
devices that are automatically unacquired whenever a read failed.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

ac442a78

winecoreaudio: Actually free the stream. · a7f0647d

authored Dec 21, 2021

Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

a7f0647d

winecoreaudio: Set the buffer to NULL after freeing. · e03611ee

authored Dec 21, 2021

This ensures the subsequent allocation is free to pick a new location.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52202Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

e03611ee

win32u: Handle memory allocation failures in nulldrv_PolyBezierTo (cppcheck). · b498f38e

authored Dec 22, 2021

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

b498f38e

quartz/tests: Test querying connection state inside of IPin::ReceiveConnection(). · 15a01af7
Zebediah Figura authored Dec 21, 2021
```
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
15a01af7

server: Avoid using the long double type on non-x86 platforms. · 674d70a6

authored Dec 21, 2021

We especially may want to support x86 on ARM, where long double is not an 80-bit
type.
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

674d70a6

winex11: Fix the build when XInput2 headers are not present. · 6ef7cd4e

authored Dec 21, 2021

Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

6ef7cd4e

po: Update Dutch time zones translation. · 110e68eb

authored Dec 22, 2021

Signed-off-by: Floris Renaud <jkfloris@dds.nl>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

110e68eb

po: Update Lithuanian translation. · b40b8c94

authored Dec 21, 2021

Signed-off-by: Aurimas Fišeras <aurimas@members.fsf.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

b40b8c94

21 Dec, 2021 16 commits

msxml3: Fix crashes due to access to invalid context pointer. · 2ef4cde8

authored Dec 20, 2021

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52073Signed-off-by: Bernhard Übelacker <bernhardu@mailbox.org>
Signed-off-by: Nikolay Sivov <nsivov@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

2ef4cde8

mmdevapi/tests: Check that GetMixFormat returns an IEEE_FLOAT format. · 32ee835d

authored Dec 20, 2021

And that a corresponding PCM format is supported.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

32ee835d

xaudio2/tests: Check that GetDeviceDetails returns a PCM format. · 0053a686

authored Dec 20, 2021

Far Cry 4 expects IXAudio27_GetDeviceDetails to return a PCM format GUID
and refuses to create a source voice if the format is IEEE_FLOAT.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

0053a686

ntdll: Fix a variable name in TRACE() message. · 93b7c335

authored Dec 21, 2021

Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

93b7c335

oledb32: Add parentheses to the switch statement. · 9cf587c5

authored Dec 21, 2021

Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

9cf587c5

schtasks: Fix a typo in FIXME() message. · 7314b976

authored Dec 21, 2021

Signed-off-by: Andrey Gusev <andrey.goosev@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

7314b976

ntdll: Restore FP status words from MSVCRT_JUMP_BUFFER on x64. · 6b78bcff
Paul Gofman authored Dec 21, 2021
```
Signed-off-by: Paul Gofman <pgofman@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
6b78bcff

winmm: Instanciate DirectInput8 class lazily using delay imported DLL. · e9282254

authored Dec 17, 2021

Instead of statically importing dinput8 and creating the class at load
time, which causes some native hooks to fail loading.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52222Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

e9282254

msvcrt: Make _setfp* helpers infallible. · c521ec04

authored Dec 21, 2021

The functions may only fail on unsupported compilers/architectures. It's
not really possible to handle errors properly.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

c521ec04

msvcrt: Don't set _EM_AMBIGOUS flag in _control87 when sse2 is not supported. · 564ede5d

authored Dec 21, 2021

Fixes compilation warning.
Signed-off-by: Piotr Caban <piotr@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

564ede5d

wine.inf: Regenerate time zones. · 929face0

authored Dec 21, 2021

Unicode CLDR release 40 and tzdata 2021e were used.
Signed-off-by: Giovanni Mascellani <gmascellani@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

929face0

wineconsole: Remove "option" from the man page. · e3d56549

authored Dec 21, 2021

Signed-off-by: Floris Renaud <jkfloris@dds.nl>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

e3d56549

wpcap: Remove unused variable ptr from build_win32_description (cppcheck). · bd7d7714

authored Dec 19, 2021

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

bd7d7714

mshtml: Avoid null pointer dereference in OmHistory_get_length (cppcheck). · 06e0220e

authored Dec 19, 2021

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

06e0220e

wldap32: Fix memory leak on error path in create_page_control (cppcheck). · 3f245899

authored Dec 20, 2021

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Hans Leidekker <hans@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

3f245899

nsiproxy: Fix use after free in icmp_send_echo (scan-build). · 06923f61

authored Dec 20, 2021

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

06923f61

20 Dec, 2021 14 commits

mountmgr: Change scope of variable pvd in VOLUME_GetSuperblockLabel (cppcheck). · 656d7f58

authored Dec 19, 2021

The data in pvd was being accessed through the label_ptr variable after
pvd went out of scope.
Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

656d7f58

quartz: Fix memory leaks on error paths in FilterMapper3_RegisterFilter (cppcheck). · 8e081d32

authored Dec 19, 2021

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

8e081d32

dinput: Ignore objects without a collection in init_pid_caps. · 531297a8

authored Dec 20, 2021

This makes sure we don't try to set effect_state report id from objects
without a collection, causing some false warnings.
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

531297a8

dinput: Convert wide action format back to ansi in ConfigureDevices. · e5131028

authored Dec 20, 2021

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52198Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

e5131028

dinput: Ignore NULL callback in IDirectInput_ConfigureDevices. · a37346c6

authored Dec 20, 2021

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52198Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

a37346c6

dinput: Keep action names when converting back to ansi. · dd1f3434

authored Dec 20, 2021

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52198Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

dd1f3434

winetest: Send the tests output to stdout when given "-o -". · 2da7e5de

authored Dec 20, 2021

This makes it easier to use WineTest with tools that capture stdout,
such as the TestBot.
Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

2da7e5de

cmd: Don't crash on 'if exist' without parameter. · 535da775

authored Dec 20, 2021

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51598Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

535da775

kernelbase: Don't hardcode magic constants. · 488a00c3

authored Dec 18, 2021

Signed-off-by: Eric Pouech <eric.pouech@gmail.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

488a00c3

winedbg: Fix disassemble with end addresses exceeding 32-bit. · f174f18f
Bernhard Übelacker authored Dec 18, 2021
```
Signed-off-by: Bernhard Übelacker <bernhardu@mailbox.org>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
```
f174f18f

win32u: Fix memory leak on error path in PATH_WidenPath (cppcheck). · d45d54ef

authored Dec 20, 2021

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

d45d54ef

nsiproxy: Fix memory leaks on error paths in get_ipv6_addr_scope_table (cppcheck). · cf7dd520

authored Dec 19, 2021

Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

cf7dd520

dinput8/tests: Don't test value again if it wasn't touched. · 3ee28693

authored Dec 18, 2021

Signed-off-by: Michael Stefaniuc <mstefani@winehq.org>
Signed-off-by: Rémi Bernon <rbernon@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

3ee28693

win32u: Use null driver to handle virtual display devices. · e63f7b7a

authored Dec 17, 2021

All drivers support UpdateDisplayDevices now, so we can avoid a server
call by being explicit in the null driver.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52180Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Huw Davies <huw@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>

e63f7b7a