reports.mk: use process substitution to dedup

The first half of both pipes was clearly a copy-pasted initial logfile processing; the file can be of considerable size (e.g. several megabytes) so it might be slightly more efficient and cool (but a bit more arcane) to use bash(1)'s process substitution along with good ol' tee(1) like this: $ echo -e '1\n2\n3' |tee /dev/stderr 2> >(grep 2 >STDERR) |grep 1 >STDOUT $ head STD* ==> STDERR <== 2 ==> STDOUT <== 1

reports.mk: use process substitution to dedup
6f584cdc · Michael Shigorin · Anton Midyukov · 4c701def · 6f584cdc
Commit 6f584cdc authored Apr 28, 2021 by Michael Shigorin Committed by Anton Midyukov Apr 29, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 3 deletions

reports.mk reports.mk +2 -3

No files found.
--- a/reports.mk
+++ b/reports.mk
@@ -79,10 +79,9 @@ reports/contents: reports/prep

 reports/packages: reports/prep
 	@grep -E 'chroot/.in/[^/]*.rpm' < $(BUILDLOG) | \
-		cut -d' ' -f 1 | tr -d "'"'`' | sed 's,^.*/,,' | \
-		sort -u > "$(REPORTDIR)/list-rpms.txt"
-	@grep -E 'chroot/.in/[^/]*.rpm' < $(BUILDLOG) | \
 		cut -d' ' -f 1 | tr -d "'"'`' | \
+		tee /dev/stderr 2> >(sed 's,^.*/,,' | \
+			sort -u > "$(REPORTDIR)/list-rpms.txt") | \
 		xargs rpm -qp --queryformat '%{sourcerpm}\n' | \
 		sort -u > "$(REPORTDIR)/list-srpms.txt"