- 05 Mar, 2018 6 commits
-
-
Marek Siarkowicz authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix stackdriver logging test Fixes https://k8s-testgrid.appspot.com/google-gce#gci-gce-sd-logging Removes location verification that was used for event-exporter tests. ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix broken useManagedIdentityExtension for azure cloud provider **What this PR does / why we need it**: useManagedIdentityExtension has been broken because azure cloud provider uses `yaml.Unmarshal` to read configs while there is no yaml tag defined for useManagedIdentityExtension. This PR fixes this problem and adds unit tests for parseConfig. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #60691 **Special notes for your reviewer**: Should be cherry-picked to 1.7, 1.8 and 1.9. **Release note**: ```release-note Fix broken useManagedIdentityExtension for azure cloud provider ```
-
Pengfei Ni authored
-
Pengfei Ni authored
-
Pengfei Ni authored
-
- 03 Mar, 2018 9 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubelet: notify systemd that kubelet has started This call has no side-effects if systemd is not used or not installed. Fixes: https://github.com/kubernetes/kubernetes/issues/59079 @smarterclayton @sjenning ```release-note kubelet now notifies systemd that it has finished starting, if systemd is available and running. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add selector to DaemonSet in newDaemonSet function so that the v1 api… **What this PR does / why we need it**: When we upgraded the DaemonSet e2e to use apps v1 I neglected to add a selector to match the labels of the created Pods. This broke some apps Serial tests. ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add m1093782566 to milestone maintainer **What this PR does / why we need it**: m1093782566 (Du Jun, dujun5@huawei.com) is one of the SIG-Network PM members, please reference: https://github.com/kubernetes/community/blob/master/sig-product-management/SIG%20PM%20representatives.md I am keeping attending SIG-Network meeting so I can identify all features in the current release from the SIG-Network and track all features. I would love to contribute resources other than codes :) **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update kubectl e2e test manifests to apps/v1 **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60159, 60731, 60720, 60736, 60740). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Cap max number of nodes to use for local PV e2e tests **What this PR does / why we need it**: Large scale tests have thousands of nodes, which will make some local PV tests that use each node take forever **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Partially addresses #60589 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60159, 60731, 60720, 60736, 60740). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Switching to Official CSI 0.2.0 tag Switching to Ofiicial CSI Spec release 0.2.0 ```release-note None ``` Fixes https://github.com/kubernetes/kubernetes/issues/60738 /sig storage /kind bug
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60159, 60731, 60720, 60736, 60740). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. [Flaky Test] Increase amount of memory filled by memory allocatable eviction test **What this PR does / why we need it**: MemoryAllocatableEviction tests have been somewhat flaky: https://k8s-testgrid.appspot.com/sig-node-kubelet#kubelet-serial-gce-e2e&include-filter-by-regex=MemoryAllocatable The failure on the flakes is ["Pod ran to completion"](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-node-kubelet-serial/3785#k8sio-memoryallocatableeviction-slow-serial-disruptive-when-we-run-containers-that-should-cause-memorypressure-should-eventually-evict-all-of-the-correct-pods). Looking at [an example log](https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-node-kubelet-serial/3785/artifacts/tmp-node-e2e-6070a774-cos-stable-63-10032-71-0/kubelet.log) (and search for memory-hog-pod, we can see that this pod fails admission because the allocatable memory threshold has already been crossed. `eviction manager: thresholds - ignoring grace period: threshold [signal=allocatableMemory.available, quantity=250Mi] observed 242404Ki` There is likely memory usage because the allocatable cgroup is not low on memory, and thus has not reclaimed all pages belonging to previous test containers. Of the 300Mi of capacity in the allocatalbe cgroup, 250Mi is reserved for the eviction threshold, and only 50 is left for the test. Increasing this to a 400Mi cgroup limit, with 150Mi for pods should eliminate this flake. **Release note**: ```release-note NONE ``` /sig node /kind bug /priority critical-urgent /assign @Random-Liu @yujuhong
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60159, 60731, 60720, 60736, 60740). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Expect NetworkTier not to be set as GCE value (all uppercase) **What this PR does / why we need it**: Reverts L76 and L123 from this PR - https://github.com/kubernetes/kubernetes/pull/59941/files#diff-497d33fc55a7de6c5bde6cbe33ecbb3cL78 . NetworkTier is set on the mock Service in Camel Case, not all uppercase. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #60721 **Release note**: ```release-note NONE ``` /assign MrHohn nicksardo
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60159, 60731, 60720, 60736, 60740). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Promote LocalStorageCapacityIsolation feature to beta The LocalStorageCapacityIsolation feature added a new resource type ResourceEphemeralStorage "ephemeral-storage" so that this resource can be allocated, limited, and consumed as the same way as CPU/memory. All the features related to resource management (resource request/limit, quota, limitrange) are available for local ephemeral storage. This local ephemeral storage represents the storage for root file system, which will be consumed by containers' writtable layer and logs. Some volumes such as emptyDir might also consume this storage. Fixes issue #60160 This PR also fixes data race issues discovered after open the feature gate. Basically setNodeStatus function in kubelet could be called by multiple threads so the data needs lock protection. Put the fix with this PR for easy testing. **Release note**: ```release-note ACTION REQUIRED: LocalStorageCapacityIsolation feature is beta and enabled by default. ```
-
- 02 Mar, 2018 21 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add //test/e2e/... and //test/integration/... to //build/visible_to:COMMON_testing **What this PR does / why we need it**: adds the common test packages `//test/e2e/...` and `//test/integration/...` to the `COMMON_testing` package group. The immediate need for this is that #60580 unintentionally broke the integration tests under bazel since it added a new dependency on `//pkg/kubectl/cmd/util` without adding an appropriate entry to `//build/visible_to:COMMON_testing`, and the integration tests aren't currently run under bazel for PRs. This PR fixes this breakage and proactively fixes future breakages by adding all packages under `//test/e2e` or `//test/integration` to `COMMON_testing`. **Release note**: ```release-note NONE ``` /assign @BenTheElder @monopole /kind bug /priority important-soon /sig testing cc @kad
-
Jing Xu authored
The LocalStorageCapacityIsolation feature added a new resource type ResourceEphemeralStorage "ephemeral-storage" so that this resource can be allocated, limited, and consumed as the same way as CPU/memory. All the features related to resource management (resource request/limit, quota, limitrange) are avaiable for local ephemeral storage. This local ephemeral storage represents the storage for root file system, which will be consumed by containers' writtable layer and logs. Some volumes such as emptyDir might also consume this storage.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60732, 60689, 60648, 60704). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix a grammatical error in a comment Fix a grammatical error in a comment in scheduler's code. We should use a word's plural form after "one of". **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60732, 60689, 60648, 60704). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Do not count failed pods as unready in HPA controller **What this PR does / why we need it**: Currently, when performing a scale up, any failed pods (which can be present for example in case of evictions performed by kubelet) will be treated as unready. Unready pods are treated as if they had 0% utilization which will slow down or even block scale up. After this change, failed pods are ignored in all calculations. This way they do not influence neither scale up nor scale down replica calculations. @MaciekPytel @DirectXMan12 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #55630 **Special notes for your reviewer**: **Release note**: ``` Stop counting failed pods as unready in HPA controller to avoid failed pods incorrectly affecting scale up replica count calculation. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60732, 60689, 60648, 60704). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. bump(6644d4): spf13/cobra: support bash completion for aliases Fixes kubernetes/kubectl#120 `spf13/cobra` was recently bumped in https://github.com/kubernetes/kubernetes/pull/60530. The changes between then and now are: - Fix generated bash completion for Bash 3 (OSX): https://github.com/spf13/cobra/commit/fd32f09af19efc9b1279c54e0d8ed23f66232a15 - Try out CircleCI: https://github.com/spf13/cobra/commit/be77323fc05148ef091e83b3866c0d47c8e74a8b (but we don't vendor this in anyway) - Do not add a space after a single flag completion: https://github.com/spf13/cobra/commit/1a618fb24b01a0f393ccd82d55c4d8058bdeaf5c - Bash completion aliases: https://github.com/spf13/cobra/commit/a1e4933ab784095895e33dbe9f001ba10cfe2060 (the commit that fixes kubernetes/kubectl#120) - Prefix bash functions with root command name: https://github.com/spf13/cobra/commit/6644d46b81fa1831979c4cded0106e774e0ef0ab (the commit that completely fixes https://github.com/kubernetes/kubernetes/issues/60517) No license changes. **Release note**: ```release-note NONE ``` /cc mengqiy cblecker sttts
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60732, 60689, 60648, 60704). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update gazelle to latest to fix vendoring issue **What this PR does / why we need it**: Fixes #60730 for the master branch. There are otherwise no functional differences. **Release note**: ```release-note NONE ``` /priority critical-urgent /milestone v1.10 /kind bug /sig testing
-
Serguei Bezverkhi authored
-
Ashley Gau authored
-
Jeff Grafton authored
-
Ashley Gau authored
-
Michelle Au authored
-
David Ashpole authored
-
Dan Williams authored
The notify call has no side-effects if systemd is not used or not installed. Fixes: https://github.com/kubernetes/kubernetes/issues/59079
-
Nikhita Raghunath authored
-
Shijun Qin authored
Fix a grammatical error in a comment in scheduler's code. We should use a word's plural form after "one of".
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60683, 60386). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Added unschedulabe predicate. Signed-off-by:
Da K. Ma <madaxa@cn.ibm.com> **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #60163 **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60683, 60386). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix PodTemplate validation **What this PR does / why we need it**: This is a bugfix for pod template validation, which can be reproduced by deleting with "foreground deletion" mode (`DeleteOptions.PropagationPolicy = metav1.DeletePropagationForeground`). Because of this bug GC will never delete a pod template with `foregroundDeletion` finalizer. **Special notes for your reviewer**: The issue was originally found and confirmed in the PR #59851, where switching to foreground deletion in `kubectl` broke a unit test revealing this bug. Extracted for easier backporting to releases as suggested in https://github.com/kubernetes/kubernetes/pull/59851#discussion_r171576397 /cc @liggitt @caesarxuchao /sig api-machinery ```release-note NONE ```
-
Nail Islamov authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 60530, 60618). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add support for `make verify WHAT=typecheck` This will be used to make the typecheck job emit junit and avoids duplicating the rest of the verify logic. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix kubectl completion so that file names are listed **What this PR does / why we need it**: This PR fixes kubectl completion so that file names are listed with `--filename`. I tested in bash and zsh. This problem is caused by spf13/cobra#520, so I updates vendor github.com/spf13/cobra to just before that commit. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #60517 **Special notes for your reviewer**: @janetkuo @mengqiy @eparis **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Moves the DevicePlugin e2e_node test back to Serial I forgot the fact that the DevicePlugin test itself restarts Kubelet for testing purpose. Move that test back to Serial but constructs a smaller test without kubelet restart that we may run during presubmit. **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes https://github.com/kubernetes/kubernetes/issues/60604 **Special notes for your reviewer**: **Release note**: ```release-note ```
-
- 01 Mar, 2018 4 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52077, 60456, 60591). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. [e2e] Fix panicing ingress jobs **What this PR does / why we need it**: When a nil error is passed into IsProbableEOF(), test will panic. Ref https://github.com/kubernetes/kubernetes/issues/60381#issuecomment-369353511. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #60381 **Special notes for your reviewer**: /assign @shyamjvs cc @krzyzacy **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52077, 60456, 60591). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Adds daemonset conformance tests **What this PR does / why we need it**: Adds conformance tests for deamonset ```release-note Conformance tests are added for the DaemonSet kinds in the apps/v1 group version. Deprecated versions of DaemonSet will not be tested for conformance, and conformance is only applicable to release 1.10 and later. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52077, 60456, 60591). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. API Changes for RunAsGroup First set of api changes for feature https://github.com/kubernetes/community/pull/756 ```release-note Add ability to control primary GID of containers through pod Spec and PodSecurityPolicy ```
-
Ryan Hitchman authored
This will be used to make the typecheck job emit junit and avoids duplicating the rest of the verify logic.
-