1. 22 Nov, 2017 7 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #55752 from kevinkim9264/fix-azure-loadbalancer · 2f2ab910
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Azure Load Balancer reconciliation should consider all Kubernetes-controlled properties of a LB NSG
      
      **What this PR does / why we need it**:
      This PR refers to issue #55733 
      With this PR, Kubernetes will update Azure nsg rules based on not just name, but also based on other properties such as destination port range and destination ip address.
      We need it because right now Kubernetes will detect the difference and update only if there is difference in Name of nsg rule. It's been working fine for changing destination port range and source IP address because these two are part of the Name. (which external users should not assume) Basically right now, Kubernetes won't detect the difference if I go ahead and change any part of nsg rule using port UI. 
      This PR will let Kubernetes detect the difference and always try to reconcile nsg rules with service definition.
      
      **Which issue(s) this PR fixes** :
      Fixes #55733 
      
      **Special notes for your reviewer**: None
      
      **Release note**:
      
      ```release-note
      Kubernetes update Azure nsg rules based on not just difference in Name, but also in Protocol, SourcePortRange, DestinationPortRange, SourceAddressPrefix, DestinationAddressPrefix, Access, and Direction.
      ```
      2f2ab910
    • Kubernetes Submit Queue's avatar
      Merge pull request #55812 from deads2k/admission-17-external · 25ebf875
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 55812, 55752, 55447, 55848, 50984). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Make versioned types for webhook admission config
      
      Versioned webhook admission config type as promised in https://github.com/kubernetes/kubernetes/pull/54414.  
      
      @kubernetes/sig-api-machinery-pr-reviews 
      @ericchiang as promised.  fyi.
      
      ```yaml
      kind: AdmissionConfiguration
      apiVersion: apiserver.k8s.io/v1alpha1
      plugins:
      - name: GenericAdmissionWebhook
        configuration:
          kind: WebhookAdmission
          apiVersion: apiserver.config.k8s.io/v1alpha1
          kubeConfigFile: /path/to/my/file
      ```
      
      `ADMISSION_CONTROL_CONFIG_FILE=../foo.yaml hack/local-up-cluster.sh`
      25ebf875
    • Kubernetes Submit Queue's avatar
      Merge pull request #56042 from stewart-yu/kubeadm#554 · 630dbede
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 56128, 56004, 56083, 55833, 56042). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Automatically opt into dependent feature gates when using kubeadm
      
      **What this PR does / why we need it**:
      There will be a dependency chain between  feature gates.  kubeadm needs to automatically opt into dependent feature gates of a chosen one.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes # [https://github.com/kubernetes/kubeadm/issues/554](https://github.com/kubernetes/kubeadm/issues/554)
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      630dbede
    • Kubernetes Submit Queue's avatar
      Merge pull request #55833 from feiskyer/azure-vmss · c975b138
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 56128, 56004, 56083, 55833, 56042). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add initial Virtual Machine Scale Sets (VMSS) support in Azure
      
      **What this PR does / why we need it**:
      
      This is the first step of adding Virtual Machine Scale Sets (VMSS) support in Azure, it
      
      - Adds  vmType params to support both vmss and standard in Azure
      - Adds initial InstanceID/InstanceType/IP/Routes support for vmss instances
      - Master nodes may not belong to any scale sets, so it falls back to VirtualMachinesClient for such instances
      
      Have validated that nodes could be registered and pods could be scheduled and run correctly.
      
      Still more work to do to fully support Azure VMSS. And next steps are tracking at #43287.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      
      Part of #43287.
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      c975b138
    • Kubernetes Submit Queue's avatar
      Merge pull request #56083 from yguo0905/sched-log · 5d3aae01
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 56128, 56004, 56083, 55833, 56042). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Suppress the warning when a pod in binding cannot be expired
      
      **What this PR does / why we need it**:
      
      I have a scheduler extender, which implements the `Bind` call and takes several minutes to respond to that call. The scheduler log was full of the following error.
      
      ```
      W1120 10:23:09.691188   99720 cache.go:442] Couldn't expire cache for pod default/xxx. Binding is still in progress.
      ```
      
      The TTL for a pod to be expired in the scheduler cache is 30 seconds. But it's also possible that the binding (which is done asynchronously) can take longer than 30 seconds.
      https://github.com/kubernetes/kubernetes/blob/2cbb07a4394ef4cfc1666e114674a047023ed178/plugin/pkg/scheduler/factory/factory.go#L143
      
      The go routine that checks whether a pod has been expired is triggered every second.
      https://github.com/kubernetes/kubernetes/blob/2cbb07a4394ef4cfc1666e114674a047023ed178/plugin/pkg/scheduler/schedulercache/cache.go#L33
      
      So, it will print the the following warning every seconds until the pod gets expired.
      https://github.com/kubernetes/kubernetes/blob/2cbb07a4394ef4cfc1666e114674a047023ed178/plugin/pkg/scheduler/schedulercache/cache.go#L442-L443
      
      I think it's a valid for the binding to take more than one second, so we should downgrade this to an info to avoid polluting the scheduler log.
      
      **Release note**:
      ```release-note
      None
      ```
      
      /sig scheduling
      /assign @bsalamat 
      /cc @vishh
      5d3aae01
    • Kubernetes Submit Queue's avatar
      Merge pull request #56004 from caesarxuchao/admission-v1beta1 · 4cafc545
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 56128, 56004, 56083, 55833, 56042). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Graduate the admission and admissionregistration (webhook part) API to v1beta1
      
      ref: kubernetes/features#492
      
      Most changes are mechanical. Please take a look at the commit message to see if the commit is worth reviewing.
      
      ```release-note
      Action required:
      The `admission/v1alpha1` API has graduated to `v1beta1`. Please delete your existing webhooks before upgrading the cluster, and update your admission webhooks to use the latest API, because the API has backwards incompatible changes.
      The webhook registration related part of the `admissionregistration` API has graduated to `v1beta1`. Please delete your existing configurations before upgrading the cluster, and update your configuration file to use the latest API.
      ```
      4cafc545
    • Kubernetes Submit Queue's avatar
      Merge pull request #56128 from MrHohn/fix-ingress-before-each · 2ba1d991
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 56128, 56004, 56083, 55833, 56042). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Don't call f.BeforeEach() again in ingress suite
      
      **What this PR does / why we need it**: Calling f.BeforeEach() explicitly in ingress suite is causing test panics. See #56089.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes (hopefully) #56089
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      2ba1d991
  2. 21 Nov, 2017 33 commits