- 05 Jun, 2017 5 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43852, 44255) Bump github.com/mitchellh/mapstructure **What this PR does / why we need it**: This PR bump revision of github.com/mitchellh/mapstructure. The library is required by Gophercloud, also they has passed tests with the newer revision. So, since Gophercloud is update, please also renew this library. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add SuccessfulMountVolume message to the events of pod **What this PR does / why we need it:** When creating a pod with volume, the volume mount may failed at first, but eventually succeed after retry several times. kubectl describe pod can only see the failed messages, so i think it will be better to add the SuccessfulMountVolume message to the pod events too. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Fixes #42867
-
Phillip Wittrock authored
Delete federation system namespace from all the federated clusters.
-
Madhusudan.C.S authored
This is part of the namespace deletion big hammer. `kubefed join` not just creates federation-system namespace, but also cluster role and cluster role bindings in the joining clusters. Sometimes unjoin fails to delete them. So we use a big hammer here to delete them. This smells like a real problem in kubefed and needs investigation. This is a short term fix to unblock the submit queue.
-
Madhusudan.C.S authored
This is a big hammer. `kubefed join` creates federation-system namespace in the joining clusters if they don't already exist. This namespace usually exists in the host cluster and hence cannot be deleted while unjoining. So in order to be safe, we don't delete the federation-system namespace from any federated cluster while unjoining them. This causes a problem in our test environment if certain resources are left in the namespace. Therefore we are deleting all federation-system namespace in all the clusters.
-
- 04 Jun, 2017 14 commits
-
-
Madhusudan.C.S authored
PV is a non-namespaced resource. Running `kubectl delete pv --all`, even with `--namespace` is going to delete all the PVs in the cluster. This is a dangerous operation and should not be deleted this way. Instead we now retrieve the PVs bound to the PVCs in the namespace we are deleteing and delete only those PVs. Fixes issue #46380.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Respect PDBs during node upgrades and add test coverage to the ServiceTest upgrade test. This is still a WIP... needs to be squashed at least, and I don't think it's currently passing until I increase the scale of the RC, but please have a look at the general outline. Thanks! Fixes #38336 @kow3ns @bdbauer @krousey @erictune @maisem @davidopp ``` On GCE, node upgrades will now respect PodDisruptionBudgets, if present. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Delete all dead containers and sandboxes when under disk pressure. This PR modifies the eviction manager to add dead container and sandbox garbage collection as a resource reclaim function for disk. It also modifies the container GC logic to allow pods that are terminated, but not deleted to be removed. It still does not delete containers that are less than the minGcAge. This should prevent nodes from entering a permanently bad state if the entire disk is occupied by pods that are terminated (in the state failed, or succeeded), but not deleted. There are two improvements we should consider making in the future: - Track the disk space and inodes reclaimed by deleting containers. We currently do not track this, and it prevents us from determining if deleting containers resolves disk pressure. So we may still evict a pod even if we are able to free disk space by deleting dead containers. - Once we can track disk space and inodes reclaimed, we should consider only deleting the containers we need to in order to relieve disk pressure. This should help avoid a scenario where we try and delete a massive number of containers all at once, and overwhelm the runtime. /assign @vishh cc @derekwaynecarr ```release-note Disk Pressure triggers the deletion of terminated containers on the node. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Delete meaningless check **What this PR does / why we need it**: Delete meaningless check The deleted check is redundant. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46681, 46786, 46264, 46680, 46805) Bump cluster-proportional-autoscaler to 1.1.2 From https://github.com/kubernetes-incubator/cluster-proportional-autoscaler/pull/33. /assign @bowei **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46681, 46786, 46264, 46680, 46805) Enable Dialer on the Aggregator Centralize the creation of the dialer during startup. Have the dialer then passed in to both APIServer and Aggregator. Aggregator the uses the dialer as its Transport base. **What this PR does / why we need it**:Enables the Aggregator to use the Dialer/SSHTunneler to connect to the user-apiserver. **Which issue this PR fixes** : fixes ##46679 **Special notes for your reviewer**: **Release note**: None
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46681, 46786, 46264, 46680, 46805) Add annotation for image policy webhook fail open. **What this PR does / why we need it**: there's no good way to audit log if binary verification fails open. Adding an annotation can solve that, and provide a useful tool to audit [non-malicious] containers. **Release note**: add the annotation "alpha.image-policy.k8s.io/failed-open=true" to pods created when the image policy webhook fails open. ```release-note Add the `alpha.image-policy.k8s.io/failed-open=true` annotation when the image policy webhook encounters an error and fails open. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46681, 46786, 46264, 46680, 46805) Added sig leads alias to OWNERS_ALIAS **What this PR does / why we need it**: Add sig leads section to OWNERS_ALIASES so sig leads without maintainers access can add status labels to issues (important to 1.7 milestone) **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: Let me know you know of additional sig leads that should be added. **Release note**: ```NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46681, 46786, 46264, 46680, 46805) Fix for-loop and err definition **What this PR does / why we need it**: we can use j directly, it's odd to use i then get j through i. we can put err definition into if{} , after all the para. was only used in if{}. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` -
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40760, 46706, 46783, 46742, 46751) Pre-generate SNI test certs Pre-generates test certs for SNI tests, since doing this dynamically can take a loooong time in entropy-starved or CPU-bound test envs (like in a container).
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40760, 46706, 46783, 46742, 46751) Update gengo to the latest
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40760, 46706, 46783, 46742, 46751) complete the controller context for init funcs This completes the conversion to initFuncs for the controller initialization to make easier and more manageable to add them.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40760, 46706, 46783, 46742, 46751) Fix unit test for kubectl create role When expected err is not nil but error deos not happen, we should report error in unit test. **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 40760, 46706, 46783, 46742, 46751) enable kubelet csr bootstrap in GCE/GKE @jcbsmpsn @pipejakob Fixes https://github.com/kubernetes/kubernetes/issues/31168 ```release-note Enable kubelet csr bootstrap in GCE/GKE ```
-
- 03 Jun, 2017 21 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Implement Daemonset history ~Depends on #45867 (the 1st commit, ignore it when reviewing)~ (already merged) Ref https://github.com/kubernetes/community/pull/527/ and https://github.com/kubernetes/community/pull/594 @kubernetes/sig-apps-api-reviews @kubernetes/sig-apps-pr-reviews @erictune @kow3ns @lukaszo @kargakis --- TODOs: - [x] API changes - [x] (maybe) Remove rollback subresource if we decide to do client-side rollback - [x] deployment controller - [x] controller revision - [x] owner ref (claim & adoption) - [x] history reconstruct (put revision number, hash collision avoidance) - [x] de-dup history and relabel pods - [x] compare ds template with history - [x] hash labels (put it in controller revision, pods, and maybe deployment) - [x] clean up old history - [x] Rename status.uniquifier when we reach consensus in #44774 - [x] e2e tests - [x] unit tests - [x] daemoncontroller_test.go - [x] update_test.go - [x] ~(maybe) storage_test.go // if we do server side rollback~ kubectl part is in #46144 --- **Release note**: ```release-note ```
-
Tim Hockin authored
Kube-proxy cleanups
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue reset resultRun on pod restart xref https://bugzilla.redhat.com/show_bug.cgi?id=1455056 There is currently an issue where, if the pod is restarted due to liveness probe failures exceeding failureThreshold, the failure count is not reset on the probe worker. When the pod restarts, if the liveness probe fails even once, the pod is restarted again, not honoring failureThreshold on the restart. ```yaml apiVersion: v1 kind: Pod metadata: name: busybox spec: containers: - name: busybox image: busybox command: - sleep - "3600" livenessProbe: httpGet: path: /healthz port: 8080 initialDelaySeconds: 3 timeoutSeconds: 1 periodSeconds: 3 successThreshold: 1 failureThreshold: 5 terminationGracePeriodSeconds: 0 ``` Before this PR: ``` $ kubectl create -f busybox-probe-fail.yaml pod "busybox" created $ kubectl get pod -w NAME READY STATUS RESTARTS AGE busybox 1/1 Running 0 4s busybox 1/1 Running 1 24s busybox 1/1 Running 2 33s busybox 0/1 CrashLoopBackOff 2 39s ``` After this PR: ``` $ kubectl create -f busybox-probe-fail.yaml $ kubectl get pod -w NAME READY STATUS RESTARTS AGE busybox 0/1 ContainerCreating 0 2s busybox 1/1 Running 0 4s busybox 1/1 Running 1 27s busybox 1/1 Running 2 45s ``` ```release-note Fix kubelet reset liveness probe failure count across pod restart boundaries ``` Restarts are now happen at even intervals. @derekwaynecarr
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46782, 46719, 46339, 46609, 46494) Do not log the content of pod manifest if parsing fails. **What this PR does / why we need it**: - ~~only accepts text/plain config file~~ - ~~not log config file content when it's invalid~~ Do not log the content of pod manifest if parsing fails. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #46493 **Special notes for your reviewer**: /cc @yujuhong @sig-node-reviewers **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46782, 46719, 46339, 46609, 46494) Fix inconsistency in finding cni binaries Fixes [#46476] Signed-off-by:Abhinav Dahiya <abhinav.dahiya@coreos.com> **What this PR does / why we need it**: This fixes the inconsistency in finding the appropriate cni binaries. Currently `lo` cniNetwork follows vendorCniDir > binDir whereas default for all others is binDir > vendorCniDir. This PR makes vendorCniDir > binDir as default behavior. **Why we need it**: Hypercube right now ships cni binaries in /opt/cni/bin. And to use latest version of calico you need to override kubelet's /opt/cni/bin from host which means all other cni plugins (flannel, loopback etc...) have to be mounted from host too. Keeping vendordir at higher order allows easy installation of newer versions of plugins.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46782, 46719, 46339, 46609, 46494) update default translation of annotations **What this PR does / why we need it**: ``` using the local cluster. the help of kubectl is not corrent # ./cluster/kubectl.sh ....... Settings Commands: label Update the labels on a resource annotate Update the annotations on a resourcewatch is only supported on individual resources and resource collections - %d resources were found completion Output shell completion code for the specified shell (bash or zsh) Other Commands: api-versions Print the supported API versions on the server, in the form of "group/version" config Modify kubeconfig files help Help about any command plugin Runs a command-line plugin version Print the client and server version information Use "kubectl <command> --help" for more information about a given command. Use "kubectl options" for a list of global command-line options (applies to all commands). ``` **Which issue this PR fixes**: **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46782, 46719, 46339, 46609, 46494) Support custom domains in the cockroachdb example's init container This switches from using v0.1 of the peer-finder image to a version that includes https://github.com/kubernetes/contrib/pull/2013 While I'm here, switch the version of cockroachdb from 1.0 to 1.0.1 ```release-note NONE ``` @tschottdorf
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add some initial resource limits to the ip-masq-agent. These limits were based on observing the agent over roughly a day RES was typically ~4M for me but I'd like to make sure we have some headroom. If there was a huge config map then this could increase slightly but not significantly since we only allow 64 entries. VmPeak: 11164 kB VmSize: 11164 kB VmLck: 0 kB VmPin: 0 kB VmHWM: 7652 kB VmRSS: 4260 kB VmData: 7612 kB VmStk: 136 kB VmExe: 1856 kB VmLib: 0 kB VmPTE: 40 kB VmPMD: 20 kB VmSwap: 0 kB
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46620, 46732, 46773, 46772, 46725) Fix AppArmor test for docker 1.13 ... & better debugging. The issue is that we run the pod containers in a shared PID namespace with docker 1.13, so PID 1 is no longer the container's root process. Since it's messy to get the container's root process, I switched to using `/proc/self` to read the apparmor profile. While this wouldn't catch a regression that caused only the init process to run with the wrong profile, I think it's a good approximation. /cc @aulanov @Amey-D
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46620, 46732, 46773, 46772, 46725) apiserver: avoid resolving 'localhost' Fixes https://github.com/kubernetes/kubernetes/issues/46767.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46620, 46732, 46773, 46772, 46725) Added missing documentation to NodeInstanceGroup. **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46620, 46732, 46773, 46772, 46725) Instrument advanced auditing Add prometheus metrics for audit logging, including: - A total count of audit events generated and sent to the output backend - A count of audit events that failed to be audited due to an error (per backend) - A count of request audit levels (1 per request) For https://github.com/kubernetes/features/issues/22 - [x] TODO: Call `HandlePluginError` from the webhook backend, once https://github.com/kubernetes/kubernetes/pull/45919 merges (in this or a separate PR, depending on timing of the merge) /cc @ihmccreery @sttts @soltysh @ericchiang
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46620, 46732, 46773, 46772, 46725) Improving test coverage for kubelet/kuberuntime. **What this PR does / why we need it**: Increases test coverage for kubelet/kuberuntime https://github.com/kubernetes/kubernetes/issues/46123 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # https://github.com/kubernetes/kubernetes/issues/46123 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Adding a metadata proxy addon **What this PR does / why we need it**: adds a metadata server proxy daemonset to hide kubelet secrets. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: this partially addresses #8867 **Special notes for your reviewer**: **Release note**: the gce metadata server can be hidden behind a proxy, hiding the kubelet's token. ```release-note The gce metadata server can be hidden behind a proxy, hiding the kubelet's token. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 36721, 46483, 45500, 46724, 46036) retry clientCA post start hook on transient failures @smarterclayton retries the poststarthook you saw failing. Having looked through, it seems that I didn't kill the server on the failure.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 36721, 46483, 45500, 46724, 46036) stop special casing the loopback connection for aggregator Fixes a TODO for the aggregator loopback connection.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 36721, 46483, 45500, 46724, 46036) AWS: Allow configuration of a single security group for ELBs **What this PR does / why we need it**: AWS has a hard limit on the number of Security Groups (500). Right now every time an ELB is created Kubernetes is creating a new Security Group. This allows for specifying a Security Group to use for all ELBS **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: For some reason the Diff tool makes this look like it was way more changes than it really was. **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 36721, 46483, 45500, 46724, 46036) Federation: Minor corrections in service controller and add a unit testcase **What this PR does / why we need it**: This PR fixes few outdated comments in federation service controller and few other minor fixes. This also adds a unit test case to test federated service deletion. /assign @quinton-hoole /cc @marun @kubernetes/sig-federation-pr-reviews ```release-note NONE ```
-
David Ashpole authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add initializer support to admission and uninitialized filtering to rest storage Initializers are the opposite of finalizers - they allow API clients to react to object creation and populate fields prior to other clients seeing them. High level description: 1. Add `metadata.initializers` field to all objects 2. By default, filter objects with > 0 initializers from LIST and WATCH to preserve legacy client behavior (known as partially-initialized objects) 3. Add an admission controller that populates .initializer values per type, and denies mutation of initializers except by certain privilege levels (you must have the `initialize` verb on a resource) 4. Allow partially-initialized objects to be viewed via LIST and WATCH for initializer types 5. When creating objects, the object is "held" by the server until the initializers list is empty 6. Allow some creators to bypass initialization (set initializers to `[]`), or to have the result returned immediately when the object is created. The code here should be backwards compatible for all clients because they do not see partially initialized objects unless they GET the resource directly. The watch cache makes checking for partially initialized objects cheap. Some reflectors may need to change to ask for partially-initialized objects. ```release-note Kubernetes resources, when the `Initializers` admission controller is enabled, can be initialized (defaulting or other additive functions) by other agents in the system prior to those resources being visible to other clients. An initialized resource is not visible to clients unless they request (for get, list, or watch) to see uninitialized resources with the `?includeUninitialized=true` query parameter. Once the initializers have completed the resource is then visible. Clients must have the the ability to perform the `initialize` action on a resource in order to modify it prior to initialization being completed. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Close file after os.Open() None
-