- 22 Feb, 2018 1 commit
-
-
Maciej Pytel authored
-
- 20 Feb, 2018 8 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Return information about which int tests failed in the summary **What this PR does / why we need it**: Currently if integration tests fail they will print the name of the failing tests as it goes, but the summary only tells that it failed. You need to know what to look for to be able to find all these occurrences. This PR provides a summary next to the failure information, eg: ``` FAILED TESTS: run_cluster_management_tests, run_plugins_tests, ``` Which should greatly simplify developers integration debugging. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix race in healthchecking etcds leading to crashes Fix https://github.com/kubernetes/kubernetes/issues/59338
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. glusterfs: improve a few comments **What this PR does / why we need it**: This PR fixes a couple of comments in the glusterfs module: * fixes a typo in a comment * removes an outdated comment that is not correct (any more) * updates one comment to refer to upstream gluster documentation instead of downstream red hat product documentation
-
Wojciech Tyczynski authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Taint node when it under PID pressure. Signed-off-by:
Da K. Ma <madaxa@cn.ibm.com> **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: part of #54313 **Release note**: ```release-note If TaintNodesByCondition enabled, taint node when it under PID pressure ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add cblecker to vendor OWNERS **What this PR does / why we need it**: Adds myself to vendor OWNERS. I can help approve dep bumps of existing deps, and refer to Tim and new deps for license review. **Release note**: ```release-note NONE ``` /assign thockin
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update bazelbuild/rules_go, kubernetes/repo-infra, and gazelle dependencies **What this PR does / why we need it**: updates our bazelbuild/rules_go dependency in order to bump everything to go1.9.4. I'm separating this effort into two separate PRs, since updating rules_go requires a large cleanup, removing an attribute from most build rules. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove duplicated definition of ResourceList in Metrics API **What this PR does / why we need it**: Remove duplicated definition of ResourceList in Metrics API **Release note**: ```release-note NONE ```
-
- 19 Feb, 2018 8 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Monitor the /kubepods cgroup for allocatable metrics **What this PR does / why we need it**: The current implementation of allocatable memory evictions sums the usage of pods in order to compute the total usage by user processes. This PR changes this to instead monitor the `/kubepods` cgroup, which contains all pods, and use this value directly. This is more accurate than summing pod usage, as it is measured at a single point in time. This also collects metrics from this cgroup on-demand. This PR is a precursor to memcg notifications on the `/kubepods` cgroup. This removes the dependency the eviction manager has on the container manager, and adds a dependency for the summary collector on the container manager (to get Cgroup Root) This also changes the way that the allocatable memory eviction signal and threshold are added to make them in-line with the memory eviction signal to address #53902 **Which issue(s) this PR fixes**: Fixes #55638 Fixes #53902 **Special notes for your reviewer**: I have tested this, and can confirm that it works when CgroupsPerQos is set to false. In this case, it returns node metrics, as it is monitoring the `/` cgroup, rather than the `/kubepods` cgroup (which doesn't exist). **Release note**: ```release-note Expose total usage of pods through the "pods" SystemContainer in the Kubelet Summary API ``` cc @sjenning @derekwaynecarr @vishh @kubernetes/sig-node-pr-reviews
-
Michael Adam authored
Do not refer to downstream Red Hat documentation in the upstream kubernetes code, if there is upstream documentation to refer to. Signed-off-by:Michael Adam <obnox@redhat.com>
-
Michael Adam authored
Signed-off-by:Michael Adam <obnox@redhat.com>
-
Michael Adam authored
This was originally added due to a misunderstanding of the documentation of Heketi (using a different convention). Heketi's documentation has meanwhile been clarified. Signed-off-by:Michael Adam <obnox@redhat.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59398, 59881). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Pipe error message from openapi/swaggerspec verify checks to stderr **What this PR does / why we need it**: This pipes the error messages from openapi and swagger spec verify jobs to stderr so they show up in junit reports. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix invalid match rules for advanced audit policy When users or groups are set in a rule, this rule should not match attribute with unauthorized request where user and group are nil. **Release note**: ```release-note Unauthorized requests will not match audit policy rules where users or groups are set. ``` Fixes: https://github.com/kubernetes/kubernetes/issues/59331
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fixing CSI e2e test Current e2e test had some inconsistencies which were preventing it from running successfully on the local cluster. ```release-note Making sure CSI E2E test runs on a local cluster ``` Closes #60016
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. GCE: Fix SelfLink of cloudprovider mocks **What this PR does / why we need it**: Allows the user to pass in a ProjectRouter to the mocked services **Special notes for your reviewer**: /assign bowei /cc agau4779 **Release note**: ```release-note NONE ```
-
- 18 Feb, 2018 1 commit
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Do not add kubeconfig flag while running kubemci unless explicitly requested Follow up to https://github.com/kubernetes/kubernetes/pull/59955 Now that we have runKubemciWithKubeconfig, runKubemciCmd should not be adding kubeconfig flag. ```release-note NONE ```
-
- 17 Feb, 2018 15 commits
-
-
Serguei Bezverkhi authored
-
David Ashpole authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Move code only used by gce out of common.sh and into gce/util.sh xref #49213 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. CSI 0.2.0 breaking changes Refactor kubernetes CSI bits to support CSI version 0.2.0 ```release-note Addressing breaking changes introduced by new 0.2.0 release of CSI spec ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Revert "add node shutdown taint" Reverts kubernetes/kubernetes#59323 Node becomes unready, but is never removed. I've found the following in [kube-controller-manager.log](https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-e2e-gci-gce-autoscaling/6055/artifacts/bootstrap-e2e-master/cluster-autoscaler.log) from test run for one such node: `E0216 01:14:27.084923 1 node_lifecycle_controller.go:686] Error determining if node bootstrap-e2e-minion-group-01b1 shutdown in cloud: failed to get instance ID from cloud provider: instance not found` This goes on for the rest of the run (~6h). Looks like the node is stuck in Unready state because of this check: https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/nodelifecycle/node_lifecycle_controller.go#L684. Previously, there was no such check and the node was removed. Reverting as this would affect all users attempting to resize their node groups on GCE. ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Updated comments to correct flag of taint. Signed-off-by:
Da K. Ma <madaxa@cn.ibm.com> **Release note**: ```release-note None ```
-
Da K. Ma authored
Signed-off-by:Da K. Ma <madaxa@cn.ibm.com>
-
Da K. Ma authored
Signed-off-by:Da K. Ma <madaxa@cn.ibm.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59927, 59989, 59950). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. cluster/images/hyperkube: Fix typo in Dockerfile for aggregator symlink **What this PR does / why we need it**: Fixes typo in the hyperkube Dockerfile for kube-aggregator
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59927, 59989, 59950). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix e2e node setKubeletConfiguration helper The helper should have been using `apiequality.Semantic.DeepEqual`, instead of `reflect.DeepEqual`. Previously, nil vs empty containers were treated as not equal, but they should be considered equal for objects managed by Kubernetes API machinery, like KubeletConfiguration. This should fix the failing eviction tests. ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59927, 59989, 59950). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Enable mount propagation tests by default MountPropagation is enabled by default now, so should be the test. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59683, 59964, 59841, 59936, 59686). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. GCE: Create cloud-provider roles and bindings via addons **What this PR does / why we need it**: This removes the `cloud-provider` role and role binding from the rbac boostrapper and replaces it with a policy applied via addon mgr. This also creates a new clusterrole allowing the service account to create events for any namespace. **Special notes for your reviewer**: /assign @bowei @timstclair /cc timstclair **Release note**: ```release-note GCE: A role and clusterrole will now be provided with GCE/GKE for allowing the cloud-provider to post warning events on all services and watching configmaps in the kube-system namespace. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59683, 59964, 59841, 59936, 59686). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Move ipvs module loading logic in local-cluster-up.sh **What this PR does / why we need it**: This PR makes the module loading logic for ipvs kube-proxy a little more robust. Previously we were attempting to load the modules and not checking that it succeeded. Now we make sure the loading was successful before proceeding with using ipvs as the proxier. /assign @cblecker Release Note ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59683, 59964, 59841, 59936, 59686). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Reevaluate eviction thresholds after reclaim functions **What this PR does / why we need it**: When the node comes under `DiskPressure` due to inodes or disk space, the eviction manager runs garbage collection functions to clean up dead containers and unused images. Currently, we use the strategy of trying to measure the disk space and inodes freed by garbage collection. However, as #46789 and #56573 point out, there are gaps in the implementation that can cause extra evictions even when they are not required. Furthermore, for nodes which frequently cycle through images, it results in a large number of evictions, as running out of inodes always causes an eviction. This PR changes this strategy to call the garbage collection functions and ignore the results. Then, it triggers another collection of node-level metrics, and sees if the node is still under DiskPressure. This way, we can simply observe the decrease in disk or inode usage, rather than trying to measure how much is freed. **Which issue(s) this PR fixes**: Fixes #46789 Fixes #56573 Related PR #56575 **Special notes for your reviewer**: This will look cleaner after #57802 removes arguments from [makeSignalObservations](https://github.com/kubernetes/kubernetes/pull/57802/files#diff-9e5246d8c78d50ce4ba440f98663f3e9R719). **Release note**: ```release-note NONE ``` /sig node /kind bug /priority important-soon cc @kubernetes/sig-node-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Updating code to use TempDir in manifest test Follow up based on comments in https://github.com/kubernetes/kubernetes/pull/59234 ```release-note NONE ``` cc @MrHohn @madhusudancs @G-Harmon
-
- 16 Feb, 2018 7 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove unused getClusterCIDR() **What this PR does / why we need it**: getClusterCIDR() has been unused since the PR 57305[1], so this removes the method for code cleanup. [1]: https://github.com/kubernetes/kubernetes/pull/57305 **Release note**: "NONE"
-
nikhiljindal authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Deprecate kubelet flag for cadvisor port **Which issue(s) this PR fixes**: Issue: #56523 TL;DR the Kubelet's `stats/summary` API is the preferred way of monitoring the node. If you need additional metrics from cAdvisor, it can be run as a daemonset. **Release note**: ```release-note Deprecate the kubelet's cadvisor port ``` /assign @mtaufen @tallclair cc @kubernetes/sig-node-pr-reviews
-
Michael Taufen authored
The helper should have been using `apiequality.Semantic.DeepEqual`, instead of `reflect.DeepEqual`. Previously, nil vs empty containers were treated as not equal, but they should be considered equal for objects managed by Kubernetes API machinery, like KubeletConfiguration. This should fix the failing eviction tests.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Log the command line flags **What this PR does / why we need it**: With d7ddcca2, we lost the logging of the flags. We should at least log what the command line flags were used to start processes as those incredibly useful for trouble shooting. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: /assign @deads2k /assign @liggitt **Release note**: ```release-note NONE ```
-
Nick Sardo authored
-
Jeff Grafton authored
-