1. 18 Oct, 2017 37 commits
  2. 17 Oct, 2017 3 commits
    • Joonas Bergius's avatar
      Remove dangling shell functions · 0c9725d5
      Joonas Bergius authored
      0c9725d5
    • Kubernetes Submit Queue's avatar
      Merge pull request #53587 from spzala/master · d97c7591
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Provide aggregated validation errors for version and kind
      
      Currently the validation checks is done individually for version and
      kind group. For example, if user provided yaml file is missing apiVersion
      and kind fields, first they will receive error on apiVersion. Once user
      update the file and try to recreate, an error on missing kind is displayed.
      The behavior is same for wrong types of the fields.
      These errors should be aggregated and displayed.
      
      Examples of current validation:
      1
      test.yaml is missing apiVersion and kind:
      $kubectl.sh create -f /home/sahdev/go/src/bugfixes/test.yaml
      error: error validating "/home/sahdev/go/src/bugfixes/test.yaml": error validating data: apiVersion not set; if you choose to ignore these errors, turn validation off with --validate=false
      2.
      test.yaml is fixed for apiVersion but missing kind:
      $kubectl.sh create -f /home/sahdev/go/src/bugfixes/test.yaml
      error: error validating "/home/sahdev/go/src/bugfixes/test.yaml": error validating data: kind not set; if you choose to ignore these errors, turn validation off with --validate=false
      
      Examples with aggregated validation: 
      1.
      error: error validating "/home/sahdev/go/src/bugfixes/test.yaml": error validating data: [apiVersion not set, kind not set]; if you choose to ignore these errors, turn validation off with --validate=false
      2.
      error: error validating "/home/sahdev/go/src/bugfixes/testmix.yaml": error validating data: [apiVersion isn't string type, kind not set]; if you choose to ignore these errors, turn validation off with --validate=false
      
      
      
      **What this PR does / why we need it**:
      To provide aggregated validations to user for version and kind group.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #54098
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      d97c7591
    • Kubernetes Submit Queue's avatar
      Merge pull request #52503 from joelsmith/journald-log-fallback · e3e2e24c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 54040, 52503). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Get fallback termination msg from docker when using journald log driver
      
      **What this PR does / why we need it**:
      
      When using the legacy docker container runtime and when a container has `terminationMessagePolicy=FallbackToLogsOnError` and when docker is configured with a log driver other than `json-log` (such as `journald`), the kubelet should not try to get the container's log from the json log file (since it's not there) but should instead ask docker for the logs.
      
      **Which issue this PR fixes** fixes #52502
      
      **Special notes for your reviewer**:
      
      **Release note**:
      ```release-note
      Fixed log fallback termination messages when using docker with journald log driver
      ```
      e3e2e24c