- 18 Oct, 2017 40 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix RC/RS conversion This fixes some round-trip information loss when representing an RC as an RS. I want to use these conversions in #49429 to eliminate the maintenance burden of duplicated RC code. @kubernetes/sig-apps-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. allow fail close webhook admission Webhook admission needs to allow failing closed. Even in an alpha state, I don't want to be one DDOS away from having an exposed cluster. /assign caesarxuchao /assign sttts
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. allow */subresource in rbac policy rules xref #29698 xref #38756 xref #49504 xref #38810 Allow `*/subresource` format in RBAC policy rules to support polymorphic subresources like `*/scale` for HPA. @DirectXMan12 fyi ```release-note RBAC PolicyRules now allow resource=`*/<subresource>` to cover `any-resource/<subresource>`. For example, `*/scale` covers `replicationcontroller/scale`. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43661, 54062). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix typo in function name. Also remove a superfluous comment. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 43661, 54062). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix #43583 (kubenet: remove code forcing bridge MAC address) **What this PR does / why we need it**: *kubenet: remove code forcing bridge MAC address* **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #43583 **Special notes for your reviewer**: **Release note**: ```release-note ``` cc @dcbw @freehan
-
Anthony Yeh authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 47717, 53896). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. decode admission responses into a fresh object Something about the way the admission request object is built causes decoding into back into it to fail with ``` W1013 14:10:42.457423 2960 admission.go:185] rejected by webhook namespacereservations.admission.online.openshift.io/apis/admission.online.openshift.io/v1alpha1/namespacereservations &{%!t(string=namespacereservations.admission.online.openshift.io/apis/admission.online.openshift.io/v1alpha1/namespacereservations) %!t(*errors.errorString=&{reflect.Value.Addr of unaddressable value})}: failed calling admission webhook "namespacereservations.admission.online.openshift.io/apis/admission.online.openshift.io/v1alpha1/namespacereservations": reflect.Value.Addr of unaddressable value ``` This simply creates a fresh object to decode into, which works fine for our usage and makes it possible to actually have the webhook call out to something.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 47717, 53896). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Delete the redundant parameter flag What this PR does / why we need it: Delete redundant parameter flag, otherwise the log will be show like: Warning: path "/var/lib/kubelet/pods/3c6c4869-4d02-11e7-9685-fa163eeda0fa/volumes" does not exist: %!q(MISSING) thank you!
-
Anthony Yeh authored
-
Anthony Yeh authored
-
Anthony Yeh authored
The `out` parameter in Convert_map_to_unversioned_LabelSelector was being ignored.
-
David Eads authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump cluster autoscaler to 1.0.1-beta1 Contains fixes around scale from 0 and node autoprovisioning.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. pkg/api: extract Scheme/Registry/Codecs into pkg/api/legacyscheme This serves as - a preparation for the pkg/api->pkg/apis/core move - and makes the dependency to the scheme explicit when vizualizing left depenncies. The later helps with our our efforts to split up the monolithic repo into self-contained sub-repos, e.g. for kubectl, controller-manager and kube-apiserver in the future.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Updated cluster/addons readme to match and point to docs **What this PR does / why we need it**: Reading the documents in the codebase lead some to think this method was current. But, according to the docs in the docs this is legacy. The updated readme is an attempt to keep the docs and codebase consistent.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add pod related conformance annotations Signed-off-by:
Brad Topol <btopol@us.ibm.com> /sig testing /area conformance @sig-testing-pr-reviews This PR adds pod related conformance annotations to the e2e test suite. The PR fixes a portion of #53822. It focuses on adding conformance annotations as defined by the Kubernetes Conformance Workgroup for a subset of the pod based e2e conformance tests. **Special notes for your reviewer**: Please see https://docs.google.com/spreadsheets/d/1WWSOqFaG35VmmPOYbwetapj1VPOVMqjZfR9ih5To5gk/edit#gid=62929400 for the list of SIG Arch approved test names and descriptions that I am using. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. add deads to admission owners /assign derekwaynecarr
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Ensure network policy conversion round trips nil from field xref https://github.com/kubernetes/kubernetes/issues/53906 ```release-note NONE ```
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54045, 51375). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Upgrade to go1.9 **What this PR does / why we need it**: Upgrade to go1.9. Upgrading is good. It's "the best golang release ever"! **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49484 **Special notes for your reviewer**: **Release note**: ```release-note Upgrade to go1.9 ``` /assign @luxas @ixdy @wojtek-t
-
Matt Farina authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Increase l7-lb-controller's memory check threshold in density test Reason for density test failing in our [latest 5k-node run](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-scale-performance/49): ``` I1016 23:17:15.673] Container l7-lb-controller-v0.9.7-gce-scale-cluster-master/l7-lb-controller is using 3428.52734375/3075 MB of memory I1016 23:17:15.673] not to have occurred[0m ``` cc @kubernetes/sig-scalability-misc
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53958, 53947). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Always retry connection reset error in webhook Fixes https://github.com/kubernetes/kubernetes/issues/52909 Audit logging uses webhook to send events to the backend and currently even a little blip in networking can cause several hundreds of events to be lost. This PR adds an additional check, that is similar to [the one in the rest package](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/rest/request.go#L657), but ignores the fact that the request is not GET and always retries "Connection reset by peers" error. ```release-note Webhook always retries connection reset error. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53958, 53947). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix PV Recycle issue when running on multi-arch **What this PR does / why we need it**: Currently PV Recycle uses image `gcr.io/google_containers/busybox`, which is an amd64 image, not applied for multi-arch , to start pod `"pv-recycler"`. For other non-x86 platforms, like `ppc64le` and `arm64`, the pod cannot get started due to the busybox image. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #53942 **Special notes for your reviewer**: /cc @gyliu513 @mkumatag /assign @saad-ali @jsafrane **Release note**: ```release-note fix PV Recycle failed on non-amd64 platfrom ```
-
Brad Topol authored
Signed-off-by:Brad Topol <btopol@us.ibm.com> ran gofmt and rebased
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53872, 53719). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix azureDisk warns about disk format failure **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #53713 **Special notes for your reviewer**: **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. refactor pd.go for future tests **What this PR does / why we need it**: Refactored _test/e2e/storage/pd.go_ so that it will be easier to add new tests, which I plan on doing to address issue 52676 1. Condenses 8 `It` blocks into 3 table driven tests. 2. Adds several `By` descriptions and `Logf` messages. 3. provides more consistent formatting and messages. **Special notes for your reviewer**: The diff is large but mostly I've not altered any test. The one semantic change I made was to remove the call to verify a write to a PD when, in fact, nothing had been written yet. This was essentially a no-op since the verify code returned immediately if the passed-in map was empty (which it was since nothing had been written). ```release-note NONE ``` cc @jingxu97 @copejon
-
Marcin Wielgus authored
-
Dr. Stefan Schimanski authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53965, 54117, 53685). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove dangling shell functions **What this PR does / why we need it**: This is clean up for shell functionality that was left over from when something was first added and subsequently removed, but didn't include cleaning up all of the logic they references. **Special notes for your reviewer**: I traced back the functions to when they were added and had their references removed, so I thought I'd share that for context: * `kube::golang::current_platform` was added in 5d33ce46, but never ended up being used. My understanding is that this is due to having more or less the same logic available in `kube::golang::host_platform`, which is what's being used. * `kube::util::gen-analytics` was added in 553f9f82 and had the use of it removed in 902ffd53 when docs * `kube::util::analytics-link` was added in 553f9f82 and had the use of it removed in ffcc6cad * `kube::util::get_random_port` was added in 5d08dcf8 and superseded by `kubectl proxy --port=0` in 22b43d8f * `kube::util::test_host_port_free` was added in 5d08dcf8 and superseded by `kubectl proxy --port=0` in 22b43d8f I should also note that [`kube::golang::unset_platform_envs()`](https://github.com/kubernetes/kubernetes/blob/e8e72a44444d9ded58bcba13d650c98dab2cb465/hack/lib/golang.sh#L301-L307) was introduced in 5d33ce46 and is currently unused, but was referenced in 9848d6cc and subsequently removed in 38690ff7. If that's something worth including here, I'd be happy to add that also. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53965, 54117, 53685). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fixing a glog message to not print managed zones when it is empty ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. CRI: Add extra information in status functions in CRI. Fixes https://github.com/kubernetes/kubernetes/issues/53757. @yujuhong @feiskyer @mrunalp /cc @kubernetes/sig-node-api-reviews ```release-note Verbose option is added to each status function in CRI. Container runtime could return extra information in status response for debugging. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 53696, 54059). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix lint warnings for useless err checks. **What this PR does / why we need it**: This check was recently added to golint. **Which issue this PR fixes** Related to #37254 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Increases test coverage for kubelet/kuberuntime What this PR does / why we need it: Increases test coverage for kubelet/kuberuntime #46123 Which issue this PR fixes: #46123 /assign @feiskyer
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix the bad code comment **What this PR does / why we need it**: fix the bad code comment in scheduler **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note None ```
-
nikhiljindal authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54030, 54041). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Adjust replenishmentControllers in resource quota controller **What this PR does / why we need it**: Since replenishmentControllers was generated by ctx.InformerFactory, remove "replenishmentControllers []cache.Controller" which is never used, and it is needless to run replenishmentControllers which has ran in "ctx.InformerFactory.Start(ctx.Stop)". **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54030, 54041). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix admission webhook test failure in go1.9 **What this PR does / why we need it**: Go 1.9 has some better checks for SAN extensions, notably: https://github.com/golang/go/commit/630e93ed2d8a13226903451a0e85e62efd78cdcd We recently added ServerName to the rest client TLSConfig: https://github.com/dims/kubernetes/commit/186a0684d582272aa2fbfec390aea5fbb88a8bc6#diff-eb3573c6b11347dc3793c477726480efR262 So we need to be sure that the ServerName "webhook-test.default.svc" is present in the certificates that we generate." **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Fixes #54020 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Di Xu authored
-