- 07 Jul, 2016 40 commits
-
-
Tim Hockin authored
This is the last piece of Clayton's #26179 to be implemented with file tags. All diffs are accounted for. Followup will use this to streamline some packages. Also add some V(5) debugging - it was helpful in diagnosing various issues, it may be helpful again.
-
Tim Hockin authored
This drives most of the logic of deep-copy generation from tags like: // +deepcopy-gen=package ..rather than hardcoded lists of packages. This will make it possible to subsequently generate code ONLY for packages that need it *right now*, rather than all of them always. Also remove pkgs that really do not need deep-copies (no symbols used anywhere).
-
Tim Hockin authored
This will be used when generated files are no longer checked in. I include it as a standalone commit for ease of review.
-
Tim Hockin authored
It's simpler and clearer without them, and it leaves room for per-use-case parsing of the tag lines. If anything we should be splitting on whitespace.
-
Tim Hockin authored
This is in prep to simplify tag logic. Don't rely on processing commas as new tag delimiters. Put new tags on new lines. This had zero effect on generated code (as intended).
-
Tim Hockin authored
Previously we just tracked comments on the 'package' declaration. Treat all file comments as one comment-block, for simplicity. Can be revisited if needed.
-
Tim Hockin authored
This means that tags like: // +foo=bar // +foo=bat ..will produce []string{"bar", "bat"}. This is needed for later commits which will want to use this to make code generation more self contained. -
Tim Hockin authored
This makes subsequent comment-tag PRs more consistent.
-
Tim Hockin authored
In bringing back Clayton's PR piece-by-piece this was almost as easy to implement as his version, and is much more like what I think we should be doing. Specifically, any time which defines a .DeepCopy() method will have that method called preferentially. Otherwise we generate our own functions for deep-copying. This affected exactly one type - resource.Quantity. In applying this heuristic, several places in the generated code were simplified. To achieve this I had to convert types.Type.Methods from a slice to a map, which seems correct anyway (to do by-name lookups).
-
Tim Hockin authored
This re-institutes some of the rolled-back logic from previous commits. It bounds the scope of what the deepcopy generator is willing to do with regards to generating and calling generated functions.
-
Tim Hockin authored
His PR cam during the middle of this development cycle, and it was easier to burn it down and recreate it than try to patch it into an existing series and re-test every assumption. This behavior will be re-introduced in subsequent commits.
-
k8s-merge-robot authored
Automatic merge from submit-queue The notes are inconsistent with the code In file "pkg/client/cache/store.go, the notes of line 102 "name and namespace" is inconsistent with line 103 "return parts[0], parts[1], nil", because parts[0] is namespace, and parts[1] is name, It is easy to be confused, and better to modify the notes to "namespace and name".
-
k8s-merge-robot authored
Automatic merge from submit-queue Validation: Make validation func return error strings Part of an ongoing series of validation cleanups. This centralizes the error strings next to the code that checks the error conditions. Future commits will refine the messages further and provide more utility validators. I'm OK if this doesn't go into 1.2, but I am tired of rebasing :) I suggest commit-by-commit review, which should go pretty quickly. This was largely mechanical. <!-- Reviewable:start --> --- This change is [<img src="http://reviewable.k8s.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](http://reviewable.k8s.io/reviews/kubernetes/kubernetes/21240) <!-- Reviewable:end -->
-
k8s-merge-robot authored
Automatic merge from submit-queue Fix the way addon-manager handles non-namespaced objects Fixes #28451 cc @wojtek-t
-
k8s-merge-robot authored
Automatic merge from submit-queue Remove unbalanced right-paren in influxdb-pv.yaml fixes #28620
-
k8s-merge-robot authored
Automatic merge from submit-queue Fix problem specifying fqdn:port in command line When specifying --server in kubectl for example, we end up with failure if you use "localhost:8080" instead of "127.0.0.1:8080". This is because of the way url.Parse works as shown in snippet: https://play.golang.org/p/luD57S6sEz Essentially localhost ends up as the Scheme and NOT as the Host. So we add another check to make sure we prepend the scheme when Host ends up being empty as well. Tested with "kubectl --server localhost:8080 get po" Fixes #2967
-
k8s-merge-robot authored
Automatic merge from submit-queue clean up dup code for kubelet `RunKubelet` is called elsewhere, hence we should keep it that way. Fixes #25345
-
k8s-merge-robot authored
Automatic merge from submit-queue Fixed a little typo in Cassandra example Readme Just a little fix for a typo in the Cassandra Cluster Example. []()
-
k8s-merge-robot authored
Automatic merge from submit-queue Move ActiveDeadlineSeconds implementation into a kubelet sync observer The first commit is from: https://github.com/kubernetes/kubernetes/pull/24344 The second commit moves the code for enforcement around active deadlines into a kubelet sync observer pattern. It groups code that used to be scattered across the kubelet. <!-- Reviewable:start --> --- This change is [<img src="http://reviewable.k8s.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](http://reviewable.k8s.io/reviews/kubernetes/kubernetes/24705) <!-- Reviewable:end -->
-
k8s-merge-robot authored
Automatic merge from submit-queue Cleanup third party (pt 2) Move forked-and-hacked golang code to the forked/ directory. Remove ast/build/parse code that is now in stdlib. Remove unused shell2junit
-
k8s-merge-robot authored
Automatic merge from submit-queue Remove cmd/integration test Fix #24440 After few cleanup PRs: https://github.com/kubernetes/kubernetes/pull/27182 https://github.com/kubernetes/kubernetes/pull/27535 https://github.com/kubernetes/kubernetes/pull/26016 The only things that are being tested here is: - starting master components without any verification (so if it didn't start, it will still work :P) - checking if kubelet is starting containers from http manifest. The latter is already tested in: https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/config/http_test.go#L54 So the test is now useless, at the same time, significantly increasing time spent on integration tests. @lavalamp @mikedanese @spxtr @fejta
-
k8s-merge-robot authored
Automatic merge from submit-queue Remove unneeded continute very minor but I noticed and it and it bugged me :-) Signed-off-by:Doug Davis <dug@us.ibm.com>
-
k8s-merge-robot authored
Automatic merge from submit-queue s/positive/negative/ in the error message I think we meant to imply that "if the error isn't real" then update the exceptions file - which to me means "false negative", ie. false failure. Signed-off-by:Doug Davis <dug@us.ibm.com>
-
allenmiller authored
-
k8s-merge-robot authored
Automatic merge from submit-queue Mount r/w GCE PD disks with -o discard As per https://cloud.google.com/compute/docs/disks/add-persistent-disk#formatting. Fixes #23258
-
derekwaynecarr authored
-
k8s-merge-robot authored
Automatic merge from submit-queue Remove br_netfilter warning in kube-proxy Many distros have this module linked in, generating a spurious error. Fixes #23385
-
k8s-merge-robot authored
Automatic merge from submit-queue MESOS: Support a pre-installed km binary at a well known, agent-local path fixes #26930
-
k8s-merge-robot authored
Automatic merge from submit-queue Represent unversioned.Time correctly in swagger spec unversioned.Time previously represented as "string" type with no format while the correct representation should also have "date-time" as format. fixes #2968
-
k8s-merge-robot authored
Automatic merge from submit-queue break integration tests into seperate packages so that they run in parallel If this is broken then our tests aren't threadsafe. ref #25940
-
Klaus Ma authored
-
k8s-merge-robot authored
Automatic merge from submit-queue api: validate generation updates @bprashanth @liggitt PTAL
-
Andrea Cosentino authored
-
k8s-merge-robot authored
Automatic merge from submit-queue Log available pods of deployments when scaling down old RS Ref #26834 []()
-
k8s-merge-robot authored
Automatic merge from submit-queue build: fixed ${KUBE_ROOT} prefix for build scripts Running `./make-build-image.sh` command inside the `build` directory doesn't work: ```sh $ cd build $ ./make-build-image.sh ./../build/common.sh: line 32: hack/lib/init.sh: No such file or directory ``` This PR adds `${KUBE_ROOT}` prefix for the `source` bash function. Also I added braces to unify the code style. []() -
k8s-merge-robot authored
Automatic merge from submit-queue Cleanup hack/ Dockerfiles <!-- Checklist for submitting a Pull Request Please remove this comment block before submitting. 1. Please read our [contributor guidelines](https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md). 2. See our [developer guide](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md). 3. If you want this PR to automatically close an issue when it is merged, add `fixes #<issue number>` or `fixes #<issue number>, fixes #<issue number>` to close multiple issues (see: https://github.com/blog/1506-closing-issues-via-pull-requests). 4. Follow the instructions for [labeling and writing a release note for this PR](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes) in the block below. --> ```release-note Small improvements to hack/ Dockerfiles ``` []()
-
Michail Kargakis authored
-
Mike Danese authored
Signed-off-by:Mike Danese <mikedanese@google.com>
-
Mike Danese authored
Signed-off-by:Mike Danese <mikedanese@google.com>
-
Mike Danese authored
Signed-off-by:Mike Danese <mikedanese@google.com>
-