• Kubernetes Submit Queue's avatar
    Merge pull request #43609 from Random-Liu/update-npd-rbac · 53d14e9a
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue
    
    Update NPD rbac.
    
    I recently enabled NPD in gke.
    
    However, I found that in gke e2e test (https://k8s-testgrid.appspot.com/google-gke#gci-gke), npd on the node could not talk with apiserver, and reported full of following errors:
    ```
    E0324 05:08:26.745545    1328 manager.go:160] failed to update node conditions: the server does not allow access to the requested resource (patch nodes gke-bootstrap-e2e-default-pool-fd91d792-mqh4)
    E0324 05:08:37.719423    1328 manager.go:160] failed to update node conditions: the server does not allow access to the requested resource (patch nodes gke-bootstrap-e2e-default-pool-fd91d792-mqh4)
    E0324 05:08:47.719694    1328 manager.go:160] failed to update node conditions: the server does not allow access to the requested resource (patch nodes gke-bootstrap-e2e-default-pool-fd91d792-mqh4)
    ```
    
    I created a GKE cluster (v1.7.0-alpha.0.1483+1e879c69) myself, and found that addon manager could not create npd binding with the following error:
    ```
    error: error validating "/etc/kubernetes/addons/node-problem-detector/standalone/npd-binding.yaml": error validating data: couldn't find type: v1alpha1.ClusterRoleBinding; if you choose to ignore these errors, turn validation off with --validate=false
    ```
    
    I found that rbac was updated to beta, but npd was missed because it was merged after https://github.com/kubernetes/kubernetes/commit/9e6a3496b44e9a5ab9740cb903e46f769d65cde3#diff-b05c70853d9a772b310db71a61297841.
    
    I updated rbac to beta in the master manifest and npd on the node could talk with apiserver immediately.
    We must get this in 1.6 to make NPD working. @dchen1107 
    
    @dchen1107 @fabioy @liggitt
    53d14e9a
Name
Last commit
Last update
..
addon-manager Loading commit data...
calico-policy-controller Loading commit data...
cluster-loadbalancing Loading commit data...
cluster-monitoring Loading commit data...
dashboard Loading commit data...
dns Loading commit data...
dns-horizontal-autoscaler Loading commit data...
e2e-rbac-bindings Loading commit data...
etcd-empty-dir-cleanup Loading commit data...
fluentd-elasticsearch Loading commit data...
fluentd-gcp Loading commit data...
node-problem-detector Loading commit data...
podsecuritypolicies Loading commit data...
python-image Loading commit data...
rbac Loading commit data...
registry Loading commit data...
storage-class Loading commit data...
BUILD Loading commit data...
README.md Loading commit data...