• Kubernetes Submit Queue's avatar
    Merge pull request #42755 from aveshagarwal/master-fix-default-toleration-seconds · 8cb14a4f
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 41794, 42349, 42755, 42901, 42933)
    
    Fix DefaultTolerationSeconds admission plugin
    
    DefaultTolerationSeconds is not working as expected. It is supposed to add default tolerations (for unreachable and notready conditions). but no pod was getting these toleration. And api server was throwing this error:
    
    ```
    Mar 08 13:43:57 fedora25 hyperkube[32070]: E0308 13:43:57.769212   32070 admission.go:71] expected pod but got Pod
    Mar 08 13:43:57 fedora25 hyperkube[32070]: E0308 13:43:57.789055   32070 admission.go:71] expected pod but got Pod
    Mar 08 13:44:02 fedora25 hyperkube[32070]: E0308 13:44:02.006784   32070 admission.go:71] expected pod but got Pod
    Mar 08 13:45:39 fedora25 hyperkube[32070]: E0308 13:45:39.754669   32070 admission.go:71] expected pod but got Pod
    Mar 08 14:48:16 fedora25 hyperkube[32070]: E0308 14:48:16.673181   32070 admission.go:71] expected pod but got Pod
    ```
    
    The reason for this error is that the input to admission plugins is internal api objects not versioned objects so expecting versioned object is incorrect. Due to this, no pod got desired tolerations and it always showed:
    
    ```
    Tolerations: <none>
    ```
    
    After this fix, the correct  tolerations are being assigned to pods as follows:
    
    ```
    Tolerations:	node.alpha.kubernetes.io/notReady=:Exists:NoExecute for 300s
    		node.alpha.kubernetes.io/unreachable=:Exists:NoExecute for 300s
    ```
    
    @davidopp @kevin-wangzefeng @kubernetes/sig-scheduling-pr-reviews @kubernetes/sig-scheduling-bugs @derekwaynecarr 
    
    Fixes https://github.com/kubernetes/kubernetes/issues/42716
    8cb14a4f
Name
Last commit
Last update
..
admit Loading commit data...
alwayspullimages Loading commit data...
antiaffinity Loading commit data...
defaulttolerationseconds Loading commit data...
deny Loading commit data...
exec Loading commit data...
gc Loading commit data...
imagepolicy Loading commit data...
initialresources Loading commit data...
limitranger Loading commit data...
namespace Loading commit data...
persistentvolume/label Loading commit data...
podnodeselector Loading commit data...
podpreset Loading commit data...
resourcequota Loading commit data...
security Loading commit data...
securitycontext/scdeny Loading commit data...
serviceaccount Loading commit data...
storageclass/default Loading commit data...
OWNERS Loading commit data...