Fixes ArcticaProject/nx-libs#907 (3/3)

Fixes ArcticaProject/nx-libs#907 (2/3)

nxagentCorrupted* were defined twice!

Fixes ArcticaProject/nx-libs#907 (1/3)

plus some whitespace improvements

Static analyzer reported: (error) Uninitialized variable: elements

Attributes ArcticaProject/nx-libs#905

Improve visibility by unindenting. Also move the ifdefs _before_ the
according comments. Finally merge ifdefs to fewer blocks.

Fix warning with NX_DEBUG_INPUT:

NXproperty.c: In function ‘ProcChangeProperty’:
NXproperty.c:210:7: warning: implicit declaration of function ‘nxagentGuessDumpInputInfo’; did you mean ‘nxagentGuessClientHint’? [-Wimplicit-function-declaration]
       nxagentGuessDumpInputInfo(client, stuff->property, (char *) &stuff[1]);
       ^~~~~~~~~~~~~~~~~~~~~~~~~
       nxagentGuessClientHint

Display.c: In function ‘nxagentResetDisplayHandlers’:
Display.c:901:5: warning: implicit declaration of function ‘nxagentReleaseAllSplits’; did you mean ‘nxagentWakeupBySplit’? [-Wimplicit-function-declaration]
     nxagentReleaseAllSplits();
     ^~~~~~~~~~~~~~~~~~~~~~~
     nxagentWakeupBySplit

As reported by static analyzer:
(error) Common realloc mistake: 'nxagentVisuals' nulled but not freed upon failure

As reported by static analyzer:
(error) Common realloc mistake: 'ptr' nulled but not freed upon failure

Attributes ArcticaProject/nx-libs#905

Fix these warnings with NX_DEBUG_INPUT enabled:

NXdispatch.c: In function ‘Dispatch’:
NXdispatch.c:350:74: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CARD32’ {aka ‘unsigned int’} [-Wformat=]
           fprintf(stderr, "Session: Session started at '%s' timestamp [%lu].\n",
                                                                        ~~^
                                                                        %u
                       GetTimeAsString(), GetTimeInMillis());

Reconnect.c: In function ‘nxagentHandleConnectionStates’:
Reconnect.c:303:74: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CARD32’ {aka ‘unsigned int’} [-Wformat=]
         fprintf(stderr, "Session: Session suspended at '%s' timestamp [%lu].\n", GetTimeAsString(), GetTimeInMillis());
                                                                        ~~^                          ~~~~~~~~~~~~~~~~~
                                                                        %u
Reconnect.c: In function ‘nxagentReconnectSession’:
Reconnect.c:673:66: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CARD32’ {aka ‘unsigned int’} [-Wformat=]
   fprintf(stderr, "Session: Session resumed at '%s' timestamp [%lu].\n", GetTimeAsString(), GetTimeInMillis());
                                                                ~~^                          ~~~~~~~~~~~~~~~~~
                                                                %u

As reported by static analyzer.

Attributes ArcticaProject/nx-libs#905

Use the "xorg_" prefix as everywhere else, not "Xorg_".

Also add original code to make NX changes obvious. Also change some
lines to match original code.

and use DEBUG like everywhere else. There were already some TEST lines
using this scheme.

Also indent DEBUG and TEST lines to make the code more readable

make compilation work with -DNX_DEBUG_INPUT

NX_WAKEUP had been non-effective and its effect had been tied to NX_TRANS_WAKEUP.

1. indent ifdefs
2. add some logic at start that unset NX_TRANS_WAKEUP and
NX_TRANS_DEBUG if NX_TRANS_SOCKET is unset. This way we only have to
check for one macro and not all three.
3. remove redundant macro checks
4. decouple debug printfs by always running the original code and adding the
   identical check in #ifdef NX_TRANS_DEBUG

and remove obsolete NX_SPLASH

Instead of hardcoding the keystrokes in Dialog.h determine the
currently configured keystrokes for the action and insert them into
the dialog strings.

Fixes ArcticaProject/nx-libs#438

and use True/False instead of 1/0

This change ensures Literals.h is always referenced during
compilation, effectively hiding it from "unused file" detection we do
occasionally to clean up the source code.

Derived from

  commit 978f3b496b9951ee8120a0efcc5cd12503e26770
  Author: Roland Mainz <roland.mainz@nrubsig.org>
  Date:   Sat Mar 5 21:38:29 2005 +0000

    xc/programs/Xserver/Imakefile
    xc/programs/Xserver/hw/xnest/Imakefile
    //bugs.freedesktop.org/show_bug.cgi?id=2653) attachment #2020
        (https://bugs.freedesktop.org/attachment.cgi?id=2020): Cleanup Xnest
        usage of the DPMS dummy stub functions from dpmsstubs.c instead of
        using it's own copy of these functions.

Fixes ArcticaProject/nx-libs#901

File was missing in Imakefile. We are not using the ffs function, but
nevertheless it's a part of dix.

Backport of this xorg-xserver commit:

  commit 75c51c67b340548286efd41a53882e2acaf74ab5
  Author: Alan Coopersmith <alan.coopersmith@sun.com>
  Date:   Thu Jun 18 09:49:12 2009 -0700

    Clarify use of and need for mffs vs. ffs
Signed-off-by: Alan Coopersmith <alan.coopersmith@sun.com>

Follow-up for 2a5364d5

See ArcticaProject/nx-libs#263 for discussion