and correctly print its value in debugging output

ensure same order for internal and external Atoms

Fixes ArcticaProject/nx-libs#907 (3/3)

Fixes ArcticaProject/nx-libs#907 (2/3)

nxagentCorrupted* were defined twice!

Fixes ArcticaProject/nx-libs#907 (1/3)

plus some whitespace improvements

Static analyzer reported: (error) Uninitialized variable: elements

Attributes ArcticaProject/nx-libs#905

Improve visibility by unindenting. Also move the ifdefs _before_ the
according comments. Finally merge ifdefs to fewer blocks.

Fix warning with NX_DEBUG_INPUT:

NXproperty.c: In function ‘ProcChangeProperty’:
NXproperty.c:210:7: warning: implicit declaration of function ‘nxagentGuessDumpInputInfo’; did you mean ‘nxagentGuessClientHint’? [-Wimplicit-function-declaration]
       nxagentGuessDumpInputInfo(client, stuff->property, (char *) &stuff[1]);
       ^~~~~~~~~~~~~~~~~~~~~~~~~
       nxagentGuessClientHint

Display.c: In function ‘nxagentResetDisplayHandlers’:
Display.c:901:5: warning: implicit declaration of function ‘nxagentReleaseAllSplits’; did you mean ‘nxagentWakeupBySplit’? [-Wimplicit-function-declaration]
     nxagentReleaseAllSplits();
     ^~~~~~~~~~~~~~~~~~~~~~~
     nxagentWakeupBySplit

As reported by static analyzer:
(error) Common realloc mistake: 'nxagentVisuals' nulled but not freed upon failure

As reported by static analyzer:
(error) Common realloc mistake: 'ptr' nulled but not freed upon failure

Attributes ArcticaProject/nx-libs#905

Fix these warnings with NX_DEBUG_INPUT enabled:

NXdispatch.c: In function ‘Dispatch’:
NXdispatch.c:350:74: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CARD32’ {aka ‘unsigned int’} [-Wformat=]
           fprintf(stderr, "Session: Session started at '%s' timestamp [%lu].\n",
                                                                        ~~^
                                                                        %u
                       GetTimeAsString(), GetTimeInMillis());

Reconnect.c: In function ‘nxagentHandleConnectionStates’:
Reconnect.c:303:74: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CARD32’ {aka ‘unsigned int’} [-Wformat=]
         fprintf(stderr, "Session: Session suspended at '%s' timestamp [%lu].\n", GetTimeAsString(), GetTimeInMillis());
                                                                        ~~^                          ~~~~~~~~~~~~~~~~~
                                                                        %u
Reconnect.c: In function ‘nxagentReconnectSession’:
Reconnect.c:673:66: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘CARD32’ {aka ‘unsigned int’} [-Wformat=]
   fprintf(stderr, "Session: Session resumed at '%s' timestamp [%lu].\n", GetTimeAsString(), GetTimeInMillis());
                                                                ~~^                          ~~~~~~~~~~~~~~~~~
                                                                %u

As reported by static analyzer.

Attributes ArcticaProject/nx-libs#905

Use the "xorg_" prefix as everywhere else, not "Xorg_".

Also add original code to make NX changes obvious. Also change some
lines to match original code.

and use DEBUG like everywhere else. There were already some TEST lines
using this scheme.

Also indent DEBUG and TEST lines to make the code more readable

make compilation work with -DNX_DEBUG_INPUT

NX_WAKEUP had been non-effective and its effect had been tied to NX_TRANS_WAKEUP.

1. indent ifdefs
2. add some logic at start that unset NX_TRANS_WAKEUP and
NX_TRANS_DEBUG if NX_TRANS_SOCKET is unset. This way we only have to
check for one macro and not all three.
3. remove redundant macro checks
4. decouple debug printfs by always running the original code and adding the
   identical check in #ifdef NX_TRANS_DEBUG

and remove obsolete NX_SPLASH