You need to sign in or sign up before continuing.
sanitycheck.cgi 38.2 KB
Newer Older
1
#!/usr/bin/perl -wT
2
# -*- Mode: perl; indent-tabs-mode: nil -*-
3
#
4 5 6 7 8 9 10 11 12 13
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
14
# The Original Code is the Bugzilla Bug Tracking System.
15
#
16
# The Initial Developer of the Original Code is Netscape Communications
17 18 19 20
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
21
# Contributor(s): Terry Weissman <terry@mozilla.org>
22
#                 Matthew Tuck <matty@chariot.net.au>
23
#                 Max Kanat-Alexander <mkanat@bugzilla.org>
24
#                 Marc Schumann <wurblzap@gmail.com>
25
#                 Frédéric Buclin <LpSolit@gmail.com>
26

27
use strict;
28

29
use lib qw(. lib);
30

31
use Bugzilla;
32
use Bugzilla::Bug;
33
use Bugzilla::Constants;
34
use Bugzilla::Util;
35
use Bugzilla::Error;
36
use Bugzilla::Status;
37

38 39 40
###########################################################################
# General subs
###########################################################################
41

42 43 44 45
sub get_string {
    my ($san_tag, $vars) = @_;
    $vars->{'san_tag'} = $san_tag;
    return get_text('sanitycheck', $vars);
46 47
}

48 49
sub Status {
    my ($san_tag, $vars, $alert) = @_;
50 51 52 53 54 55 56 57 58 59 60 61 62
    my $cgi = Bugzilla->cgi;
    return if (!$alert && Bugzilla->usage_mode == USAGE_MODE_CMDLINE && !$cgi->param('verbose'));

    if (Bugzilla->usage_mode == USAGE_MODE_CMDLINE) {
        my $output = $cgi->param('output') || '';
        my $linebreak = $alert ? "\nALERT: " : "\n";
        $cgi->param('error_found', 1) if $alert;
        $cgi->param('output', $output . $linebreak . get_string($san_tag, $vars));
    }
    else {
        my $start_tag = $alert ? '<p class="alert">' : '<p>';
        print $start_tag . get_string($san_tag, $vars) . "</p>\n";
    }
63 64
}

65 66 67
###########################################################################
# Start
###########################################################################
68

69
my $user = Bugzilla->login(LOGIN_REQUIRED);
70

71
my $cgi = Bugzilla->cgi;
72
my $dbh = Bugzilla->dbh;
73 74 75 76 77 78 79 80 81
# If the result of the sanity check is sent per email, then we have to
# take the user prefs into account rather than querying the web browser.
my $template;
if (Bugzilla->usage_mode == USAGE_MODE_CMDLINE) {
    $template = Bugzilla->template_inner($user->settings->{'lang'}->{'value'});
}
else {
    $template = Bugzilla->template;
}
82 83
my $vars = {};

84
print $cgi->header() unless Bugzilla->usage_mode == USAGE_MODE_CMDLINE;
85

86 87 88
# Make sure the user is authorized to access sanitycheck.cgi.
# As this script can now alter the group_control_map table, we no longer
# let users with editbugs privs run it anymore.
89
$user->in_group("editcomponents")
90
  || ($user->in_group('editkeywords') && $cgi->param('rebuildkeywordcache'))
91
  || ThrowUserError("auth_failure", {group  => "editcomponents",
92 93
                                     action => "run",
                                     object => "sanity_check"});
94

95 96 97 98
unless (Bugzilla->usage_mode == USAGE_MODE_CMDLINE) {
    $template->process('admin/sanitycheck/list.html.tmpl', $vars)
      || ThrowTemplateError($template->error());
}
99

100 101 102 103 104
###########################################################################
# Users with 'editkeywords' privs only can only check keywords.
###########################################################################
unless ($user->in_group('editcomponents')) {
    check_votes_or_keywords('keywords');
105 106 107 108
    Status('checks_completed');

    $template->process('global/footer.html.tmpl', $vars)
        || ThrowTemplateError($template->error());
109 110 111
    exit;
}

112 113 114 115
###########################################################################
# Fix vote cache
###########################################################################

116 117
if ($cgi->param('rebuildvotecache')) {
    Status('vote_cache_rebuild_start');
118
    $dbh->bz_start_transaction();
119 120 121 122 123 124 125 126 127
    $dbh->do(q{UPDATE bugs SET votes = 0});
    my $sth_update = $dbh->prepare(q{UPDATE bugs 
                                        SET votes = ? 
                                      WHERE bug_id = ?});
    my $sth = $dbh->prepare(q{SELECT bug_id, SUM(vote_count)
                                FROM votes }. $dbh->sql_group_by('bug_id'));
    $sth->execute();
    while (my ($id, $v) = $sth->fetchrow_array) {
        $sth_update->execute($v, $id);
128
    }
129
    $dbh->bz_commit_transaction();
130
    Status('vote_cache_rebuild_end');
131 132
}

133 134 135 136
###########################################################################
# Create missing group_control_map entries
###########################################################################

137 138
if ($cgi->param('createmissinggroupcontrolmapentries')) {
    Status('group_control_map_entries_creation');
139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175

    my $na    = CONTROLMAPNA;
    my $shown = CONTROLMAPSHOWN;
    my $insertsth = $dbh->prepare(
        qq{INSERT INTO group_control_map (
                       group_id, product_id, entry,
                       membercontrol, othercontrol, canedit
                      )
               VALUES (
                       ?, ?, 0,
                       $shown, $na, 0
                      )});
    my $updatesth = $dbh->prepare(qq{UPDATE group_control_map
                                        SET membercontrol = $shown
                                      WHERE group_id   = ?
                                        AND product_id = ?});
    my $counter = 0;

    # Find all group/product combinations used for bugs but not set up
    # correctly in group_control_map
    my $invalid_combinations = $dbh->selectall_arrayref(
        qq{    SELECT bugs.product_id,
                      bgm.group_id,
                      gcm.membercontrol,
                      groups.name,
                      products.name
                 FROM bugs
           INNER JOIN bug_group_map AS bgm
                   ON bugs.bug_id = bgm.bug_id
           INNER JOIN groups
                   ON bgm.group_id = groups.id
           INNER JOIN products
                   ON bugs.product_id = products.id
            LEFT JOIN group_control_map AS gcm
                   ON bugs.product_id = gcm.product_id
                  AND    bgm.group_id = gcm.group_id
                WHERE COALESCE(gcm.membercontrol, $na) = $na
176 177
          } . $dbh->sql_group_by('bugs.product_id, bgm.group_id',
                                 'gcm.membercontrol, groups.name, products.name'));
178 179 180 181 182 183 184

    foreach (@$invalid_combinations) {
        my ($product_id, $group_id, $currentmembercontrol,
            $group_name, $product_name) = @$_;

        $counter++;
        if (defined($currentmembercontrol)) {
185 186
            Status('group_control_map_entries_update',
                   {group_name => $group_name, product_name => $product_name});
187 188 189
            $updatesth->execute($group_id, $product_id);
        }
        else {
190 191
            Status('group_control_map_entries_generation',
                   {group_name => $group_name, product_name => $product_name});
192 193 194 195
            $insertsth->execute($group_id, $product_id);
        }
    }

196
    Status('group_control_map_entries_repaired', {counter => $counter});
197 198
}

199 200 201 202
###########################################################################
# Fix missing creation date
###########################################################################

203 204
if ($cgi->param('repair_creation_date')) {
    Status('bug_creation_date_start');
205 206 207 208 209 210 211 212

    my $bug_ids = $dbh->selectcol_arrayref('SELECT bug_id FROM bugs
                                            WHERE creation_ts IS NULL');

    my $sth_UpdateDate = $dbh->prepare('UPDATE bugs SET creation_ts = ?
                                        WHERE bug_id = ?');

    # All bugs have an entry in the 'longdescs' table when they are created,
213
    # even if no comment is required.
214 215 216 217 218 219 220 221
    my $sth_getDate = $dbh->prepare('SELECT MIN(bug_when) FROM longdescs
                                     WHERE bug_id = ?');

    foreach my $bugid (@$bug_ids) {
        $sth_getDate->execute($bugid);
        my $date = $sth_getDate->fetchrow_array;
        $sth_UpdateDate->execute($date, $bugid);
    }
222
    Status('bug_creation_date_fixed', {bug_count => scalar(@$bug_ids)});
223 224
}

225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244
###########################################################################
# Fix entries in Bugs full_text
###########################################################################

if ($cgi->param('repair_bugs_fulltext')) {
    Status('bugs_fulltext_start');

    my $bug_ids = $dbh->selectcol_arrayref('SELECT bugs.bug_id
                                            FROM bugs
                                            LEFT JOIN bugs_fulltext
                                            ON bugs_fulltext.bug_id = bugs.bug_id
                                            WHERE bugs_fulltext.bug_id IS NULL');

   foreach my $bugid (@$bug_ids) {
       Bugzilla::Bug->new($bugid)->_sync_fulltext('new_bug');
   }

   Status('bugs_fulltext_fixed', {bug_count => scalar(@$bug_ids)});
}

245 246 247 248
###########################################################################
# Send unsent mail
###########################################################################

249
if ($cgi->param('rescanallBugMail')) {
250 251
    require Bugzilla::BugMail;

252
    Status('send_bugmail_start');
253
    my $time = $dbh->sql_interval(30, 'MINUTE');
254

255 256 257 258 259 260 261
    my $list = $dbh->selectcol_arrayref(qq{
                                        SELECT bug_id
                                          FROM bugs 
                                         WHERE (lastdiffed IS NULL
                                                OR lastdiffed < delta_ts)
                                           AND delta_ts < now() - $time
                                      ORDER BY bug_id});
262

263 264
    Status('send_bugmail_status', {bug_count => scalar(@$list)});

265 266 267 268 269 270 271 272 273
    # We cannot simply look at the bugs_activity table to find who did the
    # last change in a given bug, as e.g. adding a comment doesn't add any
    # entry to this table. And some other changes may be private
    # (such as time-related changes or private attachments or comments)
    # and so choosing this user as being the last one having done a change
    # for the bug may be problematic. So the best we can do at this point
    # is to choose the currently logged in user for email notification.
    $vars->{'changer'} = Bugzilla->user->login;

274
    foreach my $bugid (@$list) {
275
        Bugzilla::BugMail::Send($bugid, $vars);
276 277
    }

278
    Status('send_bugmail_end') if scalar(@$list);
279

280 281 282 283
    unless (Bugzilla->usage_mode == USAGE_MODE_CMDLINE) {
        $template->process('global/footer.html.tmpl', $vars)
          || ThrowTemplateError($template->error());
    }
284 285 286
    exit;
}

287 288 289 290
###########################################################################
# Remove all references to deleted bugs
###########################################################################

291 292
if ($cgi->param('remove_invalid_bug_references')) {
    Status('bug_reference_deletion_start');
293

294
    $dbh->bz_start_transaction();
295

296 297
    foreach my $pair ('attachments/', 'bug_group_map/', 'bugs_activity/',
                      'bugs_fulltext/', 'cc/',
298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314
                      'dependencies/blocked', 'dependencies/dependson',
                      'duplicates/dupe', 'duplicates/dupe_of',
                      'flags/', 'keywords/', 'longdescs/', 'votes/') {

        my ($table, $field) = split('/', $pair);
        $field ||= "bug_id";

        my $bug_ids =
          $dbh->selectcol_arrayref("SELECT $table.$field FROM $table
                                    LEFT JOIN bugs ON $table.$field = bugs.bug_id
                                    WHERE bugs.bug_id IS NULL");

        if (scalar(@$bug_ids)) {
            $dbh->do("DELETE FROM $table WHERE $field IN (" . join(',', @$bug_ids) . ")");
        }
    }

315
    $dbh->bz_commit_transaction();
316
    Status('bug_reference_deletion_end');
317 318
}

319 320 321 322
###########################################################################
# Remove all references to deleted attachments
###########################################################################

323 324
if ($cgi->param('remove_invalid_attach_references')) {
    Status('attachment_reference_deletion_start');
325

326
    $dbh->bz_start_transaction();
327 328 329 330 331 332 333 334 335 336 337 338 339

    my $attach_ids =
        $dbh->selectcol_arrayref('SELECT attach_data.id
                                    FROM attach_data
                               LEFT JOIN attachments
                                      ON attachments.attach_id = attach_data.id
                                   WHERE attachments.attach_id IS NULL');

    if (scalar(@$attach_ids)) {
        $dbh->do('DELETE FROM attach_data WHERE id IN (' .
                 join(',', @$attach_ids) . ')');
    }

340
    $dbh->bz_commit_transaction();
341
    Status('attachment_reference_deletion_end');
342
}
343

344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373
###########################################################################
# Remove all references to deleted users or groups from whines
###########################################################################

if ($cgi->param('remove_old_whine_targets')) {
    Status('whines_obsolete_target_deletion_start');

    $dbh->bz_start_transaction();

    foreach my $target (['groups', 'id', MAILTO_GROUP],
                        ['profiles', 'userid', MAILTO_USER])
    {
        my ($table, $col, $type) = @$target;
        my $old_ids =
          $dbh->selectcol_arrayref("SELECT DISTINCT mailto
                                      FROM whine_schedules
                                 LEFT JOIN $table
                                        ON $table.$col = whine_schedules.mailto
                                     WHERE mailto_type = $type AND $table.$col IS NULL");

        if (scalar(@$old_ids)) {
            $dbh->do("DELETE FROM whine_schedules
                       WHERE mailto_type = $type AND mailto IN (" .
                       join(',', @$old_ids) . ")");
        }
    }
    $dbh->bz_commit_transaction();
    Status('whines_obsolete_target_deletion_end');
}

374
Status('checks_start');
375

376 377 378 379
###########################################################################
# Perform referential (cross) checks
###########################################################################

380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395
# This checks that a simple foreign key has a valid primary key value.  NULL
# references are acceptable and cause no problem.
#
# The first parameter is the primary key table name.
# The second parameter is the primary key field name.
# Each successive parameter represents a foreign key, it must be a list
# reference, where the list has:
#   the first value is the foreign key table name.
#   the second value is the foreign key field name.
#   the third value is optional and represents a field on the foreign key
#     table to display when the check fails.
#   the fourth value is optional and is a list reference to values that
#     are excluded from checking.
#
# FIXME: The excluded values parameter should go away - the QA contact
#        fields should use NULL instead - see bug #109474.
396
#        The same goes for series; no bug for that yet.
397

398 399 400
sub CrossCheck {
    my $table = shift @_;
    my $field = shift @_;
401
    my $dbh = Bugzilla->dbh;
402

403
    Status('cross_check_to', {table => $table, field => $field});
404 405 406 407 408 409 410 411

    while (@_) {
        my $ref = shift @_;
        my ($refertable, $referfield, $keyname, $exceptions) = @$ref;

        $exceptions ||= [];
        my %exceptions = map { $_ => 1 } @$exceptions;

412 413
        Status('cross_check_from', {table => $refertable, field => $referfield});

414 415 416 417 418 419 420
        my $query = qq{SELECT DISTINCT $refertable.$referfield} .
            ($keyname ? qq{, $refertable.$keyname } : q{}) .
                     qq{ FROM $refertable
                    LEFT JOIN $table
                           ON $refertable.$referfield = $table.$field
                        WHERE $table.$field IS NULL
                          AND $refertable.$referfield IS NOT NULL};
421

422 423
        my $sth = $dbh->prepare($query);
        $sth->execute;
424

425
        my $has_bad_references = 0;
426 427 428

        while (my ($value, $key) = $sth->fetchrow_array) {
            next if $exceptions{$value};
429 430 431
            Status('cross_check_alert', {value => $value, table => $refertable,
                                         field => $referfield, keyname => $keyname,
                                         key => $key}, 'alert');
432
            $has_bad_references = 1;
433
        }
434 435
        # References to non existent bugs can be safely removed, bug 288461
        if ($table eq 'bugs' && $has_bad_references) {
436
            Status('cross_check_bug_has_references');
437 438 439
        }
        # References to non existent attachments can be safely removed.
        if ($table eq 'attachments' && $has_bad_references) {
440
            Status('cross_check_attachment_has_references');
441
        }
442 443 444
    }
}

445 446 447
CrossCheck('classifications', 'id',
           ['products', 'classification_id']);

448 449 450
CrossCheck("keyworddefs", "id",
           ["keywords", "keywordid"]);

451
CrossCheck("fielddefs", "id",
452 453
           ["bugs_activity", "fieldid"],
           ['profiles_activity', 'fieldid']);
454

455
CrossCheck("flagtypes", "id",
456 457 458
           ["flags", "type_id"],
           ["flagexclusions", "type_id"],
           ["flaginclusions", "type_id"]);
459 460 461

CrossCheck("bugs", "bug_id",
           ["bugs_activity", "bug_id"],
462
           ["bug_group_map", "bug_id"],
463
           ["bugs_fulltext", "bug_id"],
464 465 466 467 468
           ["attachments", "bug_id"],
           ["cc", "bug_id"],
           ["longdescs", "bug_id"],
           ["dependencies", "blocked"],
           ["dependencies", "dependson"],
469
           ['flags', 'bug_id'],
470
           ["votes", "bug_id"],
471 472 473
           ["keywords", "bug_id"],
           ["duplicates", "dupe_of", "dupe"],
           ["duplicates", "dupe", "dupe_of"]);
474

475 476
CrossCheck("groups", "id",
           ["bug_group_map", "group_id"],
477
           ['category_group_map', 'group_id'],
478 479
           ["group_group_map", "grantor_id"],
           ["group_group_map", "member_id"],
480
           ["group_control_map", "group_id"],
481
           ["namedquery_group_map", "group_id"],
482 483 484
           ["user_group_map", "group_id"],
           ["flagtypes", "grant_group_id"],
           ["flagtypes", "request_group_id"]);
485

486 487 488 489 490
CrossCheck("namedqueries", "id",
           ["namedqueries_link_in_footer", "namedquery_id"],
           ["namedquery_group_map", "namedquery_id"],
          );

491
CrossCheck("profiles", "userid",
492 493
           ['profiles_activity', 'userid'],
           ['profiles_activity', 'who'],
494 495
           ['email_setting', 'user_id'],
           ['profile_setting', 'user_id'],
496 497
           ["bugs", "reporter", "bug_id"],
           ["bugs", "assigned_to", "bug_id"],
498
           ["bugs", "qa_contact", "bug_id"],
499
           ["attachments", "submitter_id", "bug_id"],
500 501
           ['flags', 'setter_id', 'bug_id'],
           ['flags', 'requestee_id', 'bug_id'],
502 503
           ["bugs_activity", "who", "bug_id"],
           ["cc", "who", "bug_id"],
504
           ['quips', 'userid'],
505 506
           ["votes", "who", "bug_id"],
           ["longdescs", "who", "bug_id"],
507
           ["logincookies", "userid"],
508
           ["namedqueries", "userid"],
509
           ["namedqueries_link_in_footer", "user_id"],
510
           ['series', 'creator', 'series_id'],
511 512
           ["watch", "watcher"],
           ["watch", "watched"],
513
           ['whine_events', 'owner_userid'],
514
           ["tokens", "userid"],
515
           ["user_group_map", "user_id"],
516
           ["components", "initialowner", "name"],
517 518
           ["components", "initialqacontact", "name"],
           ["component_cc", "user_id"]);
519

520 521 522 523 524
CrossCheck("products", "id",
           ["bugs", "product_id", "bug_id"],
           ["components", "product_id", "name"],
           ["milestones", "product_id", "value"],
           ["versions", "product_id", "value"],
525
           ["group_control_map", "product_id"],
526 527
           ["flaginclusions", "product_id", "type_id"],
           ["flagexclusions", "product_id", "type_id"]);
528

529
CrossCheck("components", "id",
530 531 532
           ["component_cc", "component_id"],
           ["flagexclusions", "component_id", "type_id"],
           ["flaginclusions", "component_id", "type_id"]);
533

534
# Check the former enum types -mkanat@bugzilla.org
535
CrossCheck("bug_status", "value",
536
            ["bugs", "bug_status", "bug_id"]);
537 538

CrossCheck("resolution", "value",
539
            ["bugs", "resolution", "bug_id"]);
540 541

CrossCheck("bug_severity", "value",
542
            ["bugs", "bug_severity", "bug_id"]);
543 544

CrossCheck("op_sys", "value",
545
            ["bugs", "op_sys", "bug_id"]);
546 547

CrossCheck("priority", "value",
548
            ["bugs", "priority", "bug_id"]);
549 550

CrossCheck("rep_platform", "value",
551
            ["bugs", "rep_platform", "bug_id"]);
552

553 554 555 556
CrossCheck('series', 'series_id',
           ['series_data', 'series_id']);

CrossCheck('series_categories', 'id',
557 558 559
           ['series', 'category'],
           ["category_group_map", "category_id"],
           ["series", "subcategory"]);
560 561 562 563 564

CrossCheck('whine_events', 'id',
           ['whine_queries', 'eventid'],
           ['whine_schedules', 'eventid']);

565
CrossCheck('attachments', 'attach_id',
566 567
           ['attach_data', 'id'],
           ['bugs_activity', 'attach_id']);
568

569 570 571 572
CrossCheck('bug_status', 'id',
           ['status_workflow', 'old_status'],
           ['status_workflow', 'new_status']);

573
###########################################################################
574
# Perform double field referential (cross) checks
575
###########################################################################
576
 
577 578 579 580 581 582 583 584 585 586 587 588 589 590
# This checks that a compound two-field foreign key has a valid primary key
# value.  NULL references are acceptable and cause no problem.
#
# The first parameter is the primary key table name.
# The second parameter is the primary key first field name.
# The third parameter is the primary key second field name.
# Each successive parameter represents a foreign key, it must be a list
# reference, where the list has:
#   the first value is the foreign key table name
#   the second value is the foreign key first field name.
#   the third value is the foreign key second field name.
#   the fourth value is optional and represents a field on the foreign key
#     table to display when the check fails

591 592 593 594
sub DoubleCrossCheck {
    my $table = shift @_;
    my $field1 = shift @_;
    my $field2 = shift @_;
595
    my $dbh = Bugzilla->dbh;
596 597 598 599

    Status('double_cross_check_to',
           {table => $table, field1 => $field1, field2 => $field2});

600 601 602
    while (@_) {
        my $ref = shift @_;
        my ($refertable, $referfield1, $referfield2, $keyname) = @$ref;
603 604 605

        Status('double_cross_check_from',
               {table => $refertable, field1 => $referfield1, field2 =>$referfield2});
606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621

        my $d_cross_check = $dbh->selectall_arrayref(qq{
                        SELECT DISTINCT $refertable.$referfield1, 
                                        $refertable.$referfield2 } .
                       ($keyname ? qq{, $refertable.$keyname } : q{}) .
                      qq{ FROM $refertable
                     LEFT JOIN $table
                            ON $refertable.$referfield1 = $table.$field1
                           AND $refertable.$referfield2 = $table.$field2 
                         WHERE $table.$field1 IS NULL 
                           AND $table.$field2 IS NULL 
                           AND $refertable.$referfield1 IS NOT NULL 
                           AND $refertable.$referfield2 IS NOT NULL});

        foreach my $check (@$d_cross_check) {
            my ($value1, $value2, $key) = @$check;
622 623 624 625 626
            Status('double_cross_check_alert',
                   {value1 => $value1, value2 => $value2,
                    table => $refertable,
                    field1 => $referfield1, field2 => $referfield2,
                    keyname => $keyname, key => $key}, 'alert');
627
        }
628 629 630
    }
}

631 632 633 634
DoubleCrossCheck('attachments', 'bug_id', 'attach_id',
                 ['flags', 'bug_id', 'attach_id'],
                 ['bugs_activity', 'bug_id', 'attach_id']);

635
DoubleCrossCheck("components", "product_id", "id",
636 637 638
                 ["bugs", "product_id", "component_id", "bug_id"],
                 ['flagexclusions', 'product_id', 'component_id'],
                 ['flaginclusions', 'product_id', 'component_id']);
639

640 641 642 643 644 645
DoubleCrossCheck("versions", "product_id", "value",
                 ["bugs", "product_id", "version", "bug_id"]);
 
DoubleCrossCheck("milestones", "product_id", "value",
                 ["bugs", "product_id", "target_milestone", "bug_id"],
                 ["products", "id", "defaultmilestone", "name"]);
646

647 648 649
###########################################################################
# Perform login checks
###########################################################################
650 651

Status('profile_login_start');
652

653 654
my $sth = $dbh->prepare(q{SELECT userid, login_name FROM profiles});
$sth->execute;
655

656
while (my ($id, $email) = $sth->fetchrow_array) {
657
    validate_email_syntax($email)
658
      || Status('profile_login_alert', {id => $id, email => $email}, 'alert');
659
}
660

661 662 663
###########################################################################
# Perform vote/keyword cache checks
###########################################################################
664

665
check_votes_or_keywords();
666

667 668
sub check_votes_or_keywords {
    my $check = shift || 'all';
669

670 671 672 673 674
    my $dbh = Bugzilla->dbh;
    my $sth = $dbh->prepare(q{SELECT bug_id, votes, keywords
                                FROM bugs
                               WHERE votes != 0 OR keywords != ''});
    $sth->execute;
675

676 677
    my %votes;
    my %keyword;
678

679 680 681 682 683 684
    while (my ($id, $v, $k) = $sth->fetchrow_array) {
        if ($v != 0) {
            $votes{$id} = $v;
        }
        if ($k) {
            $keyword{$id} = $k;
685 686
        }
    }
687

688 689 690 691
    # If we only want to check keywords, skip checks about votes.
    _check_votes(\%votes) unless ($check eq 'keywords');
    # If we only want to check votes, skip checks about keywords.
    _check_keywords(\%keyword) unless ($check eq 'votes');
692 693
}

694 695
sub _check_votes {
    my $votes = shift;
696

697
    Status('vote_count_start');
698 699 700 701 702
    my $dbh = Bugzilla->dbh;
    my $sth = $dbh->prepare(q{SELECT bug_id, SUM(vote_count)
                                FROM votes }.
                                $dbh->sql_group_by('bug_id'));
    $sth->execute;
703

704
    my $offer_votecache_rebuild = 0;
705

706 707
    while (my ($id, $v) = $sth->fetchrow_array) {
        if ($v <= 0) {
708
            Status('vote_count_alert', {id => $id}, 'alert');
709 710
        } else {
            if (!defined $votes->{$id} || $votes->{$id} != $v) {
711
                Status('vote_cache_alert', {id => $id}, 'alert');
712 713 714 715
                $offer_votecache_rebuild = 1;
            }
            delete $votes->{$id};
        }
716
    }
717
    foreach my $id (keys %$votes) {
718
        Status('vote_cache_alert', {id => $id}, 'alert');
719
        $offer_votecache_rebuild = 1;
720 721
    }

722
    Status('vote_cache_rebuild_fix') if $offer_votecache_rebuild;
723 724
}

725 726
sub _check_keywords {
    my $keyword = shift;
727

728
    Status('keyword_check_start');
729 730
    my $dbh = Bugzilla->dbh;
    my $cgi = Bugzilla->cgi;
731

732 733 734
    my %keywordids;
    my $keywords = $dbh->selectall_arrayref(q{SELECT id, name
                                                FROM keyworddefs});
735

736 737 738
    foreach (@$keywords) {
        my ($id, $name) = @$_;
        if ($keywordids{$id}) {
739
            Status('keyword_check_alert', {id => $id}, 'alert');
740 741 742
        }
        $keywordids{$id} = 1;
        if ($name =~ /[\s,]/) {
743
            Status('keyword_check_invalid_name', {id => $id}, 'alert');
744 745
        }
    }
746

747 748 749 750 751 752 753 754
    my $sth = $dbh->prepare(q{SELECT bug_id, keywordid
                                FROM keywords
                            ORDER BY bug_id, keywordid});
    $sth->execute;
    my $lastid;
    my $lastk;
    while (my ($id, $k) = $sth->fetchrow_array) {
        if (!$keywordids{$k}) {
755
            Status('keyword_check_invalid_id', {id => $k}, 'alert');
756
        }
757
        if (defined $lastid && $id eq $lastid && $k eq $lastk) {
758
            Status('keyword_check_duplicated_ids', {id => $id}, 'alert');
759
        }
760 761
        $lastid = $id;
        $lastk = $k;
762 763
    }

764
    Status('keyword_cache_start');
765

766
    if ($cgi->param('rebuildkeywordcache')) {
767
        $dbh->bz_start_transaction();
768
    }
769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795

    my $query = q{SELECT keywords.bug_id, keyworddefs.name
                    FROM keywords
              INNER JOIN keyworddefs
                      ON keyworddefs.id = keywords.keywordid
              INNER JOIN bugs
                      ON keywords.bug_id = bugs.bug_id
                ORDER BY keywords.bug_id, keyworddefs.name};

    $sth = $dbh->prepare($query);
    $sth->execute;

    my $lastb = 0;
    my @list;
    my %realk;
    while (1) {
        my ($b, $k) = $sth->fetchrow_array;
        if (!defined $b || $b != $lastb) {
            if (@list) {
                $realk{$lastb} = join(', ', @list);
            }
            last unless $b;

            $lastb = $b;
            @list = ();
        }
        push(@list, $k);
796
    }
797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812

    my @badbugs = ();

    foreach my $b (keys(%$keyword)) {
        if (!exists $realk{$b} || $realk{$b} ne $keyword->{$b}) {
            push(@badbugs, $b);
        }
    }
    foreach my $b (keys(%realk)) {
        if (!exists $keyword->{$b}) {
            push(@badbugs, $b);
        }
    }
    if (@badbugs) {
        @badbugs = sort {$a <=> $b} @badbugs;

813 814 815 816
        if ($cgi->param('rebuildkeywordcache')) {
            my $sth_update = $dbh->prepare(q{UPDATE bugs
                                                SET keywords = ?
                                              WHERE bug_id = ?});
817

818
            Status('keyword_cache_fixing');
819 820 821 822 823 824
            foreach my $b (@badbugs) {
                my $k = '';
                if (exists($realk{$b})) {
                    $k = $realk{$b};
                }
                $sth_update->execute($k, $b);
825
            }
826
            Status('keyword_cache_fixed');
827
        } else {
828 829
            Status('keyword_cache_alert', {badbugs => \@badbugs}, 'alert');
            Status('keyword_cache_rebuild');
830 831 832
        }
    }

833
    if ($cgi->param('rebuildkeywordcache')) {
834
        $dbh->bz_commit_transaction();
835
    }
836
}
837

838 839 840 841
###########################################################################
# Check for flags being in incorrect products and components
###########################################################################

842
Status('flag_check_start');
843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870

my $invalid_flags = $dbh->selectall_arrayref(
       'SELECT DISTINCT flags.id, flags.bug_id, flags.attach_id
          FROM flags
    INNER JOIN bugs
            ON flags.bug_id = bugs.bug_id
     LEFT JOIN flaginclusions AS i
            ON flags.type_id = i.type_id
           AND (bugs.product_id = i.product_id OR i.product_id IS NULL)
           AND (bugs.component_id = i.component_id OR i.component_id IS NULL)
         WHERE i.type_id IS NULL');

my @invalid_flags = @$invalid_flags;

$invalid_flags = $dbh->selectall_arrayref(
       'SELECT DISTINCT flags.id, flags.bug_id, flags.attach_id
          FROM flags
    INNER JOIN bugs
            ON flags.bug_id = bugs.bug_id
    INNER JOIN flagexclusions AS e
            ON flags.type_id = e.type_id
         WHERE (bugs.product_id = e.product_id OR e.product_id IS NULL)
           AND (bugs.component_id = e.component_id OR e.component_id IS NULL)');

push(@invalid_flags, @$invalid_flags);

if (scalar(@invalid_flags)) {
    if ($cgi->param('remove_invalid_flags')) {
871
        Status('flag_deletion_start');
872 873 874
        my @flag_ids = map {$_->[0]} @invalid_flags;
        # Silently delete these flags, with no notification to requesters/setters.
        $dbh->do('DELETE FROM flags WHERE id IN (' . join(',', @flag_ids) .')');
875
        Status('flag_deletion_end');
876 877 878 879
    }
    else {
        foreach my $flag (@$invalid_flags) {
            my ($flag_id, $bug_id, $attach_id) = @$flag;
880 881 882
            Status('flag_alert',
                   {flag_id => $flag_id, attach_id => $attach_id, bug_id => $bug_id},
                   'alert');
883
        }
884
        Status('flag_fix');
885 886 887
    }
}

888
###########################################################################
889
# General bug checks
890 891
###########################################################################

892
sub BugCheck {
893
    my ($middlesql, $errortext, $repairparam, $repairtext) = @_;
894
    my $dbh = Bugzilla->dbh;
895 896 897 898
 
    my $badbugs = $dbh->selectcol_arrayref(qq{SELECT DISTINCT bugs.bug_id
                                                FROM $middlesql 
                                            ORDER BY bugs.bug_id});
899

900
    if (scalar(@$badbugs)) {
901 902 903 904
        Status('bug_check_alert',
               {errortext => get_string($errortext), badbugs => $badbugs},
               'alert');

905
        if ($repairparam) {
906 907 908
            $repairtext ||= 'repair_bugs';
            Status('bug_check_repair',
                   {param => $repairparam, text => get_string($repairtext)});
909
        }
910
    }
911 912
}

913
Status('bug_check_creation_date');
914

915 916
BugCheck("bugs WHERE creation_ts IS NULL", 'bug_check_creation_date_error_text',
         'repair_creation_date', 'bug_check_creation_date_repair_text');
917

918 919 920 921 922 923
Status('bug_check_bugs_fulltext');

BugCheck("bugs LEFT JOIN bugs_fulltext ON bugs_fulltext.bug_id = bugs.bug_id " .
         "WHERE bugs_fulltext.bug_id IS NULL", 'bug_check_bugs_fulltext_error_text',
         'repair_bugs_fulltext', 'bug_check_bugs_fulltext_repair_text');

924
Status('bug_check_res_dupl');
925

926
BugCheck("bugs INNER JOIN duplicates ON bugs.bug_id = duplicates.dupe " .
927
         "WHERE bugs.resolution != 'DUPLICATE'", 'bug_check_res_dupl_error_text');
928

929 930
BugCheck("bugs LEFT JOIN duplicates ON bugs.bug_id = duplicates.dupe WHERE " .
         "bugs.resolution = 'DUPLICATE' AND " .
931
         "duplicates.dupe IS NULL", 'bug_check_res_dupl_error_text2');
932

933
Status('bug_check_status_res');
934

935
my @open_states = map($dbh->quote($_), BUG_STATE_OPEN);
936 937
my $open_states = join(', ', @open_states);

938
BugCheck("bugs WHERE bug_status IN ($open_states) AND resolution != ''",
939
         'bug_check_status_res_error_text');
940
BugCheck("bugs WHERE bug_status NOT IN ($open_states) AND resolution = ''",
941
         'bug_check_status_res_error_text2');
942

943
Status('bug_check_status_everconfirmed');
944

945
BugCheck("bugs WHERE bug_status = 'UNCONFIRMED' AND everconfirmed = 1",
946
         'bug_check_status_everconfirmed_error_text');
947 948 949 950 951

my @confirmed_open_states = grep {$_ ne 'UNCONFIRMED'} BUG_STATE_OPEN;
my $confirmed_open_states = join(', ', map {$dbh->quote($_)} @confirmed_open_states);

BugCheck("bugs WHERE bug_status IN ($confirmed_open_states) AND everconfirmed = 0",
952
         'bug_check_status_everconfirmed_error_text2');
953

954
Status('bug_check_votes_everconfirmed');
955

956 957
BugCheck("bugs INNER JOIN products ON bugs.product_id = products.id " .
         "WHERE everconfirmed = 0 AND votestoconfirm <= votes",
958
         'bug_check_votes_everconfirmed_error_text');
959

960 961 962 963 964 965
###########################################################################
# Control Values
###########################################################################

# Checks for values that are invalid OR
# not among the 9 valid combinations
966
Status('bug_check_control_values');
967 968
my $groups = join(", ", (CONTROLMAPNA, CONTROLMAPSHOWN, CONTROLMAPDEFAULT,
CONTROLMAPMANDATORY));
969
my $query = qq{
970 971 972 973 974 975 976 977
     SELECT COUNT(product_id) 
       FROM group_control_map 
      WHERE membercontrol NOT IN( $groups )
         OR othercontrol NOT IN( $groups )
         OR ((membercontrol != othercontrol)
             AND (membercontrol != } . CONTROLMAPSHOWN . q{)
             AND ((membercontrol != } . CONTROLMAPDEFAULT . q{)
                  OR (othercontrol = } . CONTROLMAPSHOWN . q{)))};
978

979 980 981 982
my $entries = $dbh->selectrow_array($query);
Status('bug_check_control_values_alert', {entries => $entries}, 'alert') if $entries;

Status('bug_check_control_values_violation');
983
BugCheck("bugs
984 985 986 987
         INNER JOIN bug_group_map
            ON bugs.bug_id = bug_group_map.bug_id
          LEFT JOIN group_control_map
            ON bugs.product_id = group_control_map.product_id
988
           AND bug_group_map.group_id = group_control_map.group_id
989
         WHERE ((group_control_map.membercontrol = " . CONTROLMAPNA . ")
990
         OR (group_control_map.membercontrol IS NULL))",
991
         'bug_check_control_values_error_text',
992
         'createmissinggroupcontrolmapentries',
993
         'bug_check_control_values_repair_text');
994

995
BugCheck("bugs
996
         INNER JOIN group_control_map
997
            ON bugs.product_id = group_control_map.product_id
998 999 1000 1001 1002
         INNER JOIN groups
            ON group_control_map.group_id = groups.id
          LEFT JOIN bug_group_map
            ON bugs.bug_id = bug_group_map.bug_id
           AND group_control_map.group_id = bug_group_map.group_id
1003
         WHERE group_control_map.membercontrol = " . CONTROLMAPMANDATORY . "
1004 1005
           AND bug_group_map.group_id IS NULL
           AND groups.isactive != 0",
1006
         'bug_check_control_values_error_text2');
1007

1008 1009 1010 1011
###########################################################################
# Unsent mail
###########################################################################

1012
Status('unsent_bugmail_check');
1013

1014 1015 1016 1017 1018 1019 1020
my $time = $dbh->sql_interval(30, 'MINUTE');
my $badbugs = $dbh->selectcol_arrayref(qq{
                    SELECT bug_id 
                      FROM bugs 
                     WHERE (lastdiffed IS NULL OR lastdiffed < delta_ts)
                       AND delta_ts < now() - $time
                  ORDER BY bug_id});
1021 1022


1023
if (scalar(@$badbugs > 0)) {
1024 1025
    Status('unsent_bugmail_alert', {badbugs => $badbugs}, 'alert');
    Status('unsent_bugmail_fix');
1026 1027
}

1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051
###########################################################################
# Whines
###########################################################################

Status('whines_obsolete_target_start');

my $display_repair_whines_link = 0;
foreach my $target (['groups', 'id', MAILTO_GROUP],
                    ['profiles', 'userid', MAILTO_USER])
{
    my ($table, $col, $type) = @$target;
    my $old = $dbh->selectall_arrayref("SELECT whine_schedules.id, mailto
                                          FROM whine_schedules
                                     LEFT JOIN $table
                                            ON $table.$col = whine_schedules.mailto
                                         WHERE mailto_type = $type AND $table.$col IS NULL");

    if (scalar(@$old)) {
        Status('whines_obsolete_target_alert', {schedules => $old, type => $type}, 'alert');
        $display_repair_whines_link = 1;
    }
}
Status('whines_obsolete_target_fix') if $display_repair_whines_link;

1052 1053 1054
###########################################################################
# End
###########################################################################
1055

1056 1057
Status('checks_completed');

1058 1059 1060 1061
unless (Bugzilla->usage_mode == USAGE_MODE_CMDLINE) {
    $template->process('global/footer.html.tmpl', $vars)
      || ThrowTemplateError($template->error());
}