process_bug.cgi 82.4 KB
Newer Older
1
#!/usr/bin/perl -wT
2
# -*- Mode: perl; indent-tabs-mode: nil -*-
terry%netscape.com's avatar
terry%netscape.com committed
3
#
4 5 6 7 8 9 10 11 12 13
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
terry%netscape.com's avatar
terry%netscape.com committed
14
# The Original Code is the Bugzilla Bug Tracking System.
15
#
terry%netscape.com's avatar
terry%netscape.com committed
16
# The Initial Developer of the Original Code is Netscape Communications
17 18 19 20
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
terry%netscape.com's avatar
terry%netscape.com committed
21
# Contributor(s): Terry Weissman <terry@mozilla.org>
22
#                 Dan Mosedale <dmose@mozilla.org>
23
#                 Dave Miller <justdave@syndicomm.com>
24
#                 Christopher Aillon <christopher@aillon.com>
25
#                 Myk Melez <myk@mozilla.org>
26
#                 Jeff Hedlund <jeff.hedlund@matrixsi.com>
27
#                 Frédéric Buclin <LpSolit@gmail.com>
28
#                 Lance Larsh <lance.larsh@oracle.com>
terry%netscape.com's avatar
terry%netscape.com committed
29

30 31 32 33 34 35 36 37 38 39 40 41
# Implementation notes for this file:
#
# 1) the 'id' form parameter is validated early on, and if it is not a valid
# bugid an error will be reported, so it is OK for later code to simply check
# for a defined form 'id' value, and it can assume a valid bugid.
#
# 2) If the 'id' form parameter is not defined (after the initial validation),
# then we are processing multiple bugs, and @idlist will contain the ids.
#
# 3) If we are processing just the one id, then it is stored in @idlist for
# later processing.

42 43
use strict;

44 45
use lib qw(.);

46
use Bugzilla;
47
use Bugzilla::Constants;
48
use Bugzilla::Bug;
49
use Bugzilla::Mailer;
50
use Bugzilla::User;
51
use Bugzilla::Util;
52
use Bugzilla::Error;
53
use Bugzilla::Field;
54
use Bugzilla::Product;
55
use Bugzilla::Component;
56
use Bugzilla::Keyword;
57 58
use Bugzilla::Flag;

59
my $user = Bugzilla->login(LOGIN_REQUIRED);
60
local our $whoid = $user->id;
61
my $grouplist = $user->groups_as_string;
62

63
my $cgi = Bugzilla->cgi;
64
my $dbh = Bugzilla->dbh;
65
my $template = Bugzilla->template;
66
local our $vars = {};
67
$vars->{'use_keywords'} = 1 if Bugzilla::Keyword::keyword_count();
68

69 70
my @editable_bug_fields = editable_bug_fields();

71
my $requiremilestone = 0;
72
my $PrivilegesRequired = 0;
73

74 75 76 77 78 79 80 81 82 83 84 85 86 87 88
######################################################################
# Subroutines
######################################################################

sub BugInGroupId {
    my ($bug_id, $group_id) = @_;
    detaint_natural($bug_id);
    detaint_natural($group_id);
    my ($in_group) = Bugzilla->dbh->selectrow_array(
        "SELECT CASE WHEN bug_id != 0 THEN 1 ELSE 0 END
           FROM bug_group_map
          WHERE bug_id = ? AND group_id = ?", undef, ($bug_id, $group_id));
    return $in_group;
}

89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105
# This function checks if there are any default groups defined.
# If so, then groups may have to be changed when bugs move from
# one bug to another.
sub AnyDefaultGroups {
    my $dbh = Bugzilla->dbh;
    my $any_default =
        $dbh->selectrow_array('SELECT 1
                                 FROM group_control_map
                           INNER JOIN groups
                                   ON groups.id = group_control_map.group_id
                                WHERE isactive != 0
                                  AND (membercontrol = ? OR othercontrol = ?) ' .
                                 $dbh->sql_limit(1),
                                 undef, (CONTROLMAPDEFAULT, CONTROLMAPDEFAULT));
    return $any_default;
}

106 107 108 109 110 111 112 113
######################################################################
# Begin Data/Security Validation
######################################################################

# Create a list of IDs of all bugs being modified in this request.
# This list will either consist of a single bug number from the "id"
# form/URL field or a series of numbers from multiple form/URL fields
# named "id_x" where "x" is the bug number.
114 115
# For each bug being modified, make sure its ID is a valid bug number 
# representing an existing bug that the user is authorized to access.
116
my @idlist;
117 118 119 120 121 122 123 124
if (defined $cgi->param('id')) {
  my $id = $cgi->param('id');
  ValidateBugID($id);

  # Store the validated, and detainted id back in the cgi data, as
  # lots of later code will need it, and will obtain it from there
  $cgi->param('id', $id);
  push @idlist, $id;
125
} else {
126
    foreach my $i ($cgi->param()) {
127
        if ($i =~ /^id_([1-9][0-9]*)/) {
128 129 130
            my $id = $1;
            ValidateBugID($id);
            push @idlist, $id;
131
        }
132 133 134
    }
}

135
# Make sure there are bugs to process.
136
scalar(@idlist) || ThrowUserError("no_bugs_chosen");
137

138 139 140
# Build a bug object using $cgi->param('id') as ID.
# If there are more than one bug changed at once, the bug object will be
# empty, which doesn't matter.
141
my $bug = new Bugzilla::Bug(scalar $cgi->param('id'));
142

143 144
# Make sure form param 'dontchange' is defined so it can be compared to easily.
$cgi->param('dontchange','') unless defined $cgi->param('dontchange');
145

146 147 148
# Make sure the 'knob' param is defined; else set it to 'none'.
$cgi->param('knob', 'none') unless defined $cgi->param('knob');

149 150
# Validate all timetracking fields
foreach my $field ("estimated_time", "work_time", "remaining_time") {
151 152 153
    if (defined $cgi->param($field)) {
        my $er_time = trim($cgi->param($field));
        if ($er_time ne $cgi->param('dontchange')) {
154 155 156 157 158
            Bugzilla::Bug::ValidateTime($er_time, $field);
        }
    }
}

159
if (UserInGroup(Bugzilla->params->{'timetrackinggroup'})) {
160 161
    my $wk_time = $cgi->param('work_time');
    if ($cgi->param('comment') =~ /^\s*$/ && $wk_time && $wk_time != 0) {
162
        ThrowUserError('comment_required');
163
    }
164 165
}

166
ValidateComment(scalar $cgi->param('comment'));
167

168 169 170 171 172 173 174
# If the bug(s) being modified have dependencies, validate them
# and rebuild the list with the validated values.  This is important
# because there are situations where validation changes the value
# instead of throwing an error, f.e. when one or more of the values
# is a bug alias that gets converted to its corresponding bug ID
# during validation.
foreach my $field ("dependson", "blocked") {
175 176 177
    if ($cgi->param('id')) {
        my @old = @{$bug->$field};
        my @new;
178
        foreach my $id (split(/[\s,]+/, $cgi->param($field))) {
179
            next unless $id;
180
            ValidateBugID($id, $field);
181
            push @new, $id;
182
        }
183 184 185 186 187 188
        $cgi->param($field, join(",", @new));
        my ($added, $removed) = Bugzilla::Util::diff_arrays(\@old, \@new);
        foreach my $id (@$added , @$removed) {
            # ValidateBugID is called without $field here so that it will
            # throw an error if any of the changed bugs are not visible.
            ValidateBugID($id);
189
            if (Bugzilla->params->{"strict_isolation"}) {
190
                my $deltabug = new Bugzilla::Bug($id);
191 192 193 194 195
                if (!$user->can_edit_product($deltabug->{'product_id'})) {
                    $vars->{'field'} = $field;
                    ThrowUserError("illegal_change_deps", $vars);
                }
            }
196
        }
197 198 199
        if ((@$added || @$removed)
            && !$bug->check_can_change_field($field, 0, 1, \$PrivilegesRequired))
        {
200 201 202 203
            $vars->{'privs'} = $PrivilegesRequired;
            $vars->{'field'} = $field;
            ThrowUserError("illegal_change", $vars);
        }
204 205 206 207 208
    } else {
        # Bugzilla does not support mass-change of dependencies so they
        # are not validated.  To prevent a URL-hacking risk, the dependencies
        # are deleted for mass-changes.
        $cgi->delete($field);
209 210 211
    }
}

212 213
# do a match on the fields if applicable

214 215
# The order of these function calls is important, as Flag::validate
# assumes User::match_field has ensured that the values
216
# in the requestee fields are legitimate user email addresses.
217
&Bugzilla::User::match_field($cgi, {
218 219 220 221
    'qa_contact'                => { 'type' => 'single' },
    'newcc'                     => { 'type' => 'multi'  },
    'masscc'                    => { 'type' => 'multi'  },
    'assigned_to'               => { 'type' => 'single' },
222
    '^requestee(_type)?-(\d+)$' => { 'type' => 'multi'  },
223
});
224 225 226 227

# Validate flags in all cases. validate() should not detect any
# reference to flags if $cgi->param('id') is undefined.
Bugzilla::Flag::validate($cgi, $cgi->param('id'));
228

229 230 231 232
######################################################################
# End Data/Security Validation
######################################################################

233
print $cgi->header();
234
$vars->{'title_tag'} = "bug_processed";
235 236 237 238

# Set the title if we can see a mid-air coming. This test may have false
# negatives, but never false positives, and should catch the majority of cases.
# It only works at all in the single bug case.
239
if (defined $cgi->param('id')) {
240 241 242
    my $delta_ts = $dbh->selectrow_array(
        q{SELECT delta_ts FROM bugs WHERE bug_id = ?},
        undef, $cgi->param('id'));
243
    
244
    if (defined $cgi->param('delta_ts') && $cgi->param('delta_ts') ne $delta_ts)
245
    {
246
        $vars->{'title_tag'} = "mid_air";
247 248
    }
}
249

250
# Set up the vars for navigational <link> elements
251
my @bug_list;
252
if ($cgi->cookie("BUGLIST") && defined $cgi->param('id')) {
253
    @bug_list = split(/:/, $cgi->cookie("BUGLIST"));
254 255 256
    $vars->{'bug_list'} = \@bug_list;
}

257 258 259 260
foreach my $field_name ('product', 'component', 'version') {
    defined($cgi->param($field_name))
      || ThrowCodeError('undefined_field', { field => $field_name });
}
261

262 263
# This function checks if there is a comment required for a specific
# function and tests, if the comment was given.
264
# If comments are required for functions is defined by params.
265
#
266
sub CheckonComment {
267
    my ($function) = (@_);
268
    my $cgi = Bugzilla->cgi;
269 270
    
    # Param is 1 if comment should be added !
271
    my $ret = Bugzilla->params->{ "commenton" . $function };
272 273 274 275 276

    # Allow without comment in case of undefined Params.
    $ret = 0 unless ( defined( $ret ));

    if( $ret ) {
277 278
        if (!defined $cgi->param('comment')
            || $cgi->param('comment') =~ /^\s*$/) {
279
            # No comment - sorry, action not allowed !
280
            ThrowUserError("comment_required");
281 282 283 284 285 286 287
        } else {
            $ret = 0;
        }
    }
    return( ! $ret ); # Return val has to be inverted
}

288 289 290 291 292
# Figure out whether or not the user is trying to change the product
# (either the "product" variable is not set to "don't change" or the
# user is changing a single bug and has changed the bug's product),
# and make the user verify the version, component, target milestone,
# and bug groups if so.
293 294
my $oldproduct = '';
if (defined $cgi->param('id')) {
295 296 297 298
    $oldproduct = $dbh->selectrow_array(
        q{SELECT name FROM products INNER JOIN bugs
        ON products.id = bugs.product_id WHERE bug_id = ?},
        undef, $cgi->param('id'));
299
}
300 301 302 303

if (((defined $cgi->param('id') && $cgi->param('product') ne $oldproduct) 
     || (!$cgi->param('id')
         && $cgi->param('product') ne $cgi->param('dontchange')))
304 305
    && CheckonComment( "reassignbycomponent" ))
{
306
    # Check to make sure they actually have the right to change the product
307 308 309
    if (!$bug->check_can_change_field('product', $oldproduct, $cgi->param('product'),
                                      \$PrivilegesRequired))
    {
310 311
        $vars->{'oldvalue'} = $oldproduct;
        $vars->{'newvalue'} = $cgi->param('product');
312
        $vars->{'field'} = 'product';
313
        $vars->{'privs'} = $PrivilegesRequired;
314
        ThrowUserError("illegal_change", $vars);
315
    }
316

317
    my $prod = $cgi->param('product');
318
    my $prod_obj = new Bugzilla::Product({name => $prod});
319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335
    trick_taint($prod);

    # If at least one bug does not belong to the product we are
    # moving to, we have to check whether or not the user is
    # allowed to enter bugs into that product.
    # Note that this check must be done early to avoid the leakage
    # of component, version and target milestone names.
    my $check_can_enter =
        $dbh->selectrow_array("SELECT 1 FROM bugs
                               INNER JOIN products
                               ON bugs.product_id = products.id
                               WHERE products.name != ?
                               AND bugs.bug_id IN
                               (" . join(',', @idlist) . ") " .
                               $dbh->sql_limit(1),
                               undef, $prod);

336
    if ($check_can_enter) { $user->can_enter_product($prod, 1) }
337 338 339 340 341 342 343 344 345

    # note that when this script is called from buglist.cgi (rather
    # than show_bug.cgi), it's possible that the product will be changed
    # but that the version and/or component will be set to 
    # "--dont_change--" but still happen to be correct.  in this case,
    # the if statement will incorrectly trigger anyway.  this is a 
    # pretty weird case, and not terribly unreasonable behavior, but 
    # worthy of a comment, perhaps.
    #
346
    my @version_names = map($_->name, @{$prod_obj->versions});
347
    my @component_names = map($_->name, @{$prod_obj->components});
348
    my $vok = lsearch(\@version_names, $cgi->param('version')) >= 0;
349
    my $cok = lsearch(\@component_names, $cgi->param('component')) >= 0;
350 351

    my $mok = 1;   # so it won't affect the 'if' statement if milestones aren't used
352
    my @milestone_names = ();
353
    if ( Bugzilla->params->{"usetargetmilestone"} ) {
354 355 356
       defined($cgi->param('target_milestone'))
         || ThrowCodeError('undefined_field', { field => 'target_milestone' });

357 358
       @milestone_names = map($_->name, @{$prod_obj->milestones});
       $mok = lsearch(\@milestone_names, $cgi->param('target_milestone')) >= 0;
359 360
    }

361 362 363
    # If the product-specific fields need to be verified, or we need to verify
    # whether or not to add the bugs to their new product's group, display
    # a verification form.
364 365
    if (!$vok || !$cok || !$mok || (AnyDefaultGroups()
        && !defined $cgi->param('addtonewgroup'))) {
366
        
367
        if (!$vok || !$cok || !$mok) {
368
            $vars->{'verify_fields'} = 1;
369 370
            my %defaults;
            # We set the defaults to these fields to the old value,
371
            # if it's a valid option, otherwise we use the default where
372
            # that's appropriate
373
            $vars->{'versions'} = \@version_names;
374
            if ($vok) {
375
                $defaults{'version'} = $cgi->param('version');
376
            }
377
            $vars->{'components'} = \@component_names;
378
            if ($cok) {
379
                $defaults{'component'} = $cgi->param('component');
380
            }
381
            if (Bugzilla->params->{"usetargetmilestone"}) {
382
                $vars->{'use_target_milestone'} = 1;
383
                $vars->{'milestones'} = \@milestone_names;
384
                if ($mok) {
385
                    $defaults{'target_milestone'} = $cgi->param('target_milestone');
386
                } else {
387 388 389 390
                    $defaults{'target_milestone'} = $dbh->selectrow_array(
                        q{SELECT defaultmilestone FROM products 
                        WHERE name = ?}, undef, $prod);
;
391
                }
392
            }
393 394
            else {
                $vars->{'use_target_milestone'} = 0;
terry%netscape.com's avatar
terry%netscape.com committed
395
            }
396
            $vars->{'defaults'} = \%defaults;
397
        }
398
        else {
399
            $vars->{'verify_fields'} = 0;
terry%netscape.com's avatar
terry%netscape.com committed
400
        }
401
        
402
        $vars->{'verify_bug_group'} = (AnyDefaultGroups() 
403
                                       && !defined $cgi->param('addtonewgroup'));
404
        
405
        $template->process("bug/process/verify-new-product.html.tmpl", $vars)
406
          || ThrowTemplateError($template->error());
407
        exit;
terry%netscape.com's avatar
terry%netscape.com committed
408 409 410
    }
}

411 412
# Confirm that the reporter of the current bug can access the bug we are duping to.
sub DuplicateUserConfirm {
413 414 415 416
    my $cgi = Bugzilla->cgi;
    my $dbh = Bugzilla->dbh;
    my $template = Bugzilla->template;

417
    # if we've already been through here, then exit
418
    if (defined $cgi->param('confirm_add_duplicate')) {
419 420 421
        return;
    }

422 423 424 425
    # Remember that we validated both these ids earlier, so we know
    # they are both valid bug ids
    my $dupe = $cgi->param('id');
    my $original = $cgi->param('dup_id');
426
    
427 428
    my $reporter = $dbh->selectrow_array(
        q{SELECT reporter FROM bugs WHERE bug_id = ?}, undef, $dupe);
429
    my $rep_user = Bugzilla::User->new($reporter);
430

431
    if ($rep_user->can_see_bug($original)) {
432
        $cgi->param('confirm_add_duplicate', '1');
433 434
        return;
    }
435

436 437 438
    $vars->{'cclist_accessible'} = $dbh->selectrow_array(
        q{SELECT cclist_accessible FROM bugs WHERE bug_id = ?},
        undef, $original);
439
    
440 441 442
    # Once in this part of the subroutine, the user has not been auto-validated
    # and the duper has not chosen whether or not to add to CC list, so let's
    # ask the duper what he/she wants to do.
443
    
444 445 446 447 448
    $vars->{'original_bug_id'} = $original;
    $vars->{'duplicate_bug_id'} = $dupe;
    
    # Confirm whether or not to add the reporter to the cc: list
    # of the original bug (the one this bug is being duped against).
449
    print Bugzilla->cgi->header();
450
    $template->process("bug/process/confirm-duplicate.html.tmpl", $vars)
451
      || ThrowTemplateError($template->error());
452
    exit;
453
}
454

455
if (defined $cgi->param('id')) {
456 457 458 459 460 461
    # since this means that we were called from show_bug.cgi, now is a good
    # time to do a whole bunch of error checking that can't easily happen when
    # we've been called from buglist.cgi, because buglist.cgi only tweaks
    # values that have been changed instead of submitting all the new values.
    # (XXX those error checks need to happen too, but implementing them 
    # is more work in the current architecture of this script...)
462
    my $prod_obj = Bugzilla::Product::check_product($cgi->param('product'));
463
    check_field('component', scalar $cgi->param('component'), 
464
                [map($_->name, @{$prod_obj->components})]);
465
    check_field('version', scalar $cgi->param('version'),
466
                [map($_->name, @{$prod_obj->versions})]);
467
    if ( Bugzilla->params->{"usetargetmilestone"} ) {
468
        check_field('target_milestone', scalar $cgi->param('target_milestone'), 
469
                    [map($_->name, @{$prod_obj->milestones})]);
470
    }
471 472 473 474
    check_field('rep_platform', scalar $cgi->param('rep_platform'));
    check_field('op_sys',       scalar $cgi->param('op_sys'));
    check_field('priority',     scalar $cgi->param('priority'));
    check_field('bug_severity', scalar $cgi->param('bug_severity'));
475 476 477 478 479 480

    # Those fields only have to exist. We don't validate their value here.
    foreach my $field_name ('bug_file_loc', 'short_desc', 'longdesclength') {
        defined($cgi->param($field_name))
          || ThrowCodeError('undefined_field', { field => $field_name });
    }
481
    $cgi->param('short_desc', clean_text($cgi->param('short_desc')));
482

483
    if (trim($cgi->param('short_desc')) eq "") {
484
        ThrowUserError("require_summary");
485
    }
terry%netscape.com's avatar
terry%netscape.com committed
486 487
}

488 489
my $action = trim($cgi->param('action') || '');

490 491
if ($action eq Bugzilla->params->{'move-button-text'}) {
    Bugzilla->params->{'move-enabled'} || ThrowUserError("move_bugs_disabled");
492

493 494
    $user->is_mover || ThrowUserError("auth_failure", {action => 'move',
                                                       object => 'bugs'});
495 496 497 498 499 500 501 502 503 504 505 506 507 508

    # Moved bugs are marked as RESOLVED MOVED.
    my $sth = $dbh->prepare("UPDATE bugs
                                SET bug_status = 'RESOLVED',
                                    resolution = 'MOVED',
                                    delta_ts = ?
                              WHERE bug_id = ?");
    # Bugs cannot be a dupe and moved at the same time.
    my $sth2 = $dbh->prepare("DELETE FROM duplicates WHERE dupe = ?");

    my $comment = "";
    if (defined $cgi->param('comment') && $cgi->param('comment') !~ /^\s*$/) {
        $comment = $cgi->param('comment') . "\n\n";
    }
509
    $comment .= "Bug moved to " . Bugzilla->params->{'move-to-url'} . ".\n\n";
510
    $comment .= "If the move succeeded, " . $user->login . " will receive a mail\n";
511 512 513 514 515 516 517 518 519 520 521 522 523 524 525
    $comment .= "containing the number of the new bug in the other database.\n";
    $comment .= "If all went well,  please mark this bug verified, and paste\n";
    $comment .= "in a link to the new bug. Otherwise, reopen this bug.\n";

    $dbh->bz_lock_tables('bugs WRITE', 'bugs_activity WRITE', 'duplicates WRITE',
                         'longdescs WRITE', 'profiles READ', 'groups READ',
                         'bug_group_map READ', 'group_group_map READ',
                         'user_group_map READ', 'classifications READ',
                         'products READ', 'components READ', 'votes READ',
                         'cc READ', 'fielddefs READ');

    my $timestamp = $dbh->selectrow_array("SELECT NOW()");
    my @bugs;
    # First update all moved bugs.
    foreach my $id (@idlist) {
526
        my $bug = new Bugzilla::Bug($id);
527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546
        push(@bugs, $bug);

        $sth->execute($timestamp, $id);
        $sth2->execute($id);

        AppendComment($id, $whoid, $comment, 0, $timestamp);

        if ($bug->bug_status ne 'RESOLVED') {
            LogActivityEntry($id, 'bug_status', $bug->bug_status,
                             'RESOLVED', $whoid, $timestamp);
        }
        if ($bug->resolution ne 'MOVED') {
            LogActivityEntry($id, 'resolution', $bug->resolution,
                             'MOVED', $whoid, $timestamp);
        }
    }
    $dbh->bz_unlock_tables();

    # Now send emails.
    foreach my $id (@idlist) {
547
        $vars->{'mailrecipients'} = { 'changer' => $user->login };
548 549 550 551 552 553 554 555
        $vars->{'id'} = $id;
        $vars->{'type'} = "move";

        $template->process("bug/process/results.html.tmpl", $vars)
          || ThrowTemplateError($template->error());
        $vars->{'header_done'} = 1;
    }
    # Prepare and send all data about these bugs to the new database
556
    my $to = Bugzilla->params->{'move-to-address'};
557
    $to =~ s/@/\@/;
558
    my $from = Bugzilla->params->{'moved-from-address'};
559 560 561 562 563
    $from =~ s/@/\@/;
    my $msg = "To: $to\n";
    $msg .= "From: Bugzilla <" . $from . ">\n";
    $msg .= "Subject: Moving bug(s) " . join(', ', @idlist) . "\n\n";

564
    my @fieldlist = (Bugzilla::Bug->fields, 'group', 'long_desc',
565
                     'attachment', 'attachmentdata');
566 567 568 569 570 571 572 573 574 575 576
    my %displayfields;
    foreach (@fieldlist) {
        $displayfields{$_} = 1;
    }

    $template->process("bug/show.xml.tmpl", { bugs => \@bugs,
                                              displayfields => \%displayfields,
                                            }, \$msg)
      || ThrowTemplateError($template->error());

    $msg .= "\n";
577
    MessageToMTA($msg);
578 579 580 581 582 583 584

    # End the response page.
    $template->process("bug/navigate.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
    $template->process("global/footer.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
    exit;
585 586 587
}


588
$::query = "UPDATE bugs SET";
589
$::comma = "";
590
local our @values;
591 592
umask(0);

593
sub _remove_remaining_time {
594
    my $cgi = Bugzilla->cgi;
595
    if (UserInGroup(Bugzilla->params->{'timetrackinggroup'})) {
596 597
        if ( defined $cgi->param('remaining_time') 
             && $cgi->param('remaining_time') > 0 )
598
        {
599
            $cgi->param('remaining_time', 0);
600 601 602 603 604 605 606 607 608
            $vars->{'message'} = "remaining_time_zeroed";
        }
    }
    else {
        DoComma();
        $::query .= "remaining_time = 0";
    }
}

609 610 611
sub DoComma {
    $::query .= "$::comma\n    ";
    $::comma = ",";
terry%netscape.com's avatar
terry%netscape.com committed
612 613
}

614 615
# $everconfirmed is used by ChangeStatus() to determine whether we are
# confirming the bug or not.
616
local our $everconfirmed;
617
sub DoConfirm {
618 619 620 621
    my $bug = shift;
    if ($bug->check_can_change_field("canconfirm", 0, 1, 
                                     \$PrivilegesRequired)) 
    {
622 623
        DoComma();
        $::query .= "everconfirmed = 1";
624
        $everconfirmed = 1;
625 626 627
    }
}

628 629
sub ChangeStatus {
    my ($str) = (@_);
630 631 632
    my $cgi = Bugzilla->cgi;
    my $dbh = Bugzilla->dbh;

633 634
    if (!$cgi->param('dontchange')
        || $str ne $cgi->param('dontchange')) {
635
        DoComma();
636
        if ($cgi->param('knob') eq 'reopen') {
637 638
            # When reopening, we need to check whether the bug was ever
            # confirmed or not
639
            $::query .= "bug_status = CASE WHEN everconfirmed = 1 THEN " .
640
                        $dbh->quote($str) . " ELSE 'UNCONFIRMED' END";
641
        } elsif (is_open_state($str)) {
642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662
            # Note that we cannot combine this with the above branch - here we
            # need to check if bugs.bug_status is open, (since we don't want to
            # reopen closed bugs when reassigning), while above the whole point
            # is to reopen a closed bug.
            # Currently, the UI doesn't permit a user to reassign a closed bug
            # from the single bug page (only during a mass change), but they
            # could still hack the submit, so don't restrict this extended
            # check to the mass change page for safety/sanity/consistency
            # purposes.

            # The logic for this block is:
            # If the new state is open:
            #   If the old state was open
            #     If the bug was confirmed
            #       - move it to the new state
            #     Else
            #       - Set the state to unconfirmed
            #   Else
            #     - leave it as it was

            # This is valid only because 'reopen' is the only thing which moves
663
            # from closed to open, and it's handled above
664 665 666
            # This also relies on the fact that confirming and accepting have
            # already called DoConfirm before this is called

667
            my @open_state = map($dbh->quote($_), BUG_STATE_OPEN);
668
            my $open_state = join(", ", @open_state);
669 670 671

            # If we are changing everconfirmed to 1, we have to take this change
            # into account and the new bug status is given by $str.
672
            my $cond = $dbh->quote($str);
673 674 675 676 677 678
            # If we are not setting everconfirmed, the new bug status depends on
            # the actual value of everconfirmed, which is bug-specific.
            unless ($everconfirmed) {
                $cond = "(CASE WHEN everconfirmed = 1 THEN " . $cond .
                        " ELSE 'UNCONFIRMED' END)";
            }
679
            $::query .= "bug_status = CASE WHEN bug_status IN($open_state) THEN " .
680
                                      $cond . " ELSE bug_status END";
681
        } else {
682 683
            $::query .= "bug_status = ?";
            push(@values, $str);
684
        }
685 686 687
        # If bugs are reassigned and their status is "UNCONFIRMED", they
        # should keep this status instead of "NEW" as suggested here.
        # This point is checked for each bug later in the code.
688
        $cgi->param('bug_status', $str);
terry%netscape.com's avatar
terry%netscape.com committed
689 690 691
    }
}

692 693
sub ChangeResolution {
    my ($str) = (@_);
694 695 696
    my $dbh = Bugzilla->dbh;
    my $cgi = Bugzilla->cgi;

697 698
    if (!$cgi->param('dontchange')
        || $str ne $cgi->param('dontchange'))
699
    {
700 701 702 703 704 705 706 707 708 709 710 711
        # Make sure the user is allowed to change the resolution.
        # If the user is changing several bugs at once using the UI,
        # then he has enough privs to do so. In the case he is hacking
        # the URL, we don't care if he reads --UNKNOWN-- as a resolution
        # in the error message.
        my $old_resolution = '-- UNKNOWN --';
        my $bug_id = $cgi->param('id');
        if ($bug_id) {
            $old_resolution =
                $dbh->selectrow_array('SELECT resolution FROM bugs WHERE bug_id = ?',
                                       undef, $bug_id);
        }
712 713 714
        unless ($bug->check_can_change_field('resolution', $old_resolution, $str,
                                             \$PrivilegesRequired))
        {
715 716 717 718 719 720 721
            $vars->{'oldvalue'} = $old_resolution;
            $vars->{'newvalue'} = $str;
            $vars->{'field'} = 'resolution';
            $vars->{'privs'} = $PrivilegesRequired;
            ThrowUserError("illegal_change", $vars);
        }

722
        DoComma();
723 724 725
        $::query .= "resolution = ?";
        trick_taint($str);
        push(@values, $str);
726
        # We define this variable here so that customized installations
727
        # may set rules based on the resolution in Bug::check_can_change_field().
728
        $cgi->param('resolution', $str);
terry%netscape.com's avatar
terry%netscape.com committed
729 730 731
    }
}

732 733 734 735
# Changing this so that it will process groups from checkboxes instead of
# select lists.  This means that instead of looking for the bit-X values in
# the form, we need to loop through all the bug groups this user has access
# to, and for each one, see if it's selected.
736 737
# If the form element isn't present, or the user isn't in the group, leave
# it as-is
738

739 740 741
my @groupAdd = ();
my @groupDel = ();

742 743 744 745 746
my $groups = $dbh->selectall_arrayref(
    qq{SELECT groups.id, isactive FROM groups
        WHERE id IN($grouplist) AND isbuggroup = 1});
foreach my $group (@$groups) {
    my ($b, $isactive) = @$group;
747 748 749 750
    # The multiple change page may not show all groups a bug is in
    # (eg product groups when listing more than one product)
    # Only consider groups which were present on the form. We can't do this
    # for single bug changes because non-checked checkboxes aren't present.
751
    # All the checkboxes should be shown in that case, though, so it isn't
752
    # an issue there
753 754
    if (defined $cgi->param('id') || defined $cgi->param("bit-$b")) {
        if (!$cgi->param("bit-$b")) {
755
            push(@groupDel, $b);
756
        } elsif ($cgi->param("bit-$b") == 1 && $isactive) {
757
            push(@groupAdd, $b);
758 759
        }
    }
760 761
}

762 763
foreach my $field ("rep_platform", "priority", "bug_severity",
                   "bug_file_loc", "short_desc", "version", "op_sys",
764
                   "target_milestone", "status_whiteboard") {
765 766 767
    if (defined $cgi->param($field)) {
        if (!$cgi->param('dontchange')
            || $cgi->param($field) ne $cgi->param('dontchange')) {
768
            DoComma();
769 770 771 772
            $::query .= "$field = ?";
            my $value = trim($cgi->param($field));
            trick_taint($value);
            push(@values, $value);
terry%netscape.com's avatar
terry%netscape.com committed
773 774 775 776
        }
    }
}

777 778 779 780 781 782 783
# Add custom fields data to the query that will update the database.
foreach my $field (Bugzilla->custom_field_names) {
    if (defined $cgi->param($field)
        && (!$cgi->param('dontchange')
            || $cgi->param($field) ne $cgi->param('dontchange')))
    {
        DoComma();
784 785 786 787
        $::query .= "$field = ?";
        my $value = $cgi->param($field);
        trick_taint($value);
        push(@values, $value);
788 789 790
    }
}

791
my $product;
792 793
my $prod_changed;
my @newprod_ids;
794
if ($cgi->param('product') ne $cgi->param('dontchange')) {
795 796
    $product = Bugzilla::Product::check_product(scalar $cgi->param('product'));

797
    DoComma();
798
    $::query .= "product_id = ?";
799 800
    push(@values, $product->id);
    @newprod_ids = ($product->id);
801
    $prod_changed = 1;
802
} else {
803 804 805 806 807 808
    @newprod_ids = @{$dbh->selectcol_arrayref("SELECT DISTINCT product_id
                                               FROM bugs 
                                               WHERE bug_id IN (" .
                                                   join(',', @idlist) . 
                                               ")")};
    if (scalar(@newprod_ids) == 1) {
809
        $product = new Bugzilla::Product($newprod_ids[0]);
810
    }
811 812
}

813
my $component;
814
if ($cgi->param('component') ne $cgi->param('dontchange')) {
815
    if (scalar(@newprod_ids) > 1) {
816
        ThrowUserError("no_component_change_for_multiple_products");
817
    }
818 819 820 821 822
    $component =
        Bugzilla::Component::check_component($product, scalar $cgi->param('component'));

    # This parameter is required later when checking fields the user can change.
    $cgi->param('component_id', $component->id);
823
    DoComma();
824
    $::query .= "component_id = ?";
825
    push(@values, $component->id);
826 827
}

828 829
# If this installation uses bug aliases, and the user is changing the alias,
# add this change to the query.
830
if (Bugzilla->params->{"usebugaliases"} && defined $cgi->param('alias')) {
831
    my $alias = trim($cgi->param('alias'));
832 833 834 835 836 837 838 839 840 841
    
    # Since aliases are unique (like bug numbers), they can only be changed
    # for one bug at a time, so ignore the alias change unless only a single
    # bug is being changed.
    if (scalar(@idlist) == 1) {
        # Add the alias change to the query.  If the field contains the blank 
        # value, make the field be NULL to indicate that the bug has no alias.
        # Otherwise, if the field contains a value, update the record 
        # with that value.
        DoComma();
842 843
        if ($alias ne "") {
            ValidateBugAlias($alias, $idlist[0]);
844 845
            $::query .= "alias = ?";
            push(@values, $alias);
846
        } else {
847
            $::query .= "alias = NULL";
848
        }
849 850
    }
}
851

852 853
# If the user is submitting changes from show_bug.cgi for a single bug,
# and that bug is restricted to a group, process the checkboxes that
854
# allowed the user to set whether or not the reporter
855 856
# and cc list can see the bug even if they are not members of all groups 
# to which the bug is restricted.
857
if (defined $cgi->param('id')) {
858 859 860
    my ($havegroup) = $dbh->selectrow_array(
        q{SELECT group_id FROM bug_group_map WHERE bug_id = ?},
        undef, $cgi->param('id'));
861
    if ( $havegroup ) {
862
        DoComma();
863 864
        $cgi->param('reporter_accessible',
                    $cgi->param('reporter_accessible') ? '1' : '0');
865 866
        $::query .= "reporter_accessible = ?";
        push(@values, $cgi->param('reporter_accessible'));
867 868

        DoComma();
869 870
        $cgi->param('cclist_accessible',
                    $cgi->param('cclist_accessible') ? '1' : '0');
871 872
        $::query .= "cclist_accessible = ?";
        push(@values, $cgi->param('cclist_accessible'));
873 874 875
    }
}

876 877 878 879
if ( defined $cgi->param('id') &&
     (Bugzilla->params->{"insidergroup"} 
      && UserInGroup(Bugzilla->params->{"insidergroup"})) ) 
{
880

881 882 883
    my $sth = $dbh->prepare('UPDATE longdescs SET isprivate = ?
                             WHERE bug_id = ? AND bug_when = ?');

884
    foreach my $field ($cgi->param()) {
885 886
        if ($field =~ /when-([0-9]+)/) {
            my $sequence = $1;
887 888 889
            my $private = $cgi->param("isprivate-$sequence") ? 1 : 0 ;
            if ($private != $cgi->param("oisprivate-$sequence")) {
                my $field_data = $cgi->param("$field");
890 891 892
                # Make sure a valid date is given.
                $field_data = format_time($field_data, '%Y-%m-%d %T');
                $sth->execute($private, $cgi->param('id'), $field_data);
893 894 895 896 897
            }
        }

    }
}
898

899
my $duplicate = 0;
900

901 902 903 904
# We need to check the addresses involved in a CC change before we touch any bugs.
# What we'll do here is formulate the CC data into two hashes of ID's involved
# in this CC change.  Then those hashes can be used later on for the actual change.
my (%cc_add, %cc_remove);
905 906 907 908
if (defined $cgi->param('newcc')
    || defined $cgi->param('addselfcc')
    || defined $cgi->param('removecc')
    || defined $cgi->param('masscc')) {
909 910 911
    # If masscc is defined, then we came from buglist and need to either add or
    # remove cc's... otherwise, we came from bugform and may need to do both.
    my ($cc_add, $cc_remove) = "";
912 913 914 915 916
    if (defined $cgi->param('masscc')) {
        if ($cgi->param('ccaction') eq 'add') {
            $cc_add = join(' ',$cgi->param('masscc'));
        } elsif ($cgi->param('ccaction') eq 'remove') {
            $cc_remove = join(' ',$cgi->param('masscc'));
917 918
        }
    } else {
919
        $cc_add = join(' ',$cgi->param('newcc'));
920 921
        # We came from bug_form which uses a select box to determine what cc's
        # need to be removed...
922 923
        if (defined $cgi->param('removecc') && $cgi->param('cc')) {
            $cc_remove = join (",", $cgi->param('cc'));
924 925 926 927
        }
    }

    if ($cc_add) {
928 929
        $cc_add =~ s/[\s,]+/ /g; # Change all delimiters to a single space
        foreach my $person ( split(" ", $cc_add) ) {
930
            my $pid = login_to_id($person, THROW_ERROR);
931 932 933
            $cc_add{$pid} = $person;
        }
    }
934
    if ($cgi->param('addselfcc')) {
935 936
        $cc_add{$whoid} = $user->login;
    }
937
    if ($cc_remove) {
938 939
        $cc_remove =~ s/[\s,]+/ /g; # Change all delimiters to a single space
        foreach my $person ( split(" ", $cc_remove) ) {
940
            my $pid = login_to_id($person, THROW_ERROR);
941 942 943 944 945
            $cc_remove{$pid} = $person;
        }
    }
}

946 947
# Store the new assignee and QA contact IDs (if any). This is the
# only way to keep these informations when bugs are reassigned by
948
# component as $cgi->param('assigned_to') and $cgi->param('qa_contact')
949
# are not the right fields to look at.
950 951 952
# If the assignee or qacontact is changed, the new one is checked when
# changed information is validated.  If not, then the unchanged assignee
# or qacontact may have to be validated later.
953 954 955

my $assignee;
my $qacontact;
956 957 958 959
my $qacontact_checked = 0;
my $assignee_checked = 0;

my %usercache = ();
960

961 962
if (defined $cgi->param('qa_contact')
    && $cgi->param('knob') ne "reassignbycomponent")
963
{
964
    my $name = trim($cgi->param('qa_contact'));
965
    # The QA contact cannot be deleted from show_bug.cgi for a single bug!
966
    if ($name ne $cgi->param('dontchange')) {
967
        $qacontact = login_to_id($name, THROW_ERROR) if ($name ne "");
968
        if ($qacontact && Bugzilla->params->{"strict_isolation"}) {
969 970 971 972
                $usercache{$qacontact} ||= Bugzilla::User->new($qacontact);
                my $qa_user = $usercache{$qacontact};
                foreach my $product_id (@newprod_ids) {
                    if (!$qa_user->can_edit_product($product_id)) {
973
                        my $product_name = Bugzilla::Product->new($product_id)->name;
974 975 976 977 978 979 980 981
                        ThrowUserError('invalid_user_group',
                                          {'users'   => $qa_user->login,
                                           'product' => $product_name,
                                           'bug_id' => (scalar(@idlist) > 1)
                                                         ? undef : $idlist[0]
                                          });
                    }
                }
982
        }
983
        $qacontact_checked = 1;
984
        DoComma();
985
        if($qacontact) {
986 987
            $::query .= "qa_contact = ?";
            push(@values, $qacontact);
988 989 990 991
        }
        else {
            $::query .= "qa_contact = NULL";
        }
992 993
    }
}
994

995
SWITCH: for ($cgi->param('knob')) {
996 997 998
    /^none$/ && do {
        last SWITCH;
    };
999
    /^confirm$/ && CheckonComment( "confirm" ) && do {
1000
        DoConfirm($bug);
1001 1002 1003
        ChangeStatus('NEW');
        last SWITCH;
    };
1004
    /^accept$/ && CheckonComment( "accept" ) && do {
1005
        DoConfirm($bug);
1006
        ChangeStatus('ASSIGNED');
1007 1008 1009
        if (Bugzilla->params->{"usetargetmilestone"} 
            && Bugzilla->params->{"musthavemilestoneonaccept"}) 
        {
1010
            $requiremilestone = 1;
1011
        }
1012 1013
        last SWITCH;
    };
1014
    /^clearresolution$/ && CheckonComment( "clearresolution" ) && do {
1015 1016 1017
        ChangeResolution('');
        last SWITCH;
    };
1018
    /^(resolve|change_resolution)$/ && CheckonComment( "resolve" ) && do {
1019
        # Check here, because it's the only place we require the resolution
1020
        check_field('resolution', scalar $cgi->param('resolution'),
1021
                    Bugzilla::Bug->settable_resolutions);
1022

1023
        # don't resolve as fixed while still unresolved blocking bugs
1024
        if (Bugzilla->params->{"noresolveonopenblockers"}
1025
            && $cgi->param('resolution') eq 'FIXED')
1026
        {
1027
            my @dependencies = Bugzilla::Bug::CountOpenDependencies(@idlist);
1028 1029
            if (scalar @dependencies > 0) {
                ThrowUserError("still_unresolved_bugs",
1030 1031
                               { dependencies     => \@dependencies,
                                 dependency_count => scalar @dependencies });
1032
            }
1033
        }
1034

1035 1036 1037 1038 1039 1040 1041
        if ($cgi->param('knob') eq 'resolve') {
            # RESOLVED bugs should have no time remaining;
            # more time can be added for the VERIFY step, if needed.
            _remove_remaining_time();

            ChangeStatus('RESOLVED');
        }
1042

1043
        ChangeResolution($cgi->param('resolution'));
1044 1045
        last SWITCH;
    };
1046
    /^reassign$/ && CheckonComment( "reassign" ) && do {
1047
        if ($cgi->param('andconfirm')) {
1048
            DoConfirm($bug);
1049
        }
1050 1051
        ChangeStatus('NEW');
        DoComma();
1052 1053
        if (defined $cgi->param('assigned_to')
            && trim($cgi->param('assigned_to')) ne "") { 
1054
            $assignee = login_to_id(trim($cgi->param('assigned_to')), THROW_ERROR);
1055
            if (Bugzilla->params->{"strict_isolation"}) {
1056 1057 1058 1059
                $usercache{$assignee} ||= Bugzilla::User->new($assignee);
                my $assign_user = $usercache{$assignee};
                foreach my $product_id (@newprod_ids) {
                    if (!$assign_user->can_edit_product($product_id)) {
1060
                        my $product_name = Bugzilla::Product->new($product_id)->name;
1061 1062 1063 1064 1065 1066 1067 1068
                        ThrowUserError('invalid_user_group',
                                          {'users'   => $assign_user->login,
                                           'product' => $product_name,
                                           'bug_id' => (scalar(@idlist) > 1)
                                                         ? undef : $idlist[0]
                                          });
                    }
                }
1069
            }
1070
        } else {
1071
            ThrowUserError("reassign_to_empty");
1072
        }
1073 1074
        $::query .= "assigned_to = ?";
        push(@values, $assignee);
1075
        $assignee_checked = 1;
1076 1077
        last SWITCH;
    };
1078
    /^reassignbycomponent$/  && CheckonComment( "reassignbycomponent" ) && do {
1079
        if ($cgi->param('compconfirm')) {
1080
            DoConfirm($bug);
1081
        }
1082 1083
        ChangeStatus('NEW');
        last SWITCH;
1084
    };
1085
    /^reopen$/  && CheckonComment( "reopen" ) && do {
1086
        ChangeStatus('REOPENED');
1087
        ChangeResolution('');
1088 1089
        last SWITCH;
    };
1090
    /^verify$/ && CheckonComment( "verify" ) && do {
1091 1092 1093
        ChangeStatus('VERIFIED');
        last SWITCH;
    };
1094
    /^close$/ && CheckonComment( "close" ) && do {
1095 1096 1097
        # CLOSED bugs should have no time remaining.
        _remove_remaining_time();

1098 1099 1100
        ChangeStatus('CLOSED');
        last SWITCH;
    };
1101
    /^duplicate$/ && CheckonComment( "duplicate" ) && do {
1102 1103 1104 1105 1106 1107
        # You cannot mark bugs as duplicates when changing
        # several bugs at once.
        unless (defined $cgi->param('id')) {
            ThrowUserError('dupe_not_allowed');
        }

1108
        # Make sure we can change the original bug (issue A on bug 96085)
1109 1110 1111
        defined($cgi->param('dup_id'))
          || ThrowCodeError('undefined_field', { field => 'dup_id' });

1112 1113 1114
        $duplicate = $cgi->param('dup_id');
        ValidateBugID($duplicate, 'dup_id');
        $cgi->param('dup_id', $duplicate);
1115

1116 1117 1118
        # Make sure a loop isn't created when marking this bug
        # as duplicate.
        my %dupes;
1119
        my $dupe_of = $duplicate;
1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141
        my $sth = $dbh->prepare('SELECT dupe_of FROM duplicates
                                 WHERE dupe = ?');

        while ($dupe_of) {
            if ($dupe_of == $cgi->param('id')) {
                ThrowUserError('dupe_loop_detected', { bug_id  => $cgi->param('id'),
                                                       dupe_of => $duplicate });
            }
            # If $dupes{$dupe_of} is already set to 1, then a loop
            # already exists which does not involve this bug.
            # As the user is not responsible for this loop, do not
            # prevent him from marking this bug as a duplicate.
            last if exists $dupes{"$dupe_of"};
            $dupes{"$dupe_of"} = 1;
            $sth->execute($dupe_of);
            $dupe_of = $sth->fetchrow_array;
        }

        # Also, let's see if the reporter has authorization to see
        # the bug to which we are duping. If not we need to prompt.
        DuplicateUserConfirm();

1142 1143 1144
        # DUPLICATE bugs should have no time remaining.
        _remove_remaining_time();

1145 1146
        ChangeStatus('RESOLVED');
        ChangeResolution('DUPLICATE');
1147 1148
        my $comment = $cgi->param('comment');
        $comment .= "\n\n*** This bug has been marked " .
1149
                    "as a duplicate of bug $duplicate ***";
1150
        $cgi->param('comment', $comment);
1151 1152
        last SWITCH;
    };
1153

1154
    ThrowCodeError("unknown_action", { action => $cgi->param('knob') });
terry%netscape.com's avatar
terry%netscape.com committed
1155 1156
}

1157 1158 1159
my @keywordlist;
my %keywordseen;

1160 1161
if (defined $cgi->param('keywords')) {
    foreach my $keyword (split(/[\s,]+/, $cgi->param('keywords'))) {
1162 1163 1164
        if ($keyword eq '') {
            next;
        }
1165 1166
        my $keyword_obj = new Bugzilla::Keyword({name => $keyword});
        if (!$keyword_obj) {
1167 1168
            ThrowUserError("unknown_keyword",
                           { keyword => $keyword });
1169
        }
1170 1171 1172
        if (!$keywordseen{$keyword_obj->id}) {
            push(@keywordlist, $keyword_obj->id);
            $keywordseen{$keyword_obj->id} = 1;
1173 1174 1175 1176
        }
    }
}

1177
my $keywordaction = $cgi->param('keywordaction') || "makeexact";
1178 1179 1180
if (!grep($keywordaction eq $_, qw(add delete makeexact))) {
    $keywordaction = "makeexact";
}
1181

1182
if ($::comma eq ""
1183
    && (! @groupAdd) && (! @groupDel)
1184 1185
    && (!Bugzilla::Keyword::keyword_count() 
        || (0 == @keywordlist && $keywordaction ne "makeexact"))
1186
    && defined $cgi->param('masscc') && ! $cgi->param('masscc')
1187
    ) {
1188
    if (!defined $cgi->param('comment') || $cgi->param('comment') =~ /^\s*$/) {
1189
        ThrowUserError("bugs_not_changed");
terry%netscape.com's avatar
terry%netscape.com committed
1190 1191 1192
    }
}

1193
# Process data for Time Tracking fields
1194
if (UserInGroup(Bugzilla->params->{'timetrackinggroup'})) {
1195
    foreach my $field ("estimated_time", "remaining_time") {
1196 1197 1198
        if (defined $cgi->param($field)) {
            my $er_time = trim($cgi->param($field));
            if ($er_time ne $cgi->param('dontchange')) {
1199
                DoComma();
1200 1201 1202
                $::query .= "$field = ?";
                trick_taint($er_time);
                push(@values, $er_time);
1203 1204 1205 1206
            }
        }
    }

1207
    if (defined $cgi->param('deadline')) {
1208
        DoComma();
1209
        if ($cgi->param('deadline')) {
1210 1211 1212
            validate_date($cgi->param('deadline'))
              || ThrowUserError('illegal_date', {date => $cgi->param('deadline'),
                                                 format => 'YYYY-MM-DD'});
1213 1214 1215 1216
            $::query .= "deadline = ?";
            my $deadline = $cgi->param('deadline');
            trick_taint($deadline);
            push(@values, $deadline);
1217
        } else {
1218
            $::query .= "deadline = NULL";
1219 1220 1221 1222
        }
    }
}

1223
my $basequery = $::query;
1224

1225
local our $delta_ts;
1226 1227
sub SnapShotBug {
    my ($id) = (@_);
1228
    my $dbh = Bugzilla->dbh;
1229
    my @row = $dbh->selectrow_array(q{SELECT delta_ts, } .
1230
                join(',', editable_bug_fields()).q{ FROM bugs WHERE bug_id = ?},
1231
                undef, $id);
1232
    $delta_ts = shift @row;
1233

1234
    return @row;
terry%netscape.com's avatar
terry%netscape.com committed
1235 1236 1237
}


1238 1239
sub SnapShotDeps {
    my ($i, $target, $me) = (@_);
1240
    my $dbh = Bugzilla->dbh;
1241 1242 1243 1244
    my $list = $dbh->selectcol_arrayref(qq{SELECT $target FROM dependencies
                                        WHERE $me = ? ORDER BY $target},
                                        undef, $i);
    return join(',', @$list);
1245 1246 1247 1248 1249
}


my $timestamp;

1250
local our $bug_changed;
1251
sub LogDependencyActivity {
1252
    my ($i, $oldstr, $target, $me, $timestamp) = (@_);
1253
    my $dbh = Bugzilla->dbh;
1254 1255
    my $newstr = SnapShotDeps($i, $target, $me);
    if ($oldstr ne $newstr) {
1256
        # Figure out what's really different...
1257
        my ($removed, $added) = diff_strings($oldstr, $newstr);
1258
        LogActivityEntry($i,$target,$removed,$added,$whoid,$timestamp);
1259
        # update timestamp on target bug so midairs will be triggered
1260 1261
        $dbh->do(q{UPDATE bugs SET delta_ts = ? WHERE bug_id = ?},
                 undef, $timestamp, $i);
1262
        $bug_changed = 1;
1263 1264 1265 1266 1267
        return 1;
    }
    return 0;
}

1268
if (Bugzilla->params->{"strict_isolation"}) {
1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286
    my @blocked_cc = ();
    foreach my $pid (keys %cc_add) {
        $usercache{$pid} ||= Bugzilla::User->new($pid);
        my $cc_user = $usercache{$pid};
        foreach my $product_id (@newprod_ids) {
            if (!$cc_user->can_edit_product($product_id)) {
                push (@blocked_cc, $cc_user->login);
                last;
            }
        }
    }
    if (scalar(@blocked_cc)) {
        ThrowUserError("invalid_user_group", 
            {'users' => \@blocked_cc,
             'bug_id' => (scalar(@idlist) > 1) ? undef : $idlist[0]});
    }
}

1287
if ($prod_changed && Bugzilla->params->{"strict_isolation"}) {
1288 1289 1290 1291 1292 1293
    my $sth_cc = $dbh->prepare("SELECT who
                                FROM cc
                                WHERE bug_id = ?");
    my $sth_bug = $dbh->prepare("SELECT assigned_to, qa_contact
                                 FROM bugs
                                 WHERE bug_id = ?");
1294

1295 1296 1297 1298 1299 1300
    foreach my $id (@idlist) {
        $sth_cc->execute($id);
        my @blocked_cc = ();
        while (my ($pid) = $sth_cc->fetchrow_array) {
            $usercache{$pid} ||= Bugzilla::User->new($pid);
            my $cc_user = $usercache{$pid};
1301
            if (!$cc_user->can_edit_product($product->id)) {
1302 1303 1304 1305 1306 1307 1308
                push (@blocked_cc, $cc_user->login);
            }
        }
        if (scalar(@blocked_cc)) {
            ThrowUserError('invalid_user_group',
                              {'users'   => \@blocked_cc,
                               'bug_id' => $id,
1309
                               'product' => $product->name});
1310 1311 1312 1313 1314 1315
        }
        $sth_bug->execute($id);
        my ($assignee, $qacontact) = $sth_bug->fetchrow_array;
        if (!$assignee_checked) {
            $usercache{$assignee} ||= Bugzilla::User->new($assignee);
            my $assign_user = $usercache{$assignee};
1316
            if (!$assign_user->can_edit_product($product->id)) {
1317 1318 1319
                    ThrowUserError('invalid_user_group',
                                      {'users'   => $assign_user->login,
                                       'bug_id' => $id,
1320
                                       'product' => $product->name});
1321 1322 1323 1324 1325
            }
        }
        if (!$qacontact_checked && $qacontact) {
            $usercache{$qacontact} ||= Bugzilla::User->new($qacontact);
            my $qa_user = $usercache{$qacontact};
1326
            if (!$qa_user->can_edit_product($product->id)) {
1327 1328 1329
                    ThrowUserError('invalid_user_group',
                                      {'users'   => $qa_user->login,
                                       'bug_id' => $id,
1330
                                       'product' => $product->name});
1331 1332 1333 1334 1335 1336
            }
        }
    }
}


1337 1338 1339
# This loop iterates once for each bug to be processed (i.e. all the
# bugs selected when this script is called with multiple bugs selected
# from buglist.cgi, or just the one bug when called from
1340 1341
# show_bug.cgi).
#
1342
foreach my $id (@idlist) {
1343
    my $query = $basequery;
1344
    my @bug_values = @values;
1345
    my $old_bug_obj = new Bugzilla::Bug($id);
1346 1347 1348

    if ($cgi->param('knob') eq 'reassignbycomponent') {
        # We have to check whether the bug is moved to another product
1349
        # and/or component before reassigning. If $component is defined,
1350
        # use it; else use the product/component the bug is already in.
1351
        my $new_comp_id = $component ? $component->id : $old_bug_obj->{'component_id'};
1352 1353 1354 1355
        $assignee = $dbh->selectrow_array('SELECT initialowner
                                           FROM components
                                           WHERE components.id = ?',
                                           undef, $new_comp_id);
1356
        $query .= ", assigned_to = ?";
1357
        push(@bug_values, $assignee);
1358
        if (Bugzilla->params->{"useqacontact"}) {
1359 1360 1361 1362 1363
            $qacontact = $dbh->selectrow_array('SELECT initialqacontact
                                                FROM components
                                                WHERE components.id = ?',
                                                undef, $new_comp_id);
            if ($qacontact) {
1364
                $query .= ", qa_contact = ?";
1365
                push(@bug_values, $qacontact);
1366 1367 1368 1369 1370 1371 1372
            }
            else {
                $query .= ", qa_contact = NULL";
            }
        }
    }

1373
    my %dependencychanged;
1374
    $bug_changed = 0;
1375 1376
    my $write = "WRITE";        # Might want to make a param to control
                                # whether we do LOW_PRIORITY ...
1377
    $dbh->bz_lock_tables("bugs $write", "bugs_activity $write", "cc $write",
1378
            "profiles READ", "dependencies $write", "votes $write",
1379
            "products READ", "components READ", "milestones READ",
1380
            "keywords $write", "longdescs $write", "fielddefs READ",
1381
            "bug_group_map $write", "flags $write", "duplicates $write",
1382
            "user_group_map READ", "group_group_map READ", "flagtypes READ",
1383 1384 1385 1386
            "flaginclusions AS i READ", "flagexclusions AS e READ",
            "keyworddefs READ", "groups READ", "attachments READ",
            "group_control_map AS oldcontrolmap READ",
            "group_control_map AS newcontrolmap READ",
1387
            "group_control_map READ", "email_setting READ", "classifications READ");
1388

1389
    # It may sound crazy to set %formhash for each bug as $cgi->param()
1390 1391
    # will not change, but %formhash is modified below and we prefer
    # to set it again.
1392
    my $i = 0;
1393 1394 1395
    my @oldvalues = SnapShotBug($id);
    my %oldhash;
    my %formhash;
1396
    foreach my $col (@editable_bug_fields) {
1397
        # Consider NULL db entries to be equivalent to the empty string
1398 1399 1400
        $oldvalues[$i] = defined($oldvalues[$i]) ? $oldvalues[$i] : '';
        # Convert the deadline taken from the DB into the YYYY-MM-DD format
        # for consistency with the deadline provided by the user, if any.
1401 1402
        # Else Bug::check_can_change_field() would see them as different
        # in all cases.
1403 1404 1405
        if ($col eq 'deadline') {
            $oldvalues[$i] = format_time($oldvalues[$i], "%Y-%m-%d");
        }
1406
        $oldhash{$col} = $oldvalues[$i];
1407
        $formhash{$col} = $cgi->param($col) if defined $cgi->param($col);
1408 1409 1410 1411 1412 1413 1414
        $i++;
    }
    # If the user is reassigning bugs, we need to:
    # - convert $newhash{'assigned_to'} and $newhash{'qa_contact'}
    #   email addresses into their corresponding IDs;
    # - update $newhash{'bug_status'} to its real state if the bug
    #   is in the unconfirmed state.
1415
    $formhash{'qa_contact'} = $qacontact if Bugzilla->params->{'useqacontact'};
1416 1417
    if ($cgi->param('knob') eq 'reassignbycomponent'
        || $cgi->param('knob') eq 'reassign') {
1418
        $formhash{'assigned_to'} = $assignee;
1419
        if ($oldhash{'bug_status'} eq 'UNCONFIRMED') {
1420 1421 1422
            $formhash{'bug_status'} = $oldhash{'bug_status'};
        }
    }
1423 1424 1425 1426 1427
    # This hash is required by Bug::check_can_change_field().
    my $cgi_hash = {
        'dontchange' => scalar $cgi->param('dontchange'),
        'knob'       => scalar $cgi->param('knob')
    };
1428
    foreach my $col (@editable_bug_fields) {
1429 1430 1431
        # The 'resolution' field is checked by ChangeResolution(),
        # i.e. only if we effectively use it.
        next if ($col eq 'resolution');
1432
        if (exists $formhash{$col}
1433 1434
            && !$old_bug_obj->check_can_change_field($col, $oldhash{$col}, $formhash{$col},
                                                     \$PrivilegesRequired, $cgi_hash))
1435 1436 1437 1438
        {
            my $vars;
            if ($col eq 'component_id') {
                # Display the component name
1439
                $vars->{'oldvalue'} = $old_bug_obj->component;
1440
                $vars->{'newvalue'} = $cgi->param('component');
1441 1442 1443
                $vars->{'field'} = 'component';
            } elsif ($col eq 'assigned_to' || $col eq 'qa_contact') {
                # Display the assignee or QA contact email address
1444 1445
                $vars->{'oldvalue'} = user_id_to_login($oldhash{$col});
                $vars->{'newvalue'} = user_id_to_login($formhash{$col});
1446 1447 1448 1449 1450
                $vars->{'field'} = $col;
            } else {
                $vars->{'oldvalue'} = $oldhash{$col};
                $vars->{'newvalue'} = $formhash{$col};
                $vars->{'field'} = $col;
1451
            }
1452
            $vars->{'privs'} = $PrivilegesRequired;
1453
            ThrowUserError("illegal_change", $vars);
1454 1455
        }
    }
1456
    
1457 1458
    # When editing multiple bugs, users can specify a list of keywords to delete
    # from bugs.  If the list matches the current set of keywords on those bugs,
1459 1460
    # Bug::check_can_change_field will fail to check permissions because it thinks
    # the list hasn't changed. To fix that, we have to call Bug::check_can_change_field
1461 1462
    # again with old!=new if the keyword action is "delete" and old=new.
    if ($keywordaction eq "delete"
1463
        && defined $cgi->param('keywords')
1464
        && length(@keywordlist) > 0
1465
        && $cgi->param('keywords') eq $oldhash{keywords}
1466 1467
        && !$old_bug_obj->check_can_change_field("keywords", "old is not", "equal to new",
                                                 \$PrivilegesRequired))
1468 1469 1470 1471
    {
        $vars->{'oldvalue'} = $oldhash{keywords};
        $vars->{'newvalue'} = "no keywords";
        $vars->{'field'} = "keywords";
1472
        $vars->{'privs'} = $PrivilegesRequired;
1473
        ThrowUserError("illegal_change", $vars);
1474 1475
    }

1476
    $oldhash{'product'} = $old_bug_obj->product;
1477
    if (!Bugzilla->user->can_edit_product($oldhash{'product_id'})) {
1478
        ThrowUserError("product_edit_denied",
1479
                      { product => $oldhash{'product'} });
1480 1481
    }

1482
    if ($requiremilestone) {
1483 1484
        # musthavemilestoneonaccept applies only if at least two
        # target milestones are defined for the current product.
1485 1486
        my $prod_obj = new Bugzilla::Product({'name' => $oldhash{'product'}});
        my $nb_milestones = scalar(@{$prod_obj->milestones});
1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498
        if ($nb_milestones > 1) {
            my $value = $cgi->param('target_milestone');
            if (!defined $value || $value eq $cgi->param('dontchange')) {
                $value = $oldhash{'target_milestone'};
            }
            my $defaultmilestone =
                $dbh->selectrow_array("SELECT defaultmilestone
                                       FROM products WHERE id = ?",
                                       undef, $oldhash{'product_id'});
            # if musthavemilestoneonaccept == 1, then the target
            # milestone must be different from the default one.
            if ($value eq $defaultmilestone) {
1499
                ThrowUserError("milestone_required", { bug_id => $id });
1500
            }
1501 1502
        }
    }   
1503 1504
    if (defined $cgi->param('delta_ts') && $cgi->param('delta_ts') ne $delta_ts)
    {
1505 1506
        ($vars->{'operations'}) =
            Bugzilla::Bug::GetBugActivity($id, $cgi->param('delta_ts'));
1507

1508
        $vars->{'start_at'} = $cgi->param('longdesclength');
1509 1510 1511 1512

        # Always sort midair collision comments oldest to newest,
        # regardless of the user's personal preference.
        $vars->{'comments'} = Bugzilla::Bug::GetComments($id, "oldest_to_newest");
1513

1514
        $cgi->param('delta_ts', $delta_ts);
1515 1516 1517
        
        $vars->{'bug_id'} = $id;
        
1518
        $dbh->bz_unlock_tables(UNLOCK_ABORT);
1519 1520
        
        # Warn the user about the mid-air collision and ask them what to do.
1521
        $template->process("bug/process/midair.html.tmpl", $vars)
1522
          || ThrowTemplateError($template->error());
1523 1524 1525
        exit;
    }

1526
    # Gather the dependency list, and make sure there are no circular refs
1527 1528
    my %deps = Bugzilla::Bug::ValidateDependencies(scalar($cgi->param('dependson')),
                                                   scalar($cgi->param('blocked')),
1529
                                                   $id);
1530

1531 1532 1533 1534
    #
    # Start updating the relevant database entries
    #

1535
    $timestamp = $dbh->selectrow_array(q{SELECT NOW()});
1536

1537
    my $work_time;
1538
    if (UserInGroup(Bugzilla->params->{'timetrackinggroup'})) {
1539
        $work_time = $cgi->param('work_time');
1540 1541 1542 1543
        if ($work_time) {
            # AppendComment (called below) can in theory raise an error,
            # but because we've already validated work_time here it's
            # safe to log the entry before adding the comment.
1544
            LogActivityEntry($id, "work_time", "", $work_time,
1545
                             $whoid, $timestamp);
1546 1547 1548
        }
    }

1549
    if ($cgi->param('comment') || $work_time) {
1550 1551
        AppendComment($id, $whoid, scalar($cgi->param('comment')),
                      scalar($cgi->param('commentprivacy')), $timestamp, $work_time);
1552 1553 1554
        $bug_changed = 1;
    }

1555 1556 1557
    if (Bugzilla::Keyword::keyword_count() 
        && defined $cgi->param('keywords')) 
    {
1558 1559 1560 1561 1562
        # There are three kinds of "keywordsaction": makeexact, add, delete.
        # For makeexact, we delete everything, and then add our things.
        # For add, we delete things we're adding (to make sure we don't
        # end up having them twice), and then we add them.
        # For delete, we just delete things on the list.
1563
        my $changed = 0;
1564
        if ($keywordaction eq "makeexact") {
1565 1566
            $dbh->do(q{DELETE FROM keywords WHERE bug_id = ?},
                     undef, $id);
1567
            $changed = 1;
1568
        }
1569 1570 1571 1572 1573 1574
        my $sth_delete = $dbh->prepare(q{DELETE FROM keywords
                                               WHERE bug_id = ?
                                                 AND keywordid = ?});
        my $sth_insert =
            $dbh->prepare(q{INSERT INTO keywords (bug_id, keywordid)
                                 VALUES (?, ?)});
1575 1576
        foreach my $keyword (@keywordlist) {
            if ($keywordaction ne "makeexact") {
1577
                $sth_delete->execute($id, $keyword);
1578
                $changed = 1;
1579 1580
            }
            if ($keywordaction ne "delete") {
1581
                $sth_insert->execute($id, $keyword);
1582 1583 1584 1585
                $changed = 1;
            }
        }
        if ($changed) {
1586 1587 1588 1589 1590 1591 1592 1593
            my $list = $dbh->selectcol_arrayref(
                q{SELECT keyworddefs.name
                    FROM keyworddefs
              INNER JOIN keywords 
                      ON keyworddefs.id = keywords.keywordid
                   WHERE keywords.bug_id = ?
                ORDER BY keyworddefs.name},
                undef, $id);
1594
            $dbh->do("UPDATE bugs SET keywords = ? WHERE bug_id = ?",
1595
                     undef, join(', ', @$list), $id);
1596 1597
        }
    }
1598
    $query .= " WHERE bug_id = ?";
1599
    push(@bug_values, $id);
1600
    
1601
    if ($::comma ne "") {
1602
        $dbh->do($query, undef, @bug_values);
terry%netscape.com's avatar
terry%netscape.com committed
1603
    }
1604

1605
    # Check for duplicates if the bug is [re]open or its resolution is changed.
1606 1607
    my $resolution = $dbh->selectrow_array(
        q{SELECT resolution FROM bugs WHERE bug_id = ?}, undef, $id);
1608
    if ($resolution ne 'DUPLICATE') {
1609
        $dbh->do(q{DELETE FROM duplicates WHERE dupe = ?}, undef, $id);
1610
    }
1611

1612 1613
    my %groupsrequired = ();
    my %groupsforbidden = ();
1614 1615 1616 1617 1618 1619 1620
    my $group_controls =
        $dbh->selectall_arrayref(q{SELECT id, membercontrol
                                     FROM groups
                                LEFT JOIN group_control_map
                                       ON id = group_id
                                      AND product_id = ?
                                    WHERE isactive != 0},
1621
        undef, $oldhash{'product_id'});
1622 1623
    foreach my $group_control (@$group_controls) {
        my ($group, $control) = @$group_control;
1624
        $control ||= 0;
1625
        unless ($control > CONTROLMAPNA)  {
1626 1627
            $groupsforbidden{$group} = 1;
        }
1628
        if ($control == CONTROLMAPMANDATORY) {
1629 1630 1631 1632
            $groupsrequired{$group} = 1;
        }
    }

1633
    my @groupAddNames = ();
1634
    my @groupAddNamesAll = ();
1635 1636
    my $sth = $dbh->prepare(q{INSERT INTO bug_group_map (bug_id, group_id)
                                   VALUES (?, ?)});
1637 1638
    foreach my $grouptoadd (@groupAdd, keys %groupsrequired) {
        next if $groupsforbidden{$grouptoadd};
1639 1640
        my $group_obj = new Bugzilla::Group($grouptoadd);
        push(@groupAddNamesAll, $group_obj->name);
1641
        if (!BugInGroupId($id, $grouptoadd)) {
1642
            push(@groupAddNames, $group_obj->name);
1643
            $sth->execute($id, $grouptoadd);
1644 1645 1646
        }
    }
    my @groupDelNames = ();
1647
    my @groupDelNamesAll = ();
1648 1649
    $sth = $dbh->prepare(q{DELETE FROM bug_group_map
                                 WHERE bug_id = ? AND group_id = ?});
1650
    foreach my $grouptodel (@groupDel, keys %groupsforbidden) {
1651 1652
        my $group_obj = new Bugzilla::Group($grouptodel);
        push(@groupDelNamesAll, $group_obj->name);
1653
        next if $groupsrequired{$grouptodel};
1654
        if (BugInGroupId($id, $grouptodel)) {
1655
            push(@groupDelNames, $group_obj->name);
1656
        }
1657
        $sth->execute($id, $grouptodel);
1658 1659 1660 1661 1662
    }

    my $groupDelNames = join(',', @groupDelNames);
    my $groupAddNames = join(',', @groupAddNames);

1663 1664 1665 1666 1667
    if ($groupDelNames ne $groupAddNames) {
        LogActivityEntry($id, "bug_group", $groupDelNames, $groupAddNames,
                         $whoid, $timestamp); 
        $bug_changed = 1;
    }
1668 1669

    my @ccRemoved = (); 
1670 1671 1672 1673
    if (defined $cgi->param('newcc')
        || defined $cgi->param('addselfcc')
        || defined $cgi->param('removecc')
        || defined $cgi->param('masscc')) {
1674 1675
        # Get the current CC list for this bug
        my %oncc;
1676 1677 1678 1679
        my $cc_list = $dbh->selectcol_arrayref(
            q{SELECT who FROM cc WHERE bug_id = ?}, undef, $id);
        foreach my $who (@$cc_list) {
            $oncc{$who} = 1;
1680 1681
        }

1682
        my (@added, @removed) = ();
1683 1684 1685

        my $sth_insert = $dbh->prepare(q{INSERT INTO cc (bug_id, who)
                                              VALUES (?, ?)});
1686 1687 1688
        foreach my $pid (keys %cc_add) {
            # If this person isn't already on the cc list, add them
            if (! $oncc{$pid}) {
1689
                $sth_insert->execute($id, $pid);
1690 1691
                push (@added, $cc_add{$pid});
                $oncc{$pid} = 1;
1692 1693
            }
        }
1694 1695
        my $sth_delete = $dbh->prepare(q{DELETE FROM cc
                                          WHERE bug_id = ? AND who = ?});
1696 1697 1698
        foreach my $pid (keys %cc_remove) {
            # If the person is on the cc list, remove them
            if ($oncc{$pid}) {
1699
                $sth_delete->execute($id, $pid);
1700 1701
                push (@removed, $cc_remove{$pid});
                $oncc{$pid} = 0;
1702 1703
            }
        }
1704

1705 1706
        # If any changes were found, record it in the activity log
        if (scalar(@removed) || scalar(@added)) {
1707 1708
            my $removed = join(", ", @removed);
            my $added = join(", ", @added);
1709 1710
            LogActivityEntry($id,"cc",$removed,$added,$whoid,$timestamp);
            $bug_changed = 1;
1711
        }
1712
        @ccRemoved = @removed;
1713
    }
1714

1715
    # We need to send mail for dependson/blocked bugs if the dependencies
1716 1717 1718
    # change or the status or resolution change. This var keeps track of that.
    my $check_dep_bugs = 0;

1719 1720 1721 1722 1723 1724
    foreach my $pair ("blocked/dependson", "dependson/blocked") {
        my ($me, $target) = split("/", $pair);

        my @oldlist = @{$dbh->selectcol_arrayref("SELECT $target FROM dependencies
                                                  WHERE $me = ? ORDER BY $target",
                                                  undef, $id)};
1725 1726 1727 1728 1729 1730

        # Only bugs depending on the current one should get notification.
        # Bugs blocking the current one never get notification, unless they
        # are added or removed from the dependency list. This case is treated
        # below.
        @dependencychanged{@oldlist} = 1 if ($me eq 'dependson');
1731

1732
        if (defined $cgi->param($target)) {
1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748
            my %snapshot;
            my @newlist = sort {$a <=> $b} @{$deps{$target}};

            while (0 < @oldlist || 0 < @newlist) {
                if (@oldlist == 0 || (@newlist > 0 &&
                                      $oldlist[0] > $newlist[0])) {
                    $snapshot{$newlist[0]} = SnapShotDeps($newlist[0], $me,
                                                          $target);
                    shift @newlist;
                } elsif (@newlist == 0 || (@oldlist > 0 &&
                                           $newlist[0] > $oldlist[0])) {
                    $snapshot{$oldlist[0]} = SnapShotDeps($oldlist[0], $me,
                                                          $target);
                    shift @oldlist;
                } else {
                    if ($oldlist[0] != $newlist[0]) {
1749
                        ThrowCodeError('list_comparison_error');
1750 1751 1752 1753 1754 1755 1756 1757
                    }
                    shift @oldlist;
                    shift @newlist;
                }
            }
            my @keys = keys(%snapshot);
            if (@keys) {
                my $oldsnap = SnapShotDeps($id, $target, $me);
1758 1759 1760 1761 1762
                $dbh->do(qq{DELETE FROM dependencies WHERE $me = ?},
                         undef, $id);
                my $sth =
                    $dbh->prepare(qq{INSERT INTO dependencies ($me, $target)
                                          VALUES (?, ?)});
1763
                foreach my $i (@{$deps{$target}}) {
1764
                    $sth->execute($id, $i);
1765 1766
                }
                foreach my $k (@keys) {
1767
                    LogDependencyActivity($k, $snapshot{$k}, $me, $target, $timestamp);
1768
                }
1769
                LogDependencyActivity($id, $oldsnap, $target, $me, $timestamp);
1770
                $check_dep_bugs = 1;
1771 1772 1773
                # All bugs added or removed from the dependency list
                # must be notified.
                @dependencychanged{@keys} = 1;
1774 1775 1776 1777
            }
        }
    }

1778 1779 1780 1781 1782
    # When a bug changes products and the old or new product is associated
    # with a bug group, it may be necessary to remove the bug from the old
    # group or add it to the new one.  There are a very specific series of
    # conditions under which these activities take place, more information
    # about which can be found in comments within the conditionals below.
1783
    # Check if the user has changed the product to which the bug belongs;
1784
    if ($cgi->param('product') ne $cgi->param('dontchange')
1785 1786
        && $cgi->param('product') ne $oldhash{'product'})
    {
1787 1788 1789 1790 1791 1792 1793 1794 1795
        # Depending on the "addtonewgroup" variable, groups with
        # defaults will change.
        #
        # For each group, determine
        # - The group id and if it is active
        # - The control map value for the old product and this group
        # - The control map value for the new product and this group
        # - Is the user in this group?
        # - Is the bug in this group?
1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812
        my $groups = $dbh->selectall_arrayref(
            qq{SELECT DISTINCT groups.id, isactive,
                               oldcontrolmap.membercontrol,
                               newcontrolmap.membercontrol,
                      CASE WHEN groups.id IN ($grouplist) THEN 1 ELSE 0 END,
                      CASE WHEN bug_group_map.group_id IS NOT NULL
                                THEN 1 ELSE 0 END
                 FROM groups
            LEFT JOIN group_control_map AS oldcontrolmap
                   ON oldcontrolmap.group_id = groups.id
                  AND oldcontrolmap.product_id = ?
            LEFT JOIN group_control_map AS newcontrolmap
                   ON newcontrolmap.group_id = groups.id
                  AND newcontrolmap.product_id = ?
            LEFT JOIN bug_group_map
                   ON bug_group_map.group_id = groups.id
                  AND bug_group_map.bug_id = ?},
1813
            undef, $oldhash{'product_id'}, $product->id, $id);
1814 1815 1816 1817 1818 1819 1820
        my @groupstoremove = ();
        my @groupstoadd = ();
        my @defaultstoremove = ();
        my @defaultstoadd = ();
        my @allgroups = ();
        my $buginanydefault = 0;
        my $buginanychangingdefault = 0;
1821 1822 1823
        foreach my $group (@$groups) {
            my ($groupid, $isactive, $oldcontrol, $newcontrol,
                   $useringroup, $bugingroup) = @$group;
1824 1825 1826 1827 1828 1829 1830 1831
            # An undefined newcontrol is none.
            $newcontrol = CONTROLMAPNA unless $newcontrol;
            $oldcontrol = CONTROLMAPNA unless $oldcontrol;
            push(@allgroups, $groupid);
            if (($bugingroup) && ($isactive)
                && ($oldcontrol == CONTROLMAPDEFAULT)) {
                # Bug was in a default group.
                $buginanydefault = 1;
1832 1833
                if (($newcontrol != CONTROLMAPDEFAULT)
                    && ($newcontrol != CONTROLMAPMANDATORY)) {
1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851
                    # Bug was in a default group that no longer is.
                    $buginanychangingdefault = 1;
                    push (@defaultstoremove, $groupid);
                }
            }
            if (($isactive) && (!$bugingroup)
                && ($newcontrol == CONTROLMAPDEFAULT)
                && ($useringroup)) {
                push (@defaultstoadd, $groupid);
            }
            if (($bugingroup) && ($isactive) && ($newcontrol == CONTROLMAPNA)) {
                # Group is no longer permitted.
                push(@groupstoremove, $groupid);
            }
            if ((!$bugingroup) && ($isactive) 
                && ($newcontrol == CONTROLMAPMANDATORY)) {
                # Group is now required.
                push(@groupstoadd, $groupid);
1852
            }
1853
        }
1854 1855 1856 1857 1858 1859 1860 1861 1862
        # If addtonewgroups = "yes", old default groups will be removed
        # and new default groups will be added.
        # If addtonewgroups = "yesifinold", old default groups will be removed
        # and new default groups will be added only if the bug was in ANY
        # of the old default groups.
        # If addtonewgroups = "no", old default groups will be removed and not
        # replaced.
        push(@groupstoremove, @defaultstoremove);
        if (AnyDefaultGroups()
1863 1864
            && (($cgi->param('addtonewgroup') eq 'yes')
            || (($cgi->param('addtonewgroup') eq 'yesifinold')
1865 1866
            && ($buginanydefault)))) {
            push(@groupstoadd, @defaultstoadd);
1867 1868
        }

1869 1870 1871
        # Now actually update the bug_group_map.
        my @DefGroupsAdded = ();
        my @DefGroupsRemoved = ();
1872 1873 1874 1875 1876 1877
        my $sth_insert =
            $dbh->prepare(q{INSERT INTO bug_group_map (bug_id, group_id)
                                 VALUES (?, ?)});
        my $sth_delete = $dbh->prepare(q{DELETE FROM bug_group_map
                                               WHERE bug_id = ?
                                                 AND group_id = ?});
1878 1879 1880 1881
        foreach my $groupid (@allgroups) {
            my $thisadd = grep( ($_ == $groupid), @groupstoadd);
            my $thisdel = grep( ($_ == $groupid), @groupstoremove);
            if ($thisadd) {
1882 1883
                my $group_obj = new Bugzilla::Group($groupid);
                push(@DefGroupsAdded, $group_obj->name);
1884
                $sth_insert->execute($id, $groupid);
1885
            } elsif ($thisdel) {
1886 1887
                my $group_obj = new Bugzilla::Group($groupid);
                push(@DefGroupsRemoved, $group_obj->name);
1888
                $sth_delete->execute($id, $groupid);
1889 1890 1891 1892 1893 1894 1895 1896
            }
        }
        if ((@DefGroupsAdded) || (@DefGroupsRemoved)) {
            LogActivityEntry($id, "bug_group",
                join(', ', @DefGroupsRemoved),
                join(', ', @DefGroupsAdded),
                     $whoid, $timestamp); 
        }
1897 1898
    }
  
1899 1900 1901 1902
    # get a snapshot of the newly set values out of the database, 
    # and then generate any necessary bug activity entries by seeing 
    # what has changed since before we wrote out the new values.
    #
1903
    my $new_bug_obj = new Bugzilla::Bug($id);
1904
    my @newvalues = SnapShotBug($id);
1905 1906
    my %newhash;
    $i = 0;
1907
    foreach my $col (@editable_bug_fields) {
1908
        # Consider NULL db entries to be equivalent to the empty string
1909
        $newvalues[$i] = defined($newvalues[$i]) ? $newvalues[$i] : '';
1910 1911 1912 1913
        # Convert the deadline to the YYYY-MM-DD format.
        if ($col eq 'deadline') {
            $newvalues[$i] = format_time($newvalues[$i], "%Y-%m-%d");
        }
1914 1915 1916
        $newhash{$col} = $newvalues[$i];
        $i++;
    }
1917
    # for passing to Bugzilla::BugMail to ensure that when someone is removed
1918 1919 1920 1921
    # from one of these fields, they get notified of that fact (if desired)
    #
    my $origOwner = "";
    my $origQaContact = "";
1922 1923 1924 1925

    # $msgs will store emails which have to be sent to voters, if any.
    my $msgs;

1926
    foreach my $c (@editable_bug_fields) {
1927 1928
        my $col = $c;           # We modify it, don't want to modify array
                                # values in place.
1929 1930 1931
        my $old = shift @oldvalues;
        my $new = shift @newvalues;
        if ($old ne $new) {
1932

1933 1934 1935
            # Products and components are now stored in the DB using ID's
            # We need to translate this to English before logging it
            if ($col eq 'product_id') {
1936 1937
                $old = $old_bug_obj->product;
                $new = $new_bug_obj->product;
1938 1939 1940
                $col = 'product';
            }
            if ($col eq 'component_id') {
1941 1942
                $old = $old_bug_obj->component;
                $new = $new_bug_obj->component;
1943 1944 1945
                $col = 'component';
            }

1946
            # save off the old value for passing to Bugzilla::BugMail so
1947
            # the old assignee can be notified
1948 1949
            #
            if ($col eq 'assigned_to') {
1950 1951
                $old = ($old) ? user_id_to_login($old) : "";
                $new = ($new) ? user_id_to_login($new) : "";
1952 1953 1954 1955 1956 1957
                $origOwner = $old;
            }

            # ditto for the old qa contact
            #
            if ($col eq 'qa_contact') {
1958 1959
                $old = ($old) ? user_id_to_login($old) : "";
                $new = ($new) ? user_id_to_login($new) : "";
1960
                $origQaContact = $old;
terry%netscape.com's avatar
terry%netscape.com committed
1961
            }
1962

1963 1964
            # If this is the keyword field, only record the changes, not everything.
            if ($col eq 'keywords') {
1965
                ($old, $new) = diff_strings($old, $new);
1966 1967
            }

1968
            if ($col eq 'product') {
1969 1970 1971 1972 1973
                # If some votes have been removed, RemoveVotes() returns
                # a list of messages to send to voters.
                # We delay the sending of these messages till tables are unlocked.
                $msgs = RemoveVotes($id, 0,
                          "This bug has been moved to a different product");
1974
            }
1975

1976
            if ($col eq 'bug_status' 
1977
                && is_open_state($old) ne is_open_state($new))
1978 1979 1980
            {
                $check_dep_bugs = 1;
            }
1981

1982 1983
            LogActivityEntry($id,$col,$old,$new,$whoid,$timestamp);
            $bug_changed = 1;
terry%netscape.com's avatar
terry%netscape.com committed
1984 1985
        }
    }
1986
    # Set and update flags.
1987
    Bugzilla::Flag::process($new_bug_obj, undef, $timestamp, $cgi);
1988

1989
    if ($bug_changed) {
1990 1991
        $dbh->do(q{UPDATE bugs SET delta_ts = ? WHERE bug_id = ?},
                 undef, $timestamp, $id);
1992
    }
1993
    $dbh->bz_unlock_tables();
1994

1995 1996
    # Now is a good time to send email to voters.
    foreach my $msg (@$msgs) {
1997
        MessageToMTA($msg);
1998 1999
    }

2000
    if ($duplicate) {
2001 2002 2003 2004 2005
        # If the bug was already marked as a duplicate, remove
        # the existing entry.
        $dbh->do('DELETE FROM duplicates WHERE dupe = ?',
                  undef, $cgi->param('id'));

2006
        # Check to see if Reporter of this bug is reporter of Dupe 
2007 2008 2009 2010 2011 2012 2013 2014
        my $reporter = $dbh->selectrow_array(
            q{SELECT reporter FROM bugs WHERE bug_id = ?}, undef, $id);
        my $isreporter = $dbh->selectrow_array(
            q{SELECT reporter FROM bugs WHERE bug_id = ? AND reporter = ?},
            undef, $duplicate, $reporter);
        my $isoncc = $dbh->selectrow_array(q{SELECT who FROM cc
                                           WHERE bug_id = ? AND who = ?},
                                           undef, $duplicate, $reporter);
2015 2016
        unless ($isreporter || $isoncc
                || !$cgi->param('confirm_add_duplicate')) {
matty%chariot.net.au's avatar
matty%chariot.net.au committed
2017
            # The reporter is oblivious to the existence of the new bug and is permitted access
2018
            # ... add 'em to the cc (and record activity)
2019
            LogActivityEntry($duplicate,"cc","",user_id_to_login($reporter),
2020
                             $whoid,$timestamp);
2021 2022
            $dbh->do(q{INSERT INTO cc (who, bug_id) VALUES (?, ?)},
                     undef, $reporter, $duplicate);
2023
        }
2024
        # Bug 171639 - Duplicate notifications do not need to be private. 
2025
        AppendComment($duplicate, $whoid,
2026 2027
                      "*** Bug " . $cgi->param('id') .
                      " has been marked as a duplicate of this bug. ***",
2028 2029
                      0, $timestamp);

2030 2031
        $dbh->do(q{INSERT INTO duplicates VALUES (?, ?)}, undef,
                 $duplicate, $cgi->param('id'));
2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043
    }

    # Now all changes to the DB have been made. It's time to email
    # all concerned users, including the bug itself, but also the
    # duplicated bug and dependent bugs, if any.

    $vars->{'mailrecipients'} = { 'cc' => \@ccRemoved,
                                  'owner' => $origOwner,
                                  'qacontact' => $origQaContact,
                                  'changer' => Bugzilla->user->login };

    $vars->{'id'} = $id;
2044
    $vars->{'type'} = "bug";
2045 2046 2047 2048 2049 2050 2051 2052
    
    # Let the user know the bug was changed and who did and didn't
    # receive email about the change.
    $template->process("bug/process/results.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
    $vars->{'header_done'} = 1;
    
    if ($duplicate) {
2053
        $vars->{'mailrecipients'} = { 'changer' => Bugzilla->user->login }; 
2054

2055 2056 2057 2058
        $vars->{'id'} = $duplicate;
        $vars->{'type'} = "dupe";
        
        # Let the user know a duplication notation was added to the original bug.
2059
        $template->process("bug/process/results.html.tmpl", $vars)
2060
          || ThrowTemplateError($template->error());
2061
        $vars->{'header_done'} = 1;
2062 2063
    }

2064 2065
    if ($check_dep_bugs) {
        foreach my $k (keys(%dependencychanged)) {
2066
            $vars->{'mailrecipients'} = { 'changer' => Bugzilla->user->login }; 
2067 2068 2069
            $vars->{'id'} = $k;
            $vars->{'type'} = "dep";

2070 2071 2072
            # Let the user (if he is able to see the bug) know we checked to see 
            # if we should email notice of this change to users with a relationship
            # to the dependent bug and who did and didn't receive email about it.
2073 2074
            $template->process("bug/process/results.html.tmpl", $vars)
              || ThrowTemplateError($template->error());
2075
            $vars->{'header_done'} = 1;
2076
        }
2077
    }
terry%netscape.com's avatar
terry%netscape.com committed
2078 2079
}

2080 2081 2082 2083 2084 2085
# Determine if Patch Viewer is installed, for Diff link
# (NB: Duplicate code with show_bug.cgi.)
eval {
    require PatchReader;
    $vars->{'patchviewerinstalled'} = 1;
};
2086

2087 2088 2089 2090 2091 2092
if (defined $cgi->param('id')) {
    $action = Bugzilla->user->settings->{'post_bug_submit_action'}->{'value'};
} else {
    # param('id') is not defined when changing multiple bugs
    $action = 'nothing';
}
2093

2094 2095 2096 2097 2098 2099 2100 2101
if ($action eq 'next_bug') {
    my $next_bug;
    my $cur = lsearch(\@bug_list, $cgi->param("id"));
    if ($cur >= 0 && $cur < $#bug_list) {
        $next_bug = $bug_list[$cur + 1];
    }
    if ($next_bug) {
        if (detaint_natural($next_bug) && Bugzilla->user->can_see_bug($next_bug)) {
2102
            my $bug = new Bugzilla::Bug($next_bug);
2103
            ThrowCodeError("bug_error", { bug => $bug }) if $bug->error;
2104

2105 2106
            $vars->{'bugs'} = [$bug];
            $vars->{'nextbug'} = $bug->bug_id;
2107

2108 2109 2110 2111 2112
            $template->process("bug/show.html.tmpl", $vars)
              || ThrowTemplateError($template->error());

            exit;
        }
2113
    }
2114
} elsif ($action eq 'same_bug') {
2115
    if (Bugzilla->user->can_see_bug($cgi->param('id'))) {
2116
        my $bug = new Bugzilla::Bug($cgi->param('id'));
2117
        ThrowCodeError("bug_error", { bug => $bug }) if $bug->error;
2118

2119
        $vars->{'bugs'} = [$bug];
2120

2121 2122
        $template->process("bug/show.html.tmpl", $vars)
          || ThrowTemplateError($template->error());
2123

2124 2125
        exit;
    }
2126 2127
} elsif ($action ne 'nothing') {
    ThrowCodeError("invalid_post_bug_submit_action");
terry%netscape.com's avatar
terry%netscape.com committed
2128
}
2129

2130
# End the response page.
2131
$template->process("bug/navigate.html.tmpl", $vars)
2132
  || ThrowTemplateError($template->error());
2133
$template->process("global/footer.html.tmpl", $vars)
2134
  || ThrowTemplateError($template->error());