attachment.cgi 29.1 KB
Newer Older
1
#!/usr/bin/perl -T
2 3 4
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
5
#
6 7
# This Source Code Form is "Incompatible With Secondary Licenses", as
# defined by the Mozilla Public License, v. 2.0.
8

9
use 5.10.1;
10
use strict;
11 12
use warnings;

13
use lib qw(. lib);
14

15
use Bugzilla;
16
use Bugzilla::BugMail;
17
use Bugzilla::Constants;
18
use Bugzilla::Error;
19 20
use Bugzilla::Flag; 
use Bugzilla::FlagType; 
21
use Bugzilla::User;
22
use Bugzilla::Util;
23
use Bugzilla::Bug;
24
use Bugzilla::Attachment;
25
use Bugzilla::Attachment::PatchReader;
26
use Bugzilla::Token;
27

28
use Encode qw(encode find_encoding);
29

30 31 32 33 34 35 36
# For most scripts we don't make $cgi and $template global variables. But
# when preparing Bugzilla for mod_perl, this script used these
# variables in so many subroutines that it was easier to just
# make them globals.
local our $cgi = Bugzilla->cgi;
local our $template = Bugzilla->template;
local our $vars = {};
37

38 39 40 41
# All calls to this script should contain an "action" variable whose
# value determines what the user wants to do.  The code below checks
# the value of that variable and runs the appropriate code. If none is
# supplied, we default to 'view'.
42 43

# Determine whether to use the action specified by the user or the default.
44
my $action = $cgi->param('action') || 'view';
45
my $format = $cgi->param('format') || '';
46

47
# You must use the appropriate urlbase/sslbase param when doing anything
48 49 50 51
# but viewing an attachment, or a raw diff.
if ($action ne 'view'
    && (($action !~ /^(?:interdiff|diff)$/) || $format ne 'raw'))
{
52 53
    do_ssl_redirect_if_required();
    if ($cgi->url_is_attachment_base) {
54 55 56 57 58 59 60 61
        $cgi->redirect_to_urlbase;
    }
    Bugzilla->login();
}

# When viewing an attachment, do not request credentials if we are on
# the alternate host. Let view() decide when to call Bugzilla->login.
if ($action eq "view")
62
{
63
    view();
64
}
65 66
elsif ($action eq "interdiff")
{
67
    interdiff();
68 69 70
}
elsif ($action eq "diff")
{
71
    diff();
72
}
73 74
elsif ($action eq "viewall") 
{ 
75
    viewall(); 
76
}
77 78
elsif ($action eq "enter") 
{ 
79 80
    Bugzilla->login(LOGIN_REQUIRED);
    enter(); 
81 82 83
}
elsif ($action eq "insert")
{
84 85
    Bugzilla->login(LOGIN_REQUIRED);
    insert();
86
}
87 88
elsif ($action eq "edit") 
{ 
89
    edit(); 
90 91 92
}
elsif ($action eq "update") 
{ 
93 94
    Bugzilla->login(LOGIN_REQUIRED);
    update();
95
}
96 97 98
elsif ($action eq "delete") {
    delete_attachment();
}
99 100
else 
{ 
101
  ThrowUserError('unknown_action', {action => $action});
102 103 104 105 106 107 108 109
}

exit;

################################################################################
# Data Validation / Security Authorization
################################################################################

110 111 112
# Validates an attachment ID. Optionally takes a parameter of a form
# variable name that contains the ID to be validated. If not specified,
# uses 'id'.
113 114
# If the second parameter is true, the attachment ID will be validated,
# however the current user's access to the attachment will not be checked.
115 116 117 118
# Will throw an error if 1) attachment ID is not a valid number,
# 2) attachment does not exist, or 3) user isn't allowed to access the
# attachment.
#
119 120 121
# Returns an attachment object.

sub validateID {
122 123
    my($param, $dont_validate_access) = @_;
    $param ||= 'id';
124

125 126 127
    # If we're not doing interdiffs, check if id wasn't specified and
    # prompt them with a page that allows them to choose an attachment.
    # Happens when calling plain attachment.cgi from the urlbar directly
128
    if ($param eq 'id' && !$cgi->param('id')) {
129
        print $cgi->header();
130 131 132 133
        $template->process("attachment/choose.html.tmpl", $vars) ||
            ThrowTemplateError($template->error());
        exit;
    }
134
    
135 136 137 138 139 140
    my $attach_id = $cgi->param($param);

    # Validate the specified attachment id. detaint kills $attach_id if
    # non-natural, so use the original value from $cgi in our exception
    # message here.
    detaint_natural($attach_id)
141 142
        || ThrowUserError("invalid_attach_id",
                          { attach_id => scalar $cgi->param($param) });
143
  
144
    # Make sure the attachment exists in the database.
145
    my $attachment = new Bugzilla::Attachment({ id => $attach_id, cache => 1 })
146
        || ThrowUserError("invalid_attach_id", { attach_id => $attach_id });
147

148 149 150 151 152 153 154 155
    return $attachment if ($dont_validate_access || check_can_access($attachment));
}

# Make sure the current user has access to the specified attachment.
sub check_can_access {
    my $attachment = shift;
    my $user = Bugzilla->user;

156
    # Make sure the user is authorized to access this attachment's bug.
157
    Bugzilla::Bug->check({ id => $attachment->bug_id, cache => 1 });
158 159 160
    if ($attachment->isprivate && $user->id != $attachment->attacher->id 
        && !$user->is_insider) 
    {
161
        ThrowUserError('auth_failure', {action => 'access',
162 163
                                        object => 'attachment',
                                        attach_id => $attachment->id});
164
    }
165 166 167 168 169 170 171 172 173 174 175 176 177
    return 1;
}

# Determines if the attachment is public -- that is, if users who are
# not logged in have access to the attachment
sub attachmentIsPublic {
    my $attachment = shift;

    return 0 if Bugzilla->params->{'requirelogin'};
    return 0 if $attachment->isprivate;

    my $anon_user = new Bugzilla::User;
    return $anon_user->can_see_bug($attachment->bug_id);
178 179
}

180 181 182
# Validates format of a diff/interdiff. Takes a list as an parameter, which
# defines the valid format values. Will throw an error if the format is not
# in the list. Returns either the user selected or default format.
183
sub validateFormat {
184 185
  # receives a list of legal formats; first item is a default
  my $format = $cgi->param('format') || $_[0];
186
  if (not grep($_ eq $format, @_)) {
187
     ThrowUserError("invalid_format", { format  => $format, formats => \@_ });
188
  }
189

190
  return $format;
191 192
}

193 194
# Validates context of a diff/interdiff. Will throw an error if the context
# is not number, "file" or "patch". Returns the validated, detainted context.
195 196
sub validateContext
{
197 198 199 200
  my $context = $cgi->param('context') || "patch";
  if ($context ne "file" && $context ne "patch") {
    detaint_natural($context)
      || ThrowUserError("invalid_context", { context => $cgi->param('context') });
201
  }
202 203

  return $context;
204 205
}

206 207 208 209
# Gets the attachment object(s) generated by validateID, while ensuring
# attachbase and token authentication is used when required.
sub get_attachment {
    my @field_names = @_ ? @_ : qw(id);
210

211
    my %attachments;
212 213

    if (use_attachbase()) {
214 215 216 217 218 219 220 221 222 223
        # Load each attachment, and ensure they are all from the same bug
        my $bug_id = 0;
        foreach my $field_name (@field_names) {
            my $attachment = validateID($field_name, 1);
            if (!$bug_id) {
                $bug_id = $attachment->bug_id;
            } elsif ($attachment->bug_id != $bug_id) {
                ThrowUserError('attachment_bug_id_mismatch');
            }
            $attachments{$field_name} = $attachment;
224
        }
225 226 227 228 229
        my @args = map { $_ . '=' . $attachments{$_}->id } @field_names;
        my $cgi_params = $cgi->canonicalise_query(@field_names, 't',
            'Bugzilla_login', 'Bugzilla_password');
        push(@args, $cgi_params) if $cgi_params;
        my $path = 'attachment.cgi?' . join('&', @args);
230 231

        # Make sure the attachment is served from the correct server.
232 233 234
        if ($cgi->url_is_attachment_base($bug_id)) {
            # No need to validate the token for public attachments. We cannot request
            # credentials as we are on the alternate host.
235
            if (!all_attachments_are_public(\%attachments)) {
236
                my $token = $cgi->param('t');
237 238 239 240 241 242 243 244 245 246 247 248 249 250
                my ($userid, undef, $token_data) = Bugzilla::Token::GetTokenData($token);
                my %token_data = unpack_token_data($token_data);
                my $valid_token = 1;
                foreach my $field_name (@field_names) {
                    my $token_id = $token_data{$field_name};
                    if (!$token_id
                        || !detaint_natural($token_id)
                        || $attachments{$field_name}->id != $token_id)
                    {
                        $valid_token = 0;
                        last;
                    }
                }
                unless ($userid && $valid_token) {
251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268
                    # Not a valid token.
                    print $cgi->redirect('-location' => correct_urlbase() . $path);
                    exit;
                }
                # Change current user without creating cookies.
                Bugzilla->set_user(new Bugzilla::User($userid));
                # Tokens are single use only, delete it.
                delete_token($token);
            }
        }
        elsif ($cgi->url_is_attachment_base) {
            # If we come here, this means that each bug has its own host
            # for attachments, and that we are trying to view one attachment
            # using another bug's host. That's not desired.
            $cgi->redirect_to_urlbase;
        }
        else {
            # We couldn't call Bugzilla->login earlier as we first had to
269 270
            # make sure we were not going to request credentials on the
            # alternate host.
271
            Bugzilla->login();
272 273 274 275
            my $attachbase = Bugzilla->params->{'attachment_base'};
            # Replace %bugid% by the ID of the bug the attachment 
            # belongs to, if present.
            $attachbase =~ s/\%bugid\%/$bug_id/;
276
            if (all_attachments_are_public(\%attachments)) {
277 278 279 280 281
                # No need for a token; redirect to attachment base.
                print $cgi->redirect(-location => $attachbase . $path);
                exit;
            } else {
                # Make sure the user can view the attachment.
282 283 284
                foreach my $field_name (@field_names) {
                    check_can_access($attachments{$field_name});
                }
285
                # Create a token and redirect.
286
                my $token = url_quote(issue_session_token(pack_token_data(\%attachments)));
287 288 289 290 291
                print $cgi->redirect(-location => $attachbase . "$path&t=$token");
                exit;
            }
        }
    } else {
292
        do_ssl_redirect_if_required();
293 294
        # No alternate host is used. Request credentials if required.
        Bugzilla->login();
295 296 297
        foreach my $field_name (@field_names) {
            $attachments{$field_name} = validateID($field_name);
        }
298 299
    }

300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337
    return wantarray
        ? map { $attachments{$_} } @field_names
        : $attachments{$field_names[0]};
}

sub all_attachments_are_public {
    my $attachments = shift;
    foreach my $field_name (keys %$attachments) {
        if (!attachmentIsPublic($attachments->{$field_name})) {
            return 0;
        }
    }
    return 1;
}

sub pack_token_data {
    my $attachments = shift;
    return join(' ', map { $_ . '=' . $attachments->{$_}->id } keys %$attachments);
}

sub unpack_token_data {
    my @token_data = split(/ /, shift || '');
    my %data;
    foreach my $token (@token_data) {
        my ($field_name, $attach_id) = split('=', $token);
        $data{$field_name} = $attach_id;
    }
    return %data;
}

################################################################################
# Functions
################################################################################

# Display an attachment.
sub view {
    my $attachment = get_attachment();

338
    # At this point, Bugzilla->login has been called if it had to.
339 340 341
    my $contenttype = $attachment->contenttype;
    my $filename = $attachment->filename;

342 343
    # Bug 111522: allow overriding content-type manually in the posted form
    # params.
344 345
    if (defined $cgi->param('content_type')) {
        $contenttype = $attachment->_check_content_type($cgi->param('content_type'));
346
    }
347

348
    # Return the appropriate HTTP response headers.
349
    $attachment->datasize || ThrowUserError("attachment_removed");
350

351
    $filename =~ s/^.*[\/\\]//;
352 353 354 355
    # escape quotes and backslashes in the filename, per RFCs 2045/822
    $filename =~ s/\\/\\\\/g; # escape backslashes
    $filename =~ s/"/\\"/g; # escape quotes

356 357 358 359 360
    # Avoid line wrapping done by Encode, which we don't need for HTTP
    # headers. See discussion in bug 328628 for details.
    local $Encode::Encoding{'MIME-Q'}->{'bpl'} = 10000;
    $filename = encode('MIME-Q', $filename);

361 362
    my $disposition = Bugzilla->params->{'allow_attachment_display'} ? 'inline' : 'attachment';

363 364 365 366 367 368 369
    # Don't send a charset header with attachments--they might not be UTF-8.
    # However, we do allow people to explicitly specify a charset if they
    # want.
    if ($contenttype !~ /\bcharset=/i) {
        # In order to prevent Apache from adding a charset, we have to send a
        # charset that's a single space.
        $cgi->charset(' ');
370 371 372 373 374 375
        if (Bugzilla->feature('detect_charset') && $contenttype =~ /^text\//) {
            my $encoding = detect_encoding($attachment->data);
            if ($encoding) {
                $cgi->charset(find_encoding($encoding)->mime_name);
            }
        }
376
    }
377
    print $cgi->header(-type=>"$contenttype; name=\"$filename\"",
378
                       -content_disposition=> "$disposition; filename=\"$filename\"",
379
                       -content_length => $attachment->datasize);
380
    disable_utf8();
381
    print $attachment->data;
382 383
}

384 385 386
sub interdiff {
    # Retrieve and validate parameters
    my $format = validateFormat('html', 'raw');
387 388 389 390 391 392 393
    my($old_attachment, $new_attachment);
    if ($format eq 'raw') {
        ($old_attachment, $new_attachment) = get_attachment('oldid', 'newid');
    } else {
        $old_attachment = validateID('oldid');
        $new_attachment = validateID('newid');
    }
394 395 396 397
    my $context = validateContext();

    Bugzilla::Attachment::PatchReader::process_interdiff(
        $old_attachment, $new_attachment, $format, $context);
398 399
}

400 401 402
sub diff {
    # Retrieve and validate parameters
    my $format = validateFormat('html', 'raw');
403
    my $attachment = $format eq 'raw' ? get_attachment() : validateID();
404
    my $context = validateContext();
405

406 407 408 409
    # If it is not a patch, view normally.
    if (!$attachment->ispatch) {
        view();
        return;
410 411
    }

412
    Bugzilla::Attachment::PatchReader::process_diff($attachment, $format, $context);
413
}
414

415 416
# Display all attachments for a given bug in a series of IFRAMEs within one
# HTML page.
417
sub viewall {
418
    # Retrieve and validate parameters
419
    my $bug = Bugzilla::Bug->check({ id => scalar $cgi->param('bugid'), cache => 1 });
420

421
    my $attachments = Bugzilla::Attachment->get_attachments_by_bug($bug);
422 423
    # Ignore deleted attachments.
    @$attachments = grep { $_->datasize } @$attachments;
424

425 426 427 428 429
    if ($cgi->param('hide_obsolete')) {
        @$attachments = grep { !$_->isobsolete } @$attachments;
        $vars->{'hide_obsolete'} = 1;
    }

430 431 432
    # Define the variables and functions that will be passed to the UI template.
    $vars->{'bug'} = $bug;
    $vars->{'attachments'} = $attachments;
433

434
    print $cgi->header();
435

436 437 438
    # Generate and return the UI (HTML page) from the appropriate template.
    $template->process("attachment/show-multiple.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
439 440
}

441
# Display a form for entering a new attachment.
442
sub enter {
443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480
    # Retrieve and validate parameters
    my $bug = Bugzilla::Bug->check(scalar $cgi->param('bugid'));
    my $bugid = $bug->id;
    Bugzilla::Attachment->_check_bug($bug);
    my $dbh = Bugzilla->dbh;
    my $user = Bugzilla->user;

    # Retrieve the attachments the user can edit from the database and write
    # them into an array of hashes where each hash represents one attachment.
  
    my ($can_edit, $not_private) = ('', '');
    if (!$user->in_group('editbugs', $bug->product_id)) {
        $can_edit = "AND submitter_id = " . $user->id;
    }
    if (!$user->is_insider) {
        $not_private = "AND isprivate = 0";
    }
    my $attach_ids = $dbh->selectcol_arrayref(
        "SELECT attach_id
           FROM attachments
          WHERE bug_id = ?
                AND isobsolete = 0
                $can_edit $not_private
       ORDER BY attach_id",
         undef, $bugid);

    # Define the variables and functions that will be passed to the UI template.
    $vars->{'bug'} = $bug;
    $vars->{'attachments'} = Bugzilla::Attachment->new_from_list($attach_ids);

    my $flag_types = Bugzilla::FlagType::match({
        'target_type'  => 'attachment',
        'product_id'   => $bug->product_id,
        'component_id' => $bug->component_id
    });
    $vars->{'flag_types'} = $flag_types;
    $vars->{'any_flags_requesteeble'} =
        grep { $_->is_requestable && $_->is_requesteeble } @$flag_types;
481
    $vars->{'token'} = issue_session_token('create_attachment');
482 483 484 485 486 487

    print $cgi->header();

    # Generate and return the UI (HTML page) from the appropriate template.
    $template->process("attachment/create.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
488 489
}

490
# Insert a new attachment into the database.
491
sub insert {
492 493
    my $dbh = Bugzilla->dbh;
    my $user = Bugzilla->user;
494

495 496
    $dbh->bz_start_transaction;

497
    # Retrieve and validate parameters
498 499
    my $bug = Bugzilla::Bug->check(scalar $cgi->param('bugid'));
    my $bugid = $bug->id;
500
    my ($timestamp) = $dbh->selectrow_array("SELECT NOW()");
501

502 503
    # Detect if the user already used the same form to submit an attachment
    my $token = trim($cgi->param('token'));
504
    check_token_data($token, 'create_attachment', 'index.cgi');
505

506 507 508 509 510 511 512 513 514 515
    # Check attachments the user tries to mark as obsolete.
    my @obsolete_attachments;
    if ($cgi->param('obsolete')) {
        my @obsolete = $cgi->param('obsolete');
        @obsolete_attachments = Bugzilla::Attachment->validate_obsolete($bug, \@obsolete);
    }

    # Must be called before create() as it may alter $cgi->param('ispatch').
    my $content_type = Bugzilla::Attachment::get_content_type();

516 517 518
    # Get the filehandle of the attachment.
    my $data_fh = $cgi->upload('data');

519 520 521
    my $attachment = Bugzilla::Attachment->create(
        {bug           => $bug,
         creation_ts   => $timestamp,
522
         data          => scalar $cgi->param('attach_text') || $data_fh,
523
         description   => scalar $cgi->param('description'),
524
         filename      => $cgi->param('attach_text') ? "file_$bugid.txt" : scalar $cgi->upload('data'),
525 526 527 528 529
         ispatch       => scalar $cgi->param('ispatch'),
         isprivate     => scalar $cgi->param('isprivate'),
         mimetype      => $content_type,
         });

530 531 532
    # Delete the token used to create this attachment.
    delete_token($token);

533
    foreach my $obsolete_attachment (@obsolete_attachments) {
534 535
        $obsolete_attachment->set_is_obsolete(1);
        $obsolete_attachment->update($timestamp);
536
    }
537

538 539 540 541 542
    my ($flags, $new_flags) = Bugzilla::Flag->extract_flags_from_cgi(
                                  $bug, $attachment, $vars, SKIP_REQUESTEE_ON_ERROR);
    $attachment->set_flags($flags, $new_flags);
    $attachment->update($timestamp);

543
    # Insert a comment about the new attachment into the database.
544
    my $comment = $cgi->param('comment');
545
    $comment = '' unless defined $comment;
546 547 548
    $bug->add_comment($comment, { isprivate => $attachment->isprivate,
                                  type => CMT_ATTACHMENT_CREATED,
                                  extra_data => $attachment->id });
549

550
  # Assign the bug to the user, if they are allowed to take it
551
  my $owner = "";
552
  if ($cgi->param('takebug') && $user->in_group('editbugs', $bug->product_id)) {
553 554 555 556 557
      # When taking a bug, we have to follow the workflow.
      my $bug_status = $cgi->param('bug_status') || '';
      ($bug_status) = grep {$_->name eq $bug_status} @{$bug->status->can_change_to};

      if ($bug_status && $bug_status->is_open
558 559
          && ($bug_status->name ne 'UNCONFIRMED' 
              || $bug->product_obj->allows_unconfirmed))
560
      {
561
          $bug->set_bug_status($bug_status->name);
562 563
          $bug->clear_resolution();
      }
564
      # Make sure the person we are taking the bug from gets mail.
565
      $owner = $bug->assigned_to->login;
566
      $bug->set_assigned_to($user);
567
  }
568 569

  $bug->add_cc($user) if $cgi->param('addselfcc');
570 571 572
  $bug->update($timestamp);

  $dbh->bz_commit_transaction;
573

574
  # Define the variables and functions that will be passed to the UI template.
575
  $vars->{'attachment'} = $attachment;
576 577 578 579
  # We cannot reuse the $bug object as delta_ts has eventually been updated
  # since the object was created.
  $vars->{'bugs'} = [new Bugzilla::Bug($bugid)];
  $vars->{'header_done'} = 1;
580
  $vars->{'contenttypemethod'} = $cgi->param('contenttypemethod');
581

582
  my $recipients =  { 'changer' => $user, 'owner' => $owner };
583 584
  $vars->{'sent_bugmail'} = Bugzilla::BugMail::Send($bugid, $recipients);

585
  print $cgi->header();
586
  # Generate and return the UI (HTML page) from the appropriate template.
587 588
  $template->process("attachment/created.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
589 590
}

591 592 593 594
# Displays a form for editing attachment properties.
# Any user is allowed to access this page, unless the attachment
# is private and the user does not belong to the insider group.
# Validations are done later when the user submits changes.
595
sub edit {
596
  my $attachment = validateID();
597

598
  my $bugattachments =
599
      Bugzilla::Attachment->get_attachments_by_bug($attachment->bug);
600

601 602 603 604 605 606
  my $any_flags_requesteeble =
    grep { $_->is_requestable && $_->is_requesteeble } @{$attachment->flag_types};
  # Useful in case a flagtype is no longer requestable but a requestee
  # has been set before we turned off that bit.
  $any_flags_requesteeble ||= grep { $_->requestee_id } @{$attachment->flags};
  $vars->{'any_flags_requesteeble'} = $any_flags_requesteeble;
607
  $vars->{'attachment'} = $attachment;
608
  $vars->{'attachments'} = $bugattachments;
609

610
  print $cgi->header();
611 612

  # Generate and return the UI (HTML page) from the appropriate template.
613 614
  $template->process("attachment/edit.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
615 616
}

617 618
# Updates an attachment record. Only users with "editbugs" privileges,
# (or the original attachment's submitter) can edit the attachment.
619
# Users cannot edit the content of the attachment itself.
620
sub update {
621 622
    my $user = Bugzilla->user;
    my $dbh = Bugzilla->dbh;
623

624 625 626
    # Start a transaction in preparation for updating the attachment.
    $dbh->bz_start_transaction();

627
    # Retrieve and validate parameters
628
    my $attachment = validateID();
629 630
    my $bug = $attachment->bug;
    $attachment->_check_bug;
631
    my $can_edit = $attachment->validate_can_edit;
632 633 634 635 636 637 638 639 640 641

    if ($can_edit) {
        $attachment->set_description(scalar $cgi->param('description'));
        $attachment->set_is_patch(scalar $cgi->param('ispatch'));
        $attachment->set_content_type(scalar $cgi->param('contenttypeentry'));
        $attachment->set_is_obsolete(scalar $cgi->param('isobsolete'));
        $attachment->set_is_private(scalar $cgi->param('isprivate'));
        $attachment->set_filename(scalar $cgi->param('filename'));

        # Now make sure the attachment has not been edited since we loaded the page.
642 643
        my $delta_ts = $cgi->param('delta_ts');
        my $modification_time = $attachment->modification_time;
644

645 646 647 648
        if ($delta_ts && $delta_ts ne $modification_time) {
            datetime_from($delta_ts)
              or ThrowCodeError('invalid_timestamp', { timestamp => $delta_ts });
            ($vars->{'operations'}) = $bug->get_activity($attachment->id, $delta_ts);
649 650 651 652 653

            # If the modification date changed but there is no entry in
            # the activity table, this means someone commented only.
            # In this case, there is no reason to midair.
            if (scalar(@{$vars->{'operations'}})) {
654 655 656 657
                $cgi->param('delta_ts', $modification_time);
                # The token contains the old modification_time. We need a new one.
                $cgi->param('token', issue_hash_token([$attachment->id, $modification_time]));

658 659 660 661 662 663 664 665
                $vars->{'attachment'} = $attachment;

                print $cgi->header();
                # Warn the user about the mid-air collision and ask them what to do.
                $template->process("attachment/midair.html.tmpl", $vars)
                  || ThrowTemplateError($template->error());
                exit;
            }
666 667
        }
    }
668 669 670 671 672 673

    # We couldn't do this check earlier as we first had to validate attachment ID
    # and display the mid-air collision page if modification_time changed.
    my $token = $cgi->param('token');
    check_hash_token($token, [$attachment->id, $attachment->modification_time]);

674 675
    # If the user submitted a comment while editing the attachment,
    # add the comment to the bug. Do this after having validated isprivate!
676
    my $comment = $cgi->param('comment');
677
    if (defined $comment && trim($comment) ne '') {
678 679 680
        $bug->add_comment($comment, { isprivate => $attachment->isprivate,
                                      type => CMT_ATTACHMENT_UPDATED,
                                      extra_data => $attachment->id });
681 682
    }

683 684
    $bug->add_cc($user) if $cgi->param('addselfcc');

685 686 687
    my ($flags, $new_flags) =
      Bugzilla::Flag->extract_flags_from_cgi($bug, $attachment, $vars);

688 689 690
    if ($can_edit) {
        $attachment->set_flags($flags, $new_flags);
    }
691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711
    # Requestees can set flags targetted to them, even if they cannot
    # edit the attachment. Flag setters can edit their own flags too.
    elsif (scalar @$flags) {
        my %flag_list = map { $_->{id} => $_ } @$flags;
        my $flag_objs = Bugzilla::Flag->new_from_list([keys %flag_list]);

        my @editable_flags;
        foreach my $flag_obj (@$flag_objs) {
            if ($flag_obj->setter_id == $user->id
                || ($flag_obj->requestee_id && $flag_obj->requestee_id == $user->id))
            {
                push(@editable_flags, $flag_list{$flag_obj->id});
            }
        }

        if (scalar @editable_flags) {
            $attachment->set_flags(\@editable_flags, []);
            # Flag changes must be committed.
            $can_edit = 1;
        }
    }
712

713
    # Figure out when the changes were made.
714
    my $timestamp = $dbh->selectrow_array('SELECT LOCALTIMESTAMP(0)');
715

716 717 718 719 720 721 722
    if ($can_edit) {
        my $changes = $attachment->update($timestamp);
        # If there are changes, we updated delta_ts in the DB. We have to
        # reflect this change in the bug object.
        $bug->{delta_ts} = $timestamp if scalar(keys %$changes);
    }

723
    # Commit the comment, if any.
724
    $bug->update($timestamp);
725

726 727
    # Commit the transaction now that we are finished updating the database.
    $dbh->bz_commit_transaction();
728

729 730 731 732
    # Define the variables and functions that will be passed to the UI template.
    $vars->{'attachment'} = $attachment;
    $vars->{'bugs'} = [$bug];
    $vars->{'header_done'} = 1;
733
    $vars->{'sent_bugmail'} = 
734
        Bugzilla::BugMail::Send($bug->id, { 'changer' => $user });
735

736
    print $cgi->header();
737

738 739 740
    # Generate and return the UI (HTML page) from the appropriate template.
    $template->process("attachment/updated.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
741
}
742 743 744 745 746 747 748 749 750 751 752 753 754

# Only administrators can delete attachments.
sub delete_attachment {
    my $user = Bugzilla->login(LOGIN_REQUIRED);
    my $dbh = Bugzilla->dbh;

    print $cgi->header();

    $user->in_group('admin')
      || ThrowUserError('auth_failure', {group  => 'admin',
                                         action => 'delete',
                                         object => 'attachment'});

755
    Bugzilla->params->{'allow_attachment_deletion'}
756 757 758
      || ThrowUserError('attachment_deletion_disabled');

    # Make sure the administrator is allowed to edit this attachment.
759
    my $attachment = validateID();
760
    Bugzilla::Attachment->_check_bug($attachment->bug);
761 762 763 764 765 766 767 768 769

    $attachment->datasize || ThrowUserError('attachment_removed');

    # We don't want to let a malicious URL accidentally delete an attachment.
    my $token = trim($cgi->param('token'));
    if ($token) {
        my ($creator_id, $date, $event) = Bugzilla::Token::GetTokenData($token);
        unless ($creator_id
                  && ($creator_id == $user->id)
770
                  && ($event eq 'delete_attachment' . $attachment->id))
771 772
        {
            # The token is invalid.
773
            ThrowUserError('token_does_not_exist');
774 775
        }

776 777
        my $bug = new Bugzilla::Bug($attachment->bug_id);

778 779
        # The token is valid. Delete the content of the attachment.
        my $msg;
780
        $vars->{'attachment'} = $attachment;
781 782 783 784 785
        $vars->{'reason'} = clean_text($cgi->param('reason') || '');

        $template->process("attachment/delete_reason.txt.tmpl", $vars, \$msg)
          || ThrowTemplateError($template->error());

786 787 788
        # Paste the reason provided by the admin into a comment.
        $bug->add_comment($msg);

789
        $attachment->remove_from_db();
790 791

        # Now delete the token.
792
        delete_token($token);
793

794 795
        # Insert the comment.
        $bug->update();
796

797
        # Required to display the bug the deleted attachment belongs to.
798
        $vars->{'bugs'} = [$bug];
799 800
        $vars->{'header_done'} = 1;

801
        $vars->{'sent_bugmail'} =
802
            Bugzilla::BugMail::Send($bug->id, { 'changer' => $user });
803

804 805 806 807 808
        $template->process("attachment/updated.html.tmpl", $vars)
          || ThrowTemplateError($template->error());
    }
    else {
        # Create a token.
809
        $token = issue_session_token('delete_attachment' . $attachment->id);
810 811 812 813 814 815 816 817

        $vars->{'a'} = $attachment;
        $vars->{'token'} = $token;

        $template->process("attachment/confirm-delete.html.tmpl", $vars)
          || ThrowTemplateError($template->error());
    }
}