sanitycheck.cgi 34.5 KB
Newer Older
1
#!/usr/bin/perl -wT
2
# -*- Mode: perl; indent-tabs-mode: nil -*-
3
#
4 5 6 7 8 9 10 11 12 13
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
14
# The Original Code is the Bugzilla Bug Tracking System.
15
#
16
# The Initial Developer of the Original Code is Netscape Communications
17 18 19 20
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
21
# Contributor(s): Terry Weissman <terry@mozilla.org>
22
#                 Matthew Tuck <matty@chariot.net.au>
23
#                 Max Kanat-Alexander <mkanat@bugzilla.org>
24
#                 Marc Schumann <wurblzap@gmail.com>
25
#                 Frédéric Buclin <LpSolit@gmail.com>
26

27
use strict;
28

29
use lib qw(. lib);
30

31
use Bugzilla;
32
use Bugzilla::Bug;
33
use Bugzilla::Constants;
34
use Bugzilla::Error;
35 36
use Bugzilla::Hook;
use Bugzilla::Util;
37
use Bugzilla::Status;
38
use Bugzilla::Token;
39

40 41 42
###########################################################################
# General subs
###########################################################################
43

44 45 46 47
sub get_string {
    my ($san_tag, $vars) = @_;
    $vars->{'san_tag'} = $san_tag;
    return get_text('sanitycheck', $vars);
48 49
}

50 51
sub Status {
    my ($san_tag, $vars, $alert) = @_;
52 53 54 55 56 57 58 59 60 61 62 63 64
    my $cgi = Bugzilla->cgi;
    return if (!$alert && Bugzilla->usage_mode == USAGE_MODE_CMDLINE && !$cgi->param('verbose'));

    if (Bugzilla->usage_mode == USAGE_MODE_CMDLINE) {
        my $output = $cgi->param('output') || '';
        my $linebreak = $alert ? "\nALERT: " : "\n";
        $cgi->param('error_found', 1) if $alert;
        $cgi->param('output', $output . $linebreak . get_string($san_tag, $vars));
    }
    else {
        my $start_tag = $alert ? '<p class="alert">' : '<p>';
        print $start_tag . get_string($san_tag, $vars) . "</p>\n";
    }
65 66
}

67 68 69
###########################################################################
# Start
###########################################################################
70

71
my $user = Bugzilla->login(LOGIN_REQUIRED);
72

73
my $cgi = Bugzilla->cgi;
74
my $dbh = Bugzilla->dbh;
75 76 77 78
# If the result of the sanity check is sent per email, then we have to
# take the user prefs into account rather than querying the web browser.
my $template;
if (Bugzilla->usage_mode == USAGE_MODE_CMDLINE) {
79
    $template = Bugzilla->template_inner($user->setting('lang'));
80 81 82
}
else {
    $template = Bugzilla->template;
83 84 85 86 87 88 89 90 91

    # Only check the token if we are running this script from the
    # web browser and a parameter is passed to the script.
    # XXX - Maybe these two parameters should be deleted once logged in?
    $cgi->delete('GoAheadAndLogIn', 'Bugzilla_restrictlogin');
    if (scalar($cgi->param())) {
        my $token = $cgi->param('token');
        check_hash_token($token, ['sanitycheck']);
    }
92
}
93 94
my $vars = {};

95
print $cgi->header() unless Bugzilla->usage_mode == USAGE_MODE_CMDLINE;
96

97 98 99
# Make sure the user is authorized to access sanitycheck.cgi.
# As this script can now alter the group_control_map table, we no longer
# let users with editbugs privs run it anymore.
100
$user->in_group("editcomponents")
101
  || ThrowUserError("auth_failure", {group  => "editcomponents",
102 103
                                     action => "run",
                                     object => "sanity_check"});
104

105 106 107 108
unless (Bugzilla->usage_mode == USAGE_MODE_CMDLINE) {
    $template->process('admin/sanitycheck/list.html.tmpl', $vars)
      || ThrowTemplateError($template->error());
}
109

110 111 112 113
###########################################################################
# Create missing group_control_map entries
###########################################################################

114 115
if ($cgi->param('createmissinggroupcontrolmapentries')) {
    Status('group_control_map_entries_creation');
116 117 118 119

    my $na    = CONTROLMAPNA;
    my $shown = CONTROLMAPSHOWN;
    my $insertsth = $dbh->prepare(
120 121 122 123
        qq{INSERT INTO group_control_map
                       (group_id, product_id, membercontrol, othercontrol)
                VALUES (?, ?, $shown, $na)});

124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148
    my $updatesth = $dbh->prepare(qq{UPDATE group_control_map
                                        SET membercontrol = $shown
                                      WHERE group_id   = ?
                                        AND product_id = ?});
    my $counter = 0;

    # Find all group/product combinations used for bugs but not set up
    # correctly in group_control_map
    my $invalid_combinations = $dbh->selectall_arrayref(
        qq{    SELECT bugs.product_id,
                      bgm.group_id,
                      gcm.membercontrol,
                      groups.name,
                      products.name
                 FROM bugs
           INNER JOIN bug_group_map AS bgm
                   ON bugs.bug_id = bgm.bug_id
           INNER JOIN groups
                   ON bgm.group_id = groups.id
           INNER JOIN products
                   ON bugs.product_id = products.id
            LEFT JOIN group_control_map AS gcm
                   ON bugs.product_id = gcm.product_id
                  AND    bgm.group_id = gcm.group_id
                WHERE COALESCE(gcm.membercontrol, $na) = $na
149 150
          } . $dbh->sql_group_by('bugs.product_id, bgm.group_id',
                                 'gcm.membercontrol, groups.name, products.name'));
151 152 153 154 155 156 157

    foreach (@$invalid_combinations) {
        my ($product_id, $group_id, $currentmembercontrol,
            $group_name, $product_name) = @$_;

        $counter++;
        if (defined($currentmembercontrol)) {
158 159
            Status('group_control_map_entries_update',
                   {group_name => $group_name, product_name => $product_name});
160 161 162
            $updatesth->execute($group_id, $product_id);
        }
        else {
163 164
            Status('group_control_map_entries_generation',
                   {group_name => $group_name, product_name => $product_name});
165 166 167 168
            $insertsth->execute($group_id, $product_id);
        }
    }

169
    Status('group_control_map_entries_repaired', {counter => $counter});
170 171
}

172 173 174 175
###########################################################################
# Fix missing creation date
###########################################################################

176 177
if ($cgi->param('repair_creation_date')) {
    Status('bug_creation_date_start');
178 179 180 181 182 183 184 185

    my $bug_ids = $dbh->selectcol_arrayref('SELECT bug_id FROM bugs
                                            WHERE creation_ts IS NULL');

    my $sth_UpdateDate = $dbh->prepare('UPDATE bugs SET creation_ts = ?
                                        WHERE bug_id = ?');

    # All bugs have an entry in the 'longdescs' table when they are created,
186
    # even if no comment is required.
187 188 189 190 191 192 193 194
    my $sth_getDate = $dbh->prepare('SELECT MIN(bug_when) FROM longdescs
                                     WHERE bug_id = ?');

    foreach my $bugid (@$bug_ids) {
        $sth_getDate->execute($bugid);
        my $date = $sth_getDate->fetchrow_array;
        $sth_UpdateDate->execute($date, $bugid);
    }
195
    Status('bug_creation_date_fixed', {bug_count => scalar(@$bug_ids)});
196 197
}

198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213
###########################################################################
# Fix everconfirmed
###########################################################################

if ($cgi->param('repair_everconfirmed')) {
    Status('everconfirmed_start');

    my @confirmed_open_states = grep {$_ ne 'UNCONFIRMED'} BUG_STATE_OPEN;
    my $confirmed_open_states = join(', ', map {$dbh->quote($_)} @confirmed_open_states);

    $dbh->do("UPDATE bugs SET everconfirmed = 0 WHERE bug_status = 'UNCONFIRMED'");
    $dbh->do("UPDATE bugs SET everconfirmed = 1 WHERE bug_status IN ($confirmed_open_states)");

    Status('everconfirmed_end');
}

214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233
###########################################################################
# Fix entries in Bugs full_text
###########################################################################

if ($cgi->param('repair_bugs_fulltext')) {
    Status('bugs_fulltext_start');

    my $bug_ids = $dbh->selectcol_arrayref('SELECT bugs.bug_id
                                            FROM bugs
                                            LEFT JOIN bugs_fulltext
                                            ON bugs_fulltext.bug_id = bugs.bug_id
                                            WHERE bugs_fulltext.bug_id IS NULL');

   foreach my $bugid (@$bug_ids) {
       Bugzilla::Bug->new($bugid)->_sync_fulltext('new_bug');
   }

   Status('bugs_fulltext_fixed', {bug_count => scalar(@$bug_ids)});
}

234 235 236 237
###########################################################################
# Send unsent mail
###########################################################################

238
if ($cgi->param('rescanallBugMail')) {
239 240
    require Bugzilla::BugMail;

241
    Status('send_bugmail_start');
242
    my $time = $dbh->sql_date_math('NOW()', '-', 30, 'MINUTE');
243

244 245 246 247 248
    my $list = $dbh->selectcol_arrayref(qq{
                                        SELECT bug_id
                                          FROM bugs 
                                         WHERE (lastdiffed IS NULL
                                                OR lastdiffed < delta_ts)
249
                                           AND delta_ts < $time
250
                                      ORDER BY bug_id});
251

252 253
    Status('send_bugmail_status', {bug_count => scalar(@$list)});

254 255 256 257 258 259 260
    # We cannot simply look at the bugs_activity table to find who did the
    # last change in a given bug, as e.g. adding a comment doesn't add any
    # entry to this table. And some other changes may be private
    # (such as time-related changes or private attachments or comments)
    # and so choosing this user as being the last one having done a change
    # for the bug may be problematic. So the best we can do at this point
    # is to choose the currently logged in user for email notification.
261
    $vars->{'changer'} = Bugzilla->user;
262

263
    foreach my $bugid (@$list) {
264
        Bugzilla::BugMail::Send($bugid, $vars);
265 266
    }

267
    Status('send_bugmail_end') if scalar(@$list);
268

269 270 271 272
    unless (Bugzilla->usage_mode == USAGE_MODE_CMDLINE) {
        $template->process('global/footer.html.tmpl', $vars)
          || ThrowTemplateError($template->error());
    }
273 274 275
    exit;
}

276 277 278 279
###########################################################################
# Remove all references to deleted bugs
###########################################################################

280 281
if ($cgi->param('remove_invalid_bug_references')) {
    Status('bug_reference_deletion_start');
282

283
    $dbh->bz_start_transaction();
284

285 286
    foreach my $pair ('attachments/', 'bug_group_map/', 'bugs_activity/',
                      'bugs_fulltext/', 'cc/',
287 288
                      'dependencies/blocked', 'dependencies/dependson',
                      'duplicates/dupe', 'duplicates/dupe_of',
289
                      'flags/', 'keywords/', 'longdescs/') {
290 291 292 293 294 295 296 297 298 299 300 301 302 303

        my ($table, $field) = split('/', $pair);
        $field ||= "bug_id";

        my $bug_ids =
          $dbh->selectcol_arrayref("SELECT $table.$field FROM $table
                                    LEFT JOIN bugs ON $table.$field = bugs.bug_id
                                    WHERE bugs.bug_id IS NULL");

        if (scalar(@$bug_ids)) {
            $dbh->do("DELETE FROM $table WHERE $field IN (" . join(',', @$bug_ids) . ")");
        }
    }

304
    $dbh->bz_commit_transaction();
305
    Status('bug_reference_deletion_end');
306 307
}

308 309 310 311
###########################################################################
# Remove all references to deleted attachments
###########################################################################

312 313
if ($cgi->param('remove_invalid_attach_references')) {
    Status('attachment_reference_deletion_start');
314

315
    $dbh->bz_start_transaction();
316 317 318 319 320 321 322 323 324 325 326 327 328

    my $attach_ids =
        $dbh->selectcol_arrayref('SELECT attach_data.id
                                    FROM attach_data
                               LEFT JOIN attachments
                                      ON attachments.attach_id = attach_data.id
                                   WHERE attachments.attach_id IS NULL');

    if (scalar(@$attach_ids)) {
        $dbh->do('DELETE FROM attach_data WHERE id IN (' .
                 join(',', @$attach_ids) . ')');
    }

329
    $dbh->bz_commit_transaction();
330
    Status('attachment_reference_deletion_end');
331
}
332

333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362
###########################################################################
# Remove all references to deleted users or groups from whines
###########################################################################

if ($cgi->param('remove_old_whine_targets')) {
    Status('whines_obsolete_target_deletion_start');

    $dbh->bz_start_transaction();

    foreach my $target (['groups', 'id', MAILTO_GROUP],
                        ['profiles', 'userid', MAILTO_USER])
    {
        my ($table, $col, $type) = @$target;
        my $old_ids =
          $dbh->selectcol_arrayref("SELECT DISTINCT mailto
                                      FROM whine_schedules
                                 LEFT JOIN $table
                                        ON $table.$col = whine_schedules.mailto
                                     WHERE mailto_type = $type AND $table.$col IS NULL");

        if (scalar(@$old_ids)) {
            $dbh->do("DELETE FROM whine_schedules
                       WHERE mailto_type = $type AND mailto IN (" .
                       join(',', @$old_ids) . ")");
        }
    }
    $dbh->bz_commit_transaction();
    Status('whines_obsolete_target_deletion_end');
}

363 364 365 366
###########################################################################
# Repair hook
###########################################################################

367
Bugzilla::Hook::process('sanitycheck_repair', { status => \&Status });
368 369 370 371

###########################################################################
# Checks
###########################################################################
372
Status('checks_start');
373

374 375 376 377
###########################################################################
# Perform referential (cross) checks
###########################################################################

378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393
# This checks that a simple foreign key has a valid primary key value.  NULL
# references are acceptable and cause no problem.
#
# The first parameter is the primary key table name.
# The second parameter is the primary key field name.
# Each successive parameter represents a foreign key, it must be a list
# reference, where the list has:
#   the first value is the foreign key table name.
#   the second value is the foreign key field name.
#   the third value is optional and represents a field on the foreign key
#     table to display when the check fails.
#   the fourth value is optional and is a list reference to values that
#     are excluded from checking.
#
# FIXME: The excluded values parameter should go away - the QA contact
#        fields should use NULL instead - see bug #109474.
394
#        The same goes for series; no bug for that yet.
395

396 397 398
sub CrossCheck {
    my $table = shift @_;
    my $field = shift @_;
399
    my $dbh = Bugzilla->dbh;
400

401
    Status('cross_check_to', {table => $table, field => $field});
402 403 404 405 406 407 408 409

    while (@_) {
        my $ref = shift @_;
        my ($refertable, $referfield, $keyname, $exceptions) = @$ref;

        $exceptions ||= [];
        my %exceptions = map { $_ => 1 } @$exceptions;

410 411
        Status('cross_check_from', {table => $refertable, field => $referfield});

412 413 414 415 416 417 418
        my $query = qq{SELECT DISTINCT $refertable.$referfield} .
            ($keyname ? qq{, $refertable.$keyname } : q{}) .
                     qq{ FROM $refertable
                    LEFT JOIN $table
                           ON $refertable.$referfield = $table.$field
                        WHERE $table.$field IS NULL
                          AND $refertable.$referfield IS NOT NULL};
419

420 421
        my $sth = $dbh->prepare($query);
        $sth->execute;
422

423
        my $has_bad_references = 0;
424 425 426

        while (my ($value, $key) = $sth->fetchrow_array) {
            next if $exceptions{$value};
427 428 429
            Status('cross_check_alert', {value => $value, table => $refertable,
                                         field => $referfield, keyname => $keyname,
                                         key => $key}, 'alert');
430
            $has_bad_references = 1;
431
        }
432 433
        # References to non existent bugs can be safely removed, bug 288461
        if ($table eq 'bugs' && $has_bad_references) {
434
            Status('cross_check_bug_has_references');
435 436 437
        }
        # References to non existent attachments can be safely removed.
        if ($table eq 'attachments' && $has_bad_references) {
438
            Status('cross_check_attachment_has_references');
439
        }
440 441 442
    }
}

443 444 445
CrossCheck('classifications', 'id',
           ['products', 'classification_id']);

446 447 448
CrossCheck("keyworddefs", "id",
           ["keywords", "keywordid"]);

449
CrossCheck("fielddefs", "id",
450 451
           ["bugs_activity", "fieldid"],
           ['profiles_activity', 'fieldid']);
452

453
CrossCheck("flagtypes", "id",
454 455 456
           ["flags", "type_id"],
           ["flagexclusions", "type_id"],
           ["flaginclusions", "type_id"]);
457 458 459

CrossCheck("bugs", "bug_id",
           ["bugs_activity", "bug_id"],
460
           ["bug_group_map", "bug_id"],
461
           ["bugs_fulltext", "bug_id"],
462 463 464 465 466
           ["attachments", "bug_id"],
           ["cc", "bug_id"],
           ["longdescs", "bug_id"],
           ["dependencies", "blocked"],
           ["dependencies", "dependson"],
467
           ['flags', 'bug_id'],
468 469 470
           ["keywords", "bug_id"],
           ["duplicates", "dupe_of", "dupe"],
           ["duplicates", "dupe", "dupe_of"]);
471

472 473
CrossCheck("groups", "id",
           ["bug_group_map", "group_id"],
474
           ['category_group_map', 'group_id'],
475 476
           ["group_group_map", "grantor_id"],
           ["group_group_map", "member_id"],
477
           ["group_control_map", "group_id"],
478
           ["namedquery_group_map", "group_id"],
479 480 481
           ["user_group_map", "group_id"],
           ["flagtypes", "grant_group_id"],
           ["flagtypes", "request_group_id"]);
482

483 484 485 486 487
CrossCheck("namedqueries", "id",
           ["namedqueries_link_in_footer", "namedquery_id"],
           ["namedquery_group_map", "namedquery_id"],
          );

488
CrossCheck("profiles", "userid",
489 490
           ['profiles_activity', 'userid'],
           ['profiles_activity', 'who'],
491 492
           ['email_setting', 'user_id'],
           ['profile_setting', 'user_id'],
493 494
           ["bugs", "reporter", "bug_id"],
           ["bugs", "assigned_to", "bug_id"],
495
           ["bugs", "qa_contact", "bug_id"],
496
           ["attachments", "submitter_id", "bug_id"],
497 498
           ['flags', 'setter_id', 'bug_id'],
           ['flags', 'requestee_id', 'bug_id'],
499 500
           ["bugs_activity", "who", "bug_id"],
           ["cc", "who", "bug_id"],
501
           ['quips', 'userid'],
502
           ["longdescs", "who", "bug_id"],
503
           ["logincookies", "userid"],
504
           ["namedqueries", "userid"],
505
           ["namedqueries_link_in_footer", "user_id"],
506
           ['series', 'creator', 'series_id'],
507 508
           ["watch", "watcher"],
           ["watch", "watched"],
509
           ['whine_events', 'owner_userid'],
510
           ["tokens", "userid"],
511
           ["user_group_map", "user_id"],
512
           ["components", "initialowner", "name"],
513 514
           ["components", "initialqacontact", "name"],
           ["component_cc", "user_id"]);
515

516 517 518 519 520
CrossCheck("products", "id",
           ["bugs", "product_id", "bug_id"],
           ["components", "product_id", "name"],
           ["milestones", "product_id", "value"],
           ["versions", "product_id", "value"],
521
           ["group_control_map", "product_id"],
522 523
           ["flaginclusions", "product_id", "type_id"],
           ["flagexclusions", "product_id", "type_id"]);
524

525
CrossCheck("components", "id",
526 527 528
           ["component_cc", "component_id"],
           ["flagexclusions", "component_id", "type_id"],
           ["flaginclusions", "component_id", "type_id"]);
529

530
# Check the former enum types -mkanat@bugzilla.org
531
CrossCheck("bug_status", "value",
532
            ["bugs", "bug_status", "bug_id"]);
533 534

CrossCheck("resolution", "value",
535
            ["bugs", "resolution", "bug_id"]);
536 537

CrossCheck("bug_severity", "value",
538
            ["bugs", "bug_severity", "bug_id"]);
539 540

CrossCheck("op_sys", "value",
541
            ["bugs", "op_sys", "bug_id"]);
542 543

CrossCheck("priority", "value",
544
            ["bugs", "priority", "bug_id"]);
545 546

CrossCheck("rep_platform", "value",
547
            ["bugs", "rep_platform", "bug_id"]);
548

549 550 551 552
CrossCheck('series', 'series_id',
           ['series_data', 'series_id']);

CrossCheck('series_categories', 'id',
553 554 555
           ['series', 'category'],
           ["category_group_map", "category_id"],
           ["series", "subcategory"]);
556 557 558 559 560

CrossCheck('whine_events', 'id',
           ['whine_queries', 'eventid'],
           ['whine_schedules', 'eventid']);

561
CrossCheck('attachments', 'attach_id',
562 563
           ['attach_data', 'id'],
           ['bugs_activity', 'attach_id']);
564

565 566 567 568
CrossCheck('bug_status', 'id',
           ['status_workflow', 'old_status'],
           ['status_workflow', 'new_status']);

569
###########################################################################
570
# Perform double field referential (cross) checks
571
###########################################################################
572
 
573 574 575 576 577 578 579 580 581 582 583 584 585 586
# This checks that a compound two-field foreign key has a valid primary key
# value.  NULL references are acceptable and cause no problem.
#
# The first parameter is the primary key table name.
# The second parameter is the primary key first field name.
# The third parameter is the primary key second field name.
# Each successive parameter represents a foreign key, it must be a list
# reference, where the list has:
#   the first value is the foreign key table name
#   the second value is the foreign key first field name.
#   the third value is the foreign key second field name.
#   the fourth value is optional and represents a field on the foreign key
#     table to display when the check fails

587 588 589 590
sub DoubleCrossCheck {
    my $table = shift @_;
    my $field1 = shift @_;
    my $field2 = shift @_;
591
    my $dbh = Bugzilla->dbh;
592 593 594 595

    Status('double_cross_check_to',
           {table => $table, field1 => $field1, field2 => $field2});

596 597 598
    while (@_) {
        my $ref = shift @_;
        my ($refertable, $referfield1, $referfield2, $keyname) = @$ref;
599 600 601

        Status('double_cross_check_from',
               {table => $refertable, field1 => $referfield1, field2 =>$referfield2});
602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617

        my $d_cross_check = $dbh->selectall_arrayref(qq{
                        SELECT DISTINCT $refertable.$referfield1, 
                                        $refertable.$referfield2 } .
                       ($keyname ? qq{, $refertable.$keyname } : q{}) .
                      qq{ FROM $refertable
                     LEFT JOIN $table
                            ON $refertable.$referfield1 = $table.$field1
                           AND $refertable.$referfield2 = $table.$field2 
                         WHERE $table.$field1 IS NULL 
                           AND $table.$field2 IS NULL 
                           AND $refertable.$referfield1 IS NOT NULL 
                           AND $refertable.$referfield2 IS NOT NULL});

        foreach my $check (@$d_cross_check) {
            my ($value1, $value2, $key) = @$check;
618 619 620 621 622
            Status('double_cross_check_alert',
                   {value1 => $value1, value2 => $value2,
                    table => $refertable,
                    field1 => $referfield1, field2 => $referfield2,
                    keyname => $keyname, key => $key}, 'alert');
623
        }
624 625 626
    }
}

627 628 629 630
DoubleCrossCheck('attachments', 'bug_id', 'attach_id',
                 ['flags', 'bug_id', 'attach_id'],
                 ['bugs_activity', 'bug_id', 'attach_id']);

631
DoubleCrossCheck("components", "product_id", "id",
632 633 634
                 ["bugs", "product_id", "component_id", "bug_id"],
                 ['flagexclusions', 'product_id', 'component_id'],
                 ['flaginclusions', 'product_id', 'component_id']);
635

636 637 638 639 640 641
DoubleCrossCheck("versions", "product_id", "value",
                 ["bugs", "product_id", "version", "bug_id"]);
 
DoubleCrossCheck("milestones", "product_id", "value",
                 ["bugs", "product_id", "target_milestone", "bug_id"],
                 ["products", "id", "defaultmilestone", "name"]);
642

643 644 645
###########################################################################
# Perform login checks
###########################################################################
646 647

Status('profile_login_start');
648

649 650
my $sth = $dbh->prepare(q{SELECT userid, login_name FROM profiles});
$sth->execute;
651

652
while (my ($id, $email) = $sth->fetchrow_array) {
653
    validate_email_syntax($email)
654
      || Status('profile_login_alert', {id => $id, email => $email}, 'alert');
655
}
656

657
###########################################################################
658
# Perform keyword checks
659
###########################################################################
660

661
sub check_keywords {
662
    my $dbh = Bugzilla->dbh;
663
    my $cgi = Bugzilla->cgi;
664

665
    Status('keyword_check_start');
666

667 668 669
    my %keywordids;
    my $keywords = $dbh->selectall_arrayref(q{SELECT id, name
                                                FROM keyworddefs});
670

671 672 673
    foreach (@$keywords) {
        my ($id, $name) = @$_;
        if ($keywordids{$id}) {
674
            Status('keyword_check_alert', {id => $id}, 'alert');
675 676 677
        }
        $keywordids{$id} = 1;
        if ($name =~ /[\s,]/) {
678
            Status('keyword_check_invalid_name', {id => $id}, 'alert');
679 680
        }
    }
681

682 683 684 685 686 687 688 689
    my $sth = $dbh->prepare(q{SELECT bug_id, keywordid
                                FROM keywords
                            ORDER BY bug_id, keywordid});
    $sth->execute;
    my $lastid;
    my $lastk;
    while (my ($id, $k) = $sth->fetchrow_array) {
        if (!$keywordids{$k}) {
690
            Status('keyword_check_invalid_id', {id => $k}, 'alert');
691
        }
692
        if (defined $lastid && $id eq $lastid && $k eq $lastk) {
693
            Status('keyword_check_duplicated_ids', {id => $id}, 'alert');
694
        }
695 696
        $lastid = $id;
        $lastk = $k;
697
    }
698
}
699

700 701 702 703
###########################################################################
# Check for flags being in incorrect products and components
###########################################################################

704
Status('flag_check_start');
705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732

my $invalid_flags = $dbh->selectall_arrayref(
       'SELECT DISTINCT flags.id, flags.bug_id, flags.attach_id
          FROM flags
    INNER JOIN bugs
            ON flags.bug_id = bugs.bug_id
     LEFT JOIN flaginclusions AS i
            ON flags.type_id = i.type_id
           AND (bugs.product_id = i.product_id OR i.product_id IS NULL)
           AND (bugs.component_id = i.component_id OR i.component_id IS NULL)
         WHERE i.type_id IS NULL');

my @invalid_flags = @$invalid_flags;

$invalid_flags = $dbh->selectall_arrayref(
       'SELECT DISTINCT flags.id, flags.bug_id, flags.attach_id
          FROM flags
    INNER JOIN bugs
            ON flags.bug_id = bugs.bug_id
    INNER JOIN flagexclusions AS e
            ON flags.type_id = e.type_id
         WHERE (bugs.product_id = e.product_id OR e.product_id IS NULL)
           AND (bugs.component_id = e.component_id OR e.component_id IS NULL)');

push(@invalid_flags, @$invalid_flags);

if (scalar(@invalid_flags)) {
    if ($cgi->param('remove_invalid_flags')) {
733
        Status('flag_deletion_start');
734 735 736
        my @flag_ids = map {$_->[0]} @invalid_flags;
        # Silently delete these flags, with no notification to requesters/setters.
        $dbh->do('DELETE FROM flags WHERE id IN (' . join(',', @flag_ids) .')');
737
        Status('flag_deletion_end');
738 739 740 741
    }
    else {
        foreach my $flag (@$invalid_flags) {
            my ($flag_id, $bug_id, $attach_id) = @$flag;
742 743 744
            Status('flag_alert',
                   {flag_id => $flag_id, attach_id => $attach_id, bug_id => $bug_id},
                   'alert');
745
        }
746
        Status('flag_fix');
747 748 749
    }
}

750
###########################################################################
751
# General bug checks
752 753
###########################################################################

754
sub BugCheck {
755
    my ($middlesql, $errortext, $repairparam, $repairtext) = @_;
756
    my $dbh = Bugzilla->dbh;
757 758 759 760
 
    my $badbugs = $dbh->selectcol_arrayref(qq{SELECT DISTINCT bugs.bug_id
                                                FROM $middlesql 
                                            ORDER BY bugs.bug_id});
761

762
    if (scalar(@$badbugs)) {
763 764 765 766
        Status('bug_check_alert',
               {errortext => get_string($errortext), badbugs => $badbugs},
               'alert');

767
        if ($repairparam) {
768 769 770
            $repairtext ||= 'repair_bugs';
            Status('bug_check_repair',
                   {param => $repairparam, text => get_string($repairtext)});
771
        }
772
    }
773 774
}

775
Status('bug_check_creation_date');
776

777 778
BugCheck("bugs WHERE creation_ts IS NULL", 'bug_check_creation_date_error_text',
         'repair_creation_date', 'bug_check_creation_date_repair_text');
779

780 781 782 783 784 785
Status('bug_check_bugs_fulltext');

BugCheck("bugs LEFT JOIN bugs_fulltext ON bugs_fulltext.bug_id = bugs.bug_id " .
         "WHERE bugs_fulltext.bug_id IS NULL", 'bug_check_bugs_fulltext_error_text',
         'repair_bugs_fulltext', 'bug_check_bugs_fulltext_repair_text');

786
Status('bug_check_res_dupl');
787

788
BugCheck("bugs INNER JOIN duplicates ON bugs.bug_id = duplicates.dupe " .
789
         "WHERE bugs.resolution != 'DUPLICATE'", 'bug_check_res_dupl_error_text');
790

791 792
BugCheck("bugs LEFT JOIN duplicates ON bugs.bug_id = duplicates.dupe WHERE " .
         "bugs.resolution = 'DUPLICATE' AND " .
793
         "duplicates.dupe IS NULL", 'bug_check_res_dupl_error_text2');
794

795
Status('bug_check_status_res');
796

797
my @open_states = map($dbh->quote($_), BUG_STATE_OPEN);
798 799
my $open_states = join(', ', @open_states);

800
BugCheck("bugs WHERE bug_status IN ($open_states) AND resolution != ''",
801
         'bug_check_status_res_error_text');
802
BugCheck("bugs WHERE bug_status NOT IN ($open_states) AND resolution = ''",
803
         'bug_check_status_res_error_text2');
804

805
Status('bug_check_status_everconfirmed');
806

807
BugCheck("bugs WHERE bug_status = 'UNCONFIRMED' AND everconfirmed = 1",
808
         'bug_check_status_everconfirmed_error_text', 'repair_everconfirmed');
809 810 811 812 813

my @confirmed_open_states = grep {$_ ne 'UNCONFIRMED'} BUG_STATE_OPEN;
my $confirmed_open_states = join(', ', map {$dbh->quote($_)} @confirmed_open_states);

BugCheck("bugs WHERE bug_status IN ($confirmed_open_states) AND everconfirmed = 0",
814
         'bug_check_status_everconfirmed_error_text2', 'repair_everconfirmed');
815

816 817 818 819 820 821
###########################################################################
# Control Values
###########################################################################

# Checks for values that are invalid OR
# not among the 9 valid combinations
822
Status('bug_check_control_values');
823 824
my $groups = join(", ", (CONTROLMAPNA, CONTROLMAPSHOWN, CONTROLMAPDEFAULT,
CONTROLMAPMANDATORY));
825
my $query = qq{
826 827 828 829 830 831 832 833
     SELECT COUNT(product_id) 
       FROM group_control_map 
      WHERE membercontrol NOT IN( $groups )
         OR othercontrol NOT IN( $groups )
         OR ((membercontrol != othercontrol)
             AND (membercontrol != } . CONTROLMAPSHOWN . q{)
             AND ((membercontrol != } . CONTROLMAPDEFAULT . q{)
                  OR (othercontrol = } . CONTROLMAPSHOWN . q{)))};
834

835 836 837 838
my $entries = $dbh->selectrow_array($query);
Status('bug_check_control_values_alert', {entries => $entries}, 'alert') if $entries;

Status('bug_check_control_values_violation');
839
BugCheck("bugs
840 841 842 843
         INNER JOIN bug_group_map
            ON bugs.bug_id = bug_group_map.bug_id
          LEFT JOIN group_control_map
            ON bugs.product_id = group_control_map.product_id
844
           AND bug_group_map.group_id = group_control_map.group_id
845
         WHERE ((group_control_map.membercontrol = " . CONTROLMAPNA . ")
846
         OR (group_control_map.membercontrol IS NULL))",
847
         'bug_check_control_values_error_text',
848
         'createmissinggroupcontrolmapentries',
849
         'bug_check_control_values_repair_text');
850

851
BugCheck("bugs
852
         INNER JOIN group_control_map
853
            ON bugs.product_id = group_control_map.product_id
854 855 856 857 858
         INNER JOIN groups
            ON group_control_map.group_id = groups.id
          LEFT JOIN bug_group_map
            ON bugs.bug_id = bug_group_map.bug_id
           AND group_control_map.group_id = bug_group_map.group_id
859
         WHERE group_control_map.membercontrol = " . CONTROLMAPMANDATORY . "
860 861
           AND bug_group_map.group_id IS NULL
           AND groups.isactive != 0",
862
         'bug_check_control_values_error_text2');
863

864 865 866 867
###########################################################################
# Unsent mail
###########################################################################

868
Status('unsent_bugmail_check');
869

870
my $time = $dbh->sql_date_math('NOW()', '-', 30, 'MINUTE');
871 872 873 874
my $badbugs = $dbh->selectcol_arrayref(qq{
                    SELECT bug_id 
                      FROM bugs 
                     WHERE (lastdiffed IS NULL OR lastdiffed < delta_ts)
875
                       AND delta_ts < $time
876
                  ORDER BY bug_id});
877 878


879
if (scalar(@$badbugs > 0)) {
880 881
    Status('unsent_bugmail_alert', {badbugs => $badbugs}, 'alert');
    Status('unsent_bugmail_fix');
882 883
}

884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907
###########################################################################
# Whines
###########################################################################

Status('whines_obsolete_target_start');

my $display_repair_whines_link = 0;
foreach my $target (['groups', 'id', MAILTO_GROUP],
                    ['profiles', 'userid', MAILTO_USER])
{
    my ($table, $col, $type) = @$target;
    my $old = $dbh->selectall_arrayref("SELECT whine_schedules.id, mailto
                                          FROM whine_schedules
                                     LEFT JOIN $table
                                            ON $table.$col = whine_schedules.mailto
                                         WHERE mailto_type = $type AND $table.$col IS NULL");

    if (scalar(@$old)) {
        Status('whines_obsolete_target_alert', {schedules => $old, type => $type}, 'alert');
        $display_repair_whines_link = 1;
    }
}
Status('whines_obsolete_target_fix') if $display_repair_whines_link;

908 909 910 911
###########################################################################
# Check hook
###########################################################################

912
Bugzilla::Hook::process('sanitycheck_check', { status => \&Status });
913

914 915 916
###########################################################################
# End
###########################################################################
917

918 919
Status('checks_completed');

920 921 922 923
unless (Bugzilla->usage_mode == USAGE_MODE_CMDLINE) {
    $template->process('global/footer.html.tmpl', $vars)
      || ThrowTemplateError($template->error());
}