attachment.cgi 44.8 KB
Newer Older
1
#!/usr/bin/perl -wT
2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22
# -*- Mode: perl; indent-tabs-mode: nil -*-
#
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
# The Original Code is the Bugzilla Bug Tracking System.
#
# The Initial Developer of the Original Code is Netscape Communications
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
# Contributor(s): Terry Weissman <terry@mozilla.org>
#                 Myk Melez <myk@mozilla.org>
23 24
#                 Daniel Raichle <draichle@gmx.net>
#                 Dave Miller <justdave@syndicomm.com>
25
#                 Alexander J. Vincent <ajvincent@juno.com>
26
#                 Max Kanat-Alexander <mkanat@bugzilla.org>
27
#                 Greg Hendricks <ghendricks@novell.com>
28 29 30 31 32 33 34 35

################################################################################
# Script Initialization
################################################################################

# Make it harder for us to do dangerous things in Perl.
use strict;

36 37
use lib qw(.);

38
use vars qw($template $vars);
39

40
# Include the Bugzilla CGI and general utility library.
41
require "globals.pl";
42
use Bugzilla::Config qw(:locations);
43

44
# Use these modules to handle flags.
45
use Bugzilla::Constants;
46 47
use Bugzilla::Flag; 
use Bugzilla::FlagType; 
48
use Bugzilla::User;
49
use Bugzilla::Util;
50
use Bugzilla::Bug;
51

52
Bugzilla->login();
53

54 55
my $cgi = Bugzilla->cgi;

56 57 58 59
################################################################################
# Main Body Execution
################################################################################

60 61 62 63
# All calls to this script should contain an "action" variable whose
# value determines what the user wants to do.  The code below checks
# the value of that variable and runs the appropriate code. If none is
# supplied, we default to 'view'.
64 65

# Determine whether to use the action specified by the user or the default.
66
my $action = $cgi->param('action') || 'view';
67 68

if ($action eq "view")  
69
{
70
    view();
71
}
72 73
elsif ($action eq "interdiff")
{
74
    interdiff();
75 76 77
}
elsif ($action eq "diff")
{
78
    diff();
79
}
80 81
elsif ($action eq "viewall") 
{ 
82
    viewall(); 
83
}
84 85
elsif ($action eq "enter") 
{ 
86 87
    Bugzilla->login(LOGIN_REQUIRED);
    enter(); 
88 89 90
}
elsif ($action eq "insert")
{
91 92
    Bugzilla->login(LOGIN_REQUIRED);
    insert();
93
}
94 95
elsif ($action eq "edit") 
{ 
96
    edit(); 
97 98 99
}
elsif ($action eq "update") 
{ 
100 101
    Bugzilla->login(LOGIN_REQUIRED);
    update();
102 103 104
}
else 
{ 
105
  ThrowCodeError("unknown_action", { action => $action });
106 107 108 109 110 111 112 113
}

exit;

################################################################################
# Data Validation / Security Authorization
################################################################################

114 115 116 117 118 119 120 121 122 123 124 125
# Validates an attachment ID. Optionally takes a parameter of a form
# variable name that contains the ID to be validated. If not specified,
# uses 'id'.
# 
# Will throw an error if 1) attachment ID is not a valid number,
# 2) attachment does not exist, or 3) user isn't allowed to access the
# attachment.
#
# Returns a list, where the first item is the validated, detainted
# attachment id, and the 2nd item is the bug id corresponding to the
# attachment.
# 
126 127
sub validateID
{
128 129
    my $param = @_ ? $_[0] : 'id';

130 131 132
    # If we're not doing interdiffs, check if id wasn't specified and
    # prompt them with a page that allows them to choose an attachment.
    # Happens when calling plain attachment.cgi from the urlbar directly
133 134
    if ($param eq 'id' && !$cgi->param('id')) {

135
        print $cgi->header();
136 137 138 139
        $template->process("attachment/choose.html.tmpl", $vars) ||
            ThrowTemplateError($template->error());
        exit;
    }
140
    
141 142 143 144 145 146 147
    my $attach_id = $cgi->param($param);

    # Validate the specified attachment id. detaint kills $attach_id if
    # non-natural, so use the original value from $cgi in our exception
    # message here.
    detaint_natural($attach_id)
     || ThrowUserError("invalid_attach_id", { attach_id => $cgi->param($param) });
148
  
149
    # Make sure the attachment exists in the database.
150
    SendSQL("SELECT bug_id, isprivate FROM attachments WHERE attach_id = $attach_id");
151
    MoreSQLData()
152
      || ThrowUserError("invalid_attach_id", { attach_id => $attach_id });
153

154
    # Make sure the user is authorized to access this attachment's bug.
155 156
    (my $bugid, my $isprivate) = FetchSQLData();

157
    ValidateBugID($bugid);
158 159 160 161
    if ($isprivate && Param("insidergroup")) {
        UserInGroup(Param("insidergroup"))
          || ThrowUserError("auth_failure", {action => "access",
                                             object => "attachment"});
162
    }
163

164
    return ($attach_id,$bugid);
165 166
}

167 168 169
# Validates format of a diff/interdiff. Takes a list as an parameter, which
# defines the valid format values. Will throw an error if the format is not
# in the list. Returns either the user selected or default format.
170 171
sub validateFormat
{
172 173 174
  # receives a list of legal formats; first item is a default
  my $format = $cgi->param('format') || $_[0];
  if ( lsearch(\@_, $format) == -1)
175
  {
176
     ThrowUserError("invalid_format", { format  => $format, formats => \@_ });
177
  }
178

179
  return $format;
180 181
}

182 183
# Validates context of a diff/interdiff. Will throw an error if the context
# is not number, "file" or "patch". Returns the validated, detainted context.
184 185
sub validateContext
{
186 187 188 189
  my $context = $cgi->param('context') || "patch";
  if ($context ne "file" && $context ne "patch") {
    detaint_natural($context)
      || ThrowUserError("invalid_context", { context => $cgi->param('context') });
190
  }
191 192

  return $context;
193 194
}

195 196 197 198 199 200 201 202 203
sub validateCanEdit
{
    my ($attach_id) = (@_);

    # People in editbugs can edit all attachments
    return if UserInGroup("editbugs");

    # Bug 97729 - the submitter can edit their attachments
    SendSQL("SELECT attach_id FROM attachments WHERE " .
204
            "attach_id = $attach_id AND submitter_id = " . Bugzilla->user->id);
205 206

    FetchSQLData()
207 208
      || ThrowUserError("illegal_attachment_edit",
                        { attach_id => $attach_id });
209 210
}

211 212 213 214
sub validateCanChangeAttachment 
{
    my ($attachid) = @_;
    SendSQL("SELECT product_id
215 216 217 218
             FROM attachments
             INNER JOIN bugs
             ON bugs.bug_id = attachments.bug_id
             WHERE attach_id = $attachid");
219 220
    my $productid = FetchOneColumn();
    CanEditProductId($productid)
221 222
      || ThrowUserError("illegal_attachment_edit",
                        { attach_id => $attachid });
223 224 225 226 227 228 229 230 231 232
}

sub validateCanChangeBug
{
    my ($bugid) = @_;
    SendSQL("SELECT product_id
             FROM bugs 
             WHERE bug_id = $bugid");
    my $productid = FetchOneColumn();
    CanEditProductId($productid)
233 234
      || ThrowUserError("illegal_attachment_edit_bug",
                        { bug_id => $bugid });
235 236
}

237 238
sub validateDescription
{
239 240
    $cgi->param('description')
      || ThrowUserError("missing_attachment_description");
241 242 243 244
}

sub validateIsPatch
{
245 246 247 248
    # Set the ispatch flag to zero if it is undefined, since the UI uses
    # an HTML checkbox to represent this flag, and unchecked HTML checkboxes
    # do not get sent in HTML requests.
    $cgi->param('ispatch', $cgi->param('ispatch') ? 1 : 0);
249

250 251
    # Set the content type to text/plain if the attachment is a patch.
    $cgi->param('contenttype', 'text/plain') if $cgi->param('ispatch');
252 253 254 255
}

sub validateContentType
{
256
  if (!defined $cgi->param('contenttypemethod'))
257
  {
258
    ThrowUserError("missing_content_type_method");
259
  }
260
  elsif ($cgi->param('contenttypemethod') eq 'autodetect')
261
  {
262
    my $contenttype = $cgi->uploadInfo($cgi->param('data'))->{'Content-Type'};
263 264
    # The user asked us to auto-detect the content type, so use the type
    # specified in the HTTP request headers.
265
    if ( !$contenttype )
266
    {
267
      ThrowUserError("missing_content_type");
268
    }
269
    $cgi->param('contenttype', $contenttype);
270
  }
271
  elsif ($cgi->param('contenttypemethod') eq 'list')
272 273
  {
    # The user selected a content type from the list, so use their selection.
274
    $cgi->param('contenttype', $cgi->param('contenttypeselection'));
275
  }
276
  elsif ($cgi->param('contenttypemethod') eq 'manual')
277 278
  {
    # The user entered a content type manually, so use their entry.
279
    $cgi->param('contenttype', $cgi->param('contenttypeentry'));
280 281 282
  }
  else
  {
283
    ThrowCodeError("illegal_content_type_method",
284
                   { contenttypemethod => $cgi->param('contenttypemethod') });
285 286
  }

287 288
  if ( $cgi->param('contenttype') !~
         /^(application|audio|image|message|model|multipart|text|video)\/.+$/ )
289
  {
290
    ThrowUserError("invalid_content_type",
291
                   { contenttype => $cgi->param('contenttype') });
292
  }
293 294 295 296
}

sub validateIsObsolete
{
297 298 299 300
    # Set the isobsolete flag to zero if it is undefined, since the UI uses
    # an HTML checkbox to represent this flag, and unchecked HTML checkboxes
    # do not get sent in HTML requests.
    $cgi->param('isobsolete', $cgi->param('isobsolete') ? 1 : 0);
301 302
}

303 304 305 306 307
sub validatePrivate
{
    # Set the isprivate flag to zero if it is undefined, since the UI uses
    # an HTML checkbox to represent this flag, and unchecked HTML checkboxes
    # do not get sent in HTML requests.
308
    $cgi->param('isprivate', $cgi->param('isprivate') ? 1 : 0);
309 310
}

311 312
sub validateData
{
313
  my $maxsize = $cgi->param('ispatch') ? Param('maxpatchsize') : Param('maxattachmentsize');
314
  $maxsize *= 1024; # Convert from K
315 316 317
  my $fh;
  # Skip uploading into a local variable if the user wants to upload huge
  # attachments into local files.
318
  if (!$cgi->param('bigfile'))
319 320 321
  {
    $fh = $cgi->upload('data');
  }
322
  my $data;
323

324 325
  # We could get away with reading only as much as required, except that then
  # we wouldn't have a size to print to the error handler below.
326
  if (!$cgi->param('bigfile'))
327
  {
328 329 330
      # enable 'slurp' mode
      local $/;
      $data = <$fh>;
331
  }
332 333

  $data
334
    || ($cgi->param('bigfile'))
335
    || ThrowUserError("zero_length_file");
336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351
    
    # Windows screenshots are usually uncompressed BMP files which
    # makes for a quick way to eat up disk space. Let's compress them. 
    # We do this before we check the size since the uncompressed version
    # could easily be greater than maxattachmentsize.
    if (Param('convert_uncompressed_images') && $cgi->param('contenttype') eq 'image/bmp'){
      require Image::Magick; 
      my $img = Image::Magick->new(magick=>'bmp');
      $img->BlobToImage($data);
      $img->set(magick=>'png');
      my $imgdata = $img->ImageToBlob();
      $data = $imgdata;
      $cgi->param('contenttype', 'image/png');
      $vars->{'convertedbmp'} = 1;
    }
    
352
  # Make sure the attachment does not exceed the maximum permitted size
353
  my $len = $data ? length($data) : 0;
354
  if ($maxsize && $len > $maxsize) {
355
      my $vars = { filesize => sprintf("%.0f", $len/1024) };
356
      if ($cgi->param('ispatch')) {
357
          ThrowUserError("patch_too_large", $vars);
358
      } else {
359
          ThrowUserError("file_too_large", $vars);
360 361 362
      }
  }

363
  return $data || '';
364 365 366 367
}

sub validateFilename
{
368
  defined $cgi->upload('data')
369
    || ThrowUserError("file_not_specified");
370

371
  my $filename = $cgi->upload('data');
372 373 374 375 376 377 378 379 380 381 382
  
  # Remove path info (if any) from the file name.  The browser should do this
  # for us, but some are buggy.  This may not work on Mac file names and could
  # mess up file names with slashes in them, but them's the breaks.  We only
  # use this as a hint to users downloading attachments anyway, so it's not 
  # a big deal if it munges incorrectly occasionally.
  $filename =~ s/^.*[\/\\]//;

  # Truncate the filename to 100 characters, counting from the end of the string
  # to make sure we keep the filename extension.
  $filename = substr($filename, -100, 100);
383 384

  return $filename;
385 386 387 388
}

sub validateObsolete
{
389 390
  my @obsolete_ids = ();

391 392
  # Make sure the attachment id is valid and the user has permissions to view
  # the bug to which it is attached.
393
  foreach my $attachid ($cgi->param('obsolete')) {
394
    my $vars = {};
395 396
    $vars->{'attach_id'} = $attachid;
    
397
    detaint_natural($attachid)
398
      || ThrowCodeError("invalid_attach_id_to_obsolete", $vars);
399 400 401 402 403 404
  
    SendSQL("SELECT bug_id, isobsolete, description 
             FROM attachments WHERE attach_id = $attachid");

    # Make sure the attachment exists in the database.
    MoreSQLData()
405
      || ThrowUserError("invalid_attach_id", $vars);
406 407 408

    my ($bugid, $isobsolete, $description) = FetchSQLData();

409 410
    $vars->{'description'} = $description;
    
411
    if ($bugid != $cgi->param('bugid'))
412
    {
413
      $vars->{'my_bug_id'} = $cgi->param('bugid');
414
      $vars->{'attach_bug_id'} = $bugid;
415
      ThrowCodeError("mismatched_bug_ids_on_obsolete", $vars);
416 417 418 419
    }

    if ( $isobsolete )
    {
420
      ThrowCodeError("attachment_already_obsolete", $vars);
421
    }
422 423 424

    # Check that the user can modify this attachment
    validateCanEdit($attachid);
425
    push(@obsolete_ids, $attachid);
426
  }
427 428

  return @obsolete_ids;
429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450
}

# Returns 1 if the parameter is a content-type viewable in this browser
# Note that we don't use $cgi->Accept()'s ability to check if a content-type
# matches, because this will return a value even if it's matched by the generic
# */* which most browsers add to the end of their Accept: headers.
sub isViewable
{
  my $contenttype = trim(shift);
    
  # We assume we can view all text and image types  
  if ($contenttype =~ /^(text|image)\//) {
    return 1;
  }
  
  # Mozilla can view XUL. Note the trailing slash on the Gecko detection to
  # avoid sending XUL to Safari.
  if (($contenttype =~ /^application\/vnd\.mozilla\./) &&
      ($cgi->user_agent() =~ /Gecko\//))
  {
    return 1;
  }
451

452 453 454 455 456 457 458 459 460
  # If it's not one of the above types, we check the Accept: header for any 
  # types mentioned explicitly.
  my $accept = join(",", $cgi->Accept());
  
  if ($accept =~ /^(.*,)?\Q$contenttype\E(,.*)?$/) {
    return 1;
  }
  
  return 0;
461 462
}

463 464 465 466
################################################################################
# Functions
################################################################################

467
# Display an attachment.
468 469
sub view
{
470 471
    # Retrieve and validate parameters
    my ($attach_id) = validateID();
472

473
    # Retrieve the attachment content and its content type from the database.
474 475
    SendSQL("SELECT mimetype, filename, thedata FROM attachments " .
            "WHERE attach_id = $attach_id");
476
    my ($contenttype, $filename, $thedata) = FetchSQLData();
477
   
478 479 480
    # Bug 111522: allow overriding content-type manually in the posted form
    # params.
    if (defined $cgi->param('content_type'))
481
    {
482 483
        $cgi->param('contenttypemethod', 'manual');
        $cgi->param('contenttypeentry', $cgi->param('content_type'));
484
        validateContentType();
485
        $contenttype = $cgi->param('content_type');
486
    }
487

488
    # Return the appropriate HTTP response headers.
489 490
    $filename =~ s/^.*[\/\\]//;
    my $filesize = length($thedata);
491 492 493 494
    # A zero length attachment in the database means the attachment is 
    # stored in a local file
    if ($filesize == 0)
    {
495
        my $hash = ($attach_id % 100) + 100;
496
        $hash =~ s/.*(\d\d)$/group.$1/;
497
        if (open(AH, "$attachdir/$hash/attachment.$attach_id")) {
498 499 500 501 502 503 504 505 506
            binmode AH;
            $filesize = (stat(AH))[7];
        }
    }
    if ($filesize == 0)
    {
        ThrowUserError("attachment_removed");
    }

507

508 509 510 511
    # escape quotes and backslashes in the filename, per RFCs 2045/822
    $filename =~ s/\\/\\\\/g; # escape backslashes
    $filename =~ s/"/\\"/g; # escape quotes

512 513 514
    print $cgi->header(-type=>"$contenttype; name=\"$filename\"",
                       -content_disposition=> "inline; filename=\"$filename\"",
                       -content_length => $filesize);
515

516 517 518 519 520 521 522 523 524
    if ($thedata) {
        print $thedata;
    } else {
        while (<AH>) {
            print $_;
        }
        close(AH);
    }

525 526
}

527 528
sub interdiff
{
529 530 531 532 533 534
  # Retrieve and validate parameters
  my ($old_id) = validateID('oldid');
  my ($new_id) = validateID('newid');
  my $format = validateFormat('html', 'raw');
  my $context = validateContext();

535 536
  # Get old patch data
  my ($old_bugid, $old_description, $old_filename, $old_file_list) =
537
      get_unified_diff($old_id);
538 539 540

  # Get new patch data
  my ($new_bugid, $new_description, $new_filename, $new_file_list) =
541
      get_unified_diff($new_id);
542 543 544 545 546 547 548 549 550 551 552

  my $warning = warn_if_interdiff_might_fail($old_file_list, $new_file_list);

  #
  # send through interdiff, send output directly to template
  #
  # Must hack path so that interdiff will work.
  #
  $ENV{'PATH'} = $::diffpath;
  open my $interdiff_fh, "$::interdiffbin $old_filename $new_filename|";
  binmode $interdiff_fh;
553 554
    my ($reader, $last_reader) = setup_patch_readers("", $context);
    if ($format eq 'raw')
555
  {
556 557
    require PatchReader::DiffPrinter::raw;
    $last_reader->sends_data_to(new PatchReader::DiffPrinter::raw());
558 559 560 561 562 563 564 565
    # Actually print out the patch
    print $cgi->header(-type => 'text/plain',
                       -expires => '+3M');
  }
  else
  {
    $vars->{warning} = $warning if $warning;
    $vars->{bugid} = $new_bugid;
566
    $vars->{oldid} = $old_id;
567
    $vars->{old_desc} = $old_description;
568
    $vars->{newid} = $new_id;
569 570 571 572
    $vars->{new_desc} = $new_description;
    delete $vars->{attachid};
    delete $vars->{do_context};
    delete $vars->{context};
573
    setup_template_patch_reader($last_reader, $format, $context);
574
  }
575
  $reader->iterate_fh($interdiff_fh, "interdiff #$old_id #$new_id");
576 577 578 579 580 581 582 583 584 585 586 587 588 589 590
  close $interdiff_fh;
  $ENV{'PATH'} = '';

  #
  # Delete temporary files
  #
  unlink($old_filename) or warn "Could not unlink $old_filename: $!";
  unlink($new_filename) or warn "Could not unlink $new_filename: $!";
}

sub get_unified_diff
{
  my ($id) = @_;

  # Bring in the modules we need
591 592 593 594
  require PatchReader::Raw;
  require PatchReader::FixPatchRoot;
  require PatchReader::DiffPrinter::raw;
  require PatchReader::PatchInfoGrabber;
595 596 597 598 599 600 601 602 603 604 605
  require File::Temp;

  # Get the patch
  SendSQL("SELECT bug_id, description, ispatch, thedata FROM attachments WHERE attach_id = $id");
  my ($bugid, $description, $ispatch, $thedata) = FetchSQLData();
  if (!$ispatch) {
    $vars->{'attach_id'} = $id;
    ThrowCodeError("must_be_patch");
  }

  # Reads in the patch, converting to unified diff in a temp file
606 607 608
  my $reader = new PatchReader::Raw;
  my $last_reader = $reader;

609
  # fixes patch root (makes canonical if possible)
610 611 612 613 614 615
  if (Param('cvsroot')) {
    my $fix_patch_root = new PatchReader::FixPatchRoot(Param('cvsroot'));
    $last_reader->sends_data_to($fix_patch_root);
    $last_reader = $fix_patch_root;
  }

616
  # Grabs the patch file info
617 618 619 620
  my $patch_info_grabber = new PatchReader::PatchInfoGrabber();
  $last_reader->sends_data_to($patch_info_grabber);
  $last_reader = $patch_info_grabber;

621 622
  # Prints out to temporary file
  my ($fh, $filename) = File::Temp::tempfile();
623 624 625 626
  my $raw_printer = new PatchReader::DiffPrinter::raw($fh);
  $last_reader->sends_data_to($raw_printer);
  $last_reader = $raw_printer;

627
  # Iterate!
628
  $reader->iterate_string($id, $thedata);
629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653

  return ($bugid, $description, $filename, $patch_info_grabber->patch_info()->{files});
}

sub warn_if_interdiff_might_fail {
  my ($old_file_list, $new_file_list) = @_;
  # Verify that the list of files diffed is the same
  my @old_files = sort keys %{$old_file_list};
  my @new_files = sort keys %{$new_file_list};
  if (@old_files != @new_files ||
      join(' ', @old_files) ne join(' ', @new_files)) {
    return "interdiff1";
  }

  # Verify that the revisions in the files are the same
  foreach my $file (keys %{$old_file_list}) {
    if ($old_file_list->{$file}{old_revision} ne
        $new_file_list->{$file}{old_revision}) {
      return "interdiff2";
    }
  }

  return undef;
}

654
sub setup_patch_readers {
655
  my ($diff_root, $context) = @_;
656 657 658 659 660 661 662 663 664

  #
  # Parameters:
  # format=raw|html
  # context=patch|file|0-n
  # collapsed=0|1
  # headers=0|1
  #

665 666 667 668 669
  # Define the patch readers
  # The reader that reads the patch in (whatever its format)
  require PatchReader::Raw;
  my $reader = new PatchReader::Raw;
  my $last_reader = $reader;
670 671 672
  # Fix the patch root if we have a cvs root
  if (Param('cvsroot'))
  {
673 674 675 676
    require PatchReader::FixPatchRoot;
    $last_reader->sends_data_to(new PatchReader::FixPatchRoot(Param('cvsroot')));
    $last_reader->sends_data_to->diff_root($diff_root) if defined($diff_root);
    $last_reader = $last_reader->sends_data_to;
677 678
  }
  # Add in cvs context if we have the necessary info to do it
679
  if ($context ne "patch" && $::cvsbin && Param('cvsroot_get'))
680
  {
681 682
    require PatchReader::AddCVSContext;
    $last_reader->sends_data_to(
683
          new PatchReader::AddCVSContext($context,
684
                                         Param('cvsroot_get')));
685
    $last_reader = $last_reader->sends_data_to;
686
  }
687
  return ($reader, $last_reader);
688 689
}

690
sub setup_template_patch_reader
691
{
692
  my ($last_reader, $format, $context) = @_;
693

694
  require PatchReader::DiffPrinter::template;
695 696

  # Define the vars for templates
697 698
  if (defined $cgi->param('headers')) {
    $vars->{headers} = $cgi->param('headers');
699
  } else {
700
    $vars->{headers} = 1 if !defined $cgi->param('headers');
701
  }
702 703
  $vars->{collapsed} = $cgi->param('collapsed');
  $vars->{context} = $context;
704 705 706 707 708
  $vars->{do_context} = $::cvsbin && Param('cvsroot_get') && !$vars->{'newid'};

  # Print everything out
  print $cgi->header(-type => 'text/html',
                     -expires => '+3M');
709
  $last_reader->sends_data_to(new PatchReader::DiffPrinter::template($template,
710 711 712 713 714 715 716 717 718 719 720 721
                             "attachment/diff-header.$format.tmpl",
                             "attachment/diff-file.$format.tmpl",
                             "attachment/diff-footer.$format.tmpl",
                             { %{$vars},
                               bonsai_url => Param('bonsai_url'),
                               lxr_url => Param('lxr_url'),
                               lxr_root => Param('lxr_root'),
                             }));
}

sub diff
{
722 723 724 725 726
  # Retrieve and validate parameters
  my ($attach_id) = validateID();
  my $format = validateFormat('html', 'raw');
  my $context = validateContext();

727
  # Get patch data
728 729
  SendSQL("SELECT bug_id, description, ispatch, thedata FROM attachments " .
          "WHERE attach_id = $attach_id");
730 731 732 733 734 735 736 737 738
  my ($bugid, $description, $ispatch, $thedata) = FetchSQLData();

  # If it is not a patch, view normally
  if (!$ispatch)
  {
    view();
    return;
  }

739
  my ($reader, $last_reader) = setup_patch_readers(undef,$context);
740

741
  if ($format eq 'raw')
742
  {
743 744
    require PatchReader::DiffPrinter::raw;
    $last_reader->sends_data_to(new PatchReader::DiffPrinter::raw());
745 746 747
    # Actually print out the patch
    print $cgi->header(-type => 'text/plain',
                       -expires => '+3M');
748
    $reader->iterate_string("Attachment $attach_id", $thedata);
749 750 751 752 753 754 755 756 757 758 759
  }
  else
  {
    $vars->{other_patches} = [];
    if ($::interdiffbin && $::diffpath) {
      # Get list of attachments on this bug.
      # Ignore the current patch, but select the one right before it
      # chronologically.
      SendSQL("SELECT attach_id, description FROM attachments WHERE bug_id = $bugid AND ispatch = 1 ORDER BY creation_ts DESC");
      my $select_next_patch = 0;
      while (my ($other_id, $other_desc) = FetchSQLData()) {
760
        if ($other_id eq $attach_id) {
761 762 763 764 765 766 767 768 769 770 771
          $select_next_patch = 1;
        } else {
          push @{$vars->{other_patches}}, { id => $other_id, desc => $other_desc, selected => $select_next_patch };
          if ($select_next_patch) {
            $select_next_patch = 0;
          }
        }
      }
    }

    $vars->{bugid} = $bugid;
772
    $vars->{attachid} = $attach_id;
773
    $vars->{description} = $description;
774
    setup_template_patch_reader($last_reader, $format, $context);
775
    # Actually print out the patch
776
    $reader->iterate_string("Attachment $attach_id", $thedata);
777 778
  }
}
779

780 781
# Display all attachments for a given bug in a series of IFRAMEs within one
# HTML page.
782 783
sub viewall
{
784 785 786
    # Retrieve and validate parameters
    my $bugid = $cgi->param('bugid');
    ValidateBugID($bugid);
787

788 789
    # Retrieve the attachments from the database and write them into an array
    # of hashes where each hash represents one attachment.
790
    my $privacy = "";
791 792
    my $dbh = Bugzilla->dbh;

793 794 795
    if (Param("insidergroup") && !(UserInGroup(Param("insidergroup")))) {
        $privacy = "AND isprivate < 1 ";
    }
796 797 798
    SendSQL("SELECT attach_id, " .
            $dbh->sql_date_format('creation_ts', '%Y.%m.%d %H:%i') . ",
            mimetype, description, ispatch, isobsolete, isprivate, 
799
            LENGTH(thedata)
800
            FROM attachments WHERE bug_id = $bugid $privacy 
801
            ORDER BY attach_id");
802
  my @attachments; # the attachments array
803 804
  while (MoreSQLData())
  {
805
    my %a; # the attachment hash
806
    ($a{'attachid'}, $a{'date'}, $a{'contenttype'},
807 808
     $a{'description'}, $a{'ispatch'}, $a{'isobsolete'}, $a{'isprivate'},
     $a{'datasize'}) = FetchSQLData();
809
    $a{'isviewable'} = isViewable($a{'contenttype'});
810 811
    $a{'flags'} = Bugzilla::Flag::match({ 'attach_id' => $a{'attachid'},
                                          'is_active' => 1 });
812 813 814 815 816

    # Add the hash representing the attachment to the array of attachments.
    push @attachments, \%a;
  }

817 818
  # Retrieve the bug summary (for displaying on screen) and assignee.
  SendSQL("SELECT short_desc, assigned_to FROM bugs " .
819
          "WHERE bug_id = $bugid");
820
  my ($bugsummary, $assignee_id) = FetchSQLData();
821 822

  # Define the variables and functions that will be passed to the UI template.
823
  $vars->{'bugid'} = $bugid;
824
  $vars->{'attachments'} = \@attachments;
825 826
  $vars->{'bugassignee_id'} = $assignee_id;
  $vars->{'bugsummary'} = $bugsummary;
827
  $vars->{'GetBugLink'} = \&GetBugLink;
828

829
  print $cgi->header();
830 831

  # Generate and return the UI (HTML page) from the appropriate template.
832 833
  $template->process("attachment/show-multiple.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
834 835
}

836
# Display a form for entering a new attachment.
837 838
sub enter
{
839 840 841 842
  # Retrieve and validate parameters
  my $bugid = $cgi->param('bugid');
  ValidateBugID($bugid);
  validateCanChangeBug($bugid);
843

844 845 846 847
  # Retrieve the attachments the user can edit from the database and write
  # them into an array of hashes where each hash represents one attachment.
  my $canEdit = "";
  if (!UserInGroup("editbugs")) {
848
      $canEdit = "AND submitter_id = " . Bugzilla->user->id;
849
  }
850
  SendSQL("SELECT attach_id, description, isprivate
851
           FROM attachments
852
           WHERE bug_id = $bugid 
853
           AND isobsolete = 0 $canEdit
854 855 856 857
           ORDER BY attach_id");
  my @attachments; # the attachments array
  while ( MoreSQLData() ) {
    my %a; # the attachment hash
858
    ($a{'id'}, $a{'description'}, $a{'isprivate'}) = FetchSQLData();
859 860 861 862 863

    # Add the hash representing the attachment to the array of attachments.
    push @attachments, \%a;
  }

864 865
  # Retrieve the bug summary (for displaying on screen) and assignee.
  SendSQL("SELECT short_desc, assigned_to FROM bugs 
866
           WHERE bug_id = $bugid");
867
  my ($bugsummary, $assignee_id) = FetchSQLData();
868 869

  # Define the variables and functions that will be passed to the UI template.
870
  $vars->{'bugid'} = $bugid;
871
  $vars->{'attachments'} = \@attachments;
872 873
  $vars->{'bugassignee_id'} = $assignee_id;
  $vars->{'bugsummary'} = $bugsummary;
874
  $vars->{'GetBugLink'} = \&GetBugLink;
875

876
  SendSQL("SELECT product_id, component_id FROM bugs
877
           WHERE bug_id = $bugid");
878 879 880 881 882 883 884 885
  my ($product_id, $component_id) = FetchSQLData();
  my $flag_types = Bugzilla::FlagType::match({'target_type'  => 'attachment',
                                              'product_id'   => $product_id,
                                              'component_id' => $component_id});
  $vars->{'flag_types'} = $flag_types;
  $vars->{'any_flags_requesteeble'} = grep($_->{'is_requesteeble'},
                                           @$flag_types);

886
  print $cgi->header();
887 888

  # Generate and return the UI (HTML page) from the appropriate template.
889 890
  $template->process("attachment/create.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
891 892
}

893
# Insert a new attachment into the database.
894 895
sub insert
{
896 897
    my $dbh = Bugzilla->dbh;
    my $userid = Bugzilla->user->id;
898

899 900 901 902 903 904 905 906
    # Retrieve and validate parameters
    my $bugid = $cgi->param('bugid');
    ValidateBugID($bugid);
    validateCanChangeBug($bugid);
    ValidateComment(scalar $cgi->param('comment'));
    my $filename = validateFilename();
    validateIsPatch();
    validateDescription();
907 908
    # need to validate content type before data as
    # we now check the content type for image/bmp in validateData()
909
    validateContentType() unless $cgi->param('ispatch');
910
    my $data = validateData();
911 912 913 914 915 916 917

    my @obsolete_ids = ();
    @obsolete_ids = validateObsolete() if $cgi->param('obsolete');

    # The order of these function calls is important, as both Flag::validate
    # and FlagType::validate assume User::match_field has ensured that the
    # values in the requestee fields are legitimate user email addresses.
918
    my $match_status = Bugzilla::User::match_field($cgi, {
919
        '^requestee(_type)?-(\d+)$' => { 'type' => 'multi' },
920 921 922 923 924 925 926 927 928 929
    }, MATCH_SKIP_CONFIRM);

    $vars->{'match_field'} = 'requestee';
    if ($match_status == USER_MATCH_FAILED) {
        $vars->{'message'} = 'user_match_failed';
    }
    elsif ($match_status == USER_MATCH_MULTIPLE) {
        $vars->{'message'} = 'user_match_multiple';
    }

930 931 932 933 934
    # Flag::validate() should not detect any reference to existing
    # flags when creating a new attachment. Setting the third param
    # to -1 will force this function to check this point.
    Bugzilla::Flag::validate($cgi, $bugid, -1);
    Bugzilla::FlagType::validate($cgi, $bugid);
935 936 937 938 939 940

    # Escape characters in strings that will be used in SQL statements.
    my $sql_filename = SqlQuote($filename);
    my $description = SqlQuote($cgi->param('description'));
    my $contenttype = SqlQuote($cgi->param('contenttype'));
    my $isprivate = $cgi->param('isprivate') ? 1 : 0;
941

942 943 944 945
  # Figure out when the changes were made.
  my ($timestamp) = Bugzilla->dbh->selectrow_array("SELECT NOW()"); 
  my $sql_timestamp = SqlQuote($timestamp); 

946
  # Insert the attachment into the database.
947 948 949
  my $sth = $dbh->prepare("INSERT INTO attachments
      (thedata, bug_id, creation_ts, filename, description,
       mimetype, ispatch, isprivate, submitter_id) 
950 951 952
      VALUES (?, $bugid, $sql_timestamp, $sql_filename,
              $description, $contenttype, " . $cgi->param('ispatch') . ",
              $isprivate, $userid)");
953 954 955 956 957
  # We only use $data here in this INSERT with a placeholder,
  # so it's safe.
  trick_taint($data);
  $sth->bind_param(1, $data, $dbh->BLOB_TYPE);
  $sth->execute();
958 959

  # Retrieve the ID of the newly created attachment record.
960
  my $attachid = $dbh->bz_last_key('attachments', 'attach_id');
961

962 963
  # If the file is to be stored locally, stream the file from the webserver
  # to the local file without reading it into a local variable.
964
  if ($cgi->param('bigfile'))
965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989
  {
    my $fh = $cgi->upload('data');
    my $hash = ($attachid % 100) + 100;
    $hash =~ s/.*(\d\d)$/group.$1/;
    mkdir "$attachdir/$hash", 0770;
    chmod 0770, "$attachdir/$hash";
    open(AH, ">$attachdir/$hash/attachment.$attachid");
    binmode AH;
    my $sizecount = 0;
    my $limit = (Param("maxlocalattachment") * 1048576);
    while (<$fh>) {
        print AH $_;
        $sizecount += length($_);
        if ($sizecount > $limit) {
            close AH;
            close $fh;
            unlink "$attachdir/$hash/attachment.$attachid";
            ThrowUserError("local_file_too_large");
        }
    }
    close AH;
    close $fh;
  }


990
  # Insert a comment about the new attachment into the database.
991 992 993
  my $comment = "Created an attachment (id=$attachid)\n" .
                $cgi->param('description') . "\n";
  $comment .= ("\n" . $cgi->param('comment')) if defined $cgi->param('comment');
994

995
  AppendComment($bugid, $userid, $comment, $isprivate, $timestamp);
996 997 998

  # Make existing attachments obsolete.
  my $fieldid = GetFieldID('attachments.isobsolete');
999
  foreach my $obsolete_id (@obsolete_ids) {
1000 1001
      # If the obsolete attachment has request flags, cancel them.
      # This call must be done before updating the 'attachments' table.
1002 1003 1004 1005 1006 1007 1008 1009
      Bugzilla::Flag::CancelRequests($bugid, $obsolete_id, $sql_timestamp);

      SendSQL("UPDATE attachments SET isobsolete = 1 " . 
              "WHERE attach_id = $obsolete_id");
      SendSQL("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when,
                                          fieldid, removed, added) 
              VALUES ($bugid, $obsolete_id, $userid, $sql_timestamp, $fieldid,
                      '0', '1')");
1010 1011
  }

1012
  # Assign the bug to the user, if they are allowed to take it
1013
  my $owner = "";
1014
  
1015
  if ($cgi->param('takebug') && UserInGroup("editbugs")) {
1016 1017 1018 1019
      
      my @fields = ("assigned_to", "bug_status", "resolution", "login_name");
      
      # Get the old values, for the bugs_activity table
1020 1021 1022 1023
      SendSQL("SELECT " . join(", ", @fields) . " " .
              "FROM bugs " .
              "INNER JOIN profiles " .
              "ON profiles.userid = bugs.assigned_to " .
1024
              "WHERE bugs.bug_id = $bugid");
1025 1026
      
      my @oldvalues = FetchSQLData();
1027
      my @newvalues = ($userid, "ASSIGNED", "", Bugzilla->user->login);
1028 1029
      
      # Make sure the person we are taking the bug from gets mail.
1030
      $owner = $oldvalues[3];  
1031 1032 1033 1034 1035
                  
      @oldvalues = map(SqlQuote($_), @oldvalues);
      @newvalues = map(SqlQuote($_), @newvalues);
               
      # Update the bug record. Note that this doesn't involve login_name.
1036
      SendSQL("UPDATE bugs SET delta_ts = $sql_timestamp, " . 
1037
              join(", ", map("$fields[$_] = $newvalues[$_]", (0..2))) . 
1038
              " WHERE bug_id = $bugid");
1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049
      
      # We store email addresses in the bugs_activity table rather than IDs.
      $oldvalues[0] = $oldvalues[3];
      $newvalues[0] = $newvalues[3];
      
      # Add the changes to the bugs_activity table
      for (my $i = 0; $i < 3; $i++) {
          if ($oldvalues[$i] ne $newvalues[$i]) {
              my $fieldid = GetFieldID($fields[$i]);
              SendSQL("INSERT INTO bugs_activity " .
                      "(bug_id, who, bug_when, fieldid, removed, added) " .
1050 1051
                      "VALUES ($bugid, $userid, $sql_timestamp, " .
                      "$fieldid, $oldvalues[$i], $newvalues[$i])");
1052 1053 1054 1055
          }
      }      
  }   
  
1056
  # Create flags.
1057
  Bugzilla::Flag::process($bugid, $attachid, $timestamp, $cgi);
1058
   
1059
  # Define the variables and functions that will be passed to the UI template.
1060
  $vars->{'mailrecipients'} =  { 'changer' => Bugzilla->user->login,
1061
                                 'owner'   => $owner };
1062
  $vars->{'bugid'} = $bugid;
1063 1064
  $vars->{'attachid'} = $attachid;
  $vars->{'description'} = $description;
1065 1066
  $vars->{'contenttypemethod'} = $cgi->param('contenttypemethod');
  $vars->{'contenttype'} = $cgi->param('contenttype');
1067

1068
  print $cgi->header();
1069 1070

  # Generate and return the UI (HTML page) from the appropriate template.
1071 1072
  $template->process("attachment/created.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
1073 1074
}

1075 1076 1077 1078
# Displays a form for editing attachment properties.
# Any user is allowed to access this page, unless the attachment
# is private and the user does not belong to the insider group.
# Validations are done later when the user submits changes.
1079 1080
sub edit
{
1081 1082
  # Retrieve and validate parameters
  my ($attach_id) = validateID();
1083 1084

  # Retrieve the attachment from the database.
1085
  SendSQL("SELECT description, mimetype, filename, bug_id, ispatch, isobsolete, isprivate, LENGTH(thedata)
1086
           FROM attachments WHERE attach_id = $attach_id");
1087
  my ($description, $contenttype, $filename, $bugid, $ispatch, $isobsolete, $isprivate, $datasize) = FetchSQLData();
1088

1089
  my $isviewable = isViewable($contenttype);
1090 1091 1092 1093 1094 1095 1096 1097

  # Retrieve a list of attachments for this bug as well as a summary of the bug
  # to use in a navigation bar across the top of the screen.
  SendSQL("SELECT attach_id FROM attachments WHERE bug_id = $bugid ORDER BY attach_id");
  my @bugattachments;
  push(@bugattachments, FetchSQLData()) while (MoreSQLData());
  SendSQL("SELECT short_desc FROM bugs WHERE bug_id = $bugid");
  my ($bugsummary) = FetchSQLData();
1098 1099 1100 1101
  
  # Get a list of flag types that can be set for this attachment.
  SendSQL("SELECT product_id, component_id FROM bugs WHERE bug_id = $bugid");
  my ($product_id, $component_id) = FetchSQLData();
1102 1103
  my $flag_types = Bugzilla::FlagType::match({ 'target_type'  => 'attachment' ,
                                               'product_id'   => $product_id ,
1104
                                               'component_id' => $component_id });
1105
  foreach my $flag_type (@$flag_types) {
1106
    $flag_type->{'flags'} = Bugzilla::Flag::match({ 'type_id'   => $flag_type->{'id'},
1107
                                                    'attach_id' => $attach_id,
1108
                                                    'is_active' => 1 });
1109 1110
  }
  $vars->{'flag_types'} = $flag_types;
1111
  $vars->{'any_flags_requesteeble'} = grep($_->{'is_requesteeble'}, @$flag_types);
1112
  
1113
  # Define the variables and functions that will be passed to the UI template.
1114
  $vars->{'attachid'} = $attach_id; 
1115
  $vars->{'description'} = $description; 
1116
  $vars->{'contenttype'} = $contenttype; 
1117
  $vars->{'filename'} = $filename;
1118 1119 1120 1121
  $vars->{'bugid'} = $bugid; 
  $vars->{'bugsummary'} = $bugsummary; 
  $vars->{'ispatch'} = $ispatch; 
  $vars->{'isobsolete'} = $isobsolete; 
1122
  $vars->{'isprivate'} = $isprivate; 
1123
  $vars->{'datasize'} = $datasize;
1124 1125
  $vars->{'isviewable'} = $isviewable; 
  $vars->{'attachments'} = \@bugattachments; 
1126
  $vars->{'GetBugLink'} = \&GetBugLink;
1127

1128 1129 1130 1131 1132
  # Determine if PatchReader is installed
  eval {
    require PatchReader;
    $vars->{'patchviewerinstalled'} = 1;
  };
1133
  print $cgi->header();
1134 1135

  # Generate and return the UI (HTML page) from the appropriate template.
1136 1137
  $template->process("attachment/edit.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
1138 1139
}

1140 1141 1142 1143 1144
# Updates an attachment record. Users with "editbugs" privileges, (or the
# original attachment's submitter) can edit the attachment's description,
# content type, ispatch and isobsolete flags, and statuses, and they can
# also submit a comment that appears in the bug.
# Users cannot edit the content of the attachment itself.
1145 1146
sub update
{
1147
  my $dbh = Bugzilla->dbh;
1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164
  my $userid = Bugzilla->user->id;

    # Retrieve and validate parameters
    ValidateComment(scalar $cgi->param('comment'));
    my ($attach_id, $bugid) = validateID();
    validateCanEdit($attach_id);
    validateCanChangeAttachment($attach_id);
    validateDescription();
    validateIsPatch();
    validateContentType() unless $cgi->param('ispatch');
    validateIsObsolete();
    validatePrivate();

    # The order of these function calls is important, as both Flag::validate
    # and FlagType::validate assume User::match_field has ensured that the
    # values in the requestee fields are legitimate user email addresses.
    Bugzilla::User::match_field($cgi, {
1165
        '^requestee(_type)?-(\d+)$' => { 'type' => 'multi' }
1166
    });
1167
    Bugzilla::Flag::validate($cgi, $bugid, $attach_id);
1168
    Bugzilla::FlagType::validate($cgi, $bugid, $attach_id);
1169

1170
  # Lock database tables in preparation for updating the attachment.
1171 1172 1173
  $dbh->bz_lock_tables('attachments WRITE', 'flags WRITE' ,
          'flagtypes READ', 'fielddefs READ', 'bugs_activity WRITE',
          'flaginclusions AS i READ', 'flagexclusions AS e READ',
1174 1175
          # cc, bug_group_map, user_group_map, and groups are in here so we
          # can check the permissions of flag requestees and email addresses
1176 1177 1178 1179 1180
          # on the flag type cc: lists via the CanSeeBug
          # function call in Flag::notify. group_group_map is in here in case
          # Bugzilla::User needs to rederive groups. profiles and 
          # user_group_map would be READ locks instead of WRITE locks if it
          # weren't for derive_groups, which needs to write to those tables.
1181
          'bugs WRITE', 'profiles WRITE', 'email_setting READ',
1182 1183 1184
          'cc READ', 'bug_group_map READ', 'user_group_map WRITE',
          'group_group_map READ', 'groups READ');

1185 1186
  # Get a copy of the attachment record before we make changes
  # so we can record those changes in the activity table.
1187
  SendSQL("SELECT description, mimetype, filename, ispatch, isobsolete, isprivate
1188
           FROM attachments WHERE attach_id = $attach_id");
1189 1190
  my ($olddescription, $oldcontenttype, $oldfilename, $oldispatch,
      $oldisobsolete, $oldisprivate) = FetchSQLData();
1191

1192
  # Quote the description and content type for use in the SQL UPDATE statement.
1193 1194 1195
  my $quoteddescription = SqlQuote($cgi->param('description'));
  my $quotedcontenttype = SqlQuote($cgi->param('contenttype'));
  my $quotedfilename = SqlQuote($cgi->param('filename'));
1196

1197 1198 1199 1200
  # Figure out when the changes were made.
  SendSQL("SELECT NOW()");
  my $timestamp = FetchOneColumn();
    
1201 1202 1203 1204
  # Update flags.  We have to do this before committing changes
  # to attachments so that we can delete pending requests if the user
  # is obsoleting this attachment without deleting any requests
  # the user submits at the same time.
1205
  Bugzilla::Flag::process($bugid, $attach_id, $timestamp, $cgi);
1206

1207 1208
  # Update the attachment record in the database.
  SendSQL("UPDATE  attachments 
1209 1210
           SET     description = $quoteddescription ,
                   mimetype = $quotedcontenttype ,
1211
                   filename = $quotedfilename ,
1212 1213 1214 1215
                   ispatch = " . $cgi->param('ispatch') . ",
                   isobsolete = " . $cgi->param('isobsolete') . ",
                   isprivate = " . $cgi->param('isprivate') . "
           WHERE   attach_id = $attach_id
1216 1217 1218
         ");

  # Record changes in the activity table.
1219
  my $sql_timestamp = SqlQuote($timestamp);
1220
  if ($olddescription ne $cgi->param('description')) {
1221 1222
    my $quotedolddescription = SqlQuote($olddescription);
    my $fieldid = GetFieldID('attachments.description');
1223 1224 1225 1226
    SendSQL("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when,
                                        fieldid, removed, added)
             VALUES ($bugid, $attach_id, $userid, $sql_timestamp, $fieldid,
                     $quotedolddescription, $quoteddescription)");
1227
  }
1228
  if ($oldcontenttype ne $cgi->param('contenttype')) {
1229
    my $quotedoldcontenttype = SqlQuote($oldcontenttype);
1230
    my $fieldid = GetFieldID('attachments.mimetype');
1231 1232 1233 1234
    SendSQL("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when,
                                        fieldid, removed, added)
             VALUES ($bugid, $attach_id, $userid, $sql_timestamp, $fieldid,
                     $quotedoldcontenttype, $quotedcontenttype)");
1235
  }
1236
  if ($oldfilename ne $cgi->param('filename')) {
1237 1238
    my $quotedoldfilename = SqlQuote($oldfilename);
    my $fieldid = GetFieldID('attachments.filename');
1239 1240 1241 1242
    SendSQL("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when,
                                        fieldid, removed, added)
             VALUES ($bugid, $attach_id, $userid, $sql_timestamp, $fieldid,
                     $quotedoldfilename, $quotedfilename)");
1243
  }
1244
  if ($oldispatch ne $cgi->param('ispatch')) {
1245
    my $fieldid = GetFieldID('attachments.ispatch');
1246 1247 1248 1249
    SendSQL("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when,
                                        fieldid, removed, added)
             VALUES ($bugid, $attach_id, $userid, $sql_timestamp, $fieldid,
                     $oldispatch, " . $cgi->param('ispatch') . ")");
1250
  }
1251
  if ($oldisobsolete ne $cgi->param('isobsolete')) {
1252
    my $fieldid = GetFieldID('attachments.isobsolete');
1253 1254 1255 1256
    SendSQL("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when,
                                        fieldid, removed, added)
             VALUES ($bugid, $attach_id, $userid, $sql_timestamp, $fieldid,
                     $oldisobsolete, " . $cgi->param('isobsolete') . ")");
1257
  }
1258
  if ($oldisprivate ne $cgi->param('isprivate')) {
1259
    my $fieldid = GetFieldID('attachments.isprivate');
1260 1261 1262 1263
    SendSQL("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when,
                                        fieldid, removed, added)
             VALUES ($bugid, $attach_id, $userid, $sql_timestamp, $fieldid,
                     $oldisprivate, " . $cgi->param('isprivate') . ")");
1264
  }
1265
  
1266
  # Unlock all database tables now that we are finished updating the database.
1267
  $dbh->bz_unlock_tables();
1268

1269
  # If the user submitted a comment while editing the attachment,
1270
  # add the comment to the bug.
1271
  if ($cgi->param('comment'))
1272
  {
1273 1274 1275 1276
    # Prepend a string to the comment to let users know that the comment came
    # from the "edit attachment" screen.
    my $comment = qq|(From update of attachment $attach_id)\n| .
                  $cgi->param('comment');
1277 1278

    # Append the comment to the list of comments in the database.
1279
    AppendComment($bugid, $userid, $comment, $cgi->param('isprivate'), $timestamp);
1280
  }
1281
  
1282
  # Define the variables and functions that will be passed to the UI template.
1283
  $vars->{'mailrecipients'} = { 'changer' => Bugzilla->user->login };
1284
  $vars->{'attachid'} = $attach_id; 
1285 1286
  $vars->{'bugid'} = $bugid; 

1287
  print $cgi->header();
1288 1289

  # Generate and return the UI (HTML page) from the appropriate template.
1290 1291
  $template->process("attachment/updated.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
1292
}