attachment.cgi 28.4 KB
Newer Older
1
#!/usr/bin/perl -wT
2 3 4
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
5
#
6 7
# This Source Code Form is "Incompatible With Secondary Licenses", as
# defined by the Mozilla Public License, v. 2.0.
8

9
use 5.10.1;
10
use strict;
11
use lib qw(. lib);
12

13
use Bugzilla;
14
use Bugzilla::BugMail;
15
use Bugzilla::Constants;
16
use Bugzilla::Error;
17 18
use Bugzilla::Flag; 
use Bugzilla::FlagType; 
19
use Bugzilla::User;
20
use Bugzilla::Util;
21
use Bugzilla::Bug;
22
use Bugzilla::Attachment;
23
use Bugzilla::Attachment::PatchReader;
24
use Bugzilla::Token;
25

26
use Encode qw(encode find_encoding);
27

28 29 30 31 32 33 34
# For most scripts we don't make $cgi and $template global variables. But
# when preparing Bugzilla for mod_perl, this script used these
# variables in so many subroutines that it was easier to just
# make them globals.
local our $cgi = Bugzilla->cgi;
local our $template = Bugzilla->template;
local our $vars = {};
35

36 37 38 39
# All calls to this script should contain an "action" variable whose
# value determines what the user wants to do.  The code below checks
# the value of that variable and runs the appropriate code. If none is
# supplied, we default to 'view'.
40 41

# Determine whether to use the action specified by the user or the default.
42
my $action = $cgi->param('action') || 'view';
43
my $format = $cgi->param('format') || '';
44

45
# You must use the appropriate urlbase/sslbase param when doing anything
46 47 48 49
# but viewing an attachment, or a raw diff.
if ($action ne 'view'
    && (($action !~ /^(?:interdiff|diff)$/) || $format ne 'raw'))
{
50 51
    do_ssl_redirect_if_required();
    if ($cgi->url_is_attachment_base) {
52 53 54 55 56 57 58 59
        $cgi->redirect_to_urlbase;
    }
    Bugzilla->login();
}

# When viewing an attachment, do not request credentials if we are on
# the alternate host. Let view() decide when to call Bugzilla->login.
if ($action eq "view")
60
{
61
    view();
62
}
63 64
elsif ($action eq "interdiff")
{
65
    interdiff();
66 67 68
}
elsif ($action eq "diff")
{
69
    diff();
70
}
71 72
elsif ($action eq "viewall") 
{ 
73
    viewall(); 
74
}
75 76
elsif ($action eq "enter") 
{ 
77 78
    Bugzilla->login(LOGIN_REQUIRED);
    enter(); 
79 80 81
}
elsif ($action eq "insert")
{
82 83
    Bugzilla->login(LOGIN_REQUIRED);
    insert();
84
}
85 86
elsif ($action eq "edit") 
{ 
87
    edit(); 
88 89 90
}
elsif ($action eq "update") 
{ 
91 92
    Bugzilla->login(LOGIN_REQUIRED);
    update();
93
}
94 95 96
elsif ($action eq "delete") {
    delete_attachment();
}
97 98
else 
{ 
99
  ThrowUserError('unknown_action', {action => $action});
100 101 102 103 104 105 106 107
}

exit;

################################################################################
# Data Validation / Security Authorization
################################################################################

108 109 110
# Validates an attachment ID. Optionally takes a parameter of a form
# variable name that contains the ID to be validated. If not specified,
# uses 'id'.
111 112
# If the second parameter is true, the attachment ID will be validated,
# however the current user's access to the attachment will not be checked.
113 114 115 116
# Will throw an error if 1) attachment ID is not a valid number,
# 2) attachment does not exist, or 3) user isn't allowed to access the
# attachment.
#
117 118 119
# Returns an attachment object.

sub validateID {
120 121
    my($param, $dont_validate_access) = @_;
    $param ||= 'id';
122

123 124 125
    # If we're not doing interdiffs, check if id wasn't specified and
    # prompt them with a page that allows them to choose an attachment.
    # Happens when calling plain attachment.cgi from the urlbar directly
126
    if ($param eq 'id' && !$cgi->param('id')) {
127
        print $cgi->header();
128 129 130 131
        $template->process("attachment/choose.html.tmpl", $vars) ||
            ThrowTemplateError($template->error());
        exit;
    }
132
    
133 134 135 136 137 138
    my $attach_id = $cgi->param($param);

    # Validate the specified attachment id. detaint kills $attach_id if
    # non-natural, so use the original value from $cgi in our exception
    # message here.
    detaint_natural($attach_id)
139 140
        || ThrowUserError("invalid_attach_id",
                          { attach_id => scalar $cgi->param($param) });
141
  
142
    # Make sure the attachment exists in the database.
143
    my $attachment = new Bugzilla::Attachment({ id => $attach_id, cache => 1 })
144
        || ThrowUserError("invalid_attach_id", { attach_id => $attach_id });
145

146 147 148 149 150 151 152 153
    return $attachment if ($dont_validate_access || check_can_access($attachment));
}

# Make sure the current user has access to the specified attachment.
sub check_can_access {
    my $attachment = shift;
    my $user = Bugzilla->user;

154
    # Make sure the user is authorized to access this attachment's bug.
155
    Bugzilla::Bug->check({ id => $attachment->bug_id, cache => 1 });
156 157 158
    if ($attachment->isprivate && $user->id != $attachment->attacher->id 
        && !$user->is_insider) 
    {
159
        ThrowUserError('auth_failure', {action => 'access',
160 161
                                        object => 'attachment',
                                        attach_id => $attachment->id});
162
    }
163 164 165 166 167 168 169 170 171 172 173 174 175
    return 1;
}

# Determines if the attachment is public -- that is, if users who are
# not logged in have access to the attachment
sub attachmentIsPublic {
    my $attachment = shift;

    return 0 if Bugzilla->params->{'requirelogin'};
    return 0 if $attachment->isprivate;

    my $anon_user = new Bugzilla::User;
    return $anon_user->can_see_bug($attachment->bug_id);
176 177
}

178 179 180
# Validates format of a diff/interdiff. Takes a list as an parameter, which
# defines the valid format values. Will throw an error if the format is not
# in the list. Returns either the user selected or default format.
181
sub validateFormat {
182 183
  # receives a list of legal formats; first item is a default
  my $format = $cgi->param('format') || $_[0];
184
  if (not grep($_ eq $format, @_)) {
185
     ThrowUserError("invalid_format", { format  => $format, formats => \@_ });
186
  }
187

188
  return $format;
189 190
}

191 192
# Validates context of a diff/interdiff. Will throw an error if the context
# is not number, "file" or "patch". Returns the validated, detainted context.
193 194
sub validateContext
{
195 196 197 198
  my $context = $cgi->param('context') || "patch";
  if ($context ne "file" && $context ne "patch") {
    detaint_natural($context)
      || ThrowUserError("invalid_context", { context => $cgi->param('context') });
199
  }
200 201

  return $context;
202 203
}

204 205 206 207
# Gets the attachment object(s) generated by validateID, while ensuring
# attachbase and token authentication is used when required.
sub get_attachment {
    my @field_names = @_ ? @_ : qw(id);
208

209
    my %attachments;
210 211

    if (use_attachbase()) {
212 213 214 215 216 217 218 219 220 221
        # Load each attachment, and ensure they are all from the same bug
        my $bug_id = 0;
        foreach my $field_name (@field_names) {
            my $attachment = validateID($field_name, 1);
            if (!$bug_id) {
                $bug_id = $attachment->bug_id;
            } elsif ($attachment->bug_id != $bug_id) {
                ThrowUserError('attachment_bug_id_mismatch');
            }
            $attachments{$field_name} = $attachment;
222
        }
223 224 225 226 227
        my @args = map { $_ . '=' . $attachments{$_}->id } @field_names;
        my $cgi_params = $cgi->canonicalise_query(@field_names, 't',
            'Bugzilla_login', 'Bugzilla_password');
        push(@args, $cgi_params) if $cgi_params;
        my $path = 'attachment.cgi?' . join('&', @args);
228 229

        # Make sure the attachment is served from the correct server.
230 231 232
        if ($cgi->url_is_attachment_base($bug_id)) {
            # No need to validate the token for public attachments. We cannot request
            # credentials as we are on the alternate host.
233
            if (!all_attachments_are_public(\%attachments)) {
234
                my $token = $cgi->param('t');
235 236 237 238 239 240 241 242 243 244 245 246 247 248
                my ($userid, undef, $token_data) = Bugzilla::Token::GetTokenData($token);
                my %token_data = unpack_token_data($token_data);
                my $valid_token = 1;
                foreach my $field_name (@field_names) {
                    my $token_id = $token_data{$field_name};
                    if (!$token_id
                        || !detaint_natural($token_id)
                        || $attachments{$field_name}->id != $token_id)
                    {
                        $valid_token = 0;
                        last;
                    }
                }
                unless ($userid && $valid_token) {
249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266
                    # Not a valid token.
                    print $cgi->redirect('-location' => correct_urlbase() . $path);
                    exit;
                }
                # Change current user without creating cookies.
                Bugzilla->set_user(new Bugzilla::User($userid));
                # Tokens are single use only, delete it.
                delete_token($token);
            }
        }
        elsif ($cgi->url_is_attachment_base) {
            # If we come here, this means that each bug has its own host
            # for attachments, and that we are trying to view one attachment
            # using another bug's host. That's not desired.
            $cgi->redirect_to_urlbase;
        }
        else {
            # We couldn't call Bugzilla->login earlier as we first had to
267 268
            # make sure we were not going to request credentials on the
            # alternate host.
269
            Bugzilla->login();
270 271 272 273
            my $attachbase = Bugzilla->params->{'attachment_base'};
            # Replace %bugid% by the ID of the bug the attachment 
            # belongs to, if present.
            $attachbase =~ s/\%bugid\%/$bug_id/;
274
            if (all_attachments_are_public(\%attachments)) {
275 276 277 278 279
                # No need for a token; redirect to attachment base.
                print $cgi->redirect(-location => $attachbase . $path);
                exit;
            } else {
                # Make sure the user can view the attachment.
280 281 282
                foreach my $field_name (@field_names) {
                    check_can_access($attachments{$field_name});
                }
283
                # Create a token and redirect.
284
                my $token = url_quote(issue_session_token(pack_token_data(\%attachments)));
285 286 287 288 289
                print $cgi->redirect(-location => $attachbase . "$path&t=$token");
                exit;
            }
        }
    } else {
290
        do_ssl_redirect_if_required();
291 292
        # No alternate host is used. Request credentials if required.
        Bugzilla->login();
293 294 295
        foreach my $field_name (@field_names) {
            $attachments{$field_name} = validateID($field_name);
        }
296 297
    }

298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335
    return wantarray
        ? map { $attachments{$_} } @field_names
        : $attachments{$field_names[0]};
}

sub all_attachments_are_public {
    my $attachments = shift;
    foreach my $field_name (keys %$attachments) {
        if (!attachmentIsPublic($attachments->{$field_name})) {
            return 0;
        }
    }
    return 1;
}

sub pack_token_data {
    my $attachments = shift;
    return join(' ', map { $_ . '=' . $attachments->{$_}->id } keys %$attachments);
}

sub unpack_token_data {
    my @token_data = split(/ /, shift || '');
    my %data;
    foreach my $token (@token_data) {
        my ($field_name, $attach_id) = split('=', $token);
        $data{$field_name} = $attach_id;
    }
    return %data;
}

################################################################################
# Functions
################################################################################

# Display an attachment.
sub view {
    my $attachment = get_attachment();

336
    # At this point, Bugzilla->login has been called if it had to.
337 338 339
    my $contenttype = $attachment->contenttype;
    my $filename = $attachment->filename;

340 341
    # Bug 111522: allow overriding content-type manually in the posted form
    # params.
342 343
    if (defined $cgi->param('content_type')) {
        $contenttype = $attachment->_check_content_type($cgi->param('content_type'));
344
    }
345

346
    # Return the appropriate HTTP response headers.
347
    $attachment->datasize || ThrowUserError("attachment_removed");
348

349
    $filename =~ s/^.*[\/\\]//;
350 351 352 353
    # escape quotes and backslashes in the filename, per RFCs 2045/822
    $filename =~ s/\\/\\\\/g; # escape backslashes
    $filename =~ s/"/\\"/g; # escape quotes

354 355 356 357 358
    # Avoid line wrapping done by Encode, which we don't need for HTTP
    # headers. See discussion in bug 328628 for details.
    local $Encode::Encoding{'MIME-Q'}->{'bpl'} = 10000;
    $filename = encode('MIME-Q', $filename);

359 360
    my $disposition = Bugzilla->params->{'allow_attachment_display'} ? 'inline' : 'attachment';

361 362 363 364 365 366 367
    # Don't send a charset header with attachments--they might not be UTF-8.
    # However, we do allow people to explicitly specify a charset if they
    # want.
    if ($contenttype !~ /\bcharset=/i) {
        # In order to prevent Apache from adding a charset, we have to send a
        # charset that's a single space.
        $cgi->charset(' ');
368 369 370 371 372 373
        if (Bugzilla->feature('detect_charset') && $contenttype =~ /^text\//) {
            my $encoding = detect_encoding($attachment->data);
            if ($encoding) {
                $cgi->charset(find_encoding($encoding)->mime_name);
            }
        }
374
    }
375
    print $cgi->header(-type=>"$contenttype; name=\"$filename\"",
376
                       -content_disposition=> "$disposition; filename=\"$filename\"",
377
                       -content_length => $attachment->datasize);
378
    disable_utf8();
379
    print $attachment->data;
380 381
}

382 383 384
sub interdiff {
    # Retrieve and validate parameters
    my $format = validateFormat('html', 'raw');
385 386 387 388 389 390 391
    my($old_attachment, $new_attachment);
    if ($format eq 'raw') {
        ($old_attachment, $new_attachment) = get_attachment('oldid', 'newid');
    } else {
        $old_attachment = validateID('oldid');
        $new_attachment = validateID('newid');
    }
392 393 394 395
    my $context = validateContext();

    Bugzilla::Attachment::PatchReader::process_interdiff(
        $old_attachment, $new_attachment, $format, $context);
396 397
}

398 399 400
sub diff {
    # Retrieve and validate parameters
    my $format = validateFormat('html', 'raw');
401
    my $attachment = $format eq 'raw' ? get_attachment() : validateID();
402
    my $context = validateContext();
403

404 405 406 407
    # If it is not a patch, view normally.
    if (!$attachment->ispatch) {
        view();
        return;
408 409
    }

410
    Bugzilla::Attachment::PatchReader::process_diff($attachment, $format, $context);
411
}
412

413 414
# Display all attachments for a given bug in a series of IFRAMEs within one
# HTML page.
415
sub viewall {
416
    # Retrieve and validate parameters
417
    my $bug = Bugzilla::Bug->check({ id => scalar $cgi->param('bugid'), cache => 1 });
418

419
    my $attachments = Bugzilla::Attachment->get_attachments_by_bug($bug);
420 421
    # Ignore deleted attachments.
    @$attachments = grep { $_->datasize } @$attachments;
422

423 424 425 426 427
    if ($cgi->param('hide_obsolete')) {
        @$attachments = grep { !$_->isobsolete } @$attachments;
        $vars->{'hide_obsolete'} = 1;
    }

428 429 430
    # Define the variables and functions that will be passed to the UI template.
    $vars->{'bug'} = $bug;
    $vars->{'attachments'} = $attachments;
431

432
    print $cgi->header();
433

434 435 436
    # Generate and return the UI (HTML page) from the appropriate template.
    $template->process("attachment/show-multiple.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
437 438
}

439
# Display a form for entering a new attachment.
440
sub enter {
441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478
    # Retrieve and validate parameters
    my $bug = Bugzilla::Bug->check(scalar $cgi->param('bugid'));
    my $bugid = $bug->id;
    Bugzilla::Attachment->_check_bug($bug);
    my $dbh = Bugzilla->dbh;
    my $user = Bugzilla->user;

    # Retrieve the attachments the user can edit from the database and write
    # them into an array of hashes where each hash represents one attachment.
  
    my ($can_edit, $not_private) = ('', '');
    if (!$user->in_group('editbugs', $bug->product_id)) {
        $can_edit = "AND submitter_id = " . $user->id;
    }
    if (!$user->is_insider) {
        $not_private = "AND isprivate = 0";
    }
    my $attach_ids = $dbh->selectcol_arrayref(
        "SELECT attach_id
           FROM attachments
          WHERE bug_id = ?
                AND isobsolete = 0
                $can_edit $not_private
       ORDER BY attach_id",
         undef, $bugid);

    # Define the variables and functions that will be passed to the UI template.
    $vars->{'bug'} = $bug;
    $vars->{'attachments'} = Bugzilla::Attachment->new_from_list($attach_ids);

    my $flag_types = Bugzilla::FlagType::match({
        'target_type'  => 'attachment',
        'product_id'   => $bug->product_id,
        'component_id' => $bug->component_id
    });
    $vars->{'flag_types'} = $flag_types;
    $vars->{'any_flags_requesteeble'} =
        grep { $_->is_requestable && $_->is_requesteeble } @$flag_types;
479
    $vars->{'token'} = issue_session_token('create_attachment');
480 481 482 483 484 485

    print $cgi->header();

    # Generate and return the UI (HTML page) from the appropriate template.
    $template->process("attachment/create.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
486 487
}

488
# Insert a new attachment into the database.
489
sub insert {
490 491
    my $dbh = Bugzilla->dbh;
    my $user = Bugzilla->user;
492

493 494
    $dbh->bz_start_transaction;

495
    # Retrieve and validate parameters
496 497
    my $bug = Bugzilla::Bug->check(scalar $cgi->param('bugid'));
    my $bugid = $bug->id;
498
    my ($timestamp) = $dbh->selectrow_array("SELECT NOW()");
499

500 501
    # Detect if the user already used the same form to submit an attachment
    my $token = trim($cgi->param('token'));
502
    check_token_data($token, 'create_attachment', 'index.cgi');
503

504 505 506 507 508 509 510 511 512 513
    # Check attachments the user tries to mark as obsolete.
    my @obsolete_attachments;
    if ($cgi->param('obsolete')) {
        my @obsolete = $cgi->param('obsolete');
        @obsolete_attachments = Bugzilla::Attachment->validate_obsolete($bug, \@obsolete);
    }

    # Must be called before create() as it may alter $cgi->param('ispatch').
    my $content_type = Bugzilla::Attachment::get_content_type();

514 515 516
    # Get the filehandle of the attachment.
    my $data_fh = $cgi->upload('data');

517 518 519
    my $attachment = Bugzilla::Attachment->create(
        {bug           => $bug,
         creation_ts   => $timestamp,
520
         data          => scalar $cgi->param('attach_text') || $data_fh,
521
         description   => scalar $cgi->param('description'),
522
         filename      => $cgi->param('attach_text') ? "file_$bugid.txt" : scalar $cgi->upload('data'),
523 524 525 526 527
         ispatch       => scalar $cgi->param('ispatch'),
         isprivate     => scalar $cgi->param('isprivate'),
         mimetype      => $content_type,
         });

528 529 530
    # Delete the token used to create this attachment.
    delete_token($token);

531
    foreach my $obsolete_attachment (@obsolete_attachments) {
532 533
        $obsolete_attachment->set_is_obsolete(1);
        $obsolete_attachment->update($timestamp);
534
    }
535

536 537 538 539 540
    my ($flags, $new_flags) = Bugzilla::Flag->extract_flags_from_cgi(
                                  $bug, $attachment, $vars, SKIP_REQUESTEE_ON_ERROR);
    $attachment->set_flags($flags, $new_flags);
    $attachment->update($timestamp);

541
    # Insert a comment about the new attachment into the database.
542
    my $comment = $cgi->param('comment');
543
    $comment = '' unless defined $comment;
544 545 546
    $bug->add_comment($comment, { isprivate => $attachment->isprivate,
                                  type => CMT_ATTACHMENT_CREATED,
                                  extra_data => $attachment->id });
547

548
  # Assign the bug to the user, if they are allowed to take it
549
  my $owner = "";
550
  if ($cgi->param('takebug') && $user->in_group('editbugs', $bug->product_id)) {
551 552 553 554 555
      # When taking a bug, we have to follow the workflow.
      my $bug_status = $cgi->param('bug_status') || '';
      ($bug_status) = grep {$_->name eq $bug_status} @{$bug->status->can_change_to};

      if ($bug_status && $bug_status->is_open
556 557
          && ($bug_status->name ne 'UNCONFIRMED' 
              || $bug->product_obj->allows_unconfirmed))
558
      {
559
          $bug->set_bug_status($bug_status->name);
560 561
          $bug->clear_resolution();
      }
562
      # Make sure the person we are taking the bug from gets mail.
563
      $owner = $bug->assigned_to->login;
564
      $bug->set_assigned_to($user);
565
  }
566 567

  $bug->add_cc($user) if $cgi->param('addselfcc');
568 569 570
  $bug->update($timestamp);

  $dbh->bz_commit_transaction;
571

572
  # Define the variables and functions that will be passed to the UI template.
573
  $vars->{'attachment'} = $attachment;
574 575 576 577
  # We cannot reuse the $bug object as delta_ts has eventually been updated
  # since the object was created.
  $vars->{'bugs'} = [new Bugzilla::Bug($bugid)];
  $vars->{'header_done'} = 1;
578
  $vars->{'contenttypemethod'} = $cgi->param('contenttypemethod');
579

580
  my $recipients =  { 'changer' => $user, 'owner' => $owner };
581 582
  $vars->{'sent_bugmail'} = Bugzilla::BugMail::Send($bugid, $recipients);

583
  print $cgi->header();
584
  # Generate and return the UI (HTML page) from the appropriate template.
585 586
  $template->process("attachment/created.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
587 588
}

589 590 591 592
# Displays a form for editing attachment properties.
# Any user is allowed to access this page, unless the attachment
# is private and the user does not belong to the insider group.
# Validations are done later when the user submits changes.
593
sub edit {
594
  my $attachment = validateID();
595

596
  my $bugattachments =
597
      Bugzilla::Attachment->get_attachments_by_bug($attachment->bug);
598

599 600 601 602 603 604
  my $any_flags_requesteeble =
    grep { $_->is_requestable && $_->is_requesteeble } @{$attachment->flag_types};
  # Useful in case a flagtype is no longer requestable but a requestee
  # has been set before we turned off that bit.
  $any_flags_requesteeble ||= grep { $_->requestee_id } @{$attachment->flags};
  $vars->{'any_flags_requesteeble'} = $any_flags_requesteeble;
605
  $vars->{'attachment'} = $attachment;
606
  $vars->{'attachments'} = $bugattachments;
607

608
  print $cgi->header();
609 610

  # Generate and return the UI (HTML page) from the appropriate template.
611 612
  $template->process("attachment/edit.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
613 614
}

615 616
# Updates an attachment record. Only users with "editbugs" privileges,
# (or the original attachment's submitter) can edit the attachment.
617
# Users cannot edit the content of the attachment itself.
618
sub update {
619 620
    my $user = Bugzilla->user;
    my $dbh = Bugzilla->dbh;
621

622 623 624
    # Start a transaction in preparation for updating the attachment.
    $dbh->bz_start_transaction();

625
    # Retrieve and validate parameters
626
    my $attachment = validateID();
627 628
    my $bug = $attachment->bug;
    $attachment->_check_bug;
629 630 631 632 633 634 635 636 637 638 639
    my $can_edit = $attachment->validate_can_edit($bug->product_id);

    if ($can_edit) {
        $attachment->set_description(scalar $cgi->param('description'));
        $attachment->set_is_patch(scalar $cgi->param('ispatch'));
        $attachment->set_content_type(scalar $cgi->param('contenttypeentry'));
        $attachment->set_is_obsolete(scalar $cgi->param('isobsolete'));
        $attachment->set_is_private(scalar $cgi->param('isprivate'));
        $attachment->set_filename(scalar $cgi->param('filename'));

        # Now make sure the attachment has not been edited since we loaded the page.
640 641
        my $delta_ts = $cgi->param('delta_ts');
        my $modification_time = $attachment->modification_time;
642

643 644 645 646
        if ($delta_ts && $delta_ts ne $modification_time) {
            datetime_from($delta_ts)
              or ThrowCodeError('invalid_timestamp', { timestamp => $delta_ts });
            ($vars->{'operations'}) = $bug->get_activity($attachment->id, $delta_ts);
647 648 649 650 651

            # If the modification date changed but there is no entry in
            # the activity table, this means someone commented only.
            # In this case, there is no reason to midair.
            if (scalar(@{$vars->{'operations'}})) {
652 653 654 655
                $cgi->param('delta_ts', $modification_time);
                # The token contains the old modification_time. We need a new one.
                $cgi->param('token', issue_hash_token([$attachment->id, $modification_time]));

656 657 658 659 660 661 662 663
                $vars->{'attachment'} = $attachment;

                print $cgi->header();
                # Warn the user about the mid-air collision and ask them what to do.
                $template->process("attachment/midair.html.tmpl", $vars)
                  || ThrowTemplateError($template->error());
                exit;
            }
664 665
        }
    }
666 667 668 669 670 671

    # We couldn't do this check earlier as we first had to validate attachment ID
    # and display the mid-air collision page if modification_time changed.
    my $token = $cgi->param('token');
    check_hash_token($token, [$attachment->id, $attachment->modification_time]);

672 673
    # If the user submitted a comment while editing the attachment,
    # add the comment to the bug. Do this after having validated isprivate!
674
    my $comment = $cgi->param('comment');
675
    if (defined $comment && trim($comment) ne '') {
676 677 678
        $bug->add_comment($comment, { isprivate => $attachment->isprivate,
                                      type => CMT_ATTACHMENT_UPDATED,
                                      extra_data => $attachment->id });
679 680
    }

681 682
    $bug->add_cc($user) if $cgi->param('addselfcc');

683 684 685 686 687
    if ($can_edit) {
        my ($flags, $new_flags) =
          Bugzilla::Flag->extract_flags_from_cgi($bug, $attachment, $vars);
        $attachment->set_flags($flags, $new_flags);
    }
688

689
    # Figure out when the changes were made.
690
    my $timestamp = $dbh->selectrow_array('SELECT LOCALTIMESTAMP(0)');
691

692 693 694 695 696 697 698
    if ($can_edit) {
        my $changes = $attachment->update($timestamp);
        # If there are changes, we updated delta_ts in the DB. We have to
        # reflect this change in the bug object.
        $bug->{delta_ts} = $timestamp if scalar(keys %$changes);
    }

699
    # Commit the comment, if any.
700
    $bug->update($timestamp);
701

702 703
    # Commit the transaction now that we are finished updating the database.
    $dbh->bz_commit_transaction();
704

705 706 707 708
    # Define the variables and functions that will be passed to the UI template.
    $vars->{'attachment'} = $attachment;
    $vars->{'bugs'} = [$bug];
    $vars->{'header_done'} = 1;
709
    $vars->{'sent_bugmail'} = 
710
        Bugzilla::BugMail::Send($bug->id, { 'changer' => $user });
711

712
    print $cgi->header();
713

714 715 716
    # Generate and return the UI (HTML page) from the appropriate template.
    $template->process("attachment/updated.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
717
}
718 719 720 721 722 723 724 725 726 727 728 729 730

# Only administrators can delete attachments.
sub delete_attachment {
    my $user = Bugzilla->login(LOGIN_REQUIRED);
    my $dbh = Bugzilla->dbh;

    print $cgi->header();

    $user->in_group('admin')
      || ThrowUserError('auth_failure', {group  => 'admin',
                                         action => 'delete',
                                         object => 'attachment'});

731
    Bugzilla->params->{'allow_attachment_deletion'}
732 733 734
      || ThrowUserError('attachment_deletion_disabled');

    # Make sure the administrator is allowed to edit this attachment.
735
    my $attachment = validateID();
736
    Bugzilla::Attachment->_check_bug($attachment->bug);
737 738 739 740 741 742 743 744 745

    $attachment->datasize || ThrowUserError('attachment_removed');

    # We don't want to let a malicious URL accidentally delete an attachment.
    my $token = trim($cgi->param('token'));
    if ($token) {
        my ($creator_id, $date, $event) = Bugzilla::Token::GetTokenData($token);
        unless ($creator_id
                  && ($creator_id == $user->id)
746
                  && ($event eq 'delete_attachment' . $attachment->id))
747 748
        {
            # The token is invalid.
749
            ThrowUserError('token_does_not_exist');
750 751
        }

752 753
        my $bug = new Bugzilla::Bug($attachment->bug_id);

754 755
        # The token is valid. Delete the content of the attachment.
        my $msg;
756
        $vars->{'attachment'} = $attachment;
757 758 759 760 761
        $vars->{'reason'} = clean_text($cgi->param('reason') || '');

        $template->process("attachment/delete_reason.txt.tmpl", $vars, \$msg)
          || ThrowTemplateError($template->error());

762 763 764
        # Paste the reason provided by the admin into a comment.
        $bug->add_comment($msg);

765
        $attachment->remove_from_db();
766 767

        # Now delete the token.
768
        delete_token($token);
769

770 771
        # Insert the comment.
        $bug->update();
772

773
        # Required to display the bug the deleted attachment belongs to.
774
        $vars->{'bugs'} = [$bug];
775 776
        $vars->{'header_done'} = 1;

777
        $vars->{'sent_bugmail'} =
778
            Bugzilla::BugMail::Send($bug->id, { 'changer' => $user });
779

780 781 782 783 784
        $template->process("attachment/updated.html.tmpl", $vars)
          || ThrowTemplateError($template->error());
    }
    else {
        # Create a token.
785
        $token = issue_session_token('delete_attachment' . $attachment->id);
786 787 788 789 790 791 792 793

        $vars->{'a'} = $attachment;
        $vars->{'token'} = $token;

        $template->process("attachment/confirm-delete.html.tmpl", $vars)
          || ThrowTemplateError($template->error());
    }
}