attachment.cgi 48.3 KB
Newer Older
1
#!/usr/bin/perl -wT
2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22
# -*- Mode: perl; indent-tabs-mode: nil -*-
#
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
# The Original Code is the Bugzilla Bug Tracking System.
#
# The Initial Developer of the Original Code is Netscape Communications
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
# Contributor(s): Terry Weissman <terry@mozilla.org>
#                 Myk Melez <myk@mozilla.org>
23 24
#                 Daniel Raichle <draichle@gmx.net>
#                 Dave Miller <justdave@syndicomm.com>
25
#                 Alexander J. Vincent <ajvincent@juno.com>
26
#                 Max Kanat-Alexander <mkanat@bugzilla.org>
27
#                 Greg Hendricks <ghendricks@novell.com>
28
#                 Frédéric Buclin <LpSolit@gmail.com>
29 30 31 32 33 34 35 36

################################################################################
# Script Initialization
################################################################################

# Make it harder for us to do dangerous things in Perl.
use strict;

37 38
use lib qw(.);

39
# Include the Bugzilla CGI and general utility library.
40
require "globals.pl";
41

42 43
use Bugzilla;
use Bugzilla::Config qw(:locations);
44
use Bugzilla::Constants;
45 46
use Bugzilla::Flag; 
use Bugzilla::FlagType; 
47
use Bugzilla::User;
48
use Bugzilla::Util;
49
use Bugzilla::Bug;
50
use Bugzilla::Field;
51
use Bugzilla::Attachment;
52
use Bugzilla::Token;
53

54
Bugzilla->login();
55

56
my $cgi = Bugzilla->cgi;
57 58
my $template = Bugzilla->template;
my $vars = {};
59

60 61 62 63
################################################################################
# Main Body Execution
################################################################################

64 65 66 67
# All calls to this script should contain an "action" variable whose
# value determines what the user wants to do.  The code below checks
# the value of that variable and runs the appropriate code. If none is
# supplied, we default to 'view'.
68 69

# Determine whether to use the action specified by the user or the default.
70
my $action = $cgi->param('action') || 'view';
71 72

if ($action eq "view")  
73
{
74
    view();
75
}
76 77
elsif ($action eq "interdiff")
{
78
    interdiff();
79 80 81
}
elsif ($action eq "diff")
{
82
    diff();
83
}
84 85
elsif ($action eq "viewall") 
{ 
86
    viewall(); 
87
}
88 89
elsif ($action eq "enter") 
{ 
90 91
    Bugzilla->login(LOGIN_REQUIRED);
    enter(); 
92 93 94
}
elsif ($action eq "insert")
{
95 96
    Bugzilla->login(LOGIN_REQUIRED);
    insert();
97
}
98 99
elsif ($action eq "edit") 
{ 
100
    edit(); 
101 102 103
}
elsif ($action eq "update") 
{ 
104 105
    Bugzilla->login(LOGIN_REQUIRED);
    update();
106
}
107 108 109
elsif ($action eq "delete") {
    delete_attachment();
}
110 111
else 
{ 
112
  ThrowCodeError("unknown_action", { action => $action });
113 114 115 116 117 118 119 120
}

exit;

################################################################################
# Data Validation / Security Authorization
################################################################################

121 122 123 124 125 126 127 128 129 130 131 132
# Validates an attachment ID. Optionally takes a parameter of a form
# variable name that contains the ID to be validated. If not specified,
# uses 'id'.
# 
# Will throw an error if 1) attachment ID is not a valid number,
# 2) attachment does not exist, or 3) user isn't allowed to access the
# attachment.
#
# Returns a list, where the first item is the validated, detainted
# attachment id, and the 2nd item is the bug id corresponding to the
# attachment.
# 
133 134
sub validateID
{
135
    my $param = @_ ? $_[0] : 'id';
136 137
    my $dbh = Bugzilla->dbh;
    
138 139 140
    # If we're not doing interdiffs, check if id wasn't specified and
    # prompt them with a page that allows them to choose an attachment.
    # Happens when calling plain attachment.cgi from the urlbar directly
141 142
    if ($param eq 'id' && !$cgi->param('id')) {

143
        print $cgi->header();
144 145 146 147
        $template->process("attachment/choose.html.tmpl", $vars) ||
            ThrowTemplateError($template->error());
        exit;
    }
148
    
149 150 151 152 153 154 155
    my $attach_id = $cgi->param($param);

    # Validate the specified attachment id. detaint kills $attach_id if
    # non-natural, so use the original value from $cgi in our exception
    # message here.
    detaint_natural($attach_id)
     || ThrowUserError("invalid_attach_id", { attach_id => $cgi->param($param) });
156
  
157
    # Make sure the attachment exists in the database.
158 159 160 161 162 163 164
    my ($bugid, $isprivate) = $dbh->selectrow_array(
                                    "SELECT bug_id, isprivate 
                                     FROM attachments 
                                     WHERE attach_id = ?",
                                     undef, $attach_id);
    ThrowUserError("invalid_attach_id", { attach_id => $attach_id }) 
        unless $bugid;
165

166
    # Make sure the user is authorized to access this attachment's bug.
167

168
    ValidateBugID($bugid);
169 170 171 172
    if ($isprivate && Param("insidergroup")) {
        UserInGroup(Param("insidergroup"))
          || ThrowUserError("auth_failure", {action => "access",
                                             object => "attachment"});
173
    }
174

175
    return ($attach_id,$bugid);
176 177
}

178 179 180
# Validates format of a diff/interdiff. Takes a list as an parameter, which
# defines the valid format values. Will throw an error if the format is not
# in the list. Returns either the user selected or default format.
181 182
sub validateFormat
{
183 184 185
  # receives a list of legal formats; first item is a default
  my $format = $cgi->param('format') || $_[0];
  if ( lsearch(\@_, $format) == -1)
186
  {
187
     ThrowUserError("invalid_format", { format  => $format, formats => \@_ });
188
  }
189

190
  return $format;
191 192
}

193 194
# Validates context of a diff/interdiff. Will throw an error if the context
# is not number, "file" or "patch". Returns the validated, detainted context.
195 196
sub validateContext
{
197 198 199 200
  my $context = $cgi->param('context') || "patch";
  if ($context ne "file" && $context ne "patch") {
    detaint_natural($context)
      || ThrowUserError("invalid_context", { context => $cgi->param('context') });
201
  }
202 203

  return $context;
204 205
}

206 207 208
sub validateCanEdit
{
    my ($attach_id) = (@_);
209 210
    my $dbh = Bugzilla->dbh;
    
211 212 213 214
    # People in editbugs can edit all attachments
    return if UserInGroup("editbugs");

    # Bug 97729 - the submitter can edit their attachments
215 216 217 218
    my ($ref) = $dbh->selectrow_array("SELECT attach_id FROM attachments 
                                       WHERE attach_id = ? 
                                       AND submitter_id = ?",
                                       undef, ($attach_id, Bugzilla->user->id));
219

220 221

   $ref || ThrowUserError("illegal_attachment_edit",{ attach_id => $attach_id });
222 223
}

224 225 226
sub validateCanChangeAttachment 
{
    my ($attachid) = @_;
227 228 229
    my $dbh = Bugzilla->dbh;
    my ($productid) = $dbh->selectrow_array(
            "SELECT product_id
230 231 232
             FROM attachments
             INNER JOIN bugs
             ON bugs.bug_id = attachments.bug_id
233 234
             WHERE attach_id = ?", undef, $attachid);

235
    Bugzilla->user->can_edit_product($productid)
236 237
      || ThrowUserError("illegal_attachment_edit",
                        { attach_id => $attachid });
238 239 240 241 242
}

sub validateCanChangeBug
{
    my ($bugid) = @_;
243 244 245
    my $dbh = Bugzilla->dbh;
    my ($productid) = $dbh->selectrow_array(
            "SELECT product_id
246
             FROM bugs 
247 248
             WHERE bug_id = ?", undef, $bugid);

249
    Bugzilla->user->can_edit_product($productid)
250 251
      || ThrowUserError("illegal_attachment_edit_bug",
                        { bug_id => $bugid });
252 253
}

254 255
sub validateDescription
{
256 257
    $cgi->param('description')
      || ThrowUserError("missing_attachment_description");
258 259 260 261
}

sub validateIsPatch
{
262 263 264 265
    # Set the ispatch flag to zero if it is undefined, since the UI uses
    # an HTML checkbox to represent this flag, and unchecked HTML checkboxes
    # do not get sent in HTML requests.
    $cgi->param('ispatch', $cgi->param('ispatch') ? 1 : 0);
266

267 268
    # Set the content type to text/plain if the attachment is a patch.
    $cgi->param('contenttype', 'text/plain') if $cgi->param('ispatch');
269 270 271 272
}

sub validateContentType
{
273
  if (!defined $cgi->param('contenttypemethod'))
274
  {
275
    ThrowUserError("missing_content_type_method");
276
  }
277
  elsif ($cgi->param('contenttypemethod') eq 'autodetect')
278
  {
279
    my $contenttype = $cgi->uploadInfo($cgi->param('data'))->{'Content-Type'};
280 281
    # The user asked us to auto-detect the content type, so use the type
    # specified in the HTTP request headers.
282
    if ( !$contenttype )
283
    {
284
      ThrowUserError("missing_content_type");
285
    }
286
    $cgi->param('contenttype', $contenttype);
287
  }
288
  elsif ($cgi->param('contenttypemethod') eq 'list')
289 290
  {
    # The user selected a content type from the list, so use their selection.
291
    $cgi->param('contenttype', $cgi->param('contenttypeselection'));
292
  }
293
  elsif ($cgi->param('contenttypemethod') eq 'manual')
294 295
  {
    # The user entered a content type manually, so use their entry.
296
    $cgi->param('contenttype', $cgi->param('contenttypeentry'));
297 298 299
  }
  else
  {
300
    ThrowCodeError("illegal_content_type_method",
301
                   { contenttypemethod => $cgi->param('contenttypemethod') });
302 303
  }

304 305
  if ( $cgi->param('contenttype') !~
         /^(application|audio|image|message|model|multipart|text|video)\/.+$/ )
306
  {
307
    ThrowUserError("invalid_content_type",
308
                   { contenttype => $cgi->param('contenttype') });
309
  }
310 311 312 313
}

sub validateIsObsolete
{
314 315 316 317
    # Set the isobsolete flag to zero if it is undefined, since the UI uses
    # an HTML checkbox to represent this flag, and unchecked HTML checkboxes
    # do not get sent in HTML requests.
    $cgi->param('isobsolete', $cgi->param('isobsolete') ? 1 : 0);
318 319
}

320 321 322 323 324
sub validatePrivate
{
    # Set the isprivate flag to zero if it is undefined, since the UI uses
    # an HTML checkbox to represent this flag, and unchecked HTML checkboxes
    # do not get sent in HTML requests.
325
    $cgi->param('isprivate', $cgi->param('isprivate') ? 1 : 0);
326 327
}

328 329
sub validateData
{
330
  my $maxsize = $cgi->param('ispatch') ? Param('maxpatchsize') : Param('maxattachmentsize');
331
  $maxsize *= 1024; # Convert from K
332 333 334
  my $fh;
  # Skip uploading into a local variable if the user wants to upload huge
  # attachments into local files.
335
  if (!$cgi->param('bigfile'))
336 337 338
  {
    $fh = $cgi->upload('data');
  }
339
  my $data;
340

341 342
  # We could get away with reading only as much as required, except that then
  # we wouldn't have a size to print to the error handler below.
343
  if (!$cgi->param('bigfile'))
344
  {
345 346 347
      # enable 'slurp' mode
      local $/;
      $data = <$fh>;
348
  }
349 350

  $data
351
    || ($cgi->param('bigfile'))
352
    || ThrowUserError("zero_length_file");
353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368
    
    # Windows screenshots are usually uncompressed BMP files which
    # makes for a quick way to eat up disk space. Let's compress them. 
    # We do this before we check the size since the uncompressed version
    # could easily be greater than maxattachmentsize.
    if (Param('convert_uncompressed_images') && $cgi->param('contenttype') eq 'image/bmp'){
      require Image::Magick; 
      my $img = Image::Magick->new(magick=>'bmp');
      $img->BlobToImage($data);
      $img->set(magick=>'png');
      my $imgdata = $img->ImageToBlob();
      $data = $imgdata;
      $cgi->param('contenttype', 'image/png');
      $vars->{'convertedbmp'} = 1;
    }
    
369
  # Make sure the attachment does not exceed the maximum permitted size
370
  my $len = $data ? length($data) : 0;
371
  if ($maxsize && $len > $maxsize) {
372
      my $vars = { filesize => sprintf("%.0f", $len/1024) };
373
      if ($cgi->param('ispatch')) {
374
          ThrowUserError("patch_too_large", $vars);
375
      } else {
376
          ThrowUserError("file_too_large", $vars);
377 378 379
      }
  }

380
  return $data || '';
381 382 383 384
}

sub validateFilename
{
385
  defined $cgi->upload('data')
386
    || ThrowUserError("file_not_specified");
387

388
  my $filename = $cgi->upload('data');
389 390 391 392 393 394 395 396 397 398 399
  
  # Remove path info (if any) from the file name.  The browser should do this
  # for us, but some are buggy.  This may not work on Mac file names and could
  # mess up file names with slashes in them, but them's the breaks.  We only
  # use this as a hint to users downloading attachments anyway, so it's not 
  # a big deal if it munges incorrectly occasionally.
  $filename =~ s/^.*[\/\\]//;

  # Truncate the filename to 100 characters, counting from the end of the string
  # to make sure we keep the filename extension.
  $filename = substr($filename, -100, 100);
400 401

  return $filename;
402 403 404 405
}

sub validateObsolete
{
406
  my @obsolete_ids = ();
407 408
  my $dbh = Bugzilla->dbh;
  
409 410
  # Make sure the attachment id is valid and the user has permissions to view
  # the bug to which it is attached.
411
  foreach my $attachid ($cgi->param('obsolete')) {
412
    my $vars = {};
413 414
    $vars->{'attach_id'} = $attachid;
    
415
    detaint_natural($attachid)
416
      || ThrowCodeError("invalid_attach_id_to_obsolete", $vars);
417
  
418 419 420
    my ($bugid, $isobsolete, $description) = $dbh->selectrow_array(
            "SELECT bug_id, isobsolete, description 
             FROM attachments WHERE attach_id = ?", undef, $attachid);
421 422

    # Make sure the attachment exists in the database.
423 424
    ThrowUserError("invalid_attach_id", $vars) unless $bugid;

425 426


427 428
    $vars->{'description'} = $description;
    
429
    if ($bugid != $cgi->param('bugid'))
430
    {
431
      $vars->{'my_bug_id'} = $cgi->param('bugid');
432
      $vars->{'attach_bug_id'} = $bugid;
433
      ThrowCodeError("mismatched_bug_ids_on_obsolete", $vars);
434 435 436 437
    }

    if ( $isobsolete )
    {
438
      ThrowCodeError("attachment_already_obsolete", $vars);
439
    }
440 441 442

    # Check that the user can modify this attachment
    validateCanEdit($attachid);
443
    push(@obsolete_ids, $attachid);
444
  }
445 446

  return @obsolete_ids;
447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468
}

# Returns 1 if the parameter is a content-type viewable in this browser
# Note that we don't use $cgi->Accept()'s ability to check if a content-type
# matches, because this will return a value even if it's matched by the generic
# */* which most browsers add to the end of their Accept: headers.
sub isViewable
{
  my $contenttype = trim(shift);
    
  # We assume we can view all text and image types  
  if ($contenttype =~ /^(text|image)\//) {
    return 1;
  }
  
  # Mozilla can view XUL. Note the trailing slash on the Gecko detection to
  # avoid sending XUL to Safari.
  if (($contenttype =~ /^application\/vnd\.mozilla\./) &&
      ($cgi->user_agent() =~ /Gecko\//))
  {
    return 1;
  }
469

470 471 472 473 474 475 476 477 478
  # If it's not one of the above types, we check the Accept: header for any 
  # types mentioned explicitly.
  my $accept = join(",", $cgi->Accept());
  
  if ($accept =~ /^(.*,)?\Q$contenttype\E(,.*)?$/) {
    return 1;
  }
  
  return 0;
479 480
}

481 482 483 484
################################################################################
# Functions
################################################################################

485
# Display an attachment.
486 487
sub view
{
488 489
    # Retrieve and validate parameters
    my ($attach_id) = validateID();
490 491
    my $dbh = Bugzilla->dbh;
    
492
    # Retrieve the attachment content and its content type from the database.
493 494
    my ($contenttype, $filename, $thedata) = $dbh->selectrow_array(
            "SELECT mimetype, filename, thedata FROM attachments " .
495
            "INNER JOIN attach_data ON id = attach_id " .
496
            "WHERE attach_id = ?", undef, $attach_id);
497
   
498 499 500
    # Bug 111522: allow overriding content-type manually in the posted form
    # params.
    if (defined $cgi->param('content_type'))
501
    {
502 503
        $cgi->param('contenttypemethod', 'manual');
        $cgi->param('contenttypeentry', $cgi->param('content_type'));
504
        validateContentType();
505
        $contenttype = $cgi->param('content_type');
506
    }
507

508
    # Return the appropriate HTTP response headers.
509 510
    $filename =~ s/^.*[\/\\]//;
    my $filesize = length($thedata);
511 512 513 514
    # A zero length attachment in the database means the attachment is 
    # stored in a local file
    if ($filesize == 0)
    {
515
        my $hash = ($attach_id % 100) + 100;
516
        $hash =~ s/.*(\d\d)$/group.$1/;
517
        if (open(AH, "$attachdir/$hash/attachment.$attach_id")) {
518 519 520 521 522 523 524 525 526
            binmode AH;
            $filesize = (stat(AH))[7];
        }
    }
    if ($filesize == 0)
    {
        ThrowUserError("attachment_removed");
    }

527

528 529 530 531
    # escape quotes and backslashes in the filename, per RFCs 2045/822
    $filename =~ s/\\/\\\\/g; # escape backslashes
    $filename =~ s/"/\\"/g; # escape quotes

532 533 534
    print $cgi->header(-type=>"$contenttype; name=\"$filename\"",
                       -content_disposition=> "inline; filename=\"$filename\"",
                       -content_length => $filesize);
535

536 537 538 539 540 541 542 543 544
    if ($thedata) {
        print $thedata;
    } else {
        while (<AH>) {
            print $_;
        }
        close(AH);
    }

545 546
}

547 548
sub interdiff
{
549 550 551 552 553 554
  # Retrieve and validate parameters
  my ($old_id) = validateID('oldid');
  my ($new_id) = validateID('newid');
  my $format = validateFormat('html', 'raw');
  my $context = validateContext();

555 556
  # Get old patch data
  my ($old_bugid, $old_description, $old_filename, $old_file_list) =
557
      get_unified_diff($old_id);
558 559 560

  # Get new patch data
  my ($new_bugid, $new_description, $new_filename, $new_file_list) =
561
      get_unified_diff($new_id);
562 563 564 565 566 567 568 569 570 571 572

  my $warning = warn_if_interdiff_might_fail($old_file_list, $new_file_list);

  #
  # send through interdiff, send output directly to template
  #
  # Must hack path so that interdiff will work.
  #
  $ENV{'PATH'} = $::diffpath;
  open my $interdiff_fh, "$::interdiffbin $old_filename $new_filename|";
  binmode $interdiff_fh;
573 574
    my ($reader, $last_reader) = setup_patch_readers("", $context);
    if ($format eq 'raw')
575
  {
576 577
    require PatchReader::DiffPrinter::raw;
    $last_reader->sends_data_to(new PatchReader::DiffPrinter::raw());
578 579 580 581 582 583 584 585
    # Actually print out the patch
    print $cgi->header(-type => 'text/plain',
                       -expires => '+3M');
  }
  else
  {
    $vars->{warning} = $warning if $warning;
    $vars->{bugid} = $new_bugid;
586
    $vars->{oldid} = $old_id;
587
    $vars->{old_desc} = $old_description;
588
    $vars->{newid} = $new_id;
589 590 591 592
    $vars->{new_desc} = $new_description;
    delete $vars->{attachid};
    delete $vars->{do_context};
    delete $vars->{context};
593
    setup_template_patch_reader($last_reader, $format, $context);
594
  }
595
  $reader->iterate_fh($interdiff_fh, "interdiff #$old_id #$new_id");
596 597 598 599 600 601 602 603 604 605 606 607 608
  close $interdiff_fh;
  $ENV{'PATH'} = '';

  #
  # Delete temporary files
  #
  unlink($old_filename) or warn "Could not unlink $old_filename: $!";
  unlink($new_filename) or warn "Could not unlink $new_filename: $!";
}

sub get_unified_diff
{
  my ($id) = @_;
609 610
  my $dbh = Bugzilla->dbh;
  
611
  # Bring in the modules we need
612 613 614 615
  require PatchReader::Raw;
  require PatchReader::FixPatchRoot;
  require PatchReader::DiffPrinter::raw;
  require PatchReader::PatchInfoGrabber;
616 617 618
  require File::Temp;

  # Get the patch
619 620
  my ($bugid, $description, $ispatch, $thedata) = $dbh->selectrow_array(
          "SELECT bug_id, description, ispatch, thedata " . 
621 622 623
          "FROM attachments " .
          "INNER JOIN attach_data " .
          "ON id = attach_id " .
624
          "WHERE attach_id = ?", undef, $id);
625 626 627 628 629 630
  if (!$ispatch) {
    $vars->{'attach_id'} = $id;
    ThrowCodeError("must_be_patch");
  }

  # Reads in the patch, converting to unified diff in a temp file
631 632 633
  my $reader = new PatchReader::Raw;
  my $last_reader = $reader;

634
  # fixes patch root (makes canonical if possible)
635 636 637 638 639 640
  if (Param('cvsroot')) {
    my $fix_patch_root = new PatchReader::FixPatchRoot(Param('cvsroot'));
    $last_reader->sends_data_to($fix_patch_root);
    $last_reader = $fix_patch_root;
  }

641
  # Grabs the patch file info
642 643 644 645
  my $patch_info_grabber = new PatchReader::PatchInfoGrabber();
  $last_reader->sends_data_to($patch_info_grabber);
  $last_reader = $patch_info_grabber;

646 647
  # Prints out to temporary file
  my ($fh, $filename) = File::Temp::tempfile();
648 649 650 651
  my $raw_printer = new PatchReader::DiffPrinter::raw($fh);
  $last_reader->sends_data_to($raw_printer);
  $last_reader = $raw_printer;

652
  # Iterate!
653
  $reader->iterate_string($id, $thedata);
654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678

  return ($bugid, $description, $filename, $patch_info_grabber->patch_info()->{files});
}

sub warn_if_interdiff_might_fail {
  my ($old_file_list, $new_file_list) = @_;
  # Verify that the list of files diffed is the same
  my @old_files = sort keys %{$old_file_list};
  my @new_files = sort keys %{$new_file_list};
  if (@old_files != @new_files ||
      join(' ', @old_files) ne join(' ', @new_files)) {
    return "interdiff1";
  }

  # Verify that the revisions in the files are the same
  foreach my $file (keys %{$old_file_list}) {
    if ($old_file_list->{$file}{old_revision} ne
        $new_file_list->{$file}{old_revision}) {
      return "interdiff2";
    }
  }

  return undef;
}

679
sub setup_patch_readers {
680
  my ($diff_root, $context) = @_;
681 682 683 684 685 686 687 688 689

  #
  # Parameters:
  # format=raw|html
  # context=patch|file|0-n
  # collapsed=0|1
  # headers=0|1
  #

690 691 692 693 694
  # Define the patch readers
  # The reader that reads the patch in (whatever its format)
  require PatchReader::Raw;
  my $reader = new PatchReader::Raw;
  my $last_reader = $reader;
695 696 697
  # Fix the patch root if we have a cvs root
  if (Param('cvsroot'))
  {
698 699 700 701
    require PatchReader::FixPatchRoot;
    $last_reader->sends_data_to(new PatchReader::FixPatchRoot(Param('cvsroot')));
    $last_reader->sends_data_to->diff_root($diff_root) if defined($diff_root);
    $last_reader = $last_reader->sends_data_to;
702 703
  }
  # Add in cvs context if we have the necessary info to do it
704
  if ($context ne "patch" && $::cvsbin && Param('cvsroot_get'))
705
  {
706 707
    require PatchReader::AddCVSContext;
    $last_reader->sends_data_to(
708
          new PatchReader::AddCVSContext($context,
709
                                         Param('cvsroot_get')));
710
    $last_reader = $last_reader->sends_data_to;
711
  }
712
  return ($reader, $last_reader);
713 714
}

715
sub setup_template_patch_reader
716
{
717
  my ($last_reader, $format, $context) = @_;
718

719
  require PatchReader::DiffPrinter::template;
720 721

  # Define the vars for templates
722 723
  if (defined $cgi->param('headers')) {
    $vars->{headers} = $cgi->param('headers');
724
  } else {
725
    $vars->{headers} = 1 if !defined $cgi->param('headers');
726
  }
727 728
  $vars->{collapsed} = $cgi->param('collapsed');
  $vars->{context} = $context;
729 730 731 732 733
  $vars->{do_context} = $::cvsbin && Param('cvsroot_get') && !$vars->{'newid'};

  # Print everything out
  print $cgi->header(-type => 'text/html',
                     -expires => '+3M');
734
  $last_reader->sends_data_to(new PatchReader::DiffPrinter::template($template,
735 736 737 738 739 740 741 742 743 744 745 746
                             "attachment/diff-header.$format.tmpl",
                             "attachment/diff-file.$format.tmpl",
                             "attachment/diff-footer.$format.tmpl",
                             { %{$vars},
                               bonsai_url => Param('bonsai_url'),
                               lxr_url => Param('lxr_url'),
                               lxr_root => Param('lxr_root'),
                             }));
}

sub diff
{
747 748 749 750
  # Retrieve and validate parameters
  my ($attach_id) = validateID();
  my $format = validateFormat('html', 'raw');
  my $context = validateContext();
751 752
  my $dbh = Bugzilla->dbh;
  
753
  # Get patch data
754 755
  my ($bugid, $description, $ispatch, $thedata) = $dbh->selectrow_array(
          "SELECT bug_id, description, ispatch, thedata FROM attachments " .
756
          "INNER JOIN attach_data ON id = attach_id " .
757
          "WHERE attach_id = ?", undef, $attach_id);
758 759 760 761 762 763 764 765

  # If it is not a patch, view normally
  if (!$ispatch)
  {
    view();
    return;
  }

766
  my ($reader, $last_reader) = setup_patch_readers(undef,$context);
767

768
  if ($format eq 'raw')
769
  {
770 771
    require PatchReader::DiffPrinter::raw;
    $last_reader->sends_data_to(new PatchReader::DiffPrinter::raw());
772 773 774
    # Actually print out the patch
    print $cgi->header(-type => 'text/plain',
                       -expires => '+3M');
775
    $reader->iterate_string("Attachment $attach_id", $thedata);
776 777 778 779 780 781 782 783
  }
  else
  {
    $vars->{other_patches} = [];
    if ($::interdiffbin && $::diffpath) {
      # Get list of attachments on this bug.
      # Ignore the current patch, but select the one right before it
      # chronologically.
784 785 786 787 788 789
      my $sth = $dbh->prepare("SELECT attach_id, description 
                               FROM attachments 
                               WHERE bug_id = ? 
                               AND ispatch = 1 
                               ORDER BY creation_ts DESC");
      $sth->execute($bugid);
790
      my $select_next_patch = 0;
791
      while (my ($other_id, $other_desc) = $sth->fetchrow_array) {
792
        if ($other_id eq $attach_id) {
793 794 795 796 797 798 799 800 801 802 803
          $select_next_patch = 1;
        } else {
          push @{$vars->{other_patches}}, { id => $other_id, desc => $other_desc, selected => $select_next_patch };
          if ($select_next_patch) {
            $select_next_patch = 0;
          }
        }
      }
    }

    $vars->{bugid} = $bugid;
804
    $vars->{attachid} = $attach_id;
805
    $vars->{description} = $description;
806
    setup_template_patch_reader($last_reader, $format, $context);
807
    # Actually print out the patch
808
    $reader->iterate_string("Attachment $attach_id", $thedata);
809 810
  }
}
811

812 813
# Display all attachments for a given bug in a series of IFRAMEs within one
# HTML page.
814 815
sub viewall
{
816 817 818
    # Retrieve and validate parameters
    my $bugid = $cgi->param('bugid');
    ValidateBugID($bugid);
819

820 821
    # Retrieve the attachments from the database and write them into an array
    # of hashes where each hash represents one attachment.
822
    my $privacy = "";
823 824
    my $dbh = Bugzilla->dbh;

825 826 827
    if (Param("insidergroup") && !(UserInGroup(Param("insidergroup")))) {
        $privacy = "AND isprivate < 1 ";
    }
828 829 830 831 832
  my $attachments = $dbh->selectall_arrayref(
           "SELECT attach_id AS attachid, " .
            $dbh->sql_date_format('creation_ts', '%Y.%m.%d %H:%i') . " AS date,
            mimetype AS contenttype, description, ispatch, isobsolete, isprivate, 
            LENGTH(thedata) AS datasize
833 834 835
            FROM attachments 
            INNER JOIN attach_data
            ON attach_id = id
836 837 838 839
            WHERE bug_id = ? $privacy 
            ORDER BY attach_id", {'Slice'=>{}}, $bugid);

  foreach my $a (@{$attachments})
840
  {
841 842
    
    $a->{'isviewable'} = isViewable($a->{'contenttype'});
843
    $a->{'flags'} = Bugzilla::Flag::match({ 'attach_id' => $a->{'attachid'} });
844 845
  }

846
  # Retrieve the bug summary (for displaying on screen) and assignee.
847 848 849
  my ($bugsummary, $assignee_id) = $dbh->selectrow_array(
          "SELECT short_desc, assigned_to FROM bugs " .
          "WHERE bug_id = ?", undef, $bugid);
850 851

  # Define the variables and functions that will be passed to the UI template.
852
  $vars->{'bugid'} = $bugid;
853
  $vars->{'attachments'} = $attachments;
854 855
  $vars->{'bugassignee_id'} = $assignee_id;
  $vars->{'bugsummary'} = $bugsummary;
856

857
  print $cgi->header();
858 859

  # Generate and return the UI (HTML page) from the appropriate template.
860 861
  $template->process("attachment/show-multiple.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
862 863
}

864
# Display a form for entering a new attachment.
865 866
sub enter
{
867 868 869 870
  # Retrieve and validate parameters
  my $bugid = $cgi->param('bugid');
  ValidateBugID($bugid);
  validateCanChangeBug($bugid);
871 872
  my $dbh = Bugzilla->dbh;
  
873 874 875 876
  # Retrieve the attachments the user can edit from the database and write
  # them into an array of hashes where each hash represents one attachment.
  my $canEdit = "";
  if (!UserInGroup("editbugs")) {
877
      $canEdit = "AND submitter_id = " . Bugzilla->user->id;
878
  }
879 880
  my $attachments = $dbh->selectall_arrayref(
          "SELECT attach_id AS id, description, isprivate
881
           FROM attachments
882
           WHERE bug_id = ? 
883
           AND isobsolete = 0 $canEdit
884
           ORDER BY attach_id",{'Slice' =>{}}, $bugid);
885

886
  # Retrieve the bug summary (for displaying on screen) and assignee.
887 888 889
  my ($bugsummary, $assignee_id) = $dbh->selectrow_array(
          "SELECT short_desc, assigned_to FROM bugs 
           WHERE bug_id = ?", undef, $bugid);
890 891

  # Define the variables and functions that will be passed to the UI template.
892
  $vars->{'bugid'} = $bugid;
893
  $vars->{'attachments'} = $attachments;
894 895
  $vars->{'bugassignee_id'} = $assignee_id;
  $vars->{'bugsummary'} = $bugsummary;
896

897 898 899 900
  my ($product_id, $component_id)= $dbh->selectrow_array(
          "SELECT product_id, component_id FROM bugs
           WHERE bug_id = ?", undef, $bugid);
           
901 902 903 904 905 906 907
  my $flag_types = Bugzilla::FlagType::match({'target_type'  => 'attachment',
                                              'product_id'   => $product_id,
                                              'component_id' => $component_id});
  $vars->{'flag_types'} = $flag_types;
  $vars->{'any_flags_requesteeble'} = grep($_->{'is_requesteeble'},
                                           @$flag_types);

908
  print $cgi->header();
909 910

  # Generate and return the UI (HTML page) from the appropriate template.
911 912
  $template->process("attachment/create.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
913 914
}

915
# Insert a new attachment into the database.
916 917
sub insert
{
918
    my $userid = Bugzilla->user->id;
919

920 921 922 923 924
    # Retrieve and validate parameters
    my $bugid = $cgi->param('bugid');
    ValidateBugID($bugid);
    validateCanChangeBug($bugid);
    ValidateComment(scalar $cgi->param('comment'));
925 926 927 928 929
    my $attachurl = $cgi->param('attachurl') || '';
    my $data;
    my $filename;
    my $contenttype;
    my $isurl;
930 931
    validateIsPatch();
    validateDescription();
932 933
    my $dbh = Bugzilla->dbh; 
    
934 935 936 937 938
    if (($attachurl =~ /^(http|https|ftp):\/\/\S+/) 
         && !(defined $cgi->upload('data'))) {
        $filename = '';
        $data = $attachurl;
        $isurl = 1;
939
        $contenttype = 'text/plain';
940 941 942 943 944 945 946 947
        $cgi->param('ispatch', 0);
        $cgi->delete('bigfile');
    } else {
        $filename = validateFilename();
        # need to validate content type before data as
        # we now check the content type for image/bmp in validateData()
        validateContentType() unless $cgi->param('ispatch');
        $data = validateData();
948 949 950 951 952
        $contenttype = $cgi->param('contenttype');

        # These are inserted using placeholders so no need to panic
        trick_taint($filename);
        trick_taint($contenttype);
953 954
        $isurl = 0;
    }
955 956 957 958 959 960 961

    my @obsolete_ids = ();
    @obsolete_ids = validateObsolete() if $cgi->param('obsolete');

    # The order of these function calls is important, as both Flag::validate
    # and FlagType::validate assume User::match_field has ensured that the
    # values in the requestee fields are legitimate user email addresses.
962
    my $match_status = Bugzilla::User::match_field($cgi, {
963
        '^requestee(_type)?-(\d+)$' => { 'type' => 'multi' },
964 965 966 967 968 969 970 971 972 973
    }, MATCH_SKIP_CONFIRM);

    $vars->{'match_field'} = 'requestee';
    if ($match_status == USER_MATCH_FAILED) {
        $vars->{'message'} = 'user_match_failed';
    }
    elsif ($match_status == USER_MATCH_MULTIPLE) {
        $vars->{'message'} = 'user_match_multiple';
    }

974 975 976
    # FlagType::validate() and Flag::validate() should not detect
    # any reference to existing flags when creating a new attachment.
    # Setting the third param to -1 will force this function to check this point.
977
    Bugzilla::Flag::validate($cgi, $bugid, -1);
978
    Bugzilla::FlagType::validate($cgi, $bugid, -1);
979 980

    # Escape characters in strings that will be used in SQL statements.
981 982
    my $description = $cgi->param('description');
    trick_taint($description);
983
    my $isprivate = $cgi->param('isprivate') ? 1 : 0;
984

985 986
  # Figure out when the changes were made.
  my ($timestamp) = Bugzilla->dbh->selectrow_array("SELECT NOW()"); 
987
  
988
  # Insert the attachment into the database.
989 990 991 992 993 994 995
  my $sth = $dbh->do(
        "INSERT INTO attachments
            (bug_id, creation_ts, filename, description,
             mimetype, ispatch, isurl, isprivate, submitter_id) 
         VALUES (?,?,?,?,?,?,?,?,?)", undef, ($bugid, $timestamp, $filename,
              $description, $contenttype, $cgi->param('ispatch'),
              $isurl, $isprivate, $userid));
996 997 998
  # Retrieve the ID of the newly created attachment record.
  my $attachid = $dbh->bz_last_key('attachments', 'attach_id');

999 1000
  # We only use $data here in this INSERT with a placeholder,
  # so it's safe.
1001 1002
  $sth = $dbh->prepare("INSERT INTO attach_data
                           (id, thedata) VALUES ($attachid, ?)");
1003 1004 1005
  trick_taint($data);
  $sth->bind_param(1, $data, $dbh->BLOB_TYPE);
  $sth->execute();
1006 1007


1008 1009
  # If the file is to be stored locally, stream the file from the webserver
  # to the local file without reading it into a local variable.
1010
  if ($cgi->param('bigfile'))
1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035
  {
    my $fh = $cgi->upload('data');
    my $hash = ($attachid % 100) + 100;
    $hash =~ s/.*(\d\d)$/group.$1/;
    mkdir "$attachdir/$hash", 0770;
    chmod 0770, "$attachdir/$hash";
    open(AH, ">$attachdir/$hash/attachment.$attachid");
    binmode AH;
    my $sizecount = 0;
    my $limit = (Param("maxlocalattachment") * 1048576);
    while (<$fh>) {
        print AH $_;
        $sizecount += length($_);
        if ($sizecount > $limit) {
            close AH;
            close $fh;
            unlink "$attachdir/$hash/attachment.$attachid";
            ThrowUserError("local_file_too_large");
        }
    }
    close AH;
    close $fh;
  }


1036
  # Insert a comment about the new attachment into the database.
1037 1038 1039
  my $comment = "Created an attachment (id=$attachid)\n" .
                $cgi->param('description') . "\n";
  $comment .= ("\n" . $cgi->param('comment')) if defined $cgi->param('comment');
1040

1041
  AppendComment($bugid, $userid, $comment, $isprivate, $timestamp);
1042 1043

  # Make existing attachments obsolete.
1044
  my $fieldid = get_field_id('attachments.isobsolete');
1045
  foreach my $obsolete_id (@obsolete_ids) {
1046 1047
      # If the obsolete attachment has request flags, cancel them.
      # This call must be done before updating the 'attachments' table.
1048
      Bugzilla::Flag::CancelRequests($bugid, $obsolete_id, $timestamp);
1049

1050 1051 1052
      $dbh->do("UPDATE attachments SET isobsolete = 1 " . 
              "WHERE attach_id = ?", undef, $obsolete_id);
      $dbh->do("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when,
1053
                                          fieldid, removed, added) 
1054 1055
              VALUES (?,?,?,?,?,?,?)", undef, 
              $bugid, $obsolete_id, $userid, $timestamp, $fieldid, 0, 1);
1056 1057
  }

1058
  # Assign the bug to the user, if they are allowed to take it
1059
  my $owner = "";
1060
  
1061
  if ($cgi->param('takebug') && UserInGroup("editbugs")) {
1062
      
1063 1064
      my @fields = ("assigned_to", "bug_status", "resolution", "everconfirmed",
                    "login_name");
1065 1066
      
      # Get the old values, for the bugs_activity table
1067 1068
      my @oldvalues = $dbh->selectrow_array(
              "SELECT " . join(", ", @fields) . " " .
1069 1070 1071
              "FROM bugs " .
              "INNER JOIN profiles " .
              "ON profiles.userid = bugs.assigned_to " .
1072
              "WHERE bugs.bug_id = ?", undef, $bugid);
1073
      
1074
      my @newvalues = ($userid, "ASSIGNED", "", 1, Bugzilla->user->login);
1075 1076
      
      # Make sure the person we are taking the bug from gets mail.
1077
      $owner = $oldvalues[4];  
1078

1079
      # Update the bug record. Note that this doesn't involve login_name.
1080 1081 1082 1083
      $dbh->do('UPDATE bugs SET delta_ts = ?, ' .
               join(', ', map("$fields[$_] = ?", (0..3))) . ' WHERE bug_id = ?',
               undef, ($timestamp, map($newvalues[$_], (0..3)) , $bugid));

1084 1085 1086 1087
      # If the bug was a dupe, we have to remove its entry from the
      # 'duplicates' table.
      $dbh->do('DELETE FROM duplicates WHERE dupe = ?', undef, $bugid);

1088
      # We store email addresses in the bugs_activity table rather than IDs.
1089 1090
      $oldvalues[0] = $oldvalues[4];
      $newvalues[0] = $newvalues[4];
1091

1092
      for (my $i = 0; $i < 4; $i++) {
1093
          if ($oldvalues[$i] ne $newvalues[$i]) {
1094 1095
              LogActivityEntry($bugid, $fields[$i], $oldvalues[$i],
                               $newvalues[$i], $userid, $timestamp);
1096 1097 1098 1099
          }
      }      
  }   
  
1100
  # Create flags.
1101
  Bugzilla::Flag::process($bugid, $attachid, $timestamp, $cgi);
1102
   
1103
  # Define the variables and functions that will be passed to the UI template.
1104
  $vars->{'mailrecipients'} =  { 'changer' => Bugzilla->user->login,
1105
                                 'owner'   => $owner };
1106
  $vars->{'bugid'} = $bugid;
1107 1108
  $vars->{'attachid'} = $attachid;
  $vars->{'description'} = $description;
1109 1110
  $vars->{'contenttypemethod'} = $cgi->param('contenttypemethod');
  $vars->{'contenttype'} = $cgi->param('contenttype');
1111

1112
  print $cgi->header();
1113 1114

  # Generate and return the UI (HTML page) from the appropriate template.
1115 1116
  $template->process("attachment/created.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
1117 1118
}

1119 1120 1121 1122
# Displays a form for editing attachment properties.
# Any user is allowed to access this page, unless the attachment
# is private and the user does not belong to the insider group.
# Validations are done later when the user submits changes.
1123
sub edit {
1124
  my ($attach_id) = validateID();
1125
  my $dbh = Bugzilla->dbh;
1126

1127 1128
  my $attachment = Bugzilla::Attachment->get($attach_id);
  my $isviewable = !$attachment->isurl && isViewable($attachment->contenttype);
1129 1130 1131

  # Retrieve a list of attachments for this bug as well as a summary of the bug
  # to use in a navigation bar across the top of the screen.
1132 1133 1134 1135 1136 1137 1138 1139 1140 1141
  my $bugattachments =
      $dbh->selectcol_arrayref('SELECT attach_id FROM attachments
                                WHERE bug_id = ? ORDER BY attach_id',
                                undef, $attachment->bug_id);

  my ($bugsummary, $product_id, $component_id) =
      $dbh->selectrow_array('SELECT short_desc, product_id, component_id
                               FROM bugs
                              WHERE bug_id = ?', undef, $attachment->bug_id);

1142
  # Get a list of flag types that can be set for this attachment.
1143 1144
  my $flag_types = Bugzilla::FlagType::match({ 'target_type'  => 'attachment' ,
                                               'product_id'   => $product_id ,
1145
                                               'component_id' => $component_id });
1146
  foreach my $flag_type (@$flag_types) {
1147
    $flag_type->{'flags'} = Bugzilla::Flag::match({ 'type_id'   => $flag_type->{'id'},
1148
                                                    'attach_id' => $attachment->id });
1149 1150
  }
  $vars->{'flag_types'} = $flag_types;
1151
  $vars->{'any_flags_requesteeble'} = grep($_->{'is_requesteeble'}, @$flag_types);
1152
  $vars->{'attachment'} = $attachment;
1153 1154
  $vars->{'bugsummary'} = $bugsummary; 
  $vars->{'isviewable'} = $isviewable; 
1155
  $vars->{'attachments'} = $bugattachments; 
1156

1157 1158 1159 1160 1161
  # Determine if PatchReader is installed
  eval {
    require PatchReader;
    $vars->{'patchviewerinstalled'} = 1;
  };
1162
  print $cgi->header();
1163 1164

  # Generate and return the UI (HTML page) from the appropriate template.
1165 1166
  $template->process("attachment/edit.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
1167 1168
}

1169 1170 1171 1172 1173
# Updates an attachment record. Users with "editbugs" privileges, (or the
# original attachment's submitter) can edit the attachment's description,
# content type, ispatch and isobsolete flags, and statuses, and they can
# also submit a comment that appears in the bug.
# Users cannot edit the content of the attachment itself.
1174 1175
sub update
{
1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187
  my $userid = Bugzilla->user->id;

    # Retrieve and validate parameters
    ValidateComment(scalar $cgi->param('comment'));
    my ($attach_id, $bugid) = validateID();
    validateCanEdit($attach_id);
    validateCanChangeAttachment($attach_id);
    validateDescription();
    validateIsPatch();
    validateContentType() unless $cgi->param('ispatch');
    validateIsObsolete();
    validatePrivate();
1188
    my $dbh = Bugzilla->dbh;
1189 1190 1191 1192 1193

    # The order of these function calls is important, as both Flag::validate
    # and FlagType::validate assume User::match_field has ensured that the
    # values in the requestee fields are legitimate user email addresses.
    Bugzilla::User::match_field($cgi, {
1194
        '^requestee(_type)?-(\d+)$' => { 'type' => 'multi' }
1195
    });
1196
    Bugzilla::Flag::validate($cgi, $bugid, $attach_id);
1197
    Bugzilla::FlagType::validate($cgi, $bugid, $attach_id);
1198

1199
  # Lock database tables in preparation for updating the attachment.
1200 1201 1202
  $dbh->bz_lock_tables('attachments WRITE', 'flags WRITE' ,
          'flagtypes READ', 'fielddefs READ', 'bugs_activity WRITE',
          'flaginclusions AS i READ', 'flagexclusions AS e READ',
1203 1204
          # cc, bug_group_map, user_group_map, and groups are in here so we
          # can check the permissions of flag requestees and email addresses
1205
          # on the flag type cc: lists via the CanSeeBug
1206 1207 1208 1209
          # function call in Flag::notify. group_group_map is in here si
          # Bugzilla::User can flatten groups.
          'bugs WRITE', 'profiles READ', 'email_setting READ',
          'cc READ', 'bug_group_map READ', 'user_group_map READ',
1210 1211
          'group_group_map READ', 'groups READ');

1212 1213
  # Get a copy of the attachment record before we make changes
  # so we can record those changes in the activity table.
1214
  my ($olddescription, $oldcontenttype, $oldfilename, $oldispatch,
1215 1216 1217
      $oldisobsolete, $oldisprivate) = $dbh->selectrow_array(
      "SELECT description, mimetype, filename, ispatch, isobsolete, isprivate
       FROM attachments WHERE attach_id = ?", undef, $attach_id);
1218

1219
  # Quote the description and content type for use in the SQL UPDATE statement.
1220 1221 1222 1223 1224 1225 1226
  my $description = $cgi->param('description');
  my $contenttype = $cgi->param('contenttype');
  my $filename = $cgi->param('filename');
  # we can detaint this way thanks to placeholders
  trick_taint($description);
  trick_taint($contenttype);
  trick_taint($filename);
1227

1228
  # Figure out when the changes were made.
1229
  my ($timestamp) = $dbh->selectrow_array("SELECT NOW()");
1230
    
1231 1232 1233 1234
  # Update flags.  We have to do this before committing changes
  # to attachments so that we can delete pending requests if the user
  # is obsoleting this attachment without deleting any requests
  # the user submits at the same time.
1235
  Bugzilla::Flag::process($bugid, $attach_id, $timestamp, $cgi);
1236

1237
  # Update the attachment record in the database.
1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248
  $dbh->do("UPDATE  attachments 
            SET     description = ?,
                    mimetype    = ?,
                    filename    = ?,
                    ispatch     = ?,
                    isobsolete  = ?,
                    isprivate   = ?
            WHERE   attach_id   = ?",
            undef, ($description, $contenttype, $filename,
            $cgi->param('ispatch'), $cgi->param('isobsolete'), 
            $cgi->param('isprivate'), $attach_id));
1249 1250

  # Record changes in the activity table.
1251
  if ($olddescription ne $cgi->param('description')) {
1252
    my $fieldid = get_field_id('attachments.description');
1253
    $dbh->do("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when,
1254
                                        fieldid, removed, added)
1255 1256 1257
              VALUES (?,?,?,?,?,?,?)",
              undef, ($bugid, $attach_id, $userid, $timestamp, $fieldid,
                     $olddescription, $description));
1258
  }
1259
  if ($oldcontenttype ne $cgi->param('contenttype')) {
1260
    my $fieldid = get_field_id('attachments.mimetype');
1261
    $dbh->do("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when,
1262
                                        fieldid, removed, added)
1263 1264 1265
              VALUES (?,?,?,?,?,?,?)",
              undef, ($bugid, $attach_id, $userid, $timestamp, $fieldid,
                     $oldcontenttype, $contenttype));
1266
  }
1267
  if ($oldfilename ne $cgi->param('filename')) {
1268
    my $fieldid = get_field_id('attachments.filename');
1269
    $dbh->do("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when,
1270
                                        fieldid, removed, added)
1271 1272 1273
              VALUES (?,?,?,?,?,?,?)", 
              undef, ($bugid, $attach_id, $userid, $timestamp, $fieldid,
                     $oldfilename, $filename));
1274
  }
1275
  if ($oldispatch ne $cgi->param('ispatch')) {
1276
    my $fieldid = get_field_id('attachments.ispatch');
1277
    $dbh->do("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when,
1278
                                        fieldid, removed, added)
1279 1280 1281
              VALUES (?,?,?,?,?,?,?)",
              undef, ($bugid, $attach_id, $userid, $timestamp, $fieldid,
                     $oldispatch, $cgi->param('ispatch')));
1282
  }
1283
  if ($oldisobsolete ne $cgi->param('isobsolete')) {
1284
    my $fieldid = get_field_id('attachments.isobsolete');
1285
    $dbh->do("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when,
1286
                                        fieldid, removed, added)
1287 1288 1289
              VALUES (?,?,?,?,?,?,?)",
              undef, ($bugid, $attach_id, $userid, $timestamp, $fieldid,
                     $oldisobsolete, $cgi->param('isobsolete')));
1290
  }
1291
  if ($oldisprivate ne $cgi->param('isprivate')) {
1292
    my $fieldid = get_field_id('attachments.isprivate');
1293
    $dbh->do("INSERT INTO bugs_activity (bug_id, attach_id, who, bug_when,
1294
                                        fieldid, removed, added)
1295 1296 1297
              VALUES (?,?,?,?,?,?,?)",
              undef, ($bugid, $attach_id, $userid, $timestamp, $fieldid,
                     $oldisprivate, $cgi->param('isprivate')));
1298
  }
1299
  
1300
  # Unlock all database tables now that we are finished updating the database.
1301
  $dbh->bz_unlock_tables();
1302

1303
  # If the user submitted a comment while editing the attachment,
1304
  # add the comment to the bug.
1305
  if ($cgi->param('comment'))
1306
  {
1307 1308 1309 1310
    # Prepend a string to the comment to let users know that the comment came
    # from the "edit attachment" screen.
    my $comment = qq|(From update of attachment $attach_id)\n| .
                  $cgi->param('comment');
1311 1312

    # Append the comment to the list of comments in the database.
1313
    AppendComment($bugid, $userid, $comment, $cgi->param('isprivate'), $timestamp);
1314
  }
1315
  
1316
  # Define the variables and functions that will be passed to the UI template.
1317
  $vars->{'mailrecipients'} = { 'changer' => Bugzilla->user->login };
1318
  $vars->{'attachid'} = $attach_id; 
1319 1320
  $vars->{'bugid'} = $bugid; 

1321
  print $cgi->header();
1322 1323

  # Generate and return the UI (HTML page) from the appropriate template.
1324 1325
  $template->process("attachment/updated.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
1326
}
1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405

# Only administrators can delete attachments.
sub delete_attachment {
    my $user = Bugzilla->login(LOGIN_REQUIRED);
    my $dbh = Bugzilla->dbh;

    print $cgi->header();

    $user->in_group('admin')
      || ThrowUserError('auth_failure', {group  => 'admin',
                                         action => 'delete',
                                         object => 'attachment'});

    Param('allow_attachment_deletion')
      || ThrowUserError('attachment_deletion_disabled');

    # Make sure the administrator is allowed to edit this attachment.
    my ($attach_id, $bug_id) = validateID();
    validateCanEdit($attach_id);
    validateCanChangeAttachment($attach_id);

    my $attachment = Bugzilla::Attachment->get($attach_id);
    $attachment->datasize || ThrowUserError('attachment_removed');

    # We don't want to let a malicious URL accidentally delete an attachment.
    my $token = trim($cgi->param('token'));
    if ($token) {
        my ($creator_id, $date, $event) = Bugzilla::Token::GetTokenData($token);
        unless ($creator_id
                  && ($creator_id == $user->id)
                  && ($event eq "attachment$attach_id"))
        {
            # The token is invalid.
            ThrowUserError('token_inexistent');
        }

        # The token is valid. Delete the content of the attachment.
        my $msg;
        $vars->{'attachid'} = $attach_id;
        $vars->{'bugid'} = $bug_id;
        $vars->{'date'} = $date;
        $vars->{'reason'} = clean_text($cgi->param('reason') || '');
        $vars->{'mailrecipients'} = { 'changer' => $user->login };

        $template->process("attachment/delete_reason.txt.tmpl", $vars, \$msg)
          || ThrowTemplateError($template->error());

        $dbh->bz_lock_tables('attachments WRITE', 'attach_data WRITE', 'flags WRITE');
        $dbh->do('DELETE FROM attach_data WHERE id = ?', undef, $attach_id);
        $dbh->do('UPDATE attachments SET mimetype = ?, ispatch = ?, isurl = ?
                  WHERE attach_id = ?', undef, ('text/plain', 0, 0, $attach_id));
        $dbh->do('DELETE FROM flags WHERE attach_id = ?', undef, $attach_id);
        $dbh->bz_unlock_tables;

        # If the attachment is stored locally, remove it.
        if (-e $attachment->_get_local_filename) {
            unlink $attachment->_get_local_filename;
        }

        # Now delete the token.
        Bugzilla::Token::DeleteToken($token);

        # Paste the reason provided by the admin into a comment.
        AppendComment($bug_id, $user->id, $msg);

        $template->process("attachment/updated.html.tmpl", $vars)
          || ThrowTemplateError($template->error());
    }
    else {
        # Create a token.
        $token = Bugzilla::Token::IssueSessionToken('attachment' . $attach_id);

        $vars->{'a'} = $attachment;
        $vars->{'token'} = $token;

        $template->process("attachment/confirm-delete.html.tmpl", $vars)
          || ThrowTemplateError($template->error());
    }
}