process_bug.cgi 76.8 KB
Newer Older
1
#!/usr/bin/perl -wT
2
# -*- Mode: perl; indent-tabs-mode: nil -*-
terry%netscape.com's avatar
terry%netscape.com committed
3
#
4 5 6 7 8 9 10 11 12 13
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
terry%netscape.com's avatar
terry%netscape.com committed
14
# The Original Code is the Bugzilla Bug Tracking System.
15
#
terry%netscape.com's avatar
terry%netscape.com committed
16
# The Initial Developer of the Original Code is Netscape Communications
17 18 19 20
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
terry%netscape.com's avatar
terry%netscape.com committed
21
# Contributor(s): Terry Weissman <terry@mozilla.org>
22
#                 Dan Mosedale <dmose@mozilla.org>
23
#                 Dave Miller <justdave@syndicomm.com>
24
#                 Christopher Aillon <christopher@aillon.com>
25
#                 Myk Melez <myk@mozilla.org>
26
#                 Jeff Hedlund <jeff.hedlund@matrixsi.com>
27
#                 Frédéric Buclin <LpSolit@gmail.com>
28
#                 Lance Larsh <lance.larsh@oracle.com>
terry%netscape.com's avatar
terry%netscape.com committed
29

30 31 32 33 34 35 36 37 38 39 40 41
# Implementation notes for this file:
#
# 1) the 'id' form parameter is validated early on, and if it is not a valid
# bugid an error will be reported, so it is OK for later code to simply check
# for a defined form 'id' value, and it can assume a valid bugid.
#
# 2) If the 'id' form parameter is not defined (after the initial validation),
# then we are processing multiple bugs, and @idlist will contain the ids.
#
# 3) If we are processing just the one id, then it is stored in @idlist for
# later processing.

42 43
use strict;

44 45
my $UserInEditGroupSet = -1;
my $UserInCanConfirmGroupSet = -1;
46
my $PrivilegesRequired = 0;
47
my $lastbugid = 0;
48

49 50
use lib qw(.);

51
require "globals.pl";
52
use Bugzilla;
53
use Bugzilla::Constants;
54
use Bugzilla::Bug;
55
use Bugzilla::BugMail;
56
use Bugzilla::User;
57
use Bugzilla::Util;
58
use Bugzilla::Field;
59

60 61
# Use the Flag module to modify flag data if the user set flags.
use Bugzilla::Flag;
62
use Bugzilla::FlagType;
63

64 65
# Shut up misguided -w warnings about "used only once":

66 67
use vars qw(@legal_product
          %versions
68 69 70 71 72 73 74
          %components
          %legal_opsys
          %legal_platform
          %legal_priority
          %settable_resolution
          %target_milestone
          %legal_severity
75
           );
76

77
my $user = Bugzilla->login(LOGIN_REQUIRED);
78
my $whoid = $user->id;
79
my $grouplist = $user->groups_as_string;
80

81
my $cgi = Bugzilla->cgi;
82
my $dbh = Bugzilla->dbh;
83 84
my $template = Bugzilla->template;
my $vars = {};
85

86 87
my $requiremilestone = 0;

88 89 90 91 92 93 94 95
######################################################################
# Begin Data/Security Validation
######################################################################

# Create a list of IDs of all bugs being modified in this request.
# This list will either consist of a single bug number from the "id"
# form/URL field or a series of numbers from multiple form/URL fields
# named "id_x" where "x" is the bug number.
96 97
# For each bug being modified, make sure its ID is a valid bug number 
# representing an existing bug that the user is authorized to access.
98
my @idlist;
99 100 101 102 103 104 105 106
if (defined $cgi->param('id')) {
  my $id = $cgi->param('id');
  ValidateBugID($id);

  # Store the validated, and detainted id back in the cgi data, as
  # lots of later code will need it, and will obtain it from there
  $cgi->param('id', $id);
  push @idlist, $id;
107
} else {
108
    foreach my $i ($cgi->param()) {
109
        if ($i =~ /^id_([1-9][0-9]*)/) {
110 111 112
            my $id = $1;
            ValidateBugID($id);
            push @idlist, $id;
113
        }
114 115 116
    }
}

117
# Make sure there are bugs to process.
118
scalar(@idlist) || ThrowUserError("no_bugs_chosen");
119

120 121
# Make sure form param 'dontchange' is defined so it can be compared to easily.
$cgi->param('dontchange','') unless defined $cgi->param('dontchange');
122

123 124
# Validate all timetracking fields
foreach my $field ("estimated_time", "work_time", "remaining_time") {
125 126 127
    if (defined $cgi->param($field)) {
        my $er_time = trim($cgi->param($field));
        if ($er_time ne $cgi->param('dontchange')) {
128 129 130 131 132
            Bugzilla::Bug::ValidateTime($er_time, $field);
        }
    }
}

133
if (UserInGroup(Param('timetrackinggroup'))) {
134 135
    my $wk_time = $cgi->param('work_time');
    if ($cgi->param('comment') =~ /^\s*$/ && $wk_time && $wk_time != 0) {
136
        ThrowUserError('comment_required');
137
    }
138 139
}

140
ValidateComment(scalar $cgi->param('comment'));
141

142 143 144 145 146 147 148
# If the bug(s) being modified have dependencies, validate them
# and rebuild the list with the validated values.  This is important
# because there are situations where validation changes the value
# instead of throwing an error, f.e. when one or more of the values
# is a bug alias that gets converted to its corresponding bug ID
# during validation.
foreach my $field ("dependson", "blocked") {
149 150 151 152
    if ($cgi->param('id')) {
        my $bug = new Bugzilla::Bug($cgi->param('id'), $user->id);
        my @old = @{$bug->$field};
        my @new;
153
        foreach my $id (split(/[\s,]+/, $cgi->param($field))) {
154
            next unless $id;
155
            ValidateBugID($id, $field);
156
            push @new, $id;
157
        }
158 159 160 161 162 163 164 165 166 167 168
        $cgi->param($field, join(",", @new));
        my ($added, $removed) = Bugzilla::Util::diff_arrays(\@old, \@new);
        foreach my $id (@$added , @$removed) {
            # ValidateBugID is called without $field here so that it will
            # throw an error if any of the changed bugs are not visible.
            ValidateBugID($id);
            if (!CheckCanChangeField($field, $bug->bug_id, 0, 1)) {
                $vars->{'privs'} = $PrivilegesRequired;
                $vars->{'field'} = $field;
                ThrowUserError("illegal_change", $vars);
            }
169 170 171 172 173 174 175
            if (Param("strict_isolation")) {
                my $deltabug = new Bugzilla::Bug($id, $user);
                if (!$user->can_edit_product($deltabug->{'product_id'})) {
                    $vars->{'field'} = $field;
                    ThrowUserError("illegal_change_deps", $vars);
                }
            }
176 177 178 179 180 181
        }
    } else {
        # Bugzilla does not support mass-change of dependencies so they
        # are not validated.  To prevent a URL-hacking risk, the dependencies
        # are deleted for mass-changes.
        $cgi->delete($field);
182 183 184
    }
}

185 186 187 188 189
# do a match on the fields if applicable

# The order of these function calls is important, as both Flag::validate
# and FlagType::validate assume User::match_field has ensured that the values
# in the requestee fields are legitimate user email addresses.
190
&Bugzilla::User::match_field($cgi, {
191 192 193 194
    'qa_contact'                => { 'type' => 'single' },
    'newcc'                     => { 'type' => 'multi'  },
    'masscc'                    => { 'type' => 'multi'  },
    'assigned_to'               => { 'type' => 'single' },
195
    '^requestee(_type)?-(\d+)$' => { 'type' => 'multi'  },
196
});
197 198 199 200 201

# Validate flags in all cases. validate() should not detect any
# reference to flags if $cgi->param('id') is undefined.
Bugzilla::Flag::validate($cgi, $cgi->param('id'));
Bugzilla::FlagType::validate($cgi, $cgi->param('id'));
202

203 204 205 206
######################################################################
# End Data/Security Validation
######################################################################

207
print $cgi->header();
208
$vars->{'title_tag'} = "bug_processed";
209 210 211 212

# Set the title if we can see a mid-air coming. This test may have false
# negatives, but never false positives, and should catch the majority of cases.
# It only works at all in the single bug case.
213 214 215
if (defined $cgi->param('id')) {
    SendSQL("SELECT delta_ts FROM bugs WHERE bug_id = " .
            $cgi->param('id'));
216 217
    my $delta_ts = FetchOneColumn();
    
218
    if (defined $cgi->param('delta_ts') && $cgi->param('delta_ts') ne $delta_ts)
219
    {
220
        $vars->{'title_tag'} = "mid_air";
221 222
    }
}
223

224
# Set up the vars for nagiavtional <link> elements
225
my @bug_list;
226
if ($cgi->cookie("BUGLIST") && defined $cgi->param('id')) {
227
    @bug_list = split(/:/, $cgi->cookie("BUGLIST"));
228 229 230
    $vars->{'bug_list'} = \@bug_list;
}

231 232
GetVersionTable();

233 234 235
check_form_field_defined($cgi, 'product');
check_form_field_defined($cgi, 'version');
check_form_field_defined($cgi, 'component');
236

237

238 239
# This function checks if there is a comment required for a specific
# function and tests, if the comment was given.
240
# If comments are required for functions is defined by params.
241
#
242
sub CheckonComment {
243 244 245 246 247 248 249 250 251
    my ($function) = (@_);
    
    # Param is 1 if comment should be added !
    my $ret = Param( "commenton" . $function );

    # Allow without comment in case of undefined Params.
    $ret = 0 unless ( defined( $ret ));

    if( $ret ) {
252 253
        if (!defined $cgi->param('comment')
            || $cgi->param('comment') =~ /^\s*$/) {
254
            # No comment - sorry, action not allowed !
255
            ThrowUserError("comment_required");
256 257 258 259 260 261 262
        } else {
            $ret = 0;
        }
    }
    return( ! $ret ); # Return val has to be inverted
}

263 264 265 266 267
# Figure out whether or not the user is trying to change the product
# (either the "product" variable is not set to "don't change" or the
# user is changing a single bug and has changed the bug's product),
# and make the user verify the version, component, target milestone,
# and bug groups if so.
268 269
my $oldproduct = '';
if (defined $cgi->param('id')) {
270
    SendSQL("SELECT name FROM products INNER JOIN bugs " .
271 272 273
            "ON products.id = bugs.product_id WHERE bug_id = " .
            $cgi->param('id'));
    $oldproduct = FetchSQLData();
274
}
275 276 277 278

if (((defined $cgi->param('id') && $cgi->param('product') ne $oldproduct) 
     || (!$cgi->param('id')
         && $cgi->param('product') ne $cgi->param('dontchange')))
279 280
    && CheckonComment( "reassignbycomponent" ))
{
281
    # Check to make sure they actually have the right to change the product
282
    if (!CheckCanChangeField('product', scalar $cgi->param('id'), $oldproduct,
283 284 285
                              $cgi->param('product'))) {
        $vars->{'oldvalue'} = $oldproduct;
        $vars->{'newvalue'} = $cgi->param('product');
286
        $vars->{'field'} = 'product';
287
        $vars->{'privs'} = $PrivilegesRequired;
288
        ThrowUserError("illegal_change", $vars);
289
    }
290

291
    my $prod = $cgi->param('product');
292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308
    trick_taint($prod);

    # If at least one bug does not belong to the product we are
    # moving to, we have to check whether or not the user is
    # allowed to enter bugs into that product.
    # Note that this check must be done early to avoid the leakage
    # of component, version and target milestone names.
    my $check_can_enter =
        $dbh->selectrow_array("SELECT 1 FROM bugs
                               INNER JOIN products
                               ON bugs.product_id = products.id
                               WHERE products.name != ?
                               AND bugs.bug_id IN
                               (" . join(',', @idlist) . ") " .
                               $dbh->sql_limit(1),
                               undef, $prod);

309
    if ($check_can_enter) { $user->can_enter_product($prod, 1) }
310 311 312 313 314 315 316 317 318

    # note that when this script is called from buglist.cgi (rather
    # than show_bug.cgi), it's possible that the product will be changed
    # but that the version and/or component will be set to 
    # "--dont_change--" but still happen to be correct.  in this case,
    # the if statement will incorrectly trigger anyway.  this is a 
    # pretty weird case, and not terribly unreasonable behavior, but 
    # worthy of a comment, perhaps.
    #
319 320
    my $vok = lsearch($::versions{$prod}, $cgi->param('version')) >= 0;
    my $cok = lsearch($::components{$prod}, $cgi->param('component')) >= 0;
321 322 323

    my $mok = 1;   # so it won't affect the 'if' statement if milestones aren't used
    if ( Param("usetargetmilestone") ) {
324
       check_form_field_defined($cgi, 'target_milestone');
325 326
       $mok = lsearch($::target_milestone{$prod},
                      $cgi->param('target_milestone')) >= 0;
327 328
    }

329 330 331
    # If the product-specific fields need to be verified, or we need to verify
    # whether or not to add the bugs to their new product's group, display
    # a verification form.
332 333
    if (!$vok || !$cok || !$mok || (AnyDefaultGroups()
        && !defined $cgi->param('addtonewgroup'))) {
334
        
335
        if (!$vok || !$cok || !$mok) {
336
            $vars->{'verify_fields'} = 1;
337 338 339 340
            my %defaults;
            # We set the defaults to these fields to the old value,
            # if its a valid option, otherwise we use the default where
            # thats appropriate
341
            $vars->{'versions'} = $::versions{$prod};
342
            if ($vok) {
343
                $defaults{'version'} = $cgi->param('version');
344
            }
345
            $vars->{'components'} = $::components{$prod};
346
            if ($cok) {
347
                $defaults{'component'} = $cgi->param('component');
348
            }
349 350 351
            if (Param("usetargetmilestone")) {
                $vars->{'use_target_milestone'} = 1;
                $vars->{'milestones'} = $::target_milestone{$prod};
352
                if ($mok) {
353
                    $defaults{'target_milestone'} = $cgi->param('target_milestone');
354
                } else {
355 356
                    SendSQL("SELECT defaultmilestone FROM products " .
                            "WHERE name = " . SqlQuote($prod));
357 358
                    $defaults{'target_milestone'} = FetchOneColumn();
                }
359
            }
360 361
            else {
                $vars->{'use_target_milestone'} = 0;
terry%netscape.com's avatar
terry%netscape.com committed
362
            }
363
            $vars->{'defaults'} = \%defaults;
364
        }
365
        else {
366
            $vars->{'verify_fields'} = 0;
terry%netscape.com's avatar
terry%netscape.com committed
367
        }
368
        
369
        $vars->{'verify_bug_group'} = (AnyDefaultGroups() 
370
                                       && !defined $cgi->param('addtonewgroup'));
371
        
372
        $template->process("bug/process/verify-new-product.html.tmpl", $vars)
373
          || ThrowTemplateError($template->error());
374
        exit;
terry%netscape.com's avatar
terry%netscape.com committed
375 376 377 378
    }
}


379 380 381 382 383 384 385 386
# Checks that the user is allowed to change the given field.  Actually, right
# now, the rules are pretty simple, and don't look at the field itself very
# much, but that could be enhanced.

my $ownerid;
my $reporterid;
my $qacontactid;

387 388 389
################################################################################
# CheckCanChangeField() defines what users are allowed to change what bugs. You
# can add code here for site-specific policy changes, according to the 
390
# instructions given in the Bugzilla Guide and below. Note that you may also
391 392
# have to update the Bugzilla::Bug::user() function to give people access to the
# options that they are permitted to change.
393 394 395 396 397 398 399 400 401 402 403 404 405 406 407
#
# CheckCanChangeField() should return true if the user is allowed to change this
# field, and false if they are not.
#
# The parameters to this function are as follows:
# $field    - name of the field in the bugs table the user is trying to change
# $bugid    - the ID of the bug they are changing
# $oldvalue - what they are changing it from
# $newvalue - what they are changing it to
#
# Note that this function is currently not called for dependency changes 
# (bug 141593) or CC changes, which means anyone can change those fields.
#
# Do not change the sections between START DO_NOT_CHANGE and END DO_NOT_CHANGE.
################################################################################
408
sub CheckCanChangeField {
409 410 411
    # START DO_NOT_CHANGE
    my ($field, $bugid, $oldvalue, $newvalue) = (@_);

412 413 414
    $oldvalue = defined($oldvalue) ? $oldvalue : '';
    $newvalue = defined($newvalue) ? $newvalue : '';

415
    # Return true if they haven't changed this field at all.
416 417
    if ($oldvalue eq $newvalue) {
        return 1;
418
    } elsif (trim($oldvalue) eq trim($newvalue)) {
419
        return 1;
420
    # numeric fields need to be compared using == 
421
    } elsif (($field eq "estimated_time" || $field eq "remaining_time")
422
             && $newvalue ne $cgi->param('dontchange')
423 424
             && $oldvalue == $newvalue)
    {
425
        return 1;
426
    }
427

428 429 430 431 432
    # A resolution change is always accompanied by a status change. So, we 
    # always OK resolution changes; if they really can't do this, we will 
    # notice it when status is checked. 
    if ($field eq "resolution") { 
        return 1;             
433
    }
434 435 436 437 438
    # END DO_NOT_CHANGE

    # Allow anyone to change comments.
    if ($field =~ /^longdesc/) {
        return 1;
439
    }
440 441 442

    # Ignore the assigned_to field if the bug is not being reassigned
    if ($field eq "assigned_to"
443 444
        && $cgi->param('knob') ne "reassignbycomponent"
        && $cgi->param('knob') ne "reassign")
445 446 447 448
    {
        return 1;
    }

449 450 451 452
    # START DO_NOT_CHANGE
    # Find out whether the user is a member of the "editbugs" and/or
    # "canconfirm" groups. $UserIn*GroupSet are caches of the return value of 
    # the UserInGroup calls.
453 454 455
    if ($UserInEditGroupSet < 0) {
        $UserInEditGroupSet = UserInGroup("editbugs");
    }
456 457 458 459 460
    
    if ($UserInCanConfirmGroupSet < 0) {
        $UserInCanConfirmGroupSet = UserInGroup("canconfirm");
    }
    # END DO_NOT_CHANGE
461 462 463 464 465 466

    # If the user isn't allowed to change a field, we must tell him who can.
    # We store the required permission set into the $PrivilegesRequired
    # variable which gets passed to the error template.
    #
    # $PrivilegesRequired = 0 : no privileges required;
467 468
    # $PrivilegesRequired = 1 : the reporter, assignee or an empowered user;
    # $PrivilegesRequired = 2 : the assignee or an empowered user;
469 470 471
    # $PrivilegesRequired = 3 : an empowered user.

    # Allow anyone with "editbugs" privs to change anything.
472 473 474
    if ($UserInEditGroupSet) {
        return 1;
    }
475 476 477 478

    # *Only* users with "canconfirm" privs can confirm bugs.
    if ($field eq "canconfirm"
        || ($field eq "bug_status"
479
            && $oldvalue eq 'UNCONFIRMED'
480 481 482 483
            && IsOpenedState($newvalue)))
    {
        $PrivilegesRequired = 3;
        return $UserInCanConfirmGroupSet;
484
    }
485

486 487
    # START DO_NOT_CHANGE
    # $reporterid, $ownerid and $qacontactid are caches of the results of
488
    # the call to find out the assignee, reporter and qacontact of the current bug.
489
    if ($lastbugid != $bugid) {
490 491
        SendSQL("SELECT reporter, assigned_to, qa_contact FROM bugs
                 WHERE bug_id = $bugid");
492
        ($reporterid, $ownerid, $qacontactid) = (FetchSQLData());
493
        $lastbugid = $bugid;
494 495 496
    }    
    # END DO_NOT_CHANGE

497
    # Allow the assignee to change anything else.
498
    if ($ownerid == $whoid) {
499
        return 1;
500
    }
501
    
502
    # Allow the QA contact to change anything else.
503
    if (Param('useqacontact') && $qacontactid && ($qacontactid == $whoid)) {
504 505
        return 1;
    }
506
    
507 508
    # At this point, the user is either the reporter or an
    # unprivileged user. We first check for fields the reporter
509
    # is not allowed to change.
510 511 512 513

    # The reporter may not:
    # - reassign bugs, unless the bugs are assigned to him;
    #   in that case we will have already returned 1 above
514
    #   when checking for the assignee of the bug.
515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532
    if ($field eq "assigned_to") {
        $PrivilegesRequired = 2;
        return 0;
    }
    # - change the QA contact
    if ($field eq "qa_contact") {
        $PrivilegesRequired = 2;
        return 0;
    }
    # - change the target milestone
    if ($field eq "target_milestone") {
        $PrivilegesRequired = 2;
        return 0;
    }
    # - change the priority (unless he could have set it originally)
    if ($field eq "priority"
        && !Param('letsubmitterchoosepriority'))
    {
533
        $PrivilegesRequired = 2;
534 535
        return 0;
    }
536

537 538
    # The reporter is allowed to change anything else.
    if ($reporterid == $whoid) {
539
        return 1;
540
    }
541

542 543
    # If we haven't returned by this point, then the user doesn't
    # have the necessary permissions to change this field.
544
    $PrivilegesRequired = 1;
545
    return 0;
546 547
}

548 549
# Confirm that the reporter of the current bug can access the bug we are duping to.
sub DuplicateUserConfirm {
550
    # if we've already been through here, then exit
551
    if (defined $cgi->param('confirm_add_duplicate')) {
552 553 554
        return;
    }

555 556 557 558
    # Remember that we validated both these ids earlier, so we know
    # they are both valid bug ids
    my $dupe = $cgi->param('id');
    my $original = $cgi->param('dup_id');
559
    
560
    SendSQL("SELECT reporter FROM bugs WHERE bug_id = $dupe");
561
    my $reporter = FetchOneColumn();
562
    my $rep_user = Bugzilla::User->new($reporter);
563

564
    if ($rep_user->can_see_bug($original)) {
565
        $cgi->param('confirm_add_duplicate', '1');
566 567
        return;
    }
568 569

    SendSQL("SELECT cclist_accessible FROM bugs WHERE bug_id = $original");
570
    $vars->{'cclist_accessible'} = FetchOneColumn();
571
    
572 573 574
    # Once in this part of the subroutine, the user has not been auto-validated
    # and the duper has not chosen whether or not to add to CC list, so let's
    # ask the duper what he/she wants to do.
575
    
576 577 578 579 580
    $vars->{'original_bug_id'} = $original;
    $vars->{'duplicate_bug_id'} = $dupe;
    
    # Confirm whether or not to add the reporter to the cc: list
    # of the original bug (the one this bug is being duped against).
581
    print Bugzilla->cgi->header();
582
    $template->process("bug/process/confirm-duplicate.html.tmpl", $vars)
583
      || ThrowTemplateError($template->error());
584
    exit;
585
}
586

587
if (defined $cgi->param('id')) {
588 589 590 591 592 593 594
    # since this means that we were called from show_bug.cgi, now is a good
    # time to do a whole bunch of error checking that can't easily happen when
    # we've been called from buglist.cgi, because buglist.cgi only tweaks
    # values that have been changed instead of submitting all the new values.
    # (XXX those error checks need to happen too, but implementing them 
    # is more work in the current architecture of this script...)
    #
595 596
    check_form_field($cgi, 'product', \@::legal_product);
    check_form_field($cgi, 'component', 
597
                   \@{$::components{$cgi->param('product')}});
598
    check_form_field($cgi, 'version', \@{$::versions{$cgi->param('product')}});
599
    if ( Param("usetargetmilestone") ) {
600
        check_form_field($cgi, 'target_milestone', 
601
                       \@{$::target_milestone{$cgi->param('product')}});
602
    }
603 604 605 606 607 608 609
    check_form_field($cgi, 'rep_platform', \@::legal_platform);
    check_form_field($cgi, 'op_sys', \@::legal_opsys);
    check_form_field($cgi, 'priority', \@::legal_priority);
    check_form_field($cgi, 'bug_severity', \@::legal_severity);
    check_form_field_defined($cgi, 'bug_file_loc');
    check_form_field_defined($cgi, 'short_desc');
    check_form_field_defined($cgi, 'longdesclength');
610

611
    if (trim($cgi->param('short_desc')) eq "") {
612
        ThrowUserError("require_summary");
613
    }
terry%netscape.com's avatar
terry%netscape.com committed
614 615
}

616 617 618 619 620
my $action = trim($cgi->param('action') || '');

if ($action eq Param('move-button-text')) {
    Param('move-enabled') || ThrowUserError("move_bugs_disabled");

621 622
    $user->is_mover || ThrowUserError("auth_failure", {action => 'move',
                                                       object => 'bugs'});
623 624 625 626 627 628 629 630 631 632 633 634 635 636 637

    # Moved bugs are marked as RESOLVED MOVED.
    my $sth = $dbh->prepare("UPDATE bugs
                                SET bug_status = 'RESOLVED',
                                    resolution = 'MOVED',
                                    delta_ts = ?
                              WHERE bug_id = ?");
    # Bugs cannot be a dupe and moved at the same time.
    my $sth2 = $dbh->prepare("DELETE FROM duplicates WHERE dupe = ?");

    my $comment = "";
    if (defined $cgi->param('comment') && $cgi->param('comment') !~ /^\s*$/) {
        $comment = $cgi->param('comment') . "\n\n";
    }
    $comment .= "Bug moved to " . Param('move-to-url') . ".\n\n";
638
    $comment .= "If the move succeeded, " . $user->login . " will receive a mail\n";
639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674
    $comment .= "containing the number of the new bug in the other database.\n";
    $comment .= "If all went well,  please mark this bug verified, and paste\n";
    $comment .= "in a link to the new bug. Otherwise, reopen this bug.\n";

    $dbh->bz_lock_tables('bugs WRITE', 'bugs_activity WRITE', 'duplicates WRITE',
                         'longdescs WRITE', 'profiles READ', 'groups READ',
                         'bug_group_map READ', 'group_group_map READ',
                         'user_group_map READ', 'classifications READ',
                         'products READ', 'components READ', 'votes READ',
                         'cc READ', 'fielddefs READ');

    my $timestamp = $dbh->selectrow_array("SELECT NOW()");
    my @bugs;
    # First update all moved bugs.
    foreach my $id (@idlist) {
        my $bug = new Bugzilla::Bug($id, $whoid);
        push(@bugs, $bug);

        $sth->execute($timestamp, $id);
        $sth2->execute($id);

        AppendComment($id, $whoid, $comment, 0, $timestamp);

        if ($bug->bug_status ne 'RESOLVED') {
            LogActivityEntry($id, 'bug_status', $bug->bug_status,
                             'RESOLVED', $whoid, $timestamp);
        }
        if ($bug->resolution ne 'MOVED') {
            LogActivityEntry($id, 'resolution', $bug->resolution,
                             'MOVED', $whoid, $timestamp);
        }
    }
    $dbh->bz_unlock_tables();

    # Now send emails.
    foreach my $id (@idlist) {
675
        $vars->{'mailrecipients'} = { 'changer' => $user->login };
676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711
        $vars->{'id'} = $id;
        $vars->{'type'} = "move";

        $template->process("bug/process/results.html.tmpl", $vars)
          || ThrowTemplateError($template->error());
        $vars->{'header_done'} = 1;
    }
    # Prepare and send all data about these bugs to the new database
    my $to = Param('move-to-address');
    $to =~ s/@/\@/;
    my $from = Param('moved-from-address');
    $from =~ s/@/\@/;
    my $msg = "To: $to\n";
    $msg .= "From: Bugzilla <" . $from . ">\n";
    $msg .= "Subject: Moving bug(s) " . join(', ', @idlist) . "\n\n";

    my @fieldlist = (Bugzilla::Bug::fields(), 'group', 'long_desc', 'attachment');
    my %displayfields;
    foreach (@fieldlist) {
        $displayfields{$_} = 1;
    }

    $template->process("bug/show.xml.tmpl", { bugs => \@bugs,
                                              displayfields => \%displayfields,
                                            }, \$msg)
      || ThrowTemplateError($template->error());

    $msg .= "\n";
    Bugzilla::BugMail::MessageToMTA($msg);

    # End the response page.
    $template->process("bug/navigate.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
    $template->process("global/footer.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
    exit;
712 713 714
}


715 716 717 718
$::query = "update bugs\nset";
$::comma = "";
umask(0);

719 720
sub _remove_remaining_time {
    if (UserInGroup(Param('timetrackinggroup'))) {
721 722
        if ( defined $cgi->param('remaining_time') 
             && $cgi->param('remaining_time') > 0 )
723
        {
724
            $cgi->param('remaining_time', 0);
725 726 727 728 729 730 731 732 733
            $vars->{'message'} = "remaining_time_zeroed";
        }
    }
    else {
        DoComma();
        $::query .= "remaining_time = 0";
    }
}

734 735 736
sub DoComma {
    $::query .= "$::comma\n    ";
    $::comma = ",";
terry%netscape.com's avatar
terry%netscape.com committed
737 738
}

739
sub DoConfirm {
740
    if (CheckCanChangeField("canconfirm", scalar $cgi->param('id'), 0, 1)) {
741 742 743 744 745
        DoComma();
        $::query .= "everconfirmed = 1";
    }
}

746 747
sub ChangeStatus {
    my ($str) = (@_);
748 749
    if (!$cgi->param('dontchange')
        || $str ne $cgi->param('dontchange')) {
750
        DoComma();
751
        if ($cgi->param('knob') eq 'reopen') {
752 753
            # When reopening, we need to check whether the bug was ever
            # confirmed or not
754
            $::query .= "bug_status = CASE WHEN everconfirmed = 1 THEN " .
755
                         SqlQuote($str) . " ELSE 'UNCONFIRMED' END";
756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781
        } elsif (IsOpenedState($str)) {
            # Note that we cannot combine this with the above branch - here we
            # need to check if bugs.bug_status is open, (since we don't want to
            # reopen closed bugs when reassigning), while above the whole point
            # is to reopen a closed bug.
            # Currently, the UI doesn't permit a user to reassign a closed bug
            # from the single bug page (only during a mass change), but they
            # could still hack the submit, so don't restrict this extended
            # check to the mass change page for safety/sanity/consistency
            # purposes.

            # The logic for this block is:
            # If the new state is open:
            #   If the old state was open
            #     If the bug was confirmed
            #       - move it to the new state
            #     Else
            #       - Set the state to unconfirmed
            #   Else
            #     - leave it as it was

            # This is valid only because 'reopen' is the only thing which moves
            # from closed to open, and its handled above
            # This also relies on the fact that confirming and accepting have
            # already called DoConfirm before this is called

782 783
            my @open_state = map(SqlQuote($_), OpenStates());
            my $open_state = join(", ", @open_state);
784 785 786
            $::query .= "bug_status = CASE WHEN bug_status IN($open_state) THEN " .
                                        "(CASE WHEN everconfirmed = 1 THEN " .
                                            SqlQuote($str) . " ELSE " .
787
                                            " 'UNCONFIRMED' END) ELSE " .
788
                                        "bug_status END";
789
        } else {
790
            $::query .= "bug_status = " . SqlQuote($str);
791
        }
792 793 794
        # If bugs are reassigned and their status is "UNCONFIRMED", they
        # should keep this status instead of "NEW" as suggested here.
        # This point is checked for each bug later in the code.
795
        $cgi->param('bug_status', $str);
terry%netscape.com's avatar
terry%netscape.com committed
796 797 798
    }
}

799 800
sub ChangeResolution {
    my ($str) = (@_);
801 802
    if (!$cgi->param('dontchange')
        || $str ne $cgi->param('dontchange'))
803
    {
804
        DoComma();
805
        $::query .= "resolution = " . SqlQuote($str);
806 807
        # We define this variable here so that customized installations
        # may set rules based on the resolution in CheckCanChangeField.
808
        $cgi->param('resolution', $str);
terry%netscape.com's avatar
terry%netscape.com committed
809 810 811
    }
}

812 813 814 815
# Changing this so that it will process groups from checkboxes instead of
# select lists.  This means that instead of looking for the bit-X values in
# the form, we need to loop through all the bug groups this user has access
# to, and for each one, see if it's selected.
816 817
# If the form element isn't present, or the user isn't in the group, leave
# it as-is
818

819 820 821
my @groupAdd = ();
my @groupDel = ();

822 823 824
SendSQL("SELECT groups.id, isactive FROM groups " .
        "WHERE id IN($grouplist) " .
        "AND isbuggroup = 1");
825 826 827 828 829 830 831
while (my ($b, $isactive) = FetchSQLData()) {
    # The multiple change page may not show all groups a bug is in
    # (eg product groups when listing more than one product)
    # Only consider groups which were present on the form. We can't do this
    # for single bug changes because non-checked checkboxes aren't present.
    # All the checkboxes should be shown in that case, though, so its not
    # an issue there
832 833
    if (defined $cgi->param('id') || defined $cgi->param("bit-$b")) {
        if (!$cgi->param("bit-$b")) {
834
            push(@groupDel, $b);
835
        } elsif ($cgi->param("bit-$b") == 1 && $isactive) {
836
            push(@groupAdd, $b);
837 838
        }
    }
839 840
}

841 842
foreach my $field ("rep_platform", "priority", "bug_severity",
                   "bug_file_loc", "short_desc", "version", "op_sys",
843
                   "target_milestone", "status_whiteboard") {
844 845 846
    if (defined $cgi->param($field)) {
        if (!$cgi->param('dontchange')
            || $cgi->param($field) ne $cgi->param('dontchange')) {
847
            DoComma();
848
            $::query .= "$field = " . SqlQuote(trim($cgi->param($field)));
terry%netscape.com's avatar
terry%netscape.com committed
849 850 851 852
        }
    }
}

853
my $prod_id; # Remember, can't use this for mass changes
854 855
if ($cgi->param('product') ne $cgi->param('dontchange')) {
    $prod_id = get_product_id($cgi->param('product'));
856
    $prod_id ||
857 858
      ThrowUserError("invalid_product_name", 
                     {product => $cgi->param('product')});
859
      
860 861 862 863
    DoComma();
    $::query .= "product_id = $prod_id";
} else {
    SendSQL("SELECT DISTINCT product_id FROM bugs WHERE bug_id IN (" .
864
            join(',', @idlist) . ") " . $dbh->sql_limit(2));
865 866 867 868 869
    $prod_id = FetchOneColumn();
    $prod_id = undef if (FetchOneColumn());
}

my $comp_id; # Remember, can't use this for mass changes
870
if ($cgi->param('component') ne $cgi->param('dontchange')) {
871
    if (!defined $prod_id) {
872
        ThrowUserError("no_component_change_for_multiple_products");
873 874
    }
    $comp_id = get_component_id($prod_id,
875
                                $cgi->param('component'));
876
    $comp_id || ThrowCodeError("invalid_component", 
877 878
                               {name => $cgi->param('component'),
                                product => $cgi->param('product')});
879
    
880
    $cgi->param('component_id', $comp_id);
881 882 883 884
    DoComma();
    $::query .= "component_id = $comp_id";
}

885 886
# If this installation uses bug aliases, and the user is changing the alias,
# add this change to the query.
887 888
if (Param("usebugaliases") && defined $cgi->param('alias')) {
    my $alias = trim($cgi->param('alias'));
889 890 891 892 893 894 895 896 897 898 899
    
    # Since aliases are unique (like bug numbers), they can only be changed
    # for one bug at a time, so ignore the alias change unless only a single
    # bug is being changed.
    if (scalar(@idlist) == 1) {
        # Add the alias change to the query.  If the field contains the blank 
        # value, make the field be NULL to indicate that the bug has no alias.
        # Otherwise, if the field contains a value, update the record 
        # with that value.
        DoComma();
        $::query .= "alias = ";
900 901 902
        if ($alias ne "") {
            ValidateBugAlias($alias, $idlist[0]);
            $::query .= $dbh->quote($alias);
903
        } else {
904
            $::query .= "NULL";
905
        }
906 907
    }
}
908

909 910
# If the user is submitting changes from show_bug.cgi for a single bug,
# and that bug is restricted to a group, process the checkboxes that
911
# allowed the user to set whether or not the reporter
912 913
# and cc list can see the bug even if they are not members of all groups 
# to which the bug is restricted.
914 915 916
if (defined $cgi->param('id')) {
    SendSQL("SELECT group_id FROM bug_group_map WHERE bug_id = " .
            $cgi->param('id'));
917 918
    my ($havegroup) = FetchSQLData();
    if ( $havegroup ) {
919
        DoComma();
920 921 922 923
        $cgi->param('reporter_accessible',
                    $cgi->param('reporter_accessible') ? '1' : '0');
        $::query .= 'reporter_accessible = ' .
                    $cgi->param('reporter_accessible');
924 925

        DoComma();
926 927 928
        $cgi->param('cclist_accessible',
                    $cgi->param('cclist_accessible') ? '1' : '0');
        $::query .= 'cclist_accessible = ' . $cgi->param('cclist_accessible');
929 930 931
    }
}

932
if (defined $cgi->param('id') &&
933
    (Param("insidergroup") && UserInGroup(Param("insidergroup")))) {
934 935

    foreach my $field ($cgi->param()) {
936 937
        if ($field =~ /when-([0-9]+)/) {
            my $sequence = $1;
938 939 940 941 942 943 944
            my $private = $cgi->param("isprivate-$sequence") ? 1 : 0 ;
            if ($private != $cgi->param("oisprivate-$sequence")) {
                my $field_data = $cgi->param("$field");
                detaint_natural($field_data);
                SendSQL("UPDATE longdescs SET isprivate = $private " .
                        "WHERE bug_id = " . $cgi->param('id') . 
                        " AND bug_when = $field_data");
945 946 947 948 949
            }
        }

    }
}
950

951
my $duplicate = 0;
952

953 954 955 956
# We need to check the addresses involved in a CC change before we touch any bugs.
# What we'll do here is formulate the CC data into two hashes of ID's involved
# in this CC change.  Then those hashes can be used later on for the actual change.
my (%cc_add, %cc_remove);
957 958 959 960
if (defined $cgi->param('newcc')
    || defined $cgi->param('addselfcc')
    || defined $cgi->param('removecc')
    || defined $cgi->param('masscc')) {
961 962 963
    # If masscc is defined, then we came from buglist and need to either add or
    # remove cc's... otherwise, we came from bugform and may need to do both.
    my ($cc_add, $cc_remove) = "";
964 965 966 967 968
    if (defined $cgi->param('masscc')) {
        if ($cgi->param('ccaction') eq 'add') {
            $cc_add = join(' ',$cgi->param('masscc'));
        } elsif ($cgi->param('ccaction') eq 'remove') {
            $cc_remove = join(' ',$cgi->param('masscc'));
969 970
        }
    } else {
971
        $cc_add = join(' ',$cgi->param('newcc'));
972 973
        # We came from bug_form which uses a select box to determine what cc's
        # need to be removed...
974 975
        if (defined $cgi->param('removecc') && $cgi->param('cc')) {
            $cc_remove = join (",", $cgi->param('cc'));
976 977 978 979
        }
    }

    if ($cc_add) {
980 981
        $cc_add =~ s/[\s,]+/ /g; # Change all delimiters to a single space
        foreach my $person ( split(" ", $cc_add) ) {
982 983 984 985
            my $pid = DBNameToIdAndCheck($person);
            $cc_add{$pid} = $person;
        }
    }
986
    if ($cgi->param('addselfcc')) {
987 988
        $cc_add{$whoid} = $user->login;
    }
989
    if ($cc_remove) {
990 991
        $cc_remove =~ s/[\s,]+/ /g; # Change all delimiters to a single space
        foreach my $person ( split(" ", $cc_remove) ) {
992 993 994 995 996 997
            my $pid = DBNameToIdAndCheck($person);
            $cc_remove{$pid} = $person;
        }
    }
}

998 999
# Store the new assignee and QA contact IDs (if any). This is the
# only way to keep these informations when bugs are reassigned by
1000
# component as $cgi->param('assigned_to') and $cgi->param('qa_contact')
1001 1002 1003 1004 1005
# are not the right fields to look at.

my $assignee;
my $qacontact;

1006 1007
if (defined $cgi->param('qa_contact')
    && $cgi->param('knob') ne "reassignbycomponent")
1008
{
1009
    my $name = trim($cgi->param('qa_contact'));
1010
    # The QA contact cannot be deleted from show_bug.cgi for a single bug!
1011
    if ($name ne $cgi->param('dontchange')) {
1012
        $qacontact = DBNameToIdAndCheck($name) if ($name ne "");
1013 1014 1015 1016 1017
        if (Param("strict_isolation")) {
                my $product_id = get_product_id($cgi->param('product'));
                Bugzilla::Bug::can_add_user_to_bug(
                    $product_id, $cgi->param('id'), $qacontact);
        }
1018
        DoComma();
1019 1020 1021 1022 1023 1024
        if($qacontact) {
            $::query .= "qa_contact = $qacontact";
        }
        else {
            $::query .= "qa_contact = NULL";
        }
1025 1026
    }
}
1027

1028
check_form_field_defined($cgi, 'knob');
1029
SWITCH: for ($cgi->param('knob')) {
1030 1031 1032
    /^none$/ && do {
        last SWITCH;
    };
1033 1034 1035 1036 1037
    /^confirm$/ && CheckonComment( "confirm" ) && do {
        DoConfirm();
        ChangeStatus('NEW');
        last SWITCH;
    };
1038
    /^accept$/ && CheckonComment( "accept" ) && do {
1039
        DoConfirm();
1040
        ChangeStatus('ASSIGNED');
1041 1042
        if (Param("usetargetmilestone") && Param("musthavemilestoneonaccept")) {
            $requiremilestone = 1;
1043
        }
1044 1045
        last SWITCH;
    };
1046
    /^clearresolution$/ && CheckonComment( "clearresolution" ) && do {
1047 1048 1049
        ChangeResolution('');
        last SWITCH;
    };
1050
    /^resolve$/ && CheckonComment( "resolve" ) && do {
1051
        # Check here, because its the only place we require the resolution
1052
        check_form_field($cgi, 'resolution', \@::settable_resolution);
1053

1054
        # don't resolve as fixed while still unresolved blocking bugs
1055
        if (Param("noresolveonopenblockers")
1056
            && $cgi->param('resolution') eq 'FIXED')
1057
        {
1058
            my @dependencies = Bugzilla::Bug::CountOpenDependencies(@idlist);
1059 1060
            if (scalar @dependencies > 0) {
                ThrowUserError("still_unresolved_bugs",
1061 1062
                               { dependencies     => \@dependencies,
                                 dependency_count => scalar @dependencies });
1063
            }
1064
        }
1065 1066 1067 1068 1069

        # RESOLVED bugs should have no time remaining;
        # more time can be added for the VERIFY step, if needed.
        _remove_remaining_time();

1070
        ChangeStatus('RESOLVED');
1071
        ChangeResolution($cgi->param('resolution'));
1072 1073
        last SWITCH;
    };
1074
    /^reassign$/ && CheckonComment( "reassign" ) && do {
1075
        if ($cgi->param('andconfirm')) {
1076 1077
            DoConfirm();
        }
1078 1079
        ChangeStatus('NEW');
        DoComma();
1080 1081 1082 1083 1084 1085 1086 1087
        if (defined $cgi->param('assigned_to')) { 
            my $uid = DBNameToIdAndCheck($cgi->param('assigned_to'));
            if (Param("strict_isolation")) {
                my $product_id = get_product_id($cgi->param('product'));
                Bugzilla::Bug::can_add_user_to_bug(
                    $product_id, $cgi->param('id'), $uid);
            }
        } elsif (!defined $cgi->param('assigned_to')
1088
            || trim($cgi->param('assigned_to')) eq "") {
1089
            ThrowUserError("reassign_to_empty");
1090
        }
1091
        $assignee = DBNameToIdAndCheck(trim($cgi->param('assigned_to')));
1092
        $::query .= "assigned_to = $assignee";
1093 1094
        last SWITCH;
    };
1095
    /^reassignbycomponent$/  && CheckonComment( "reassignbycomponent" ) && do {
1096
        if ($cgi->param('product') eq $cgi->param('dontchange')) {
1097
            ThrowUserError("need_product");
1098
        }
1099
        if ($cgi->param('component') eq $cgi->param('dontchange')) {
1100
            ThrowUserError("need_component");
terry%netscape.com's avatar
terry%netscape.com committed
1101
        }
1102
        if ($cgi->param('compconfirm')) {
1103 1104
            DoConfirm();
        }
1105
        ChangeStatus('NEW');
1106 1107
        SendSQL("SELECT initialowner FROM components " .
                "WHERE components.id = $comp_id");
1108
        $assignee = FetchOneColumn();
1109
        DoComma();
1110
        $::query .= "assigned_to = $assignee";
1111
        if (Param("useqacontact")) {
1112 1113
            SendSQL("SELECT initialqacontact FROM components " .
                    "WHERE components.id = $comp_id");
1114
            $qacontact = FetchOneColumn();
1115
            DoComma();
1116 1117 1118 1119 1120 1121
            if ($qacontact) {
                $::query .= "qa_contact = $qacontact";
            }
            else {
                $::query .= "qa_contact = NULL";
            }
1122
        }
1123 1124
        last SWITCH;
    };   
1125
    /^reopen$/  && CheckonComment( "reopen" ) && do {
1126
        ChangeStatus('REOPENED');
1127
        ChangeResolution('');
1128 1129
        last SWITCH;
    };
1130
    /^verify$/ && CheckonComment( "verify" ) && do {
1131 1132 1133
        ChangeStatus('VERIFIED');
        last SWITCH;
    };
1134
    /^close$/ && CheckonComment( "close" ) && do {
1135 1136 1137
        # CLOSED bugs should have no time remaining.
        _remove_remaining_time();

1138 1139 1140
        ChangeStatus('CLOSED');
        last SWITCH;
    };
1141
    /^duplicate$/ && CheckonComment( "duplicate" ) && do {
1142 1143 1144 1145 1146 1147
        # You cannot mark bugs as duplicates when changing
        # several bugs at once.
        unless (defined $cgi->param('id')) {
            ThrowUserError('dupe_not_allowed');
        }

1148
        # Make sure we can change the original bug (issue A on bug 96085)
1149
        check_form_field_defined($cgi, 'dup_id');
1150 1151 1152
        $duplicate = $cgi->param('dup_id');
        ValidateBugID($duplicate, 'dup_id');
        $cgi->param('dup_id', $duplicate);
1153

1154 1155 1156 1157 1158 1159 1160 1161 1162 1163
        # Make sure the bug is not already marked as a dupe
        # (may appear in race condition)
        my $dupe_of =
            $dbh->selectrow_array("SELECT dupe_of FROM duplicates
                                   WHERE dupe = ?",
                                   undef, $cgi->param('id'));
        if ($dupe_of) {
            ThrowUserError("dupe_entry_found", { dupe_of => $dupe_of });
        }

1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189
        # Make sure a loop isn't created when marking this bug
        # as duplicate.
        my %dupes;
        $dupe_of = $duplicate;
        my $sth = $dbh->prepare('SELECT dupe_of FROM duplicates
                                 WHERE dupe = ?');

        while ($dupe_of) {
            if ($dupe_of == $cgi->param('id')) {
                ThrowUserError('dupe_loop_detected', { bug_id  => $cgi->param('id'),
                                                       dupe_of => $duplicate });
            }
            # If $dupes{$dupe_of} is already set to 1, then a loop
            # already exists which does not involve this bug.
            # As the user is not responsible for this loop, do not
            # prevent him from marking this bug as a duplicate.
            last if exists $dupes{"$dupe_of"};
            $dupes{"$dupe_of"} = 1;
            $sth->execute($dupe_of);
            $dupe_of = $sth->fetchrow_array;
        }

        # Also, let's see if the reporter has authorization to see
        # the bug to which we are duping. If not we need to prompt.
        DuplicateUserConfirm();

1190 1191 1192
        # DUPLICATE bugs should have no time remaining.
        _remove_remaining_time();

1193 1194
        ChangeStatus('RESOLVED');
        ChangeResolution('DUPLICATE');
1195 1196
        my $comment = $cgi->param('comment');
        $comment .= "\n\n*** This bug has been marked " .
1197
                    "as a duplicate of bug $duplicate ***";
1198
        $cgi->param('comment', $comment);
1199 1200
        last SWITCH;
    };
1201

1202
    ThrowCodeError("unknown_action", { action => $cgi->param('knob') });
terry%netscape.com's avatar
terry%netscape.com committed
1203 1204
}

1205 1206 1207
my @keywordlist;
my %keywordseen;

1208 1209
if (defined $cgi->param('keywords')) {
    foreach my $keyword (split(/[\s,]+/, $cgi->param('keywords'))) {
1210 1211 1212
        if ($keyword eq '') {
            next;
        }
1213
        my $i = GetKeywordIdFromName($keyword);
1214
        if (!$i) {
1215 1216
            ThrowUserError("unknown_keyword",
                           { keyword => $keyword });
1217 1218 1219 1220 1221 1222 1223 1224
        }
        if (!$keywordseen{$i}) {
            push(@keywordlist, $i);
            $keywordseen{$i} = 1;
        }
    }
}

1225
my $keywordaction = $cgi->param('keywordaction') || "makeexact";
1226 1227 1228
if (!grep($keywordaction eq $_, qw(add delete makeexact))) {
    $keywordaction = "makeexact";
}
1229

1230
if ($::comma eq ""
1231
    && (! @groupAdd) && (! @groupDel)
1232
    && (! @::legal_keywords || (0 == @keywordlist && $keywordaction ne "makeexact"))
1233
    && defined $cgi->param('masscc') && ! $cgi->param('masscc')
1234
    ) {
1235
    if (!defined $cgi->param('comment') || $cgi->param('comment') =~ /^\s*$/) {
1236
        ThrowUserError("bugs_not_changed");
terry%netscape.com's avatar
terry%netscape.com committed
1237 1238 1239
    }
}

1240 1241 1242
# Process data for Time Tracking fields
if (UserInGroup(Param('timetrackinggroup'))) {
    foreach my $field ("estimated_time", "remaining_time") {
1243 1244 1245
        if (defined $cgi->param($field)) {
            my $er_time = trim($cgi->param($field));
            if ($er_time ne $cgi->param('dontchange')) {
1246 1247 1248 1249 1250 1251
                DoComma();
                $::query .= "$field = " . SqlQuote($er_time);
            }
        }
    }

1252
    if (defined $cgi->param('deadline')) {
1253 1254
        DoComma();
        $::query .= "deadline = ";
1255
        if ($cgi->param('deadline')) {
1256 1257 1258
            validate_date($cgi->param('deadline'))
              || ThrowUserError('illegal_date', {date => $cgi->param('deadline'),
                                                 format => 'YYYY-MM-DD'});
1259
            $::query .= SqlQuote($cgi->param('deadline'));
1260 1261 1262 1263 1264 1265
        } else {
            $::query .= "NULL" ;
        }
    }
}

1266
my $basequery = $::query;
1267
my $delta_ts;
terry%netscape.com's avatar
terry%netscape.com committed
1268

1269

1270 1271
sub SnapShotBug {
    my ($id) = (@_);
1272 1273
    SendSQL("SELECT delta_ts, " . join(',', @::log_columns) .
            " FROM bugs WHERE bug_id = $id");
1274 1275
    my @row = FetchSQLData();
    $delta_ts = shift @row;
1276

1277
    return @row;
terry%netscape.com's avatar
terry%netscape.com committed
1278 1279 1280
}


1281 1282
sub SnapShotDeps {
    my ($i, $target, $me) = (@_);
1283
    SendSQL("SELECT $target FROM dependencies WHERE $me = $i ORDER BY $target");
1284 1285 1286 1287 1288 1289 1290 1291 1292
    my @list;
    while (MoreSQLData()) {
        push(@list, FetchOneColumn());
    }
    return join(',', @list);
}


my $timestamp;
1293
my $bug_changed;
1294 1295

sub LogDependencyActivity {
1296 1297
    my ($i, $oldstr, $target, $me, $timestamp) = (@_);
    my $sql_timestamp = SqlQuote($timestamp);
1298 1299
    my $newstr = SnapShotDeps($i, $target, $me);
    if ($oldstr ne $newstr) {
1300
        # Figure out what's really different...
1301
        my ($removed, $added) = diff_strings($oldstr, $newstr);
1302
        LogActivityEntry($i,$target,$removed,$added,$whoid,$timestamp);
1303
        # update timestamp on target bug so midairs will be triggered
1304
        SendSQL("UPDATE bugs SET delta_ts = $sql_timestamp WHERE bug_id = $i");
1305
        $bug_changed = 1;
1306 1307 1308 1309 1310
        return 1;
    }
    return 0;
}

1311 1312 1313
# This loop iterates once for each bug to be processed (i.e. all the
# bugs selected when this script is called with multiple bugs selected
# from buglist.cgi, or just the one bug when called from
1314 1315
# show_bug.cgi).
#
1316
foreach my $id (@idlist) {
1317
    my $bug_obj = new Bugzilla::Bug($id, $whoid);
1318
    my %dependencychanged;
1319
    $bug_changed = 0;
1320 1321
    my $write = "WRITE";        # Might want to make a param to control
                                # whether we do LOW_PRIORITY ...
1322 1323
    $dbh->bz_lock_tables("bugs $write", "bugs_activity $write",
            "cc $write", "cc AS selectVisible_cc $write",
1324
            "profiles READ", "dependencies $write", "votes $write",
1325 1326 1327
            "products READ", "components READ",
            "keywords $write", "longdescs $write", "fielddefs $write",
            "bug_group_map $write", "flags $write", "duplicates $write",
1328
            "user_group_map READ", "group_group_map READ", "flagtypes READ",
1329 1330 1331 1332
            "flaginclusions AS i READ", "flagexclusions AS e READ",
            "keyworddefs READ", "groups READ", "attachments READ",
            "group_control_map AS oldcontrolmap READ",
            "group_control_map AS newcontrolmap READ",
1333
            "group_control_map READ", "email_setting READ");
1334

1335
    # It may sound crazy to set %formhash for each bug as $cgi->param()
1336 1337
    # will not change, but %formhash is modified below and we prefer
    # to set it again.
1338
    my $i = 0;
1339 1340 1341
    my @oldvalues = SnapShotBug($id);
    my %oldhash;
    my %formhash;
1342
    foreach my $col (@::log_columns) {
1343
        # Consider NULL db entries to be equivalent to the empty string
1344 1345 1346 1347 1348 1349 1350
        $oldvalues[$i] = defined($oldvalues[$i]) ? $oldvalues[$i] : '';
        # Convert the deadline taken from the DB into the YYYY-MM-DD format
        # for consistency with the deadline provided by the user, if any.
        # Else CheckCanChangeField() would see them as different in all cases.
        if ($col eq 'deadline') {
            $oldvalues[$i] = format_time($oldvalues[$i], "%Y-%m-%d");
        }
1351
        $oldhash{$col} = $oldvalues[$i];
1352
        $formhash{$col} = $cgi->param($col) if defined $cgi->param($col);
1353 1354 1355 1356 1357 1358 1359 1360
        $i++;
    }
    # If the user is reassigning bugs, we need to:
    # - convert $newhash{'assigned_to'} and $newhash{'qa_contact'}
    #   email addresses into their corresponding IDs;
    # - update $newhash{'bug_status'} to its real state if the bug
    #   is in the unconfirmed state.
    $formhash{'qa_contact'} = $qacontact if Param('useqacontact');
1361 1362
    if ($cgi->param('knob') eq 'reassignbycomponent'
        || $cgi->param('knob') eq 'reassign') {
1363
        $formhash{'assigned_to'} = $assignee;
1364
        if ($oldhash{'bug_status'} eq 'UNCONFIRMED') {
1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375
            $formhash{'bug_status'} = $oldhash{'bug_status'};
        }
    }
    foreach my $col (@::log_columns) {
        if (exists $formhash{$col}
            && !CheckCanChangeField($col, $id, $oldhash{$col}, $formhash{$col}))
        {
            my $vars;
            if ($col eq 'component_id') {
                # Display the component name
                $vars->{'oldvalue'} = get_component_name($oldhash{$col});
1376
                $vars->{'newvalue'} = $cgi->param('component');
1377 1378 1379 1380 1381 1382 1383 1384 1385 1386
                $vars->{'field'} = 'component';
            } elsif ($col eq 'assigned_to' || $col eq 'qa_contact') {
                # Display the assignee or QA contact email address
                $vars->{'oldvalue'} = DBID_to_name($oldhash{$col});
                $vars->{'newvalue'} = DBID_to_name($formhash{$col});
                $vars->{'field'} = $col;
            } else {
                $vars->{'oldvalue'} = $oldhash{$col};
                $vars->{'newvalue'} = $formhash{$col};
                $vars->{'field'} = $col;
1387
            }
1388
            $vars->{'privs'} = $PrivilegesRequired;
1389
            ThrowUserError("illegal_change", $vars);
1390 1391
        }
    }
1392 1393 1394 1395 1396 1397 1398 1399 1400 1401
    if ($cgi->param('assigned_to') && Param("strict_isolation")) { 
        my $uid = DBNameToIdAndCheck($cgi->param('assigned_to'));
        Bugzilla::Bug::can_add_user_to_bug(
            $bug_obj->{'product_id'}, $id, $uid);
    }
    if ($cgi->param('qa_contact') && Param("strict_isolation")) { 
        Bugzilla::Bug::can_add_user_to_bug(
            $bug_obj->{'product_id'}, $id, $qacontact);
    }
    
1402 1403 1404 1405 1406 1407
    # When editing multiple bugs, users can specify a list of keywords to delete
    # from bugs.  If the list matches the current set of keywords on those bugs,
    # CheckCanChangeField above will fail to check permissions because it thinks
    # the list hasn't changed.  To fix that, we have to call CheckCanChangeField
    # again with old!=new if the keyword action is "delete" and old=new.
    if ($keywordaction eq "delete"
1408
        && defined $cgi->param('keywords')
1409
        && length(@keywordlist) > 0
1410
        && $cgi->param('keywords') eq $oldhash{keywords}
1411 1412 1413 1414 1415
        && !CheckCanChangeField("keywords", $id, "old is not", "equal to new"))
    {
        $vars->{'oldvalue'} = $oldhash{keywords};
        $vars->{'newvalue'} = "no keywords";
        $vars->{'field'} = "keywords";
1416
        $vars->{'privs'} = $PrivilegesRequired;
1417
        ThrowUserError("illegal_change", $vars);
1418 1419
    }

1420
    $oldhash{'product'} = get_product_name($oldhash{'product_id'});
1421
    if (!Bugzilla->user->can_edit_product($oldhash{'product_id'})) {
1422
        ThrowUserError("product_edit_denied",
1423
                      { product => $oldhash{'product'} });
1424 1425
    }

1426
    if ($requiremilestone) {
1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441
        # musthavemilestoneonaccept applies only if at least two
        # target milestones are defined for the current product.
        my $nb_milestones = scalar(@{$::target_milestone{$oldhash{'product'}}});
        if ($nb_milestones > 1) {
            my $value = $cgi->param('target_milestone');
            if (!defined $value || $value eq $cgi->param('dontchange')) {
                $value = $oldhash{'target_milestone'};
            }
            my $defaultmilestone =
                $dbh->selectrow_array("SELECT defaultmilestone
                                       FROM products WHERE id = ?",
                                       undef, $oldhash{'product_id'});
            # if musthavemilestoneonaccept == 1, then the target
            # milestone must be different from the default one.
            if ($value eq $defaultmilestone) {
1442
                ThrowUserError("milestone_required", { bug_id => $id });
1443
            }
1444 1445
        }
    }   
1446 1447
    if (defined $cgi->param('delta_ts') && $cgi->param('delta_ts') ne $delta_ts)
    {
1448 1449
        ($vars->{'operations'}) =
            Bugzilla::Bug::GetBugActivity($id, $cgi->param('delta_ts'));
1450

1451
        $vars->{'start_at'} = $cgi->param('longdesclength');
1452 1453 1454 1455

        # Always sort midair collision comments oldest to newest,
        # regardless of the user's personal preference.
        $vars->{'comments'} = Bugzilla::Bug::GetComments($id, "oldest_to_newest");
1456

1457
        $cgi->param('delta_ts', $delta_ts);
1458 1459 1460
        
        $vars->{'bug_id'} = $id;
        
1461
        $dbh->bz_unlock_tables(UNLOCK_ABORT);
1462 1463
        
        # Warn the user about the mid-air collision and ask them what to do.
1464
        $template->process("bug/process/midair.html.tmpl", $vars)
1465
          || ThrowTemplateError($template->error());
1466 1467 1468
        exit;
    }

1469
    # Gather the dependency list, and make sure there are no circular refs
1470 1471
    my %deps = Bugzilla::Bug::ValidateDependencies(scalar($cgi->param('dependson')),
                                                   scalar($cgi->param('blocked')),
1472
                                                   $id);
1473

1474 1475 1476 1477
    #
    # Start updating the relevant database entries
    #

1478 1479
    SendSQL("select now()");
    $timestamp = FetchOneColumn();
1480
    my $sql_timestamp = SqlQuote($timestamp);
1481

1482 1483
    my $work_time;
    if (UserInGroup(Param('timetrackinggroup'))) {
1484
        $work_time = $cgi->param('work_time');
1485 1486 1487 1488
        if ($work_time) {
            # AppendComment (called below) can in theory raise an error,
            # but because we've already validated work_time here it's
            # safe to log the entry before adding the comment.
1489
            LogActivityEntry($id, "work_time", "", $work_time,
1490
                             $whoid, $timestamp);
1491 1492 1493
        }
    }

1494
    if ($cgi->param('comment') || $work_time) {
1495 1496
        AppendComment($id, $whoid, scalar($cgi->param('comment')),
                      scalar($cgi->param('commentprivacy')), $timestamp, $work_time);
1497 1498 1499
        $bug_changed = 1;
    }

1500
    if (@::legal_keywords && defined $cgi->param('keywords')) {
1501 1502 1503 1504 1505
        # There are three kinds of "keywordsaction": makeexact, add, delete.
        # For makeexact, we delete everything, and then add our things.
        # For add, we delete things we're adding (to make sure we don't
        # end up having them twice), and then we add them.
        # For delete, we just delete things on the list.
1506
        my $changed = 0;
1507 1508
        if ($keywordaction eq "makeexact") {
            SendSQL("DELETE FROM keywords WHERE bug_id = $id");
1509
            $changed = 1;
1510 1511 1512 1513 1514
        }
        foreach my $keyword (@keywordlist) {
            if ($keywordaction ne "makeexact") {
                SendSQL("DELETE FROM keywords
                         WHERE bug_id = $id AND keywordid = $keyword");
1515
                $changed = 1;
1516 1517 1518 1519
            }
            if ($keywordaction ne "delete") {
                SendSQL("INSERT INTO keywords 
                         (bug_id, keywordid) VALUES ($id, $keyword)");
1520 1521 1522 1523 1524
                $changed = 1;
            }
        }
        if ($changed) {
            SendSQL("SELECT keyworddefs.name 
1525 1526
                     FROM keyworddefs INNER JOIN keywords
                       ON keyworddefs.id = keywords.keywordid
1527 1528 1529 1530 1531
                     WHERE keywords.bug_id = $id
                     ORDER BY keyworddefs.name");
            my @list;
            while (MoreSQLData()) {
                push(@list, FetchOneColumn());
1532
            }
1533 1534
            $dbh->do("UPDATE bugs SET keywords = ? WHERE bug_id = ?",
                     undef, join(', ', @list), $id);
1535 1536
        }
    }
1537
    my $query = "$basequery\nwhere bug_id = $id";
terry%netscape.com's avatar
terry%netscape.com committed
1538
    
1539 1540
    if ($::comma ne "") {
        SendSQL($query);
terry%netscape.com's avatar
terry%netscape.com committed
1541
    }
1542

1543 1544 1545 1546 1547 1548 1549
    # Check for duplicates if the bug is [re]open
    SendSQL("SELECT resolution FROM bugs WHERE bug_id = $id");
    my $resolution = FetchOneColumn();
    if ($resolution eq '') {
        SendSQL("DELETE FROM duplicates WHERE dupe = $id");
    }
    
1550
    my $newproduct_id = $oldhash{'product_id'};
1551
    if ($cgi->param('product') ne $cgi->param('dontchange')) {
1552
        my $newproduct_id = get_product_id($cgi->param('product'));
1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571
    }

    my %groupsrequired = ();
    my %groupsforbidden = ();
    SendSQL("SELECT id, membercontrol 
             FROM groups LEFT JOIN group_control_map
             ON id = group_id
             AND product_id = $newproduct_id WHERE isactive != 0");
    while (MoreSQLData()) {
        my ($group, $control) = FetchSQLData();
        $control ||= 0;
        unless ($control > &::CONTROLMAPNA)  {
            $groupsforbidden{$group} = 1;
        }
        if ($control == &::CONTROLMAPMANDATORY) {
            $groupsrequired{$group} = 1;
        }
    }

1572
    my @groupAddNames = ();
1573 1574 1575 1576
    my @groupAddNamesAll = ();
    foreach my $grouptoadd (@groupAdd, keys %groupsrequired) {
        next if $groupsforbidden{$grouptoadd};
        push(@groupAddNamesAll, GroupIdToName($grouptoadd));
1577 1578 1579 1580 1581 1582 1583
        if (!BugInGroupId($id, $grouptoadd)) {
            push(@groupAddNames, GroupIdToName($grouptoadd));
            SendSQL("INSERT INTO bug_group_map (bug_id, group_id) 
                     VALUES ($id, $grouptoadd)");
        }
    }
    my @groupDelNames = ();
1584 1585 1586 1587
    my @groupDelNamesAll = ();
    foreach my $grouptodel (@groupDel, keys %groupsforbidden) {
        push(@groupDelNamesAll, GroupIdToName($grouptodel));
        next if $groupsrequired{$grouptodel};
1588 1589 1590 1591 1592 1593 1594 1595 1596 1597
        if (BugInGroupId($id, $grouptodel)) {
            push(@groupDelNames, GroupIdToName($grouptodel));
        }
        SendSQL("DELETE FROM bug_group_map 
                 WHERE bug_id = $id AND group_id = $grouptodel");
    }

    my $groupDelNames = join(',', @groupDelNames);
    my $groupAddNames = join(',', @groupAddNames);

1598 1599 1600 1601 1602
    if ($groupDelNames ne $groupAddNames) {
        LogActivityEntry($id, "bug_group", $groupDelNames, $groupAddNames,
                         $whoid, $timestamp); 
        $bug_changed = 1;
    }
1603 1604

    my @ccRemoved = (); 
1605 1606 1607 1608
    if (defined $cgi->param('newcc')
        || defined $cgi->param('addselfcc')
        || defined $cgi->param('removecc')
        || defined $cgi->param('masscc')) {
1609 1610 1611 1612 1613 1614 1615
        # Get the current CC list for this bug
        my %oncc;
        SendSQL("SELECT who FROM cc WHERE bug_id = $id");
        while (MoreSQLData()) {
            $oncc{FetchOneColumn()} = 1;
        }

1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631
        my (@added, @removed, @blocked_cc) = ();
        
        if (Param("strict_isolation")) {
            foreach my $pid (keys %cc_add) {
                my $user = Bugzilla::User->new($pid);
                if (!$user->can_edit_product($bug_obj->{'product_id'})) {
                    push (@blocked_cc, $cc_add{$pid});
                }
            }
            if (scalar(@blocked_cc)) {
                my $blocked_cc = join(", ", @blocked_cc);
                ThrowUserError("invalid_user_group", 
                    {'user' => $blocked_cc , bug_id => $id });
            }
        }
 
1632 1633 1634 1635 1636 1637
        foreach my $pid (keys %cc_add) {
            # If this person isn't already on the cc list, add them
            if (! $oncc{$pid}) {
                SendSQL("INSERT INTO cc (bug_id, who) VALUES ($id, $pid)");
                push (@added, $cc_add{$pid});
                $oncc{$pid} = 1;
1638 1639
            }
        }
1640 1641 1642 1643 1644 1645
        foreach my $pid (keys %cc_remove) {
            # If the person is on the cc list, remove them
            if ($oncc{$pid}) {
                SendSQL("DELETE FROM cc WHERE bug_id = $id AND who = $pid");
                push (@removed, $cc_remove{$pid});
                $oncc{$pid} = 0;
1646 1647
            }
        }
1648

1649 1650
        # If any changes were found, record it in the activity log
        if (scalar(@removed) || scalar(@added)) {
1651 1652
            my $removed = join(", ", @removed);
            my $added = join(", ", @added);
1653 1654
            LogActivityEntry($id,"cc",$removed,$added,$whoid,$timestamp);
            $bug_changed = 1;
1655
        }
1656
        @ccRemoved = @removed;
1657
    }
1658

1659
    # We need to send mail for dependson/blocked bugs if the dependencies
1660 1661 1662
    # change or the status or resolution change. This var keeps track of that.
    my $check_dep_bugs = 0;

1663 1664 1665 1666 1667 1668 1669 1670
    foreach my $pair ("blocked/dependson", "dependson/blocked") {
        my ($me, $target) = split("/", $pair);

        my @oldlist = @{$dbh->selectcol_arrayref("SELECT $target FROM dependencies
                                                  WHERE $me = ? ORDER BY $target",
                                                  undef, $id)};
        @dependencychanged{@oldlist} = 1;

1671
        if (defined $cgi->param($target)) {
1672 1673
            my %snapshot;
            my @newlist = sort {$a <=> $b} @{$deps{$target}};
1674
            @dependencychanged{@newlist} = 1;
1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688

            while (0 < @oldlist || 0 < @newlist) {
                if (@oldlist == 0 || (@newlist > 0 &&
                                      $oldlist[0] > $newlist[0])) {
                    $snapshot{$newlist[0]} = SnapShotDeps($newlist[0], $me,
                                                          $target);
                    shift @newlist;
                } elsif (@newlist == 0 || (@oldlist > 0 &&
                                           $newlist[0] > $oldlist[0])) {
                    $snapshot{$oldlist[0]} = SnapShotDeps($oldlist[0], $me,
                                                          $target);
                    shift @oldlist;
                } else {
                    if ($oldlist[0] != $newlist[0]) {
1689
                        $dbh->bz_unlock_tables(UNLOCK_ABORT);
1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703
                        die "Error in list comparing code";
                    }
                    shift @oldlist;
                    shift @newlist;
                }
            }
            my @keys = keys(%snapshot);
            if (@keys) {
                my $oldsnap = SnapShotDeps($id, $target, $me);
                SendSQL("delete from dependencies where $me = $id");
                foreach my $i (@{$deps{$target}}) {
                    SendSQL("insert into dependencies ($me, $target) values ($id, $i)");
                }
                foreach my $k (@keys) {
1704
                    LogDependencyActivity($k, $snapshot{$k}, $me, $target, $timestamp);
1705
                }
1706
                LogDependencyActivity($id, $oldsnap, $target, $me, $timestamp);
1707
                $check_dep_bugs = 1;
1708 1709 1710 1711
            }
        }
    }

1712 1713 1714 1715 1716
    # When a bug changes products and the old or new product is associated
    # with a bug group, it may be necessary to remove the bug from the old
    # group or add it to the new one.  There are a very specific series of
    # conditions under which these activities take place, more information
    # about which can be found in comments within the conditionals below.
1717
    # Check if the user has changed the product to which the bug belongs;
1718
    if ($cgi->param('product') ne $cgi->param('dontchange')
1719
        && $cgi->param('product') ne $oldhash{'product'}
1720
    ) {
1721
        $newproduct_id = get_product_id($cgi->param('product'));
1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732
        # Depending on the "addtonewgroup" variable, groups with
        # defaults will change.
        #
        # For each group, determine
        # - The group id and if it is active
        # - The control map value for the old product and this group
        # - The control map value for the new product and this group
        # - Is the user in this group?
        # - Is the bug in this group?
        SendSQL("SELECT DISTINCT groups.id, isactive, " .
                "oldcontrolmap.membercontrol, newcontrolmap.membercontrol, " .
1733
                "CASE WHEN groups.id IN ($grouplist) THEN 1 ELSE 0 END, " .
1734 1735
                "CASE WHEN bug_group_map.group_id IS NOT NULL " .
                "THEN 1 ELSE 0 END " .
1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764
                "FROM groups " .
                "LEFT JOIN group_control_map AS oldcontrolmap " .
                "ON oldcontrolmap.group_id = groups.id " .
                "AND oldcontrolmap.product_id = " . $oldhash{'product_id'} .
                " LEFT JOIN group_control_map AS newcontrolmap " .
                "ON newcontrolmap.group_id = groups.id " .
                "AND newcontrolmap.product_id = $newproduct_id " .
                "LEFT JOIN bug_group_map " .
                "ON bug_group_map.group_id = groups.id " .
                "AND bug_group_map.bug_id = $id "
            );
        my @groupstoremove = ();
        my @groupstoadd = ();
        my @defaultstoremove = ();
        my @defaultstoadd = ();
        my @allgroups = ();
        my $buginanydefault = 0;
        my $buginanychangingdefault = 0;
        while (MoreSQLData()) {
            my ($groupid, $isactive, $oldcontrol, $newcontrol, 
            $useringroup, $bugingroup) = FetchSQLData();
            # An undefined newcontrol is none.
            $newcontrol = CONTROLMAPNA unless $newcontrol;
            $oldcontrol = CONTROLMAPNA unless $oldcontrol;
            push(@allgroups, $groupid);
            if (($bugingroup) && ($isactive)
                && ($oldcontrol == CONTROLMAPDEFAULT)) {
                # Bug was in a default group.
                $buginanydefault = 1;
1765 1766
                if (($newcontrol != CONTROLMAPDEFAULT)
                    && ($newcontrol != CONTROLMAPMANDATORY)) {
1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784
                    # Bug was in a default group that no longer is.
                    $buginanychangingdefault = 1;
                    push (@defaultstoremove, $groupid);
                }
            }
            if (($isactive) && (!$bugingroup)
                && ($newcontrol == CONTROLMAPDEFAULT)
                && ($useringroup)) {
                push (@defaultstoadd, $groupid);
            }
            if (($bugingroup) && ($isactive) && ($newcontrol == CONTROLMAPNA)) {
                # Group is no longer permitted.
                push(@groupstoremove, $groupid);
            }
            if ((!$bugingroup) && ($isactive) 
                && ($newcontrol == CONTROLMAPMANDATORY)) {
                # Group is now required.
                push(@groupstoadd, $groupid);
1785
            }
1786
        }
1787 1788 1789 1790 1791 1792 1793 1794 1795
        # If addtonewgroups = "yes", old default groups will be removed
        # and new default groups will be added.
        # If addtonewgroups = "yesifinold", old default groups will be removed
        # and new default groups will be added only if the bug was in ANY
        # of the old default groups.
        # If addtonewgroups = "no", old default groups will be removed and not
        # replaced.
        push(@groupstoremove, @defaultstoremove);
        if (AnyDefaultGroups()
1796 1797
            && (($cgi->param('addtonewgroup') eq 'yes')
            || (($cgi->param('addtonewgroup') eq 'yesifinold')
1798 1799
            && ($buginanydefault)))) {
            push(@groupstoadd, @defaultstoadd);
1800 1801
        }

1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823
        # Now actually update the bug_group_map.
        my @DefGroupsAdded = ();
        my @DefGroupsRemoved = ();
        foreach my $groupid (@allgroups) {
            my $thisadd = grep( ($_ == $groupid), @groupstoadd);
            my $thisdel = grep( ($_ == $groupid), @groupstoremove);
            if ($thisadd) {
                push(@DefGroupsAdded, GroupIdToName($groupid));
                SendSQL("INSERT INTO bug_group_map (bug_id, group_id) VALUES " .
                        "($id, $groupid)");
            } elsif ($thisdel) {
                push(@DefGroupsRemoved, GroupIdToName($groupid));
                SendSQL("DELETE FROM bug_group_map WHERE bug_id = $id " .
                        "AND group_id = $groupid");
            }
        }
        if ((@DefGroupsAdded) || (@DefGroupsRemoved)) {
            LogActivityEntry($id, "bug_group",
                join(', ', @DefGroupsRemoved),
                join(', ', @DefGroupsAdded),
                     $whoid, $timestamp); 
        }
1824 1825
    }
  
1826 1827 1828 1829
    # get a snapshot of the newly set values out of the database, 
    # and then generate any necessary bug activity entries by seeing 
    # what has changed since before we wrote out the new values.
    #
1830
    my @newvalues = SnapShotBug($id);
1831 1832 1833 1834
    my %newhash;
    $i = 0;
    foreach my $col (@::log_columns) {
        # Consider NULL db entries to be equivalent to the empty string
1835
        $newvalues[$i] = defined($newvalues[$i]) ? $newvalues[$i] : '';
1836 1837 1838 1839
        # Convert the deadline to the YYYY-MM-DD format.
        if ($col eq 'deadline') {
            $newvalues[$i] = format_time($newvalues[$i], "%Y-%m-%d");
        }
1840 1841 1842
        $newhash{$col} = $newvalues[$i];
        $i++;
    }
1843
    # for passing to Bugzilla::BugMail to ensure that when someone is removed
1844 1845 1846 1847
    # from one of these fields, they get notified of that fact (if desired)
    #
    my $origOwner = "";
    my $origQaContact = "";
1848
    
1849
    foreach my $c (@::log_columns) {
1850 1851
        my $col = $c;           # We modify it, don't want to modify array
                                # values in place.
1852 1853 1854
        my $old = shift @oldvalues;
        my $new = shift @newvalues;
        if ($old ne $new) {
1855

1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868
            # Products and components are now stored in the DB using ID's
            # We need to translate this to English before logging it
            if ($col eq 'product_id') {
                $old = get_product_name($old);
                $new = get_product_name($new);
                $col = 'product';
            }
            if ($col eq 'component_id') {
                $old = get_component_name($old);
                $new = get_component_name($new);
                $col = 'component';
            }

1869
            # save off the old value for passing to Bugzilla::BugMail so
1870
            # the old assignee can be notified
1871 1872 1873 1874 1875 1876 1877 1878 1879 1880
            #
            if ($col eq 'assigned_to') {
                $old = ($old) ? DBID_to_name($old) : "";
                $new = ($new) ? DBID_to_name($new) : "";
                $origOwner = $old;
            }

            # ditto for the old qa contact
            #
            if ($col eq 'qa_contact') {
1881 1882
                $old = ($old) ? DBID_to_name($old) : "";
                $new = ($new) ? DBID_to_name($new) : "";
1883
                $origQaContact = $old;
terry%netscape.com's avatar
terry%netscape.com committed
1884
            }
1885

1886 1887
            # If this is the keyword field, only record the changes, not everything.
            if ($col eq 'keywords') {
1888
                ($old, $new) = diff_strings($old, $new);
1889 1890
            }

1891
            if ($col eq 'product') {
1892
                RemoveVotes($id, 0,
1893 1894
                            "This bug has been moved to a different product");
            }
1895 1896 1897 1898 1899 1900
            
            if ($col eq 'bug_status' 
                && IsOpenedState($old) ne IsOpenedState($new))
            {
                $check_dep_bugs = 1;
            }
1901

1902 1903
            LogActivityEntry($id,$col,$old,$new,$whoid,$timestamp);
            $bug_changed = 1;
terry%netscape.com's avatar
terry%netscape.com committed
1904 1905
        }
    }
1906
    # Set and update flags.
1907
    Bugzilla::Flag::process($id, undef, $timestamp, $cgi);
1908

1909
    if ($bug_changed) {
1910
        SendSQL("UPDATE bugs SET delta_ts = $sql_timestamp WHERE bug_id = $id");
1911
    }
1912
    $dbh->bz_unlock_tables();
1913

1914 1915
    if ($duplicate) {
        # Check to see if Reporter of this bug is reporter of Dupe 
1916 1917
        SendSQL("SELECT reporter FROM bugs WHERE bug_id = " .
                $cgi->param('id'));
1918
        my $reporter = FetchOneColumn();
1919 1920
        SendSQL("SELECT reporter FROM bugs WHERE bug_id = " .
                "$duplicate and reporter = $reporter");
1921
        my $isreporter = FetchOneColumn();
1922 1923
        SendSQL("SELECT who FROM cc WHERE bug_id = " .
                " $duplicate and who = $reporter");
1924
        my $isoncc = FetchOneColumn();
1925 1926
        unless ($isreporter || $isoncc
                || !$cgi->param('confirm_add_duplicate')) {
matty%chariot.net.au's avatar
matty%chariot.net.au committed
1927
            # The reporter is oblivious to the existence of the new bug and is permitted access
1928
            # ... add 'em to the cc (and record activity)
1929 1930
            LogActivityEntry($duplicate,"cc","",DBID_to_name($reporter),
                             $whoid,$timestamp);
1931 1932
            SendSQL("INSERT INTO cc (who, bug_id) " .
                    "VALUES ($reporter, $duplicate)");
1933
        }
1934
        # Bug 171639 - Duplicate notifications do not need to be private. 
1935
        AppendComment($duplicate, $whoid,
1936 1937
                      "*** Bug " . $cgi->param('id') .
                      " has been marked as a duplicate of this bug. ***",
1938 1939
                      0, $timestamp);

1940
        check_form_field_defined($cgi,'comment');
1941 1942
        SendSQL("INSERT INTO duplicates VALUES ($duplicate, " .
                $cgi->param('id') . ")");
1943 1944 1945 1946 1947 1948 1949 1950 1951 1952 1953 1954
    }

    # Now all changes to the DB have been made. It's time to email
    # all concerned users, including the bug itself, but also the
    # duplicated bug and dependent bugs, if any.

    $vars->{'mailrecipients'} = { 'cc' => \@ccRemoved,
                                  'owner' => $origOwner,
                                  'qacontact' => $origQaContact,
                                  'changer' => Bugzilla->user->login };

    $vars->{'id'} = $id;
1955
    $vars->{'type'} = "bug";
1956 1957 1958 1959 1960 1961 1962 1963
    
    # Let the user know the bug was changed and who did and didn't
    # receive email about the change.
    $template->process("bug/process/results.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
    $vars->{'header_done'} = 1;
    
    if ($duplicate) {
1964
        $vars->{'mailrecipients'} = { 'changer' => Bugzilla->user->login }; 
1965

1966 1967 1968 1969
        $vars->{'id'} = $duplicate;
        $vars->{'type'} = "dupe";
        
        # Let the user know a duplication notation was added to the original bug.
1970
        $template->process("bug/process/results.html.tmpl", $vars)
1971
          || ThrowTemplateError($template->error());
1972
        $vars->{'header_done'} = 1;
1973 1974
    }

1975 1976
    if ($check_dep_bugs) {
        foreach my $k (keys(%dependencychanged)) {
1977
            $vars->{'mailrecipients'} = { 'changer' => Bugzilla->user->login }; 
1978 1979 1980
            $vars->{'id'} = $k;
            $vars->{'type'} = "dep";

1981 1982 1983
            # Let the user (if he is able to see the bug) know we checked to see 
            # if we should email notice of this change to users with a relationship
            # to the dependent bug and who did and didn't receive email about it.
1984 1985
            $template->process("bug/process/results.html.tmpl", $vars)
              || ThrowTemplateError($template->error());
1986
            $vars->{'header_done'} = 1;
1987
        }
1988
    }
terry%netscape.com's avatar
terry%netscape.com committed
1989 1990
}

1991 1992 1993 1994 1995 1996
# Determine if Patch Viewer is installed, for Diff link
# (NB: Duplicate code with show_bug.cgi.)
eval {
    require PatchReader;
    $vars->{'patchviewerinstalled'} = 1;
};
1997

1998 1999 2000 2001 2002 2003
if (defined $cgi->param('id')) {
    $action = Bugzilla->user->settings->{'post_bug_submit_action'}->{'value'};
} else {
    # param('id') is not defined when changing multiple bugs
    $action = 'nothing';
}
2004

2005 2006 2007 2008 2009 2010 2011 2012 2013 2014
if ($action eq 'next_bug') {
    my $next_bug;
    my $cur = lsearch(\@bug_list, $cgi->param("id"));
    if ($cur >= 0 && $cur < $#bug_list) {
        $next_bug = $bug_list[$cur + 1];
    }
    if ($next_bug) {
        if (detaint_natural($next_bug) && Bugzilla->user->can_see_bug($next_bug)) {
            my $bug = new Bugzilla::Bug($next_bug, $whoid);
            ThrowCodeError("bug_error", { bug => $bug }) if $bug->error;
2015

2016 2017
            $vars->{'bugs'} = [$bug];
            $vars->{'nextbug'} = $bug->bug_id;
2018

2019 2020 2021 2022 2023
            $template->process("bug/show.html.tmpl", $vars)
              || ThrowTemplateError($template->error());

            exit;
        }
2024
    }
2025
} elsif ($action eq 'same_bug') {
2026 2027 2028
    if (Bugzilla->user->can_see_bug($cgi->param('id'))) {
        my $bug = new Bugzilla::Bug($cgi->param('id'), $whoid);
        ThrowCodeError("bug_error", { bug => $bug }) if $bug->error;
2029

2030
        $vars->{'bugs'} = [$bug];
2031

2032 2033
        $template->process("bug/show.html.tmpl", $vars)
          || ThrowTemplateError($template->error());
2034

2035 2036
        exit;
    }
2037 2038
} elsif ($action ne 'nothing') {
    ThrowCodeError("invalid_post_bug_submit_action");
terry%netscape.com's avatar
terry%netscape.com committed
2039
}
2040

2041
# End the response page.
2042
$template->process("bug/navigate.html.tmpl", $vars)
2043
  || ThrowTemplateError($template->error());
2044
$template->process("global/footer.html.tmpl", $vars)
2045
  || ThrowTemplateError($template->error());