attachment.cgi 29 KB
Newer Older
1
#!/usr/bin/perl -wT
2 3 4
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
5
#
6 7
# This Source Code Form is "Incompatible With Secondary Licenses", as
# defined by the Mozilla Public License, v. 2.0.
8 9 10 11 12 13 14 15

################################################################################
# Script Initialization
################################################################################

# Make it harder for us to do dangerous things in Perl.
use strict;

16
use lib qw(. lib);
17

18
use Bugzilla;
19
use Bugzilla::BugMail;
20
use Bugzilla::Constants;
21
use Bugzilla::Error;
22 23
use Bugzilla::Flag; 
use Bugzilla::FlagType; 
24
use Bugzilla::User;
25
use Bugzilla::Util;
26
use Bugzilla::Bug;
27
use Bugzilla::Field;
28
use Bugzilla::Attachment;
29
use Bugzilla::Attachment::PatchReader;
30
use Bugzilla::Token;
31
use Bugzilla::Keyword;
32

33
use Encode qw(encode find_encoding);
34

35 36 37 38 39 40 41
# For most scripts we don't make $cgi and $template global variables. But
# when preparing Bugzilla for mod_perl, this script used these
# variables in so many subroutines that it was easier to just
# make them globals.
local our $cgi = Bugzilla->cgi;
local our $template = Bugzilla->template;
local our $vars = {};
42

43 44 45 46
################################################################################
# Main Body Execution
################################################################################

47 48 49 50
# All calls to this script should contain an "action" variable whose
# value determines what the user wants to do.  The code below checks
# the value of that variable and runs the appropriate code. If none is
# supplied, we default to 'view'.
51 52

# Determine whether to use the action specified by the user or the default.
53
my $action = $cgi->param('action') || 'view';
54
my $format = $cgi->param('format') || '';
55

56
# You must use the appropriate urlbase/sslbase param when doing anything
57 58 59 60
# but viewing an attachment, or a raw diff.
if ($action ne 'view'
    && (($action !~ /^(?:interdiff|diff)$/) || $format ne 'raw'))
{
61 62
    do_ssl_redirect_if_required();
    if ($cgi->url_is_attachment_base) {
63 64 65 66 67 68 69 70
        $cgi->redirect_to_urlbase;
    }
    Bugzilla->login();
}

# When viewing an attachment, do not request credentials if we are on
# the alternate host. Let view() decide when to call Bugzilla->login.
if ($action eq "view")
71
{
72
    view();
73
}
74 75
elsif ($action eq "interdiff")
{
76
    interdiff();
77 78 79
}
elsif ($action eq "diff")
{
80
    diff();
81
}
82 83
elsif ($action eq "viewall") 
{ 
84
    viewall(); 
85
}
86 87
elsif ($action eq "enter") 
{ 
88 89
    Bugzilla->login(LOGIN_REQUIRED);
    enter(); 
90 91 92
}
elsif ($action eq "insert")
{
93 94
    Bugzilla->login(LOGIN_REQUIRED);
    insert();
95
}
96 97
elsif ($action eq "edit") 
{ 
98
    edit(); 
99 100 101
}
elsif ($action eq "update") 
{ 
102 103
    Bugzilla->login(LOGIN_REQUIRED);
    update();
104
}
105 106 107
elsif ($action eq "delete") {
    delete_attachment();
}
108 109
else 
{ 
110
  ThrowUserError('unknown_action', {action => $action});
111 112 113 114 115 116 117 118
}

exit;

################################################################################
# Data Validation / Security Authorization
################################################################################

119 120 121
# Validates an attachment ID. Optionally takes a parameter of a form
# variable name that contains the ID to be validated. If not specified,
# uses 'id'.
122 123
# If the second parameter is true, the attachment ID will be validated,
# however the current user's access to the attachment will not be checked.
124 125 126 127
# Will throw an error if 1) attachment ID is not a valid number,
# 2) attachment does not exist, or 3) user isn't allowed to access the
# attachment.
#
128 129 130
# Returns an attachment object.

sub validateID {
131 132
    my($param, $dont_validate_access) = @_;
    $param ||= 'id';
133

134 135 136
    # If we're not doing interdiffs, check if id wasn't specified and
    # prompt them with a page that allows them to choose an attachment.
    # Happens when calling plain attachment.cgi from the urlbar directly
137
    if ($param eq 'id' && !$cgi->param('id')) {
138
        print $cgi->header();
139 140 141 142
        $template->process("attachment/choose.html.tmpl", $vars) ||
            ThrowTemplateError($template->error());
        exit;
    }
143
    
144 145 146 147 148 149
    my $attach_id = $cgi->param($param);

    # Validate the specified attachment id. detaint kills $attach_id if
    # non-natural, so use the original value from $cgi in our exception
    # message here.
    detaint_natural($attach_id)
150 151
        || ThrowUserError("invalid_attach_id",
                          { attach_id => scalar $cgi->param($param) });
152
  
153
    # Make sure the attachment exists in the database.
154
    my $attachment = new Bugzilla::Attachment($attach_id)
155
        || ThrowUserError("invalid_attach_id", { attach_id => $attach_id });
156

157 158 159 160 161 162 163 164
    return $attachment if ($dont_validate_access || check_can_access($attachment));
}

# Make sure the current user has access to the specified attachment.
sub check_can_access {
    my $attachment = shift;
    my $user = Bugzilla->user;

165
    # Make sure the user is authorized to access this attachment's bug.
166 167 168 169
    Bugzilla::Bug->check($attachment->bug_id);
    if ($attachment->isprivate && $user->id != $attachment->attacher->id 
        && !$user->is_insider) 
    {
170
        ThrowUserError('auth_failure', {action => 'access',
171 172
                                        object => 'attachment',
                                        attach_id => $attachment->id});
173
    }
174 175 176 177 178 179 180 181 182 183 184 185 186
    return 1;
}

# Determines if the attachment is public -- that is, if users who are
# not logged in have access to the attachment
sub attachmentIsPublic {
    my $attachment = shift;

    return 0 if Bugzilla->params->{'requirelogin'};
    return 0 if $attachment->isprivate;

    my $anon_user = new Bugzilla::User;
    return $anon_user->can_see_bug($attachment->bug_id);
187 188
}

189 190 191
# Validates format of a diff/interdiff. Takes a list as an parameter, which
# defines the valid format values. Will throw an error if the format is not
# in the list. Returns either the user selected or default format.
192
sub validateFormat {
193 194
  # receives a list of legal formats; first item is a default
  my $format = $cgi->param('format') || $_[0];
195
  if (not grep($_ eq $format, @_)) {
196
     ThrowUserError("invalid_format", { format  => $format, formats => \@_ });
197
  }
198

199
  return $format;
200 201
}

202 203
# Validates context of a diff/interdiff. Will throw an error if the context
# is not number, "file" or "patch". Returns the validated, detainted context.
204 205
sub validateContext
{
206 207
  my $context = $cgi->param('context') || "patch";
  if ($context ne "file" && $context ne "patch") {
208 209 210
      my $orig_context = $context;
      detaint_natural($context)
        || ThrowUserError("invalid_context", { context => $orig_context });
211
  }
212 213

  return $context;
214 215
}

216 217 218 219
# Gets the attachment object(s) generated by validateID, while ensuring
# attachbase and token authentication is used when required.
sub get_attachment {
    my @field_names = @_ ? @_ : qw(id);
220

221
    my %attachments;
222 223

    if (use_attachbase()) {
224 225 226 227 228 229 230 231 232 233
        # Load each attachment, and ensure they are all from the same bug
        my $bug_id = 0;
        foreach my $field_name (@field_names) {
            my $attachment = validateID($field_name, 1);
            if (!$bug_id) {
                $bug_id = $attachment->bug_id;
            } elsif ($attachment->bug_id != $bug_id) {
                ThrowUserError('attachment_bug_id_mismatch');
            }
            $attachments{$field_name} = $attachment;
234
        }
235 236 237 238 239
        my @args = map { $_ . '=' . $attachments{$_}->id } @field_names;
        my $cgi_params = $cgi->canonicalise_query(@field_names, 't',
            'Bugzilla_login', 'Bugzilla_password');
        push(@args, $cgi_params) if $cgi_params;
        my $path = 'attachment.cgi?' . join('&', @args);
240 241

        # Make sure the attachment is served from the correct server.
242 243 244
        if ($cgi->url_is_attachment_base($bug_id)) {
            # No need to validate the token for public attachments. We cannot request
            # credentials as we are on the alternate host.
245
            if (!all_attachments_are_public(\%attachments)) {
246
                my $token = $cgi->param('t');
247 248 249 250 251 252 253 254 255 256 257 258 259 260
                my ($userid, undef, $token_data) = Bugzilla::Token::GetTokenData($token);
                my %token_data = unpack_token_data($token_data);
                my $valid_token = 1;
                foreach my $field_name (@field_names) {
                    my $token_id = $token_data{$field_name};
                    if (!$token_id
                        || !detaint_natural($token_id)
                        || $attachments{$field_name}->id != $token_id)
                    {
                        $valid_token = 0;
                        last;
                    }
                }
                unless ($userid && $valid_token) {
261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278
                    # Not a valid token.
                    print $cgi->redirect('-location' => correct_urlbase() . $path);
                    exit;
                }
                # Change current user without creating cookies.
                Bugzilla->set_user(new Bugzilla::User($userid));
                # Tokens are single use only, delete it.
                delete_token($token);
            }
        }
        elsif ($cgi->url_is_attachment_base) {
            # If we come here, this means that each bug has its own host
            # for attachments, and that we are trying to view one attachment
            # using another bug's host. That's not desired.
            $cgi->redirect_to_urlbase;
        }
        else {
            # We couldn't call Bugzilla->login earlier as we first had to
279 280
            # make sure we were not going to request credentials on the
            # alternate host.
281
            Bugzilla->login();
282 283 284 285
            my $attachbase = Bugzilla->params->{'attachment_base'};
            # Replace %bugid% by the ID of the bug the attachment 
            # belongs to, if present.
            $attachbase =~ s/\%bugid\%/$bug_id/;
286
            if (all_attachments_are_public(\%attachments)) {
287 288 289 290 291
                # No need for a token; redirect to attachment base.
                print $cgi->redirect(-location => $attachbase . $path);
                exit;
            } else {
                # Make sure the user can view the attachment.
292 293 294
                foreach my $field_name (@field_names) {
                    check_can_access($attachments{$field_name});
                }
295
                # Create a token and redirect.
296
                my $token = url_quote(issue_session_token(pack_token_data(\%attachments)));
297 298 299 300 301
                print $cgi->redirect(-location => $attachbase . "$path&t=$token");
                exit;
            }
        }
    } else {
302
        do_ssl_redirect_if_required();
303 304
        # No alternate host is used. Request credentials if required.
        Bugzilla->login();
305 306 307
        foreach my $field_name (@field_names) {
            $attachments{$field_name} = validateID($field_name);
        }
308 309
    }

310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347
    return wantarray
        ? map { $attachments{$_} } @field_names
        : $attachments{$field_names[0]};
}

sub all_attachments_are_public {
    my $attachments = shift;
    foreach my $field_name (keys %$attachments) {
        if (!attachmentIsPublic($attachments->{$field_name})) {
            return 0;
        }
    }
    return 1;
}

sub pack_token_data {
    my $attachments = shift;
    return join(' ', map { $_ . '=' . $attachments->{$_}->id } keys %$attachments);
}

sub unpack_token_data {
    my @token_data = split(/ /, shift || '');
    my %data;
    foreach my $token (@token_data) {
        my ($field_name, $attach_id) = split('=', $token);
        $data{$field_name} = $attach_id;
    }
    return %data;
}

################################################################################
# Functions
################################################################################

# Display an attachment.
sub view {
    my $attachment = get_attachment();

348
    # At this point, Bugzilla->login has been called if it had to.
349 350 351
    my $contenttype = $attachment->contenttype;
    my $filename = $attachment->filename;

352 353
    # Bug 111522: allow overriding content-type manually in the posted form
    # params.
354 355
    if (defined $cgi->param('content_type')) {
        $contenttype = $attachment->_check_content_type($cgi->param('content_type'));
356
    }
357

358
    # Return the appropriate HTTP response headers.
359
    $attachment->datasize || ThrowUserError("attachment_removed");
360

361
    $filename =~ s/^.*[\/\\]//;
362 363 364 365
    # escape quotes and backslashes in the filename, per RFCs 2045/822
    $filename =~ s/\\/\\\\/g; # escape backslashes
    $filename =~ s/"/\\"/g; # escape quotes

366 367 368 369 370
    # Avoid line wrapping done by Encode, which we don't need for HTTP
    # headers. See discussion in bug 328628 for details.
    local $Encode::Encoding{'MIME-Q'}->{'bpl'} = 10000;
    $filename = encode('MIME-Q', $filename);

371 372
    my $disposition = Bugzilla->params->{'allow_attachment_display'} ? 'inline' : 'attachment';

373 374 375 376 377 378 379
    # Don't send a charset header with attachments--they might not be UTF-8.
    # However, we do allow people to explicitly specify a charset if they
    # want.
    if ($contenttype !~ /\bcharset=/i) {
        # In order to prevent Apache from adding a charset, we have to send a
        # charset that's a single space.
        $cgi->charset(' ');
380 381 382 383 384 385
        if (Bugzilla->feature('detect_charset') && $contenttype =~ /^text\//) {
            my $encoding = detect_encoding($attachment->data);
            if ($encoding) {
                $cgi->charset(find_encoding($encoding)->mime_name);
            }
        }
386
    }
387
    print $cgi->header(-type=>"$contenttype; name=\"$filename\"",
388
                       -content_disposition=> "$disposition; filename=\"$filename\"",
389
                       -content_length => $attachment->datasize);
390
    disable_utf8();
391
    print $attachment->data;
392 393
}

394 395 396
sub interdiff {
    # Retrieve and validate parameters
    my $format = validateFormat('html', 'raw');
397 398 399 400 401 402 403
    my($old_attachment, $new_attachment);
    if ($format eq 'raw') {
        ($old_attachment, $new_attachment) = get_attachment('oldid', 'newid');
    } else {
        $old_attachment = validateID('oldid');
        $new_attachment = validateID('newid');
    }
404 405 406 407
    my $context = validateContext();

    Bugzilla::Attachment::PatchReader::process_interdiff(
        $old_attachment, $new_attachment, $format, $context);
408 409
}

410 411 412
sub diff {
    # Retrieve and validate parameters
    my $format = validateFormat('html', 'raw');
413
    my $attachment = $format eq 'raw' ? get_attachment() : validateID();
414
    my $context = validateContext();
415

416 417 418 419
    # If it is not a patch, view normally.
    if (!$attachment->ispatch) {
        view();
        return;
420 421
    }

422
    Bugzilla::Attachment::PatchReader::process_diff($attachment, $format, $context);
423
}
424

425 426
# Display all attachments for a given bug in a series of IFRAMEs within one
# HTML page.
427
sub viewall {
428
    # Retrieve and validate parameters
429
    my $bug = Bugzilla::Bug->check(scalar $cgi->param('bugid'));
430

431
    my $attachments = Bugzilla::Attachment->get_attachments_by_bug($bug);
432 433
    # Ignore deleted attachments.
    @$attachments = grep { $_->datasize } @$attachments;
434

435 436 437 438 439
    if ($cgi->param('hide_obsolete')) {
        @$attachments = grep { !$_->isobsolete } @$attachments;
        $vars->{'hide_obsolete'} = 1;
    }

440 441 442
    # Define the variables and functions that will be passed to the UI template.
    $vars->{'bug'} = $bug;
    $vars->{'attachments'} = $attachments;
443

444
    print $cgi->header();
445

446 447 448
    # Generate and return the UI (HTML page) from the appropriate template.
    $template->process("attachment/show-multiple.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
449 450
}

451
# Display a form for entering a new attachment.
452
sub enter {
453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490
    # Retrieve and validate parameters
    my $bug = Bugzilla::Bug->check(scalar $cgi->param('bugid'));
    my $bugid = $bug->id;
    Bugzilla::Attachment->_check_bug($bug);
    my $dbh = Bugzilla->dbh;
    my $user = Bugzilla->user;

    # Retrieve the attachments the user can edit from the database and write
    # them into an array of hashes where each hash represents one attachment.
  
    my ($can_edit, $not_private) = ('', '');
    if (!$user->in_group('editbugs', $bug->product_id)) {
        $can_edit = "AND submitter_id = " . $user->id;
    }
    if (!$user->is_insider) {
        $not_private = "AND isprivate = 0";
    }
    my $attach_ids = $dbh->selectcol_arrayref(
        "SELECT attach_id
           FROM attachments
          WHERE bug_id = ?
                AND isobsolete = 0
                $can_edit $not_private
       ORDER BY attach_id",
         undef, $bugid);

    # Define the variables and functions that will be passed to the UI template.
    $vars->{'bug'} = $bug;
    $vars->{'attachments'} = Bugzilla::Attachment->new_from_list($attach_ids);

    my $flag_types = Bugzilla::FlagType::match({
        'target_type'  => 'attachment',
        'product_id'   => $bug->product_id,
        'component_id' => $bug->component_id
    });
    $vars->{'flag_types'} = $flag_types;
    $vars->{'any_flags_requesteeble'} =
        grep { $_->is_requestable && $_->is_requesteeble } @$flag_types;
491
    $vars->{'token'} = issue_session_token('create_attachment');
492 493 494 495 496 497

    print $cgi->header();

    # Generate and return the UI (HTML page) from the appropriate template.
    $template->process("attachment/create.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
498 499
}

500
# Insert a new attachment into the database.
501
sub insert {
502 503
    my $dbh = Bugzilla->dbh;
    my $user = Bugzilla->user;
504

505 506
    $dbh->bz_start_transaction;

507
    # Retrieve and validate parameters
508 509
    my $bug = Bugzilla::Bug->check(scalar $cgi->param('bugid'));
    my $bugid = $bug->id;
510
    my ($timestamp) = $dbh->selectrow_array("SELECT NOW()");
511

512 513
    # Detect if the user already used the same form to submit an attachment
    my $token = trim($cgi->param('token'));
514
    check_token_data($token, 'create_attachment', 'index.cgi');
515

516 517 518 519 520 521 522 523 524 525
    # Check attachments the user tries to mark as obsolete.
    my @obsolete_attachments;
    if ($cgi->param('obsolete')) {
        my @obsolete = $cgi->param('obsolete');
        @obsolete_attachments = Bugzilla::Attachment->validate_obsolete($bug, \@obsolete);
    }

    # Must be called before create() as it may alter $cgi->param('ispatch').
    my $content_type = Bugzilla::Attachment::get_content_type();

526 527
    # Get the filehandle of the attachment.
    my $data_fh = $cgi->upload('data');
528
    my $attach_text = $cgi->param('attach_text');
529

530 531 532
    my $attachment = Bugzilla::Attachment->create(
        {bug           => $bug,
         creation_ts   => $timestamp,
533
         data          => $attach_text || $data_fh,
534
         description   => scalar $cgi->param('description'),
535
         filename      => $attach_text ? "file_$bugid.txt" : $data_fh,
536 537 538 539 540
         ispatch       => scalar $cgi->param('ispatch'),
         isprivate     => scalar $cgi->param('isprivate'),
         mimetype      => $content_type,
         });

541 542 543
    # Delete the token used to create this attachment.
    delete_token($token);

544
    foreach my $obsolete_attachment (@obsolete_attachments) {
545 546
        $obsolete_attachment->set_is_obsolete(1);
        $obsolete_attachment->update($timestamp);
547
    }
548

549 550 551 552
    my ($flags, $new_flags) = Bugzilla::Flag->extract_flags_from_cgi(
                                  $bug, $attachment, $vars, SKIP_REQUESTEE_ON_ERROR);
    $attachment->set_flags($flags, $new_flags);

553
    # Insert a comment about the new attachment into the database.
554
    my $comment = $cgi->param('comment');
555
    $comment = '' unless defined $comment;
556 557 558
    $bug->add_comment($comment, { isprivate => $attachment->isprivate,
                                  type => CMT_ATTACHMENT_CREATED,
                                  extra_data => $attachment->id });
559

560
  # Assign the bug to the user, if they are allowed to take it
561
  my $owner = "";
562
  if ($cgi->param('takebug') && $user->in_group('editbugs', $bug->product_id)) {
563 564 565 566 567
      # When taking a bug, we have to follow the workflow.
      my $bug_status = $cgi->param('bug_status') || '';
      ($bug_status) = grep {$_->name eq $bug_status} @{$bug->status->can_change_to};

      if ($bug_status && $bug_status->is_open
568 569
          && ($bug_status->name ne 'UNCONFIRMED' 
              || $bug->product_obj->allows_unconfirmed))
570
      {
571
          $bug->set_bug_status($bug_status->name);
572 573
          $bug->clear_resolution();
      }
574
      # Make sure the person we are taking the bug from gets mail.
575
      $owner = $bug->assigned_to->login;
576
      $bug->set_assigned_to($user);
577
  }
578 579

  $bug->add_cc($user) if $cgi->param('addselfcc');
580 581
  $bug->update($timestamp);

582 583 584 585
  # We have to update the attachment after updating the bug, to ensure new
  # comments are available.
  $attachment->update($timestamp);

586
  $dbh->bz_commit_transaction;
587

588
  # Define the variables and functions that will be passed to the UI template.
589
  $vars->{'attachment'} = $attachment;
590 591 592 593
  # We cannot reuse the $bug object as delta_ts has eventually been updated
  # since the object was created.
  $vars->{'bugs'} = [new Bugzilla::Bug($bugid)];
  $vars->{'header_done'} = 1;
594
  $vars->{'contenttypemethod'} = $cgi->param('contenttypemethod');
595

596
  my $recipients =  { 'changer' => $user, 'owner' => $owner };
597 598
  $vars->{'sent_bugmail'} = Bugzilla::BugMail::Send($bugid, $recipients);

599
  print $cgi->header();
600
  # Generate and return the UI (HTML page) from the appropriate template.
601 602
  $template->process("attachment/created.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
603 604
}

605 606 607 608
# Displays a form for editing attachment properties.
# Any user is allowed to access this page, unless the attachment
# is private and the user does not belong to the insider group.
# Validations are done later when the user submits changes.
609
sub edit {
610
  my $attachment = validateID();
611

612
  my $bugattachments =
613
      Bugzilla::Attachment->get_attachments_by_bug($attachment->bug);
614

615 616 617 618 619 620
  my $any_flags_requesteeble =
    grep { $_->is_requestable && $_->is_requesteeble } @{$attachment->flag_types};
  # Useful in case a flagtype is no longer requestable but a requestee
  # has been set before we turned off that bit.
  $any_flags_requesteeble ||= grep { $_->requestee_id } @{$attachment->flags};
  $vars->{'any_flags_requesteeble'} = $any_flags_requesteeble;
621
  $vars->{'attachment'} = $attachment;
622
  $vars->{'attachments'} = $bugattachments;
623

624
  print $cgi->header();
625 626

  # Generate and return the UI (HTML page) from the appropriate template.
627 628
  $template->process("attachment/edit.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
629 630
}

631 632
# Updates an attachment record. Only users with "editbugs" privileges,
# (or the original attachment's submitter) can edit the attachment.
633
# Users cannot edit the content of the attachment itself.
634
sub update {
635 636
    my $user = Bugzilla->user;
    my $dbh = Bugzilla->dbh;
637

638 639 640
    # Start a transaction in preparation for updating the attachment.
    $dbh->bz_start_transaction();

641
    # Retrieve and validate parameters
642
    my $attachment = validateID();
643 644
    my $bug = $attachment->bug;
    $attachment->_check_bug;
645 646 647 648 649 650 651 652 653 654 655
    my $can_edit = $attachment->validate_can_edit($bug->product_id);

    if ($can_edit) {
        $attachment->set_description(scalar $cgi->param('description'));
        $attachment->set_is_patch(scalar $cgi->param('ispatch'));
        $attachment->set_content_type(scalar $cgi->param('contenttypeentry'));
        $attachment->set_is_obsolete(scalar $cgi->param('isobsolete'));
        $attachment->set_is_private(scalar $cgi->param('isprivate'));
        $attachment->set_filename(scalar $cgi->param('filename'));

        # Now make sure the attachment has not been edited since we loaded the page.
656 657
        my $delta_ts = $cgi->param('delta_ts');
        my $modification_time = $attachment->modification_time;
658

659 660 661 662
        if ($delta_ts && $delta_ts ne $modification_time) {
            datetime_from($delta_ts)
              or ThrowCodeError('invalid_timestamp', { timestamp => $delta_ts });
            ($vars->{'operations'}) = $bug->get_activity($attachment->id, $delta_ts);
663 664 665 666 667

            # If the modification date changed but there is no entry in
            # the activity table, this means someone commented only.
            # In this case, there is no reason to midair.
            if (scalar(@{$vars->{'operations'}})) {
668 669 670 671
                $cgi->param('delta_ts', $modification_time);
                # The token contains the old modification_time. We need a new one.
                $cgi->param('token', issue_hash_token([$attachment->id, $modification_time]));

672 673 674 675 676 677 678 679
                $vars->{'attachment'} = $attachment;

                print $cgi->header();
                # Warn the user about the mid-air collision and ask them what to do.
                $template->process("attachment/midair.html.tmpl", $vars)
                  || ThrowTemplateError($template->error());
                exit;
            }
680 681
        }
    }
682 683 684 685 686 687

    # We couldn't do this check earlier as we first had to validate attachment ID
    # and display the mid-air collision page if modification_time changed.
    my $token = $cgi->param('token');
    check_hash_token($token, [$attachment->id, $attachment->modification_time]);

688 689
    # If the user submitted a comment while editing the attachment,
    # add the comment to the bug. Do this after having validated isprivate!
690
    my $comment = $cgi->param('comment');
691
    if (defined $comment && trim($comment) ne '') {
692 693 694
        $bug->add_comment($comment, { isprivate => $attachment->isprivate,
                                      type => CMT_ATTACHMENT_UPDATED,
                                      extra_data => $attachment->id });
695 696
    }

697 698
    $bug->add_cc($user) if $cgi->param('addselfcc');

699 700 701 702 703
    if ($can_edit) {
        my ($flags, $new_flags) =
          Bugzilla::Flag->extract_flags_from_cgi($bug, $attachment, $vars);
        $attachment->set_flags($flags, $new_flags);
    }
704

705
    # Figure out when the changes were made.
706
    my $timestamp = $dbh->selectrow_array('SELECT LOCALTIMESTAMP(0)');
707

708 709 710 711 712
    # Commit the comment, if any.
    # This has to happen before updating the attachment, to ensure new comments
    # are available to $attachment->update.
    $bug->update($timestamp);

713 714 715 716 717 718 719
    if ($can_edit) {
        my $changes = $attachment->update($timestamp);
        # If there are changes, we updated delta_ts in the DB. We have to
        # reflect this change in the bug object.
        $bug->{delta_ts} = $timestamp if scalar(keys %$changes);
    }

720 721
    # Commit the transaction now that we are finished updating the database.
    $dbh->bz_commit_transaction();
722

723 724 725 726
    # Define the variables and functions that will be passed to the UI template.
    $vars->{'attachment'} = $attachment;
    $vars->{'bugs'} = [$bug];
    $vars->{'header_done'} = 1;
727
    $vars->{'sent_bugmail'} = 
728
        Bugzilla::BugMail::Send($bug->id, { 'changer' => $user });
729

730
    print $cgi->header();
731

732 733 734
    # Generate and return the UI (HTML page) from the appropriate template.
    $template->process("attachment/updated.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
735
}
736 737 738 739 740 741 742 743 744 745 746 747 748

# Only administrators can delete attachments.
sub delete_attachment {
    my $user = Bugzilla->login(LOGIN_REQUIRED);
    my $dbh = Bugzilla->dbh;

    print $cgi->header();

    $user->in_group('admin')
      || ThrowUserError('auth_failure', {group  => 'admin',
                                         action => 'delete',
                                         object => 'attachment'});

749
    Bugzilla->params->{'allow_attachment_deletion'}
750 751 752
      || ThrowUserError('attachment_deletion_disabled');

    # Make sure the administrator is allowed to edit this attachment.
753
    my $attachment = validateID();
754
    Bugzilla::Attachment->_check_bug($attachment->bug);
755 756 757 758 759 760 761 762 763

    $attachment->datasize || ThrowUserError('attachment_removed');

    # We don't want to let a malicious URL accidentally delete an attachment.
    my $token = trim($cgi->param('token'));
    if ($token) {
        my ($creator_id, $date, $event) = Bugzilla::Token::GetTokenData($token);
        unless ($creator_id
                  && ($creator_id == $user->id)
764
                  && ($event eq 'delete_attachment' . $attachment->id))
765 766
        {
            # The token is invalid.
767
            ThrowUserError('token_does_not_exist');
768 769
        }

770 771
        my $bug = new Bugzilla::Bug($attachment->bug_id);

772 773
        # The token is valid. Delete the content of the attachment.
        my $msg;
774
        $vars->{'attachment'} = $attachment;
775 776 777 778 779
        $vars->{'reason'} = clean_text($cgi->param('reason') || '');

        $template->process("attachment/delete_reason.txt.tmpl", $vars, \$msg)
          || ThrowTemplateError($template->error());

780 781 782
        # Paste the reason provided by the admin into a comment.
        $bug->add_comment($msg);

783
        $attachment->remove_from_db();
784 785

        # Now delete the token.
786
        delete_token($token);
787

788 789
        # Insert the comment.
        $bug->update();
790

791
        # Required to display the bug the deleted attachment belongs to.
792
        $vars->{'bugs'} = [$bug];
793 794
        $vars->{'header_done'} = 1;

795
        $vars->{'sent_bugmail'} =
796
            Bugzilla::BugMail::Send($bug->id, { 'changer' => $user });
797

798 799 800 801 802
        $template->process("attachment/updated.html.tmpl", $vars)
          || ThrowTemplateError($template->error());
    }
    else {
        # Create a token.
803
        $token = issue_session_token('delete_attachment' . $attachment->id);
804 805 806 807 808 809 810 811

        $vars->{'a'} = $attachment;
        $vars->{'token'} = $token;

        $template->process("attachment/confirm-delete.html.tmpl", $vars)
          || ThrowTemplateError($template->error());
    }
}