Flag.pm 35.2 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
# -*- Mode: perl; indent-tabs-mode: nil -*-
#
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
# The Original Code is the Bugzilla Bug Tracking System.
#
# The Initial Developer of the Original Code is Netscape Communications
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
# Contributor(s): Myk Melez <myk@mozilla.org>
21
#                 Jouni Heikniemi <jouni@heikniemi.net>
22
#                 Frédéric Buclin <LpSolit@gmail.com>
23

24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39
=head1 NAME

Bugzilla::Flag - A module to deal with Bugzilla flag values.

=head1 SYNOPSIS

Flag.pm provides an interface to flags as stored in Bugzilla.
See below for more information.

=head1 NOTES

=over

=item *

Prior to calling routines in this module, it's assumed that you have
40
already done a C<require globals.pl>.
41 42 43

=item *

44
Import relevant functions from that script.
45 46 47 48 49 50 51 52 53 54 55 56 57

=item *

Use of private functions / variables outside this module may lead to
unexpected results after an upgrade.  Please avoid usi8ng private
functions in other files/modules.  Private functions are functions
whose names start with _ or a re specifically noted as being private.

=back

=cut

######################################################################
58
# Module Initialization
59
######################################################################
60 61 62 63 64 65 66 67 68

# Make it harder for us to do dangerous things in Perl.
use strict;

# This module implements bug and attachment flags.
package Bugzilla::Flag;

use Bugzilla::FlagType;
use Bugzilla::User;
69
use Bugzilla::Config;
70
use Bugzilla::Util;
71
use Bugzilla::Error;
72
use Bugzilla::Attachment;
73
use Bugzilla::BugMail;
74
use Bugzilla::Constants;
75
use Bugzilla::Field;
76

77
######################################################################
78
# Global Variables
79
######################################################################
80 81 82

# basic sets of columns and tables for getting flags from the database

83 84 85 86 87 88 89 90 91 92 93 94 95
=begin private

=head1 PRIVATE VARIABLES/CONSTANTS

=over

=item C<@base_columns>

basic sets of columns and tables for getting flag types from th
database.  B<Used by get, match, sqlify_criteria and perlify_record>

=cut

96
my @base_columns = 
97
  ("id", "type_id", "bug_id", "attach_id", "requestee_id", 
98
   "setter_id", "status");
99

100 101 102 103 104 105 106
=pod

=item C<@base_tables>

Which database(s) is the data coming from?

Note: when adding tables to @base_tables, make sure to include the separator 
107 108 109
(i.e. words like "LEFT OUTER JOIN") before the table name, since tables take
multiple separators based on the join type, and therefore it is not possible
to join them later using a single known separator.
110 111 112 113 114 115 116
B<Used by get, match, sqlify_criteria and perlify_record>

=back

=end private

=cut
117 118 119

my @base_tables = ("flags");

120
######################################################################
121
# Searching/Retrieving Flags
122 123 124 125
######################################################################

=head1 PUBLIC FUNCTIONS

126 127 128
=over

=item C<get($id)>
129 130 131

Retrieves and returns a flag from the database.

132 133
=back

134
=cut
135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151

# !!! Implement a cache for this function!
sub get {
    my ($id) = @_;

    my $select_clause = "SELECT " . join(", ", @base_columns);
    my $from_clause = "FROM " . join(" ", @base_tables);
    
    # Execute the query, retrieve the result, and write it into a record.
    &::PushGlobalSQLState();
    &::SendSQL("$select_clause $from_clause WHERE flags.id = $id");
    my $flag = perlify_record(&::FetchSQLData());
    &::PopGlobalSQLState();

    return $flag;
}

152 153 154 155 156
=pod

=over

=item C<match($criteria)>
157

158 159 160 161 162 163 164 165 166
Queries the database for flags matching the given criteria
(specified as a hash of field names and their matching values)
and returns an array of matching records.

=back

=cut

sub match {
167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188
    my ($criteria) = @_;

    my $select_clause = "SELECT " . join(", ", @base_columns);
    my $from_clause = "FROM " . join(" ", @base_tables);
    
    my @criteria = sqlify_criteria($criteria);
    
    my $where_clause = "WHERE " . join(" AND ", @criteria);
    
    # Execute the query, retrieve the results, and write them into records.
    &::PushGlobalSQLState();
    &::SendSQL("$select_clause $from_clause $where_clause");
    my @flags;
    while (&::MoreSQLData()) {
        my $flag = perlify_record(&::FetchSQLData());
        push(@flags, $flag);
    }
    &::PopGlobalSQLState();

    return \@flags;
}

189 190 191 192 193 194 195 196 197 198 199
=pod

=over

=item C<count($criteria)>

Queries the database for flags matching the given criteria 
(specified as a hash of field names and their matching values)
and returns an array of matching records.

=back
200

201 202 203
=cut

sub count {
204 205 206 207 208 209 210 211 212 213 214 215 216 217 218
    my ($criteria) = @_;

    my @criteria = sqlify_criteria($criteria);
    
    my $where_clause = "WHERE " . join(" AND ", @criteria);
    
    # Execute the query, retrieve the result, and write it into a record.
    &::PushGlobalSQLState();
    &::SendSQL("SELECT COUNT(id) FROM flags $where_clause");
    my $count = &::FetchOneColumn();
    &::PopGlobalSQLState();

    return $count;
}

219
######################################################################
220
# Creating and Modifying
221
######################################################################
222

223 224 225 226
=pod

=over

227
=item C<validate($cgi, $bug_id, $attach_id)>
228

229 230
Validates fields containing flag modifications.

231 232 233
If the attachment is new, it has no ID yet and $attach_id is set
to -1 to force its check anyway.

234 235 236 237 238
=back

=cut

sub validate {
239 240
    my ($cgi, $bug_id, $attach_id) = @_;

241
    my $user = Bugzilla->user;
242 243
    my $dbh = Bugzilla->dbh;

244 245 246 247
    # Get a list of flags to validate.  Uses the "map" function
    # to extract flag IDs from form field names by matching fields
    # whose name looks like "flag-nnn", where "nnn" is the ID,
    # and returning just the ID portion of matching field names.
248
    my @ids = map(/^flag-(\d+)$/ ? $1 : (), $cgi->param());
249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279

    return unless scalar(@ids);
    
    # No flag reference should exist when changing several bugs at once.
    ThrowCodeError("flags_not_available", { type => 'b' }) unless $bug_id;

    # No reference to existing flags should exist when creating a new
    # attachment.
    if ($attach_id && ($attach_id < 0)) {
        ThrowCodeError("flags_not_available", { type => 'a' });
    }

    # Make sure all flags belong to the bug/attachment they pretend to be.
    my $field = ($attach_id) ? "attach_id" : "bug_id";
    my $field_id = $attach_id || $bug_id;
    my $not = ($attach_id) ? "" : "NOT";

    my $invalid_data =
        $dbh->selectrow_array("SELECT 1 FROM flags
                               WHERE id IN (" . join(',', @ids) . ")
                               AND ($field != ? OR attach_id IS $not NULL) " .
                               $dbh->sql_limit(1),
                               undef, $field_id);

    if ($invalid_data) {
        ThrowCodeError("invalid_flag_association",
                       { bug_id    => $bug_id,
                         attach_id => $attach_id });
    }

    foreach my $id (@ids) {
280
        my $status = $cgi->param("flag-$id");
281
        my @requestees = $cgi->param("requestee-$id");
282 283 284
        
        # Make sure the flag exists.
        my $flag = get($id);
285
        $flag || ThrowCodeError("flag_nonexistent", { id => $id });
286 287 288

        # Make sure the user chose a valid status.
        grep($status eq $_, qw(X + - ?))
289 290
          || ThrowCodeError("flag_status_invalid", 
                            { id => $id, status => $status });
291 292
                
        # Make sure the user didn't request the flag unless it's requestable.
293 294 295 296 297 298
        # If the flag was requested before it became unrequestable, leave it
        # as is.
        if ($status eq '?'
            && $flag->{status} ne '?'
            && !$flag->{type}->{is_requestable})
        {
299
            ThrowCodeError("flag_status_invalid", 
300
                           { id => $id, status => $status });
301
        }
302 303 304

        # Make sure the user didn't specify a requestee unless the flag
        # is specifically requestable. If the requestee was set before
305 306 307 308 309 310 311 312 313 314 315 316
        # the flag became specifically unrequestable, don't let the user
        # change the requestee, but let the user remove it by entering
        # an empty string for the requestee.
        if ($status eq '?' && !$flag->{type}->{is_requesteeble}) {
            my $old_requestee =
                $flag->{'requestee'} ? $flag->{'requestee'}->login : '';
            my $new_requestee = join('', @requestees);
            if ($new_requestee && $new_requestee ne $old_requestee) {
                ThrowCodeError("flag_requestee_disabled",
                               { type => $flag->{type} });
            }
        }
317

318 319
        # Make sure the user didn't enter multiple requestees for a flag
        # that can't be requested from more than one person at a time.
320
        if ($status eq '?'
321 322
            && !$flag->{type}->{is_multiplicable}
            && scalar(@requestees) > 1)
323
        {
324
            ThrowUserError("flag_not_multiplicable", { type => $flag->{type} });
325 326
        }

327
        # Make sure the requestees are authorized to access the bug.
328 329
        # (and attachment, if this installation is using the "insider group"
        # feature and the attachment is marked private).
330 331 332 333 334 335 336 337 338 339 340 341 342 343 344
        if ($status eq '?' && $flag->{type}->{is_requesteeble}) {
            my $old_requestee =
                $flag->{'requestee'} ? $flag->{'requestee'}->login : '';
            foreach my $login (@requestees) {
                next if $login eq $old_requestee;

                # We know the requestee exists because we ran
                # Bugzilla::User::match_field before getting here.
                my $requestee = Bugzilla::User->new_from_login($login);
                
                # Throw an error if the user can't see the bug.
                # Note that if permissions on this bug are changed,
                # can_see_bug() will refer to old settings.
                if (!$requestee->can_see_bug($bug_id)) {
                    ThrowUserError("flag_requestee_unauthorized",
345 346 347 348 349
                                   { flag_type  => $flag->{'type'},
                                     requestee  => $requestee,
                                     bug_id     => $bug_id,
                                     attachment => $flag->{target}->{attachment}
                                   });
350 351 352 353
                }
    
                # Throw an error if the target is a private attachment and
                # the requestee isn't in the group of insiders who can see it.
354
                if ($flag->{target}->{attachment}
355 356 357 358 359
                    && $cgi->param('isprivate')
                    && Param("insidergroup")
                    && !$requestee->in_group(Param("insidergroup")))
                {
                    ThrowUserError("flag_requestee_unauthorized_attachment",
360 361 362 363 364
                                   { flag_type  => $flag->{'type'},
                                     requestee  => $requestee,
                                     bug_id     => $bug_id,
                                     attachment => $flag->{target}->{attachment}
                                   });
365
                }
366 367
            }
        }
368 369 370 371 372

        # Make sure the user is authorized to modify flags, see bug 180879
        # - The flag is unchanged
        next if ($status eq $flag->{status});

373 374 375
        # - User in the $request_gid group can clear pending requests and set flags
        #   and can rerequest set flags.
        next if (($status eq 'X' || $status eq '?')
376
                 && (!$flag->{type}->{request_gid}
377
                     || $user->in_group_id($flag->{type}->{request_gid})));
378 379 380 381

        # - User in the $grant_gid group can set/clear flags,
        #   including "+" and "-"
        next if (!$flag->{type}->{grant_gid}
382
                 || $user->in_group_id($flag->{type}->{grant_gid}));
383 384 385 386 387 388

        # - Any other flag modification is denied
        ThrowUserError("flag_update_denied",
                        { name       => $flag->{type}->{name},
                          status     => $status,
                          old_status => $flag->{status} });
389 390 391
    }
}

392 393 394 395
sub snapshot {
    my ($bug_id, $attach_id) = @_;

    my $flags = match({ 'bug_id'    => $bug_id,
396
                        'attach_id' => $attach_id });
397 398 399 400 401 402 403 404 405
    my @summaries;
    foreach my $flag (@$flags) {
        my $summary = $flag->{'type'}->{'name'} . $flag->{'status'};
        $summary .= "(" . $flag->{'requestee'}->login . ")" if $flag->{'requestee'};
        push(@summaries, $summary);
    }
    return @summaries;
}

406

407 408 409 410
=pod

=over

411
=item C<process($target, $timestamp, $cgi)>
412 413 414 415 416

Processes changes to flags.

The target is the bug or attachment this flag is about, the timestamp
is the date/time the bug was last touched (so that changes to the flag
417 418
can be stamped with the same date/time), the cgi is the CGI object
used to obtain the flag fields that the user submitted.
419 420 421 422 423 424

=back

=cut

sub process {
425
    my ($bug_id, $attach_id, $timestamp, $cgi) = @_;
426 427

    my $dbh = Bugzilla->dbh;
428 429 430
    my $target = get_target($bug_id, $attach_id);
    # Make sure the target exists.
    return unless $target->{'exists'};
431 432 433

    # Use the date/time we were given if possible (allowing calling code
    # to synchronize the comment's timestamp with those of other records).
434 435
    # XXX - we shouldn't quote the timestamp here, but this would involve
    # many changes in this file.
436 437 438
    $timestamp = ($timestamp ? &::SqlQuote($timestamp) : "NOW()");
    
    # Take a snapshot of flags before any changes.
439
    my @old_summaries = snapshot($bug_id, $attach_id);
440
    
441
    # Cancel pending requests if we are obsoleting an attachment.
442
    if ($attach_id && $cgi->param('isobsolete')) {
443 444 445
        CancelRequests($bug_id, $attach_id);
    }

446
    # Create new flags and update existing flags.
447
    my $new_flags = FormToNewFlags($target, $cgi);
448
    foreach my $flag (@$new_flags) { create($flag, $timestamp) }
449
    modify($cgi, $timestamp);
450 451 452
    
    # In case the bug's product/component has changed, clear flags that are
    # no longer valid.
453 454
    my $flag_ids = $dbh->selectcol_arrayref(
        "SELECT flags.id 
455 456 457 458 459
           FROM flags
     INNER JOIN bugs
             ON flags.bug_id = bugs.bug_id
      LEFT JOIN flaginclusions AS i
             ON flags.type_id = i.type_id 
460
            AND (bugs.product_id = i.product_id OR i.product_id IS NULL)
461 462 463
            AND (bugs.component_id = i.component_id OR i.component_id IS NULL)
          WHERE bugs.bug_id = ?
            AND i.type_id IS NULL",
464 465
        undef, $bug_id);

466
    foreach my $flag_id (@$flag_ids) { clear($flag_id) }
467 468 469

    $flag_ids = $dbh->selectcol_arrayref(
        "SELECT flags.id 
470
        FROM flags, bugs, flagexclusions e
471
        WHERE bugs.bug_id = ?
472
        AND flags.bug_id = bugs.bug_id
473
        AND flags.type_id = e.type_id
474
        AND (bugs.product_id = e.product_id OR e.product_id IS NULL)
475 476 477
        AND (bugs.component_id = e.component_id OR e.component_id IS NULL)",
        undef, $bug_id);

478
    foreach my $flag_id (@$flag_ids) { clear($flag_id) }
479

480 481 482 483 484 485 486 487 488
    # Take a snapshot of flags after changes.
    my @new_summaries = snapshot($bug_id, $attach_id);

    update_activity($bug_id, $attach_id, $timestamp, \@old_summaries, \@new_summaries);
}

sub update_activity {
    my ($bug_id, $attach_id, $timestamp, $old_summaries, $new_summaries) = @_;
    my $dbh = Bugzilla->dbh;
489
    my $user_id = Bugzilla->user->id;
490 491 492 493

    $attach_id ||= 'NULL';
    $old_summaries = join(", ", @$old_summaries);
    $new_summaries = join(", ", @$new_summaries);
494
    my ($removed, $added) = diff_strings($old_summaries, $new_summaries);
495 496 497
    if ($removed ne $added) {
        my $sql_removed = &::SqlQuote($removed);
        my $sql_added = &::SqlQuote($added);
498
        my $field_id = get_field_id('flagtypes.name');
499 500
        $dbh->do("INSERT INTO bugs_activity
                  (bug_id, attach_id, who, bug_when, fieldid, removed, added)
501
                  VALUES ($bug_id, $attach_id, $user_id, $timestamp,
502
                  $field_id, $sql_removed, $sql_added)");
503 504 505

        $dbh->do("UPDATE bugs SET delta_ts = $timestamp WHERE bug_id = ?",
                 undef, $bug_id);
506 507 508
    }
}

509 510 511 512 513 514 515
=pod

=over

=item C<create($flag, $timestamp)>

Creates a flag record in the database.
516

517 518 519 520 521
=back

=cut

sub create {
522 523
    my ($flag, $timestamp) = @_;

524 525 526
    my $attach_id =
      $flag->{target}->{attachment} ? $flag->{target}->{attachment}->{id}
                                    : "NULL";
527
    my $requestee_id = $flag->{'requestee'} ? $flag->{'requestee'}->id : "NULL";
528 529 530 531 532

    &::SendSQL("INSERT INTO flags (type_id, bug_id, attach_id, 
                                   requestee_id, setter_id, status, 
                                   creation_date, modification_date)
                VALUES ($flag->{'type'}->{'id'}, 
533 534 535
                        $flag->{'target'}->{'bug'}->{'id'}, 
                        $attach_id,
                        $requestee_id,
536
                        " . $flag->{'setter'}->id . ",
537 538 539 540 541
                        '$flag->{'status'}', 
                        $timestamp,
                        $timestamp)");
    
    # Send an email notifying the relevant parties about the flag creation.
542 543
    if ($flag->{'requestee'} 
          && $flag->{'requestee'}->wants_mail([EVT_FLAG_REQUESTED]))
544
    {
545
        $flag->{'addressee'} = $flag->{'requestee'};
546
    }
547 548

    notify($flag, "request/email.txt.tmpl");
549 550
}

551
=pod
552

553 554 555 556 557 558 559 560 561 562 563 564
=over

=item C<migrate($old_attach_id, $new_attach_id, $timestamp)>

Moves a flag from one attachment to another.  Useful for migrating
a flag from an obsolete attachment to the attachment that obsoleted it.

=back

=cut

sub migrate {
565 566 567 568 569
    my ($old_attach_id, $new_attach_id, $timestamp) = @_;

    # Use the date/time we were given if possible (allowing calling code
    # to synchronize the comment's timestamp with those of other records).
    $timestamp = ($timestamp ? &::SqlQuote($timestamp) : "NOW()");
570 571 572 573

    # Update the record in the flags table to point to the new attachment.
    &::SendSQL("UPDATE flags " . 
               "SET    attach_id = $new_attach_id , " . 
574
               "       modification_date = $timestamp " . 
575 576 577
               "WHERE  attach_id = $old_attach_id");
}

578 579 580 581
=pod

=over

582
=item C<modify($cgi, $timestamp)>
583

584 585 586 587 588 589 590
Modifies flags in the database when a user changes them.

=back

=cut

sub modify {
591
    my ($cgi, $timestamp) = @_;
592
    my $setter = Bugzilla->user;
593 594

    # Extract a list of flags from the form data.
595
    my @ids = map(/^flag-(\d+)$/ ? $1 : (), $cgi->param());
596
    
597 598 599 600
    # Loop over flags and update their record in the database if necessary.
    # Two kinds of changes can happen to a flag: it can be set to a different
    # state, and someone else can be asked to set it.  We take care of both
    # those changes.
601 602 603
    my @flags;
    foreach my $id (@ids) {
        my $flag = get($id);
604

605
        my $status = $cgi->param("flag-$id");
606

607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623
        # If the user entered more than one name into the requestee field
        # (i.e. they want more than one person to set the flag) we can reuse
        # the existing flag for the first person (who may well be the existing
        # requestee), but we have to create new flags for each additional.
        my @requestees = $cgi->param("requestee-$id");
        my $requestee_email;
        if ($status eq "?"
            && scalar(@requestees) > 1
            && $flag->{type}->{is_multiplicable})
        {
            # The first person, for which we'll reuse the existing flag.
            $requestee_email = shift(@requestees);
  
            # Create new flags like the existing one for each additional person.
            foreach my $login (@requestees) {
                create({ type      => $flag->{type} ,
                         target    => $flag->{target} , 
624
                         setter    => $setter, 
625 626 627 628 629 630 631 632 633
                         status    => "?",
                         requestee => new Bugzilla::User(login_to_id($login)) },
                       $timestamp);
            }
        }
        else {
            $requestee_email = trim($cgi->param("requestee-$id") || '');
        }

634 635 636 637 638
        # Ignore flags the user didn't change. There are two components here:
        # either the status changes (trivial) or the requestee changes.
        # Change of either field will cause full update of the flag.

        my $status_changed = ($status ne $flag->{'status'});
639
        
640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655
        # Requestee is considered changed, if all of the following apply:
        # 1. Flag status is '?' (requested)
        # 2. Flag can have a requestee
        # 3. The requestee specified on the form is different from the 
        #    requestee specified in the db.
        
        my $old_requestee = 
          $flag->{'requestee'} ? $flag->{'requestee'}->login : '';

        my $requestee_changed = 
          ($status eq "?" && 
           $flag->{'type'}->{'is_requesteeble'} &&
           $old_requestee ne $requestee_email);
           
        next unless ($status_changed || $requestee_changed);

656
        
657 658 659
        # Since the status is validated, we know it's safe, but it's still
        # tainted, so we have to detaint it before using it in a query.
        &::trick_taint($status);
660
        
661 662
        if ($status eq '+' || $status eq '-') {
            &::SendSQL("UPDATE flags 
663
                        SET    setter_id = " . $setter->id . ", 
664
                               requestee_id = NULL , 
665
                               status = '$status' , 
666
                               modification_date = $timestamp
667
                        WHERE  id = $flag->{'id'}");
668 669 670 671 672 673

            # If the status of the flag was "?", we have to notify
            # the requester (if he wants to).
            my $requester;
            if ($flag->{'status'} eq '?') {
                $requester = $flag->{'setter'};
674
            }
675 676 677 678 679 680 681 682 683 684 685 686
            # Now update the flag object with its new values.
            $flag->{'setter'} = $setter;
            $flag->{'requestee'} = undef;
            $flag->{'status'} = $status;

            # Send an email notifying the relevant parties about the fulfillment,
            # including the requester.
            if ($requester && $requester->wants_mail([EVT_REQUESTED_FLAG])) {
                $flag->{'addressee'} = $requester;
            }

            notify($flag, "request/email.txt.tmpl");
687 688
        }
        elsif ($status eq '?') {
689 690 691
            # Get the requestee, if any.
            my $requestee_id = "NULL";
            if ($requestee_email) {
692
                $requestee_id = login_to_id($requestee_email);
693 694
                $flag->{'requestee'} = new Bugzilla::User($requestee_id);
            }
695 696 697 698 699
            else {
                # If the status didn't change but we only removed the
                # requestee, we have to clear the requestee field.
                $flag->{'requestee'} = undef;
            }
700 701

            # Update the database with the changes.
702
            &::SendSQL("UPDATE flags 
703
                        SET    setter_id = " . $setter->id . ", 
704 705
                               requestee_id = $requestee_id , 
                               status = '$status' , 
706
                               modification_date = $timestamp
707
                        WHERE  id = $flag->{'id'}");
708 709 710 711 712

            # Now update the flag object with its new values.
            $flag->{'setter'} = $setter;
            $flag->{'status'} = $status;

713
            # Send an email notifying the relevant parties about the request.
714 715
            if ($flag->{'requestee'}
                  && $flag->{'requestee'}->wants_mail([EVT_FLAG_REQUESTED]))
716
            {
717
                $flag->{'addressee'} = $flag->{'requestee'};
718
            }
719 720

            notify($flag, "request/email.txt.tmpl");
721 722 723 724 725 726 727 728 729 730 731
        }
        elsif ($status eq 'X') {
            clear($flag->{'id'});
        }
        
        push(@flags, $flag);
    }
    
    return \@flags;
}

732 733 734 735 736 737
=pod

=over

=item C<clear($id)>

738
Remove a flag from the DB.
739 740 741 742 743

=back

=cut

744 745
sub clear {
    my ($id) = @_;
746 747
    my $dbh = Bugzilla->dbh;

748
    my $flag = get($id);
749
    $dbh->do('DELETE FROM flags WHERE id = ?', undef, $id);
750

751 752 753 754 755 756 757 758 759 760
    # If we cancel a pending request, we have to notify the requester
    # (if he wants to).
    my $requester;
    if ($flag->{'status'} eq '?') {
        $requester = $flag->{'setter'};
    }

    # Now update the flag object to its new values. The last
    # requester/setter and requestee are kept untouched (for the
    # record). Else we could as well delete the flag completely.
761
    $flag->{'exists'} = 0;    
762
    $flag->{'status'} = "X";
763 764 765 766 767 768

    if ($requester && $requester->wants_mail([EVT_REQUESTED_FLAG])) {
        $flag->{'addressee'} = $requester;
    }

    notify($flag, "request/email.txt.tmpl");
769 770 771
}


772
######################################################################
773
# Utility Functions
774 775 776 777 778 779
######################################################################

=pod

=over

780
=item C<FormToNewFlags($target, $cgi)>
781

782 783
Checks whether or not there are new flags to create and returns an
array of flag objects. This array is then passed to Flag::create().
784 785 786 787

=back

=cut
788 789

sub FormToNewFlags {
790
    my ($target, $cgi) = @_;
791
    my $dbh = Bugzilla->dbh;
792
    my $setter = Bugzilla->user;
793
    
794
    # Extract a list of flag type IDs from field names.
795 796
    my @type_ids = map(/^flag_type-(\d+)$/ ? $1 : (), $cgi->param());
    @type_ids = grep($cgi->param("flag_type-$_") ne 'X', @type_ids);
797

798
    return () unless scalar(@type_ids);
799 800 801 802 803 804 805 806

    # Get a list of active flag types available for this target.
    my $flag_types = Bugzilla::FlagType::match(
        { 'target_type'  => $target->{'type'},
          'product_id'   => $target->{'product_id'},
          'component_id' => $target->{'component_id'},
          'is_active'    => 1 });

807
    my @flags;
808 809 810 811 812 813
    foreach my $flag_type (@$flag_types) {
        my $type_id = $flag_type->{'id'};

        # We are only interested in flags the user tries to create.
        next unless scalar(grep { $_ == $type_id } @type_ids);

814
        # Get the number of flags of this type already set for this target.
815 816 817 818
        my $has_flags = count(
            { 'type_id'     => $type_id,
              'target_type' => $target->{'type'},
              'bug_id'      => $target->{'bug'}->{'id'},
819
              'attach_id'   => $target->{'attachment'} ?
820
                                 $target->{'attachment'}->{'id'} : undef });
821 822

        # Do not create a new flag of this type if this flag type is
823
        # not multiplicable and already has a flag set.
824 825
        next if (!$flag_type->{'is_multiplicable'} && $has_flags);

826
        my $status = $cgi->param("flag_type-$type_id");
827
        trick_taint($status);
828

829 830 831
        my @logins = $cgi->param("requestee_type-$type_id");
        if ($status eq "?" && scalar(@logins) > 0) {
            foreach my $login (@logins) {
832 833 834 835 836 837 838
                my $requestee = new Bugzilla::User(login_to_id($login));
                push (@flags, { type      => $flag_type ,
                                target    => $target , 
                                setter    => $setter , 
                                status    => $status ,
                                requestee => $requestee });
                last if !$flag_type->{'is_multiplicable'};
839
            }
840
        }
841 842 843 844 845 846
        else {
            push (@flags, { type   => $flag_type ,
                            target => $target , 
                            setter => $setter , 
                            status => $status });
        }
847 848 849 850 851 852
    }

    # Return the list of flags.
    return \@flags;
}

853 854 855 856 857 858 859 860 861 862 863 864
=pod

=over

=item C<GetBug($id)>

Returns a hash of information about a target bug.

=back

=cut

865 866 867 868 869 870
# Ideally, we'd use Bug.pm, but it's way too heavyweight, and it can't be
# made lighter without totally rewriting it, so we'll use this function
# until that one gets rewritten.
sub GetBug {
    my ($id) = @_;

871 872
    my $dbh = Bugzilla->dbh;

873 874 875
    # Save the currently running query (if any) so we do not overwrite it.
    &::PushGlobalSQLState();

876 877 878 879
    &::SendSQL("SELECT    1, short_desc, product_id, component_id,
                          COUNT(bug_group_map.group_id)
                FROM      bugs LEFT JOIN bug_group_map
                            ON (bugs.bug_id = bug_group_map.bug_id)
880 881 882
                WHERE     bugs.bug_id = $id " .
                $dbh->sql_group_by('bugs.bug_id',
                                   'short_desc, product_id, component_id'));
883 884 885 886

    my $bug = { 'id' => $id };
    
    ($bug->{'exists'}, $bug->{'summary'}, $bug->{'product_id'}, 
887
     $bug->{'component_id'}, $bug->{'restricted'}) = &::FetchSQLData();
888 889 890 891 892 893 894

    # Restore the previously running query (if any).
    &::PopGlobalSQLState();

    return $bug;
}

895 896 897 898
=pod

=over

899
=item C<get_target($bug_id, $attach_id)>
900 901 902 903 904 905 906

Someone please document this function.

=back

=cut

907
sub get_target {
908 909 910 911 912 913
    my ($bug_id, $attach_id) = @_;
    
    # Create an object representing the target bug/attachment.
    my $target = { 'exists' => 0 };

    if ($attach_id) {
914
        $target->{'attachment'} = Bugzilla::Attachment->get($attach_id);
915 916 917
        if ($bug_id) {
            # Make sure the bug and attachment IDs correspond to each other
            # (i.e. this is the bug to which this attachment is attached).
918 919 920 921 922
            if (!$target->{'attachment'}
                || $target->{'attachment'}->{'bug_id'} != $bug_id)
            {
              return { 'exists' => 0 };
            }
923
        }
924 925
        $target->{'bug'} = GetBug($bug_id);
        $target->{'exists'} = 1;
926 927 928 929 930 931 932 933 934 935 936
        $target->{'type'} = "attachment";
    }
    elsif ($bug_id) {
        $target->{'bug'} = GetBug($bug_id);
        $target->{'exists'} = $target->{'bug'}->{'exists'};
        $target->{'type'} = "bug";
    }

    return $target;
}

937 938 939 940 941 942
=pod

=over

=item C<notify($flag, $template_file)>

943 944
Sends an email notification about a flag being created, fulfilled
or deleted.
945 946 947 948 949

=back

=cut

950 951
sub notify {
    my ($flag, $template_file) = @_;
952

953
    my $template = Bugzilla->template;
954 955 956 957

    # There is nobody to notify.
    return unless ($flag->{'addressee'} || $flag->{'type'}->{'cc_list'});

958 959 960
    my $attachment_is_private = $flag->{'target'}->{'attachment'} ?
      $flag->{'target'}->{'attachment'}->{'isprivate'} : undef;

961 962 963 964
    # If the target bug is restricted to one or more groups, then we need
    # to make sure we don't send email about it to unauthorized users
    # on the request type's CC: list, so we have to trawl the list for users
    # not in those groups or email addresses that don't have an account.
965
    if ($flag->{'target'}->{'bug'}->{'restricted'} || $attachment_is_private) {
966 967
        my @new_cc_list;
        foreach my $cc (split(/[, ]+/, $flag->{'type'}->{'cc_list'})) {
968
            my $ccuser = Bugzilla::User->new_from_login($cc) || next;
969

970
            next if $flag->{'target'}->{'bug'}->{'restricted'}
971
              && !$ccuser->can_see_bug($flag->{'target'}->{'bug'}->{'id'});
972
            next if $attachment_is_private
973
              && Param("insidergroup")
974
              && !$ccuser->in_group(Param("insidergroup"));
975
            push(@new_cc_list, $cc);
976 977 978 979
        }
        $flag->{'type'}->{'cc_list'} = join(", ", @new_cc_list);
    }

980 981 982
    # If there is nobody left to notify, return.
    return unless ($flag->{'addressee'} || $flag->{'type'}->{'cc_list'});

983 984 985 986 987 988 989 990 991 992 993 994
    # Process and send notification for each recipient
    foreach my $to ($flag->{'addressee'} ? $flag->{'addressee'}->email : '',
                    split(/[, ]+/, $flag->{'type'}->{'cc_list'}))
    {
        next unless $to;
        my $vars = { 'flag' => $flag, 'to' => $to };
        my $message;
        my $rv = $template->process($template_file, $vars, \$message);
        if (!$rv) {
            Bugzilla->cgi->header();
            ThrowTemplateError($template->error());
        }
995

996 997
        Bugzilla::BugMail::MessageToMTA($message);
    }
998 999
}

1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017
# Cancel all request flags from the attachment being obsoleted.
sub CancelRequests {
    my ($bug_id, $attach_id, $timestamp) = @_;
    my $dbh = Bugzilla->dbh;

    my $request_ids =
        $dbh->selectcol_arrayref("SELECT flags.id
                                  FROM flags
                                  LEFT JOIN attachments ON flags.attach_id = attachments.attach_id
                                  WHERE flags.attach_id = ?
                                  AND flags.status = '?'
                                  AND attachments.isobsolete = 0",
                                  undef, $attach_id);

    return if (!scalar(@$request_ids));

    # Take a snapshot of flags before any changes.
    my @old_summaries = snapshot($bug_id, $attach_id) if ($timestamp);
1018
    foreach my $flag (@$request_ids) { clear($flag) }
1019 1020 1021 1022 1023 1024 1025 1026 1027

    # If $timestamp is undefined, do not update the activity table
    return unless ($timestamp);

    # Take a snapshot of flags after any changes.
    my @new_summaries = snapshot($bug_id, $attach_id);
    update_activity($bug_id, $attach_id, $timestamp, \@old_summaries, \@new_summaries);
}

1028
######################################################################
1029
# Private Functions
1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044
######################################################################

=begin private

=head1 PRIVATE FUNCTIONS

=over

=item C<sqlify_criteria($criteria)>

Converts a hash of criteria into a list of SQL criteria.

=back

=cut
1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076

sub sqlify_criteria {
    # a reference to a hash containing the criteria (field => value)
    my ($criteria) = @_;

    # the generated list of SQL criteria; "1=1" is a clever way of making sure
    # there's something in the list so calling code doesn't have to check list
    # size before building a WHERE clause out of it
    my @criteria = ("1=1");
    
    # If the caller specified only bug or attachment flags,
    # limit the query to those kinds of flags.
    if (defined($criteria->{'target_type'})) {
        if    ($criteria->{'target_type'} eq 'bug')        { push(@criteria, "attach_id IS NULL") }
        elsif ($criteria->{'target_type'} eq 'attachment') { push(@criteria, "attach_id IS NOT NULL") }
    }
    
    # Go through each criterion from the calling code and add it to the query.
    foreach my $field (keys %$criteria) {
        my $value = $criteria->{$field};
        next unless defined($value);
        if    ($field eq 'type_id')      { push(@criteria, "type_id      = $value") }
        elsif ($field eq 'bug_id')       { push(@criteria, "bug_id       = $value") }
        elsif ($field eq 'attach_id')    { push(@criteria, "attach_id    = $value") }
        elsif ($field eq 'requestee_id') { push(@criteria, "requestee_id = $value") }
        elsif ($field eq 'setter_id')    { push(@criteria, "setter_id    = $value") }
        elsif ($field eq 'status')       { push(@criteria, "status       = '$value'") }
    }
    
    return @criteria;
}

1077 1078 1079 1080 1081 1082 1083 1084 1085 1086
=pod

=over

=item C<perlify_record($exists, $id, $type_id, $bug_id, $attach_id, $requestee_id, $setter_id, $status)>

Converts a row from the database into a Perl record.

=back

1087 1088
=end private

1089 1090
=cut

1091
sub perlify_record {
1092
    my ($id, $type_id, $bug_id, $attach_id, 
1093 1094
        $requestee_id, $setter_id, $status) = @_;
    
1095
    return undef unless $id;
1096
    
1097 1098 1099 1100
    my $flag =
      {
        id        => $id ,
        type      => Bugzilla::FlagType::get($type_id) ,
1101
        target    => get_target($bug_id, $attach_id) , 
1102
        requestee => $requestee_id ? new Bugzilla::User($requestee_id) : undef,
1103 1104 1105 1106 1107 1108 1109
        setter    => new Bugzilla::User($setter_id) ,
        status    => $status , 
      };
    
    return $flag;
}

1110 1111 1112 1113 1114 1115 1116 1117
=head1 SEE ALSO

=over

=item B<Bugzilla::FlagType>

=back

1118

1119 1120 1121 1122 1123 1124 1125 1126 1127 1128
=head1 CONTRIBUTORS

=over

=item Myk Melez <myk@mozilla.org>

=item Jouni Heikniemi <jouni@heikniemi.net>

=item Kevin Benton <kevin.benton@amd.com>

1129 1130
=item Frédéric Buclin <LpSolit@gmail.com>

1131 1132 1133 1134
=back

=cut

1135
1;