sanitycheck.cgi 34.5 KB
Newer Older
1
#!/usr/bin/perl -wT
2
# -*- Mode: perl; indent-tabs-mode: nil -*-
3
#
4 5 6 7 8 9 10 11 12 13
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
14
# The Original Code is the Bugzilla Bug Tracking System.
15
#
16
# The Initial Developer of the Original Code is Netscape Communications
17 18 19 20
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
21
# Contributor(s): Terry Weissman <terry@mozilla.org>
22
#                 Matthew Tuck <matty@chariot.net.au>
23
#                 Max Kanat-Alexander <mkanat@bugzilla.org>
24
#                 Marc Schumann <wurblzap@gmail.com>
25

26
use strict;
27

28 29
use lib qw(.);

30
use Bugzilla;
31
use Bugzilla::Constants;
32
use Bugzilla::Util;
33
use Bugzilla::Error;
34
use Bugzilla::User;
35

36 37 38
###########################################################################
# General subs
###########################################################################
39 40 41

sub Status {
    my ($str) = (@_);
42
    print "$str <p>\n";
43 44
}

45 46
sub Alert {
    my ($str) = (@_);
47
    Status("<font color=\"red\">$str</font>");
48 49
}

50 51
sub BugLink {
    my ($id) = (@_);
52
    return "<a href=\"show_bug.cgi?id=$id\">$id</a>";
53 54
}

55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71
#
# Parameter is a list of bug ids.
#
# Return is a string containing a list of all the bugids, as hrefs,
# followed by a link to them all as a buglist
sub BugListLinks {
    my @bugs = @_;

    # Historically, GetBugLink() wasn't used here. I'm guessing this
    # was because it didn't exist or is too performance heavy, or just
    # plain unnecessary
    my @bug_links = map(BugLink($_), @bugs);

    return join(', ',@bug_links) . " <a href=\"buglist.cgi?bug_id=" .
        join(',',@bugs) . "\">(as buglist)</a>";
}

72 73 74
###########################################################################
# Start
###########################################################################
75

76
Bugzilla->login(LOGIN_REQUIRED);
77

78
my $cgi = Bugzilla->cgi;
79
my $dbh = Bugzilla->dbh;
80
my $template = Bugzilla->template;
81

82 83 84 85 86 87 88
# Make sure the user is authorized to access sanitycheck.cgi.  Access
# is restricted to logged-in users who have "editbugs" privileges,
# which is a reasonable compromise between allowing all users to access
# the script (creating the potential for denial of service attacks)
# and restricting access to this installation's administrators (which
# prevents users with a legitimate interest in Bugzilla integrity
# from accessing the script).
89
Bugzilla->user->in_group("editbugs")
90 91 92
  || ThrowUserError("auth_failure", {group  => "editbugs",
                                     action => "run",
                                     object => "sanity_check"});
93

94
print $cgi->header();
95

96
my @row;
97

98
$template->put_header("Sanity Check");
99

100 101 102 103
###########################################################################
# Fix vote cache
###########################################################################

104
if (defined $cgi->param('rebuildvotecache')) {
105
    Status("OK, now rebuilding vote cache.");
106
    $dbh->bz_lock_tables('bugs WRITE', 'votes READ');
107 108 109 110 111 112 113 114 115
    $dbh->do(q{UPDATE bugs SET votes = 0});
    my $sth_update = $dbh->prepare(q{UPDATE bugs 
                                        SET votes = ? 
                                      WHERE bug_id = ?});
    my $sth = $dbh->prepare(q{SELECT bug_id, SUM(vote_count)
                                FROM votes }. $dbh->sql_group_by('bug_id'));
    $sth->execute();
    while (my ($id, $v) = $sth->fetchrow_array) {
        $sth_update->execute($v, $id);
116
    }
117
    $dbh->bz_unlock_tables();
118
    Status("Vote cache has been rebuilt.");
119 120
}

121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164
###########################################################################
# Create missing group_control_map entries
###########################################################################

if (defined $cgi->param('createmissinggroupcontrolmapentries')) {
    Status(qq{OK, now creating <code>SHOWN</code> member control entries
              for product/group combinations lacking one.});

    my $na    = CONTROLMAPNA;
    my $shown = CONTROLMAPSHOWN;
    my $insertsth = $dbh->prepare(
        qq{INSERT INTO group_control_map (
                       group_id, product_id, entry,
                       membercontrol, othercontrol, canedit
                      )
               VALUES (
                       ?, ?, 0,
                       $shown, $na, 0
                      )});
    my $updatesth = $dbh->prepare(qq{UPDATE group_control_map
                                        SET membercontrol = $shown
                                      WHERE group_id   = ?
                                        AND product_id = ?});
    my $counter = 0;

    # Find all group/product combinations used for bugs but not set up
    # correctly in group_control_map
    my $invalid_combinations = $dbh->selectall_arrayref(
        qq{    SELECT bugs.product_id,
                      bgm.group_id,
                      gcm.membercontrol,
                      groups.name,
                      products.name
                 FROM bugs
           INNER JOIN bug_group_map AS bgm
                   ON bugs.bug_id = bgm.bug_id
           INNER JOIN groups
                   ON bgm.group_id = groups.id
           INNER JOIN products
                   ON bugs.product_id = products.id
            LEFT JOIN group_control_map AS gcm
                   ON bugs.product_id = gcm.product_id
                  AND    bgm.group_id = gcm.group_id
                WHERE COALESCE(gcm.membercontrol, $na) = $na
165 166
          } . $dbh->sql_group_by('bugs.product_id, bgm.group_id',
                                 'gcm.membercontrol, groups.name, products.name'));
167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190

    foreach (@$invalid_combinations) {
        my ($product_id, $group_id, $currentmembercontrol,
            $group_name, $product_name) = @$_;

        $counter++;
        if (defined($currentmembercontrol)) {
            Status(qq{Updating <code>NA/<em>xxx</em></code> group control
                      setting for group <em>$group_name</em> to
                      <code>SHOWN/<em>xxx</em></code> in product
                      <em>$product_name</em>.});
            $updatesth->execute($group_id, $product_id);
        }
        else {
            Status(qq{Generating <code>SHOWN/NA</code> group control setting
                      for group <em>$group_name</em> in product
                      <em>$product_name</em>.});
            $insertsth->execute($group_id, $product_id);
        }
    }

    Status("Repaired $counter defective group control settings.");
}

191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216
###########################################################################
# Fix missing creation date
###########################################################################

if (defined $cgi->param('repair_creation_date')) {
    Status("OK, now fixing missing bug creation dates");

    my $bug_ids = $dbh->selectcol_arrayref('SELECT bug_id FROM bugs
                                            WHERE creation_ts IS NULL');

    my $sth_UpdateDate = $dbh->prepare('UPDATE bugs SET creation_ts = ?
                                        WHERE bug_id = ?');

    # All bugs have an entry in the 'longdescs' table when they are created,
    # even if 'commentoncreate' is turned off.
    my $sth_getDate = $dbh->prepare('SELECT MIN(bug_when) FROM longdescs
                                     WHERE bug_id = ?');

    foreach my $bugid (@$bug_ids) {
        $sth_getDate->execute($bugid);
        my $date = $sth_getDate->fetchrow_array;
        $sth_UpdateDate->execute($date, $bugid);
    }
    Status(scalar(@$bug_ids) . " bugs have been fixed.");
}

217 218 219 220
###########################################################################
# Send unsent mail
###########################################################################

221
if (defined $cgi->param('rescanallBugMail')) {
222 223 224
    require Bugzilla::BugMail;

    Status("OK, now attempting to send unsent mail");
225 226 227 228 229 230 231 232 233 234 235
    my $time = $dbh->sql_interval(30, 'MINUTE');
    
    my $list = $dbh->selectcol_arrayref(qq{
                                        SELECT bug_id
                                          FROM bugs 
                                         WHERE (lastdiffed IS NULL
                                                OR lastdiffed < delta_ts)
                                           AND delta_ts < now() - $time
                                      ORDER BY bug_id});
         
    Status(scalar(@$list) . ' bugs found with possibly unsent mail.');
236 237 238 239 240 241 242 243 244 245 246

    my $vars = {};
    # We cannot simply look at the bugs_activity table to find who did the
    # last change in a given bug, as e.g. adding a comment doesn't add any
    # entry to this table. And some other changes may be private
    # (such as time-related changes or private attachments or comments)
    # and so choosing this user as being the last one having done a change
    # for the bug may be problematic. So the best we can do at this point
    # is to choose the currently logged in user for email notification.
    $vars->{'changer'} = Bugzilla->user->login;

247
    foreach my $bugid (@$list) {
248
        Bugzilla::BugMail::Send($bugid, $vars);
249 250
    }

251
    if (scalar(@$list) > 0) {
252 253 254
        Status("Unsent mail has been sent.");
    }

255
    $template->put_footer();
256 257 258
    exit;
}

259 260 261 262
###########################################################################
# Remove all references to deleted bugs
###########################################################################

263
if (defined $cgi->param('remove_invalid_bug_references')) {
264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293
    Status("OK, now removing all references to deleted bugs.");

    $dbh->bz_lock_tables('attachments WRITE', 'bug_group_map WRITE',
                         'bugs_activity WRITE', 'cc WRITE',
                         'dependencies WRITE', 'duplicates WRITE',
                         'flags WRITE', 'keywords WRITE',
                         'longdescs WRITE', 'votes WRITE', 'bugs READ');

    foreach my $pair ('attachments/', 'bug_group_map/', 'bugs_activity/', 'cc/',
                      'dependencies/blocked', 'dependencies/dependson',
                      'duplicates/dupe', 'duplicates/dupe_of',
                      'flags/', 'keywords/', 'longdescs/', 'votes/') {

        my ($table, $field) = split('/', $pair);
        $field ||= "bug_id";

        my $bug_ids =
          $dbh->selectcol_arrayref("SELECT $table.$field FROM $table
                                    LEFT JOIN bugs ON $table.$field = bugs.bug_id
                                    WHERE bugs.bug_id IS NULL");

        if (scalar(@$bug_ids)) {
            $dbh->do("DELETE FROM $table WHERE $field IN (" . join(',', @$bug_ids) . ")");
        }
    }

    $dbh->bz_unlock_tables();
    Status("All references to deleted bugs have been removed.");
}

294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317
###########################################################################
# Remove all references to deleted attachments
###########################################################################

if (defined $cgi->param('remove_invalid_attach_references')) {
    Status("OK, now removing all references to deleted attachments.");

    $dbh->bz_lock_tables('attachments WRITE', 'attach_data WRITE');

    my $attach_ids =
        $dbh->selectcol_arrayref('SELECT attach_data.id
                                    FROM attach_data
                               LEFT JOIN attachments
                                      ON attachments.attach_id = attach_data.id
                                   WHERE attachments.attach_id IS NULL');

    if (scalar(@$attach_ids)) {
        $dbh->do('DELETE FROM attach_data WHERE id IN (' .
                 join(',', @$attach_ids) . ')');
    }

    $dbh->bz_unlock_tables();
    Status("All references to deleted attachments have been removed.");
}
318

319
print "OK, now running sanity checks.<p>\n";
320

321 322 323 324
###########################################################################
# Perform referential (cross) checks
###########################################################################

325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340
# This checks that a simple foreign key has a valid primary key value.  NULL
# references are acceptable and cause no problem.
#
# The first parameter is the primary key table name.
# The second parameter is the primary key field name.
# Each successive parameter represents a foreign key, it must be a list
# reference, where the list has:
#   the first value is the foreign key table name.
#   the second value is the foreign key field name.
#   the third value is optional and represents a field on the foreign key
#     table to display when the check fails.
#   the fourth value is optional and is a list reference to values that
#     are excluded from checking.
#
# FIXME: The excluded values parameter should go away - the QA contact
#        fields should use NULL instead - see bug #109474.
341
#        The same goes for series; no bug for that yet.
342

343 344 345
sub CrossCheck {
    my $table = shift @_;
    my $field = shift @_;
346
    my $dbh = Bugzilla->dbh;
347 348 349 350 351 352 353 354 355 356 357

    Status("Checking references to $table.$field");

    while (@_) {
        my $ref = shift @_;
        my ($refertable, $referfield, $keyname, $exceptions) = @$ref;

        $exceptions ||= [];
        my %exceptions = map { $_ => 1 } @$exceptions;

        Status("... from $refertable.$referfield");
358 359 360 361 362 363 364 365 366 367 368
       
        my $query = qq{SELECT DISTINCT $refertable.$referfield} .
            ($keyname ? qq{, $refertable.$keyname } : q{}) .
                     qq{ FROM $refertable
                    LEFT JOIN $table
                           ON $refertable.$referfield = $table.$field
                        WHERE $table.$field IS NULL
                          AND $refertable.$referfield IS NOT NULL};
         
        my $sth = $dbh->prepare($query);
        $sth->execute;
369

370
        my $has_bad_references = 0;
371 372 373 374 375 376 377 378 379

        while (my ($value, $key) = $sth->fetchrow_array) {
            next if $exceptions{$value};
            my $alert = "Bad value &quot;$value&quot; found in $refertable.$referfield";
            if ($keyname) {
                if ($keyname eq 'bug_id') {
                    $alert .= ' (bug ' . BugLink($key) . ')';
                } else {
                    $alert .= " ($keyname == '$key')";
380 381
                }
            }
382 383
            Alert($alert);
            $has_bad_references = 1;
384
        }
385 386
        # References to non existent bugs can be safely removed, bug 288461
        if ($table eq 'bugs' && $has_bad_references) {
387 388 389 390 391 392 393
            print qq{<a href="sanitycheck.cgi?remove_invalid_bug_references=1">
                     Remove invalid references to non existent bugs.</a><p>\n};
        }
        # References to non existent attachments can be safely removed.
        if ($table eq 'attachments' && $has_bad_references) {
            print qq{<a href="sanitycheck.cgi?remove_invalid_attach_references=1">
                     Remove invalid references to non existent attachments.</a><p>\n};
394
        }
395 396 397
    }
}

398 399 400
CrossCheck('classifications', 'id',
           ['products', 'classification_id']);

401 402 403
CrossCheck("keyworddefs", "id",
           ["keywords", "keywordid"]);

404
CrossCheck("fielddefs", "id",
405 406
           ["bugs_activity", "fieldid"],
           ['profiles_activity', 'fieldid']);
407

408 409
CrossCheck("flagtypes", "id",
           ["flags", "type_id"]);
410 411 412

CrossCheck("bugs", "bug_id",
           ["bugs_activity", "bug_id"],
413
           ["bug_group_map", "bug_id"],
414 415 416 417 418
           ["attachments", "bug_id"],
           ["cc", "bug_id"],
           ["longdescs", "bug_id"],
           ["dependencies", "blocked"],
           ["dependencies", "dependson"],
419
           ['flags', 'bug_id'],
420
           ["votes", "bug_id"],
421 422 423
           ["keywords", "bug_id"],
           ["duplicates", "dupe_of", "dupe"],
           ["duplicates", "dupe", "dupe_of"]);
424

425 426
CrossCheck("groups", "id",
           ["bug_group_map", "group_id"],
427
           ['category_group_map', 'group_id'],
428 429
           ["group_group_map", "grantor_id"],
           ["group_group_map", "member_id"],
430
           ["group_control_map", "group_id"],
431
           ["namedquery_group_map", "group_id"],
432 433
           ["user_group_map", "group_id"]);

434 435 436 437 438
CrossCheck("namedqueries", "id",
           ["namedqueries_link_in_footer", "namedquery_id"],
           ["namedquery_group_map", "namedquery_id"],
          );

439
CrossCheck("profiles", "userid",
440 441
           ['profiles_activity', 'userid'],
           ['profiles_activity', 'who'],
442 443
           ['email_setting', 'user_id'],
           ['profile_setting', 'user_id'],
444 445
           ["bugs", "reporter", "bug_id"],
           ["bugs", "assigned_to", "bug_id"],
446
           ["bugs", "qa_contact", "bug_id"],
447
           ["attachments", "submitter_id", "bug_id"],
448 449
           ['flags', 'setter_id', 'bug_id'],
           ['flags', 'requestee_id', 'bug_id'],
450 451
           ["bugs_activity", "who", "bug_id"],
           ["cc", "who", "bug_id"],
452
           ['quips', 'userid'],
453 454
           ["votes", "who", "bug_id"],
           ["longdescs", "who", "bug_id"],
455
           ["logincookies", "userid"],
456
           ["namedqueries", "userid"],
457
           ["namedqueries_link_in_footer", "user_id"],
458
           ['series', 'creator', 'series_id'],
459 460
           ["watch", "watcher"],
           ["watch", "watched"],
461
           ['whine_events', 'owner_userid'],
462
           ["tokens", "userid"],
463
           ["user_group_map", "user_id"],
464
           ["components", "initialowner", "name"],
465
           ["components", "initialqacontact", "name"]);
466

467 468 469 470 471
CrossCheck("products", "id",
           ["bugs", "product_id", "bug_id"],
           ["components", "product_id", "name"],
           ["milestones", "product_id", "value"],
           ["versions", "product_id", "value"],
472
           ["group_control_map", "product_id"],
473 474
           ["flaginclusions", "product_id", "type_id"],
           ["flagexclusions", "product_id", "type_id"]);
475

476
# Check the former enum types -mkanat@bugzilla.org
477
CrossCheck("bug_status", "value",
478
            ["bugs", "bug_status", "bug_id"]);
479 480

CrossCheck("resolution", "value",
481
            ["bugs", "resolution", "bug_id"]);
482 483

CrossCheck("bug_severity", "value",
484
            ["bugs", "bug_severity", "bug_id"]);
485 486

CrossCheck("op_sys", "value",
487
            ["bugs", "op_sys", "bug_id"]);
488 489

CrossCheck("priority", "value",
490
            ["bugs", "priority", "bug_id"]);
491 492

CrossCheck("rep_platform", "value",
493
            ["bugs", "rep_platform", "bug_id"]);
494

495 496 497 498 499 500 501 502 503 504
CrossCheck('series', 'series_id',
           ['series_data', 'series_id']);

CrossCheck('series_categories', 'id',
           ['series', 'category']);

CrossCheck('whine_events', 'id',
           ['whine_queries', 'eventid'],
           ['whine_schedules', 'eventid']);

505 506 507
CrossCheck('attachments', 'attach_id',
           ['attach_data', 'id']);

508
###########################################################################
509
# Perform double field referential (cross) checks
510
###########################################################################
511
 
512 513 514 515 516 517 518 519 520 521 522 523 524 525
# This checks that a compound two-field foreign key has a valid primary key
# value.  NULL references are acceptable and cause no problem.
#
# The first parameter is the primary key table name.
# The second parameter is the primary key first field name.
# The third parameter is the primary key second field name.
# Each successive parameter represents a foreign key, it must be a list
# reference, where the list has:
#   the first value is the foreign key table name
#   the second value is the foreign key first field name.
#   the third value is the foreign key second field name.
#   the fourth value is optional and represents a field on the foreign key
#     table to display when the check fails

526 527 528 529
sub DoubleCrossCheck {
    my $table = shift @_;
    my $field1 = shift @_;
    my $field2 = shift @_;
530
    my $dbh = Bugzilla->dbh;
531 532 533 534 535 536 537 538
 
    Status("Checking references to $table.$field1 / $table.$field2");
 
    while (@_) {
        my $ref = shift @_;
        my ($refertable, $referfield1, $referfield2, $keyname) = @$ref;
 
        Status("... from $refertable.$referfield1 / $refertable.$referfield2");
539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554

        my $d_cross_check = $dbh->selectall_arrayref(qq{
                        SELECT DISTINCT $refertable.$referfield1, 
                                        $refertable.$referfield2 } .
                       ($keyname ? qq{, $refertable.$keyname } : q{}) .
                      qq{ FROM $refertable
                     LEFT JOIN $table
                            ON $refertable.$referfield1 = $table.$field1
                           AND $refertable.$referfield2 = $table.$field2 
                         WHERE $table.$field1 IS NULL 
                           AND $table.$field2 IS NULL 
                           AND $refertable.$referfield1 IS NOT NULL 
                           AND $refertable.$referfield2 IS NOT NULL});

        foreach my $check (@$d_cross_check) {
            my ($value1, $value2, $key) = @$check;
555
            my $alert = "Bad values &quot;$value1&quot;, &quot;$value2&quot; found in " .
556 557 558 559 560 561 562 563 564 565 566
                "$refertable.$referfield1 / $refertable.$referfield2";
            if ($keyname) {
                if ($keyname eq 'bug_id') {
                   $alert .= ' (bug ' . BugLink($key) . ')';
                }
                else {
                    $alert .= " ($keyname == '$key')";
                }
            }
            Alert($alert);
        }
567 568 569
    }
}

570 571 572 573
DoubleCrossCheck('attachments', 'bug_id', 'attach_id',
                 ['flags', 'bug_id', 'attach_id'],
                 ['bugs_activity', 'bug_id', 'attach_id']);

574
DoubleCrossCheck("components", "product_id", "id",
575 576 577
                 ["bugs", "product_id", "component_id", "bug_id"],
                 ['flagexclusions', 'product_id', 'component_id'],
                 ['flaginclusions', 'product_id', 'component_id']);
578

579 580 581 582 583 584
DoubleCrossCheck("versions", "product_id", "value",
                 ["bugs", "product_id", "version", "bug_id"]);
 
DoubleCrossCheck("milestones", "product_id", "value",
                 ["bugs", "product_id", "target_milestone", "bug_id"],
                 ["products", "id", "defaultmilestone", "name"]);
585

586 587 588 589
###########################################################################
# Perform login checks
###########################################################################
 
590
Status("Checking profile logins");
591

592 593
my $sth = $dbh->prepare(q{SELECT userid, login_name FROM profiles});
$sth->execute;
594

595
while (my ($id, $email) = $sth->fetchrow_array) {
596 597
    validate_email_syntax($email)
      || Alert "Bad profile email address, id=$id,  &lt;$email&gt;.";
598
}
599

600 601 602
###########################################################################
# Perform vote/keyword cache checks
###########################################################################
603

604 605 606 607 608
sub AlertBadVoteCache {
    my ($id) = (@_);
    Alert("Bad vote cache for bug " . BugLink($id));
}

609 610 611 612 613
$sth = $dbh->prepare(q{SELECT bug_id, votes, keywords
                         FROM bugs
                        WHERE votes != 0 
                           OR keywords != ''});
$sth->execute;
614

615
my %votes;
616
my %bugid;
617
my %keyword;
618

619
while (my ($id, $v, $k) = $sth->fetchrow_array) {
620 621 622
    if ($v != 0) {
        $votes{$id} = $v;
    }
623 624 625
    if ($k) {
        $keyword{$id} = $k;
    }
626 627 628
}

Status("Checking cached vote counts");
629 630 631 632
$sth = $dbh->prepare(q{SELECT bug_id, SUM(vote_count)
                         FROM votes }.
                       $dbh->sql_group_by('bug_id'));
$sth->execute;
633

634 635
my $offer_votecache_rebuild = 0;

636
while (my ($id, $v) = $sth->fetchrow_array) {
637 638 639 640 641
    if ($v <= 0) {
        Alert("Bad vote sum for bug $id");
    } else {
        if (!defined $votes{$id} || $votes{$id} != $v) {
            AlertBadVoteCache($id);
642
            $offer_votecache_rebuild = 1;
643 644 645 646 647 648
        }
        delete $votes{$id};
    }
}
foreach my $id (keys %votes) {
    AlertBadVoteCache($id);
649
    $offer_votecache_rebuild = 1;
650 651
}

652
if ($offer_votecache_rebuild) {
653 654 655 656
    print qq{<a href="sanitycheck.cgi?rebuildvotecache=1">Click here to rebuild the vote cache</a><p>\n};
}


657 658 659
Status("Checking keywords table");

my %keywordids;
660 661 662 663 664 665

my $keywords = $dbh->selectall_arrayref(q{SELECT id, name 
                                            FROM keyworddefs});

foreach my $keyword (@$keywords) {
    my ($id, $name) = @$keyword;
666 667 668 669
    if ($keywordids{$id}) {
        Alert("Duplicate entry in keyworddefs for id $id");
    }
    $keywordids{$id} = 1;
670
    if ($name =~ /[\s,]/) {
671 672 673 674
        Alert("Bogus name in keyworddefs for id $id");
    }
}

675 676 677 678
$sth = $dbh->prepare(q{SELECT bug_id, keywordid
                         FROM keywords
                     ORDER BY bug_id, keywordid});
$sth->execute;
679 680
my $lastid;
my $lastk;
681
while (my ($id, $k) = $sth->fetchrow_array) {
682 683 684 685 686 687 688 689 690 691 692 693 694 695
    if (!$keywordids{$k}) {
        Alert("Bogus keywordids $k found in keywords table");
    }
    if (defined $lastid && $id eq $lastid && $k eq $lastk) {
        Alert("Duplicate keyword ids found in bug " . BugLink($id));
    }
    $lastid = $id;
    $lastk = $k;
}

Status("Checking cached keywords");

my %realk;

696
if (defined $cgi->param('rebuildkeywordcache')) {
697 698
    $dbh->bz_lock_tables('bugs write', 'keywords read',
                                  'keyworddefs read');
699 700
}

701 702 703 704 705 706 707 708 709 710
my $query = q{SELECT keywords.bug_id, keyworddefs.name
                FROM keywords
          INNER JOIN keyworddefs
                  ON keyworddefs.id = keywords.keywordid
          INNER JOIN bugs
                  ON keywords.bug_id = bugs.bug_id
            ORDER BY keywords.bug_id, keyworddefs.name};

$sth = $dbh->prepare($query);
$sth->execute;
711

712
my $lastb = 0;
713 714
my @list;
while (1) {
715
    my ($b, $k) = $sth->fetchrow_array; 
716
    if (!defined $b || $b != $lastb) {
717 718 719 720 721 722 723 724 725 726 727 728
        if (@list) {
            $realk{$lastb} = join(', ', @list);
        }
        if (!$b) {
            last;
        }
        $lastb = $b;
        @list = ();
    }
    push(@list, $k);
}

729
my @badbugs = ();
730

731 732
foreach my $b (keys(%keyword)) {
    if (!exists $realk{$b} || $realk{$b} ne $keyword{$b}) {
733
        push(@badbugs, $b);
734 735 736 737
    }
}
foreach my $b (keys(%realk)) {
    if (!exists $keyword{$b}) {
738
        push(@badbugs, $b);
739 740
    }
}
741 742
if (@badbugs) {
    @badbugs = sort {$a <=> $b} @badbugs;
743 744
    Alert(scalar(@badbugs) . " bug(s) found with incorrect keyword cache: " .
          BugListLinks(@badbugs));
745 746 747 748 749
          
    my $sth_update = $dbh->prepare(q{UPDATE bugs
                                        SET keywords = ?
                                      WHERE bug_id = ?});
                                      
750
    if (defined $cgi->param('rebuildkeywordcache')) {
751
        Status("OK, now fixing keyword cache.");
752
        foreach my $b (@badbugs) {
753 754 755 756
            my $k = '';
            if (exists($realk{$b})) {
                $k = $realk{$b};
            }
757
            $sth_update->execute($k, $b);
758 759 760 761 762 763 764
        }
        Status("Keyword cache fixed.");
    } else {
        print qq{<a href="sanitycheck.cgi?rebuildkeywordcache=1">Click here to rebuild the keyword cache</a><p>\n};
    }
}

765
if (defined $cgi->param('rebuildkeywordcache')) {
766
    $dbh->bz_unlock_tables();
767
}
768

769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820
###########################################################################
# Check for flags being in incorrect products and components
###########################################################################

Status('Checking for flags being in the wrong product/component');

my $invalid_flags = $dbh->selectall_arrayref(
       'SELECT DISTINCT flags.id, flags.bug_id, flags.attach_id
          FROM flags
    INNER JOIN bugs
            ON flags.bug_id = bugs.bug_id
     LEFT JOIN flaginclusions AS i
            ON flags.type_id = i.type_id
           AND (bugs.product_id = i.product_id OR i.product_id IS NULL)
           AND (bugs.component_id = i.component_id OR i.component_id IS NULL)
         WHERE i.type_id IS NULL');

my @invalid_flags = @$invalid_flags;

$invalid_flags = $dbh->selectall_arrayref(
       'SELECT DISTINCT flags.id, flags.bug_id, flags.attach_id
          FROM flags
    INNER JOIN bugs
            ON flags.bug_id = bugs.bug_id
    INNER JOIN flagexclusions AS e
            ON flags.type_id = e.type_id
         WHERE (bugs.product_id = e.product_id OR e.product_id IS NULL)
           AND (bugs.component_id = e.component_id OR e.component_id IS NULL)');

push(@invalid_flags, @$invalid_flags);

if (scalar(@invalid_flags)) {
    if ($cgi->param('remove_invalid_flags')) {
        Status("OK, now deleting invalid flags.");
        my @flag_ids = map {$_->[0]} @invalid_flags;
        $dbh->bz_lock_tables('flags WRITE');
        # Silently delete these flags, with no notification to requesters/setters.
        $dbh->do('DELETE FROM flags WHERE id IN (' . join(',', @flag_ids) .')');
        $dbh->bz_unlock_tables();
        Status("Invalid flags deleted.");
    }
    else {
        foreach my $flag (@$invalid_flags) {
            my ($flag_id, $bug_id, $attach_id) = @$flag;
            Alert("Invalid flag $flag_id for " .
                  ($attach_id ? "attachment $attach_id in bug " : "bug ") . BugLink($bug_id));
        }
        print qq{<a href="sanitycheck.cgi?remove_invalid_flags=1">Click
                 here to delete invalid flags</a><p>\n};
    }
}

821
###########################################################################
822
# General bug checks
823 824
###########################################################################

825
sub BugCheck {
826
    my ($middlesql, $errortext, $repairparam, $repairtext) = @_;
827
    my $dbh = Bugzilla->dbh;
828 829 830 831
 
    my $badbugs = $dbh->selectcol_arrayref(qq{SELECT DISTINCT bugs.bug_id
                                                FROM $middlesql 
                                            ORDER BY bugs.bug_id});
832

833 834
    if (scalar(@$badbugs)) {
        Alert("$errortext: " . BugListLinks(@$badbugs));
835 836 837 838 839
        if ($repairparam) {
            $repairtext ||= 'Repair these bugs';
            print qq{<a href="sanitycheck.cgi?$repairparam=1">$repairtext</a>.},
                  '<p>';
        }
840
    }
841 842
}

843 844 845 846 847
Status("Checking for bugs with no creation date (which makes them invisible)");

BugCheck("bugs WHERE creation_ts IS NULL", "Bugs with no creation date",
         "repair_creation_date", "Repair missing creation date for these bugs");

848
Status("Checking resolution/duplicates");
849

850 851
BugCheck("bugs INNER JOIN duplicates ON bugs.bug_id = duplicates.dupe " .
         "WHERE bugs.resolution != 'DUPLICATE'",
852
         "Bug(s) found on duplicates table that are not marked duplicate");
853

854 855 856 857
BugCheck("bugs LEFT JOIN duplicates ON bugs.bug_id = duplicates.dupe WHERE " .
         "bugs.resolution = 'DUPLICATE' AND " .
         "duplicates.dupe IS NULL",
         "Bug(s) found marked resolved duplicate and not on duplicates table");
858 859 860

Status("Checking statuses/resolutions");

861
my @open_states = map($dbh->quote($_), BUG_STATE_OPEN);
862 863
my $open_states = join(', ', @open_states);

864 865 866 867
BugCheck("bugs WHERE bug_status IN ($open_states) AND resolution != ''",
         "Bugs with open status and a resolution");
BugCheck("bugs WHERE bug_status NOT IN ($open_states) AND resolution = ''",
         "Bugs with non-open status and no resolution");
868 869 870

Status("Checking statuses/everconfirmed");

871
BugCheck("bugs WHERE bug_status = 'UNCONFIRMED' AND everconfirmed = 1",
872 873 874
         "Bugs that are UNCONFIRMED but have everconfirmed set");
# The below list of resolutions is hardcoded because we don't know if future
# resolutions will be confirmed, unconfirmed or maybeconfirmed.  I suspect
875
# they will be maybeconfirmed, e.g. ASLEEP and REMIND.  This hardcoding should
876 877 878
# disappear when we have customised statuses.
BugCheck("bugs WHERE bug_status IN ('NEW', 'ASSIGNED', 'REOPENED') AND everconfirmed = 0",
         "Bugs with confirmed status but don't have everconfirmed set"); 
879 880 881

Status("Checking votes/everconfirmed");

882 883
BugCheck("bugs INNER JOIN products ON bugs.product_id = products.id " .
         "WHERE everconfirmed = 0 AND votestoconfirm <= votes",
884
         "Bugs that have enough votes to be confirmed but haven't been");
885

886 887 888 889 890 891 892
###########################################################################
# Control Values
###########################################################################

# Checks for values that are invalid OR
# not among the 9 valid combinations
Status("Checking for bad values in group_control_map");
893 894 895 896 897 898 899 900 901 902 903 904 905
my $groups = join(", ", (CONTROLMAPNA, CONTROLMAPSHOWN, CONTROLMAPDEFAULT,
CONTROLMAPMANDATORY));
$query = qq{
     SELECT COUNT(product_id) 
       FROM group_control_map 
      WHERE membercontrol NOT IN( $groups )
         OR othercontrol NOT IN( $groups )
         OR ((membercontrol != othercontrol)
             AND (membercontrol != } . CONTROLMAPSHOWN . q{)
             AND ((membercontrol != } . CONTROLMAPDEFAULT . q{)
                  OR (othercontrol = } . CONTROLMAPSHOWN . q{)))};
                  
my $c = $dbh->selectrow_array($query);
906 907 908 909 910
if ($c) {
    Alert("Found $c bad group_control_map entries");
}

Status("Checking for bugs with groups violating their product's group controls");
911
BugCheck("bugs
912 913 914 915
         INNER JOIN bug_group_map
            ON bugs.bug_id = bug_group_map.bug_id
          LEFT JOIN group_control_map
            ON bugs.product_id = group_control_map.product_id
916
           AND bug_group_map.group_id = group_control_map.group_id
917
         WHERE ((group_control_map.membercontrol = " . CONTROLMAPNA . ")
918
         OR (group_control_map.membercontrol IS NULL))",
919 920 921 922
         'Have groups not permitted for their products',
         'createmissinggroupcontrolmapentries',
         'Permit the missing groups for the affected products
          (set member control to <code>SHOWN</code>)');
923

924
BugCheck("bugs
925
         INNER JOIN group_control_map
926
            ON bugs.product_id = group_control_map.product_id
927 928 929 930 931
         INNER JOIN groups
            ON group_control_map.group_id = groups.id
          LEFT JOIN bug_group_map
            ON bugs.bug_id = bug_group_map.bug_id
           AND group_control_map.group_id = bug_group_map.group_id
932
         WHERE group_control_map.membercontrol = " . CONTROLMAPMANDATORY . "
933 934
           AND bug_group_map.group_id IS NULL
           AND groups.isactive != 0",
935 936 937
         "Are missing groups required for their products");


938 939 940 941 942 943
###########################################################################
# Unsent mail
###########################################################################

Status("Checking for unsent mail");

944 945 946 947 948 949 950
my $time = $dbh->sql_interval(30, 'MINUTE');
my $badbugs = $dbh->selectcol_arrayref(qq{
                    SELECT bug_id 
                      FROM bugs 
                     WHERE (lastdiffed IS NULL OR lastdiffed < delta_ts)
                       AND delta_ts < now() - $time
                  ORDER BY bug_id});
951 952


953
if (scalar(@$badbugs > 0)) {
954
    Alert("Bugs that have changes but no mail sent for at least half an hour: " .
955
          BugListLinks(@$badbugs));
956

957
    print qq{<a href="sanitycheck.cgi?rescanallBugMail=1">Send these mails</a>.<p>\n};
958 959
}

960 961 962
###########################################################################
# End
###########################################################################
963 964

Status("Sanity check completed.");
965
$template->put_footer();