votes.cgi 12.6 KB
Newer Older
1
#!/usr/bin/perl -wT
2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28
# -*- Mode: perl; indent-tabs-mode: nil -*-
#
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
# The Original Code is the Bugzilla Bug Tracking System.
#
# The Initial Developer of the Original Code is Netscape Communications
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
# Contributor(s): Terry Weissman <terry@mozilla.org>
#                 Stephan Niemz  <st.n@gmx.net>
#                 Christopher Aillon <christopher@aillon.com>
#                 Gervase Markham <gerv@gerv.net>

use strict;
use lib ".";

29
use Bugzilla;
30
use Bugzilla::Constants;
31

32
require "CGI.pl";
33 34 35 36

# Use global template variables
use vars qw($template $vars);

37 38
my $cgi = Bugzilla->cgi;

39 40 41 42 43 44 45 46
# If the action is show_bug, you need a bug_id.
# If the action is show_user, you can supply a userid to show the votes for
# another user, otherwise you see your own.
# If the action is vote, your votes are set to those encoded in the URL as 
# <bug_id>=<votes>.
#
# If no action is defined, we default to show_bug if a bug_id is given,
# otherwise to show_user.
47 48
my $bug_id = $cgi->param('bug_id');
my $action = $cgi->param('action') || ($bug_id ? "show_bug" : "show_user");
49 50

if ($action eq "show_bug" ||
51
    ($action eq "show_user" && defined $cgi->param('user')))
52
{
53
    Bugzilla->login();
54 55
}
else {
56
    Bugzilla->login(LOGIN_REQUIRED);
57 58 59 60 61 62 63 64
}

################################################################################
# Begin Data/Security Validation
################################################################################

# Make sure the bug ID is a positive integer representing an existing
# bug that the user is authorized to access.
65 66

ValidateBugID($bug_id) if defined $bug_id;
67 68 69 70 71 72 73 74 75 76 77 78

################################################################################
# End Data/Security Validation
################################################################################

if ($action eq "show_bug") {
    show_bug();
} 
elsif ($action eq "show_user") {
    show_user();
}
elsif ($action eq "vote") {
79
    record_votes() if Param('usevotes');
80 81 82
    show_user();
}
else {
83
    ThrowCodeError("unknown_action", {action => $action});
84 85 86 87 88 89
}

exit;

# Display the names of all the people voting for this one bug.
sub show_bug {
90 91
    my $cgi = Bugzilla->cgi;

92 93
    ThrowCodeError("missing_bug_id") unless defined $bug_id;

94 95 96
    my $total = 0;
    my @users;
    
97
    SendSQL("SELECT profiles.login_name, votes.who, votes.vote_count 
98 99 100 101 102 103 104 105 106 107 108 109 110 111
             FROM votes, profiles 
             WHERE votes.bug_id = $bug_id 
               AND profiles.userid = votes.who");
                   
    while (MoreSQLData()) {
        my ($name, $userid, $count) = (FetchSQLData());
        push (@users, { name => $name, id => $userid, count => $count });
        $total += $count;
    }
    
    $vars->{'bug_id'} = $bug_id;
    $vars->{'users'} = \@users;
    $vars->{'total'} = $total;
    
112
    print $cgi->header();
113 114
    $template->process("bug/votes/list-for-bug.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
115 116 117 118 119 120
}

# Display all the votes for a particular user. If it's the user
# doing the viewing, give them the option to edit them too.
sub show_user {
    GetVersionTable();
121

122
    my $cgi = Bugzilla->cgi;
123
    my $dbh = Bugzilla->dbh;
124

125
    # If a bug_id is given, and we're editing, we'll add it to the votes list.
126 127 128
    $bug_id ||= "";
    
    my $name = $cgi->param('user') || Bugzilla->user->login;
129
    my $who = DBNameToIdAndCheck($name);
130
    my $userid = Bugzilla->user->id;
131
    
132
    my $canedit = (Param('usevotes') && $userid == $who) ? 1 : 0;
133 134 135 136 137

    $dbh->bz_lock_tables('bugs READ', 'products READ', 'votes WRITE',
             'cc READ', 'bug_group_map READ', 'user_group_map READ',
             'cc AS selectVisible_cc READ', 'groups READ');

138 139 140
    if ($canedit && $bug_id) {
        # Make sure there is an entry for this bug
        # in the vote table, just so that things display right.
141
        SendSQL("SELECT votes.vote_count FROM votes 
142 143
                 WHERE votes.bug_id = $bug_id AND votes.who = $who");
        if (!FetchOneColumn()) {
144
            SendSQL("INSERT INTO votes (who, bug_id, vote_count) 
145 146 147 148 149 150 151 152
                     VALUES ($who, $bug_id, 0)");
        }
    }
    
    # Calculate the max votes per bug for each product; doing it here means
    # we can do it all in one query.
    my %maxvotesperbug;
    if($canedit) {
153
        SendSQL("SELECT products.name, products.maxvotesperbug 
154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170
                 FROM products");
        while (MoreSQLData()) {
            my ($prod, $max) = FetchSQLData();
            $maxvotesperbug{$prod} = $max;
        }
    }
    
    my @products;
    
    # Read the votes data for this user for each product
    foreach my $product (sort(keys(%::prodmaxvotes))) {
        next if $::prodmaxvotes{$product} <= 0;
        
        my @bugs;
        my $total = 0;
        my $onevoteonly = 0;
        
171
        SendSQL("SELECT votes.bug_id, votes.vote_count, bugs.short_desc,
172
                        bugs.bug_status 
173
                  FROM  votes, bugs, products
174 175
                  WHERE votes.who = $who 
                    AND votes.bug_id = bugs.bug_id 
176 177
                    AND bugs.product_id = products.id 
                    AND products.name = " . SqlQuote($product) . 
178 179 180 181 182 183 184 185 186 187 188
                 "ORDER BY votes.bug_id");        
        
        while (MoreSQLData()) {
            my ($id, $count, $summary, $status) = FetchSQLData();
            next if !defined($status);
            $total += $count;
             
            # Next if user can't see this bug. So, the totals will be correct
            # and they can see there are votes 'missing', but not on what bug
            # they are. This seems a reasonable compromise; the alternative is
            # to lie in the totals.
189
            next if !Bugzilla->user->can_see_bug($id);            
190 191 192 193 194 195 196
            
            push (@bugs, { id => $id, 
                           summary => $summary,
                           count => $count,
                           opened => IsOpenedState($status) });
        }
        
197 198 199 200
        # In case we didn't populate this earlier (i.e. an error, or
        # a not logged in user viewing a users votes)
        $maxvotesperbug{$product} ||= 0;

201 202 203 204 205 206 207 208 209 210 211 212 213 214
        $onevoteonly = 1 if (min($::prodmaxvotes{$product},
                                 $maxvotesperbug{$product}) == 1);
        
        # Only add the product for display if there are any bugs in it.
        if ($#bugs > -1) {                         
            push (@products, { name => $product,
                               bugs => \@bugs,
                               onevoteonly => $onevoteonly,
                               total => $total,
                               maxvotes => $::prodmaxvotes{$product},
                               maxperbug => $maxvotesperbug{$product} });
        }
    }

215
    SendSQL("DELETE FROM votes WHERE vote_count <= 0");
216
    $dbh->bz_unlock_tables();
217 218

    $vars->{'canedit'} = $canedit;
219
    $vars->{'voting_user'} = { "login" => $name };
220
    $vars->{'products'} = \@products;
221
    $vars->{'bug_id'} = $bug_id;
222

223
    print $cgi->header();
224 225
    $template->process("bug/votes/list-for-user.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
226 227 228 229 230 231 232 233
}

# Update the user's votes in the database.
sub record_votes {
    ############################################################################
    # Begin Data/Security Validation
    ############################################################################

234
    my $cgi = Bugzilla->cgi;
235
    my $dbh = Bugzilla->dbh;
236

237 238 239
    # Build a list of bug IDs for which votes have been submitted.  Votes
    # are submitted in form fields in which the field names are the bug 
    # IDs and the field values are the number of votes.
240 241

    my @buglist = grep {/^[1-9][0-9]*$/} $cgi->param();
242 243 244 245

    # If no bugs are in the buglist, let's make sure the user gets notified
    # that their votes will get nuked if they continue.
    if (scalar(@buglist) == 0) {
246
        if (!defined $cgi->param('delete_all_votes')) {
247
            print $cgi->header();
248 249
            $template->process("bug/votes/delete-all.html.tmpl", $vars)
              || ThrowTemplateError($template->error());
250 251
            exit();
        }
252
        elsif ($cgi->param('delete_all_votes') == 0) {
253
            print $cgi->redirect("votes.cgi");
254 255 256 257 258 259 260 261 262
            exit();
        }
    }

    # Call ValidateBugID on each bug ID to make sure it is a positive
    # integer representing an existing bug that the user is authorized 
    # to access, and make sure the number of votes submitted is also
    # a non-negative integer (a series of digits not preceded by a
    # minus sign).
263
    my %votes;
264 265
    foreach my $id (@buglist) {
      ValidateBugID($id);
266 267
      $votes{$id} = $cgi->param($id);
      detaint_natural($votes{$id}) 
268
        || ThrowUserError("votes_must_be_nonnegative");
269 270 271 272 273 274 275 276
    }

    ############################################################################
    # End Data/Security Validation
    ############################################################################

    GetVersionTable();

277
    my $who = Bugzilla->user->id;
278 279 280 281

    # If the user is voting for bugs, make sure they aren't overstuffing
    # the ballot box.
    if (scalar(@buglist)) {
282
        SendSQL("SELECT bugs.bug_id, products.name, products.maxvotesperbug
283
                 FROM bugs, products
284
                 WHERE products.id = bugs.product_id
285 286 287 288 289 290 291
                   AND bugs.bug_id IN (" . join(", ", @buglist) . ")");

        my %prodcount;

        while (MoreSQLData()) {
            my ($id, $prod, $max) = FetchSQLData();
            $prodcount{$prod} ||= 0;
292
            $prodcount{$prod} += $votes{$id};
293 294
            
            # Make sure we haven't broken the votes-per-bug limit
295
            ($votes{$id} <= $max)               
296 297 298
              || ThrowUserError("too_many_votes_for_bug",
                                {max => $max, 
                                 product => $prod, 
299
                                 votes => $votes{$id}});
300 301 302 303
        }

        # Make sure we haven't broken the votes-per-product limit
        foreach my $prod (keys(%prodcount)) {
304 305 306 307 308
            ($prodcount{$prod} <= $::prodmaxvotes{$prod})
              || ThrowUserError("too_many_votes_for_product",
                                {max => $::prodmaxvotes{$prod}, 
                                 product => $prod, 
                                 votes => $prodcount{$prod}});
309 310 311 312 313 314 315 316 317 318
        }
    }

    # Update the user's votes in the database.  If the user did not submit 
    # any votes, they may be using a form with checkboxes to remove all their
    # votes (checkboxes are not submitted along with other form data when
    # they are not checked, and Bugzilla uses them to represent single votes
    # for products that only allow one vote per bug).  In that case, we still
    # need to clear the user's votes from the database.
    my %affected;
319 320 321 322 323 324 325
    $dbh->bz_lock_tables('bugs WRITE', 'bugs_activity WRITE',
             'votes WRITE', 'longdescs WRITE', 'profiles READ',
             'products READ', 'components READ', 'cc READ',
             'dependencies READ', 'groups READ', 'fielddefs READ',
             'namedqueries READ', 'whine_queries READ', 'watch READ',
             'profiles AS watchers READ', 'profiles AS watched READ',
             'user_group_map READ', 'bug_group_map READ');
326 327 328 329 330 331 332 333 334 335 336 337
    
    # Take note of, and delete the user's old votes from the database.
    SendSQL("SELECT bug_id FROM votes WHERE who = $who");
    while (MoreSQLData()) {
        my $id = FetchOneColumn();
        $affected{$id} = 1;
    }
    
    SendSQL("DELETE FROM votes WHERE who = $who");
    
    # Insert the new values in their place
    foreach my $id (@buglist) {
338
        if ($votes{$id} > 0) {
339
            SendSQL("INSERT INTO votes (who, bug_id, vote_count) 
340
                     VALUES ($who, $id, ".$votes{$id}.")");
341 342 343 344 345
        }
        $affected{$id} = 1;
    }
    
    # Update the cached values in the bugs table
346
    print $cgi->header();
347
    foreach my $id (keys %affected) {
348
        SendSQL("SELECT sum(vote_count) FROM votes WHERE bug_id = $id");
349
        my $v = FetchOneColumn() || 0;
350
        SendSQL("UPDATE bugs SET votes = $v WHERE bug_id = $id");
351 352
        my $confirmed = CheckIfVotedConfirmed($id, $who);
        $vars->{'header_done'} = 1 if $confirmed;
353 354
    }

355
    $dbh->bz_unlock_tables();
356 357 358

    $vars->{'votes_recorded'} = 1;
}