sanitycheck.cgi 35.7 KB
Newer Older
1
#!/usr/bin/perl -wT
2
# -*- Mode: perl; indent-tabs-mode: nil -*-
3
#
4 5 6 7 8 9 10 11 12 13
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
14
# The Original Code is the Bugzilla Bug Tracking System.
15
#
16
# The Initial Developer of the Original Code is Netscape Communications
17 18 19 20
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
21
# Contributor(s): Terry Weissman <terry@mozilla.org>
22
#                 Matthew Tuck <matty@chariot.net.au>
23
#                 Max Kanat-Alexander <mkanat@bugzilla.org>
24
#                 Marc Schumann <wurblzap@gmail.com>
25
#                 Frédéric Buclin <LpSolit@gmail.com>
26

27
use strict;
28

29 30
use lib qw(.);

31
use Bugzilla;
32
use Bugzilla::Constants;
33
use Bugzilla::Util;
34
use Bugzilla::Error;
35
use Bugzilla::User;
36

37 38 39
###########################################################################
# General subs
###########################################################################
40 41 42

sub Status {
    my ($str) = (@_);
43
    print "$str <p>\n";
44 45
}

46 47
sub Alert {
    my ($str) = (@_);
48
    Status("<font color=\"red\">$str</font>");
49 50
}

51 52
sub BugLink {
    my ($id) = (@_);
53
    return "<a href=\"show_bug.cgi?id=$id\">$id</a>";
54 55
}

56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72
#
# Parameter is a list of bug ids.
#
# Return is a string containing a list of all the bugids, as hrefs,
# followed by a link to them all as a buglist
sub BugListLinks {
    my @bugs = @_;

    # Historically, GetBugLink() wasn't used here. I'm guessing this
    # was because it didn't exist or is too performance heavy, or just
    # plain unnecessary
    my @bug_links = map(BugLink($_), @bugs);

    return join(', ',@bug_links) . " <a href=\"buglist.cgi?bug_id=" .
        join(',',@bugs) . "\">(as buglist)</a>";
}

73 74 75
###########################################################################
# Start
###########################################################################
76

77
Bugzilla->login(LOGIN_REQUIRED);
78

79
my $cgi = Bugzilla->cgi;
80
my $dbh = Bugzilla->dbh;
81
my $template = Bugzilla->template;
82
my $user = Bugzilla->user;
83

84 85 86
# Make sure the user is authorized to access sanitycheck.cgi.
# As this script can now alter the group_control_map table, we no longer
# let users with editbugs privs run it anymore.
87 88
$user->in_group("editcomponents")
  || ($user->in_group('editkeywords') && defined $cgi->param('rebuildkeywordcache'))
89
  || ThrowUserError("auth_failure", {group  => "editcomponents",
90 91
                                     action => "run",
                                     object => "sanity_check"});
92

93
print $cgi->header();
94

95
my @row;
96

97
$template->put_header("Sanity Check");
98

99 100 101 102 103 104 105 106 107 108
###########################################################################
# Users with 'editkeywords' privs only can only check keywords.
###########################################################################
unless ($user->in_group('editcomponents')) {
    check_votes_or_keywords('keywords');
    Status("Sanity check completed.");
    $template->put_footer();
    exit;
}

109 110 111 112
###########################################################################
# Fix vote cache
###########################################################################

113
if (defined $cgi->param('rebuildvotecache')) {
114
    Status("OK, now rebuilding vote cache.");
115
    $dbh->bz_lock_tables('bugs WRITE', 'votes READ');
116 117 118 119 120 121 122 123 124
    $dbh->do(q{UPDATE bugs SET votes = 0});
    my $sth_update = $dbh->prepare(q{UPDATE bugs 
                                        SET votes = ? 
                                      WHERE bug_id = ?});
    my $sth = $dbh->prepare(q{SELECT bug_id, SUM(vote_count)
                                FROM votes }. $dbh->sql_group_by('bug_id'));
    $sth->execute();
    while (my ($id, $v) = $sth->fetchrow_array) {
        $sth_update->execute($v, $id);
125
    }
126
    $dbh->bz_unlock_tables();
127
    Status("Vote cache has been rebuilt.");
128 129
}

130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173
###########################################################################
# Create missing group_control_map entries
###########################################################################

if (defined $cgi->param('createmissinggroupcontrolmapentries')) {
    Status(qq{OK, now creating <code>SHOWN</code> member control entries
              for product/group combinations lacking one.});

    my $na    = CONTROLMAPNA;
    my $shown = CONTROLMAPSHOWN;
    my $insertsth = $dbh->prepare(
        qq{INSERT INTO group_control_map (
                       group_id, product_id, entry,
                       membercontrol, othercontrol, canedit
                      )
               VALUES (
                       ?, ?, 0,
                       $shown, $na, 0
                      )});
    my $updatesth = $dbh->prepare(qq{UPDATE group_control_map
                                        SET membercontrol = $shown
                                      WHERE group_id   = ?
                                        AND product_id = ?});
    my $counter = 0;

    # Find all group/product combinations used for bugs but not set up
    # correctly in group_control_map
    my $invalid_combinations = $dbh->selectall_arrayref(
        qq{    SELECT bugs.product_id,
                      bgm.group_id,
                      gcm.membercontrol,
                      groups.name,
                      products.name
                 FROM bugs
           INNER JOIN bug_group_map AS bgm
                   ON bugs.bug_id = bgm.bug_id
           INNER JOIN groups
                   ON bgm.group_id = groups.id
           INNER JOIN products
                   ON bugs.product_id = products.id
            LEFT JOIN group_control_map AS gcm
                   ON bugs.product_id = gcm.product_id
                  AND    bgm.group_id = gcm.group_id
                WHERE COALESCE(gcm.membercontrol, $na) = $na
174 175
          } . $dbh->sql_group_by('bugs.product_id, bgm.group_id',
                                 'gcm.membercontrol, groups.name, products.name'));
176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199

    foreach (@$invalid_combinations) {
        my ($product_id, $group_id, $currentmembercontrol,
            $group_name, $product_name) = @$_;

        $counter++;
        if (defined($currentmembercontrol)) {
            Status(qq{Updating <code>NA/<em>xxx</em></code> group control
                      setting for group <em>$group_name</em> to
                      <code>SHOWN/<em>xxx</em></code> in product
                      <em>$product_name</em>.});
            $updatesth->execute($group_id, $product_id);
        }
        else {
            Status(qq{Generating <code>SHOWN/NA</code> group control setting
                      for group <em>$group_name</em> in product
                      <em>$product_name</em>.});
            $insertsth->execute($group_id, $product_id);
        }
    }

    Status("Repaired $counter defective group control settings.");
}

200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225
###########################################################################
# Fix missing creation date
###########################################################################

if (defined $cgi->param('repair_creation_date')) {
    Status("OK, now fixing missing bug creation dates");

    my $bug_ids = $dbh->selectcol_arrayref('SELECT bug_id FROM bugs
                                            WHERE creation_ts IS NULL');

    my $sth_UpdateDate = $dbh->prepare('UPDATE bugs SET creation_ts = ?
                                        WHERE bug_id = ?');

    # All bugs have an entry in the 'longdescs' table when they are created,
    # even if 'commentoncreate' is turned off.
    my $sth_getDate = $dbh->prepare('SELECT MIN(bug_when) FROM longdescs
                                     WHERE bug_id = ?');

    foreach my $bugid (@$bug_ids) {
        $sth_getDate->execute($bugid);
        my $date = $sth_getDate->fetchrow_array;
        $sth_UpdateDate->execute($date, $bugid);
    }
    Status(scalar(@$bug_ids) . " bugs have been fixed.");
}

226 227 228 229
###########################################################################
# Send unsent mail
###########################################################################

230
if (defined $cgi->param('rescanallBugMail')) {
231 232 233
    require Bugzilla::BugMail;

    Status("OK, now attempting to send unsent mail");
234 235 236 237 238 239 240 241 242 243 244
    my $time = $dbh->sql_interval(30, 'MINUTE');
    
    my $list = $dbh->selectcol_arrayref(qq{
                                        SELECT bug_id
                                          FROM bugs 
                                         WHERE (lastdiffed IS NULL
                                                OR lastdiffed < delta_ts)
                                           AND delta_ts < now() - $time
                                      ORDER BY bug_id});
         
    Status(scalar(@$list) . ' bugs found with possibly unsent mail.');
245 246 247 248 249 250 251 252 253 254 255

    my $vars = {};
    # We cannot simply look at the bugs_activity table to find who did the
    # last change in a given bug, as e.g. adding a comment doesn't add any
    # entry to this table. And some other changes may be private
    # (such as time-related changes or private attachments or comments)
    # and so choosing this user as being the last one having done a change
    # for the bug may be problematic. So the best we can do at this point
    # is to choose the currently logged in user for email notification.
    $vars->{'changer'} = Bugzilla->user->login;

256
    foreach my $bugid (@$list) {
257
        Bugzilla::BugMail::Send($bugid, $vars);
258 259
    }

260
    if (scalar(@$list) > 0) {
261 262 263
        Status("Unsent mail has been sent.");
    }

264
    $template->put_footer();
265 266 267
    exit;
}

268 269 270 271
###########################################################################
# Remove all references to deleted bugs
###########################################################################

272
if (defined $cgi->param('remove_invalid_bug_references')) {
273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302
    Status("OK, now removing all references to deleted bugs.");

    $dbh->bz_lock_tables('attachments WRITE', 'bug_group_map WRITE',
                         'bugs_activity WRITE', 'cc WRITE',
                         'dependencies WRITE', 'duplicates WRITE',
                         'flags WRITE', 'keywords WRITE',
                         'longdescs WRITE', 'votes WRITE', 'bugs READ');

    foreach my $pair ('attachments/', 'bug_group_map/', 'bugs_activity/', 'cc/',
                      'dependencies/blocked', 'dependencies/dependson',
                      'duplicates/dupe', 'duplicates/dupe_of',
                      'flags/', 'keywords/', 'longdescs/', 'votes/') {

        my ($table, $field) = split('/', $pair);
        $field ||= "bug_id";

        my $bug_ids =
          $dbh->selectcol_arrayref("SELECT $table.$field FROM $table
                                    LEFT JOIN bugs ON $table.$field = bugs.bug_id
                                    WHERE bugs.bug_id IS NULL");

        if (scalar(@$bug_ids)) {
            $dbh->do("DELETE FROM $table WHERE $field IN (" . join(',', @$bug_ids) . ")");
        }
    }

    $dbh->bz_unlock_tables();
    Status("All references to deleted bugs have been removed.");
}

303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326
###########################################################################
# Remove all references to deleted attachments
###########################################################################

if (defined $cgi->param('remove_invalid_attach_references')) {
    Status("OK, now removing all references to deleted attachments.");

    $dbh->bz_lock_tables('attachments WRITE', 'attach_data WRITE');

    my $attach_ids =
        $dbh->selectcol_arrayref('SELECT attach_data.id
                                    FROM attach_data
                               LEFT JOIN attachments
                                      ON attachments.attach_id = attach_data.id
                                   WHERE attachments.attach_id IS NULL');

    if (scalar(@$attach_ids)) {
        $dbh->do('DELETE FROM attach_data WHERE id IN (' .
                 join(',', @$attach_ids) . ')');
    }

    $dbh->bz_unlock_tables();
    Status("All references to deleted attachments have been removed.");
}
327

328
print "OK, now running sanity checks.<p>\n";
329

330 331 332 333
###########################################################################
# Perform referential (cross) checks
###########################################################################

334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349
# This checks that a simple foreign key has a valid primary key value.  NULL
# references are acceptable and cause no problem.
#
# The first parameter is the primary key table name.
# The second parameter is the primary key field name.
# Each successive parameter represents a foreign key, it must be a list
# reference, where the list has:
#   the first value is the foreign key table name.
#   the second value is the foreign key field name.
#   the third value is optional and represents a field on the foreign key
#     table to display when the check fails.
#   the fourth value is optional and is a list reference to values that
#     are excluded from checking.
#
# FIXME: The excluded values parameter should go away - the QA contact
#        fields should use NULL instead - see bug #109474.
350
#        The same goes for series; no bug for that yet.
351

352 353 354
sub CrossCheck {
    my $table = shift @_;
    my $field = shift @_;
355
    my $dbh = Bugzilla->dbh;
356 357 358 359 360 361 362 363 364 365 366

    Status("Checking references to $table.$field");

    while (@_) {
        my $ref = shift @_;
        my ($refertable, $referfield, $keyname, $exceptions) = @$ref;

        $exceptions ||= [];
        my %exceptions = map { $_ => 1 } @$exceptions;

        Status("... from $refertable.$referfield");
367 368 369 370 371 372 373 374 375 376 377
       
        my $query = qq{SELECT DISTINCT $refertable.$referfield} .
            ($keyname ? qq{, $refertable.$keyname } : q{}) .
                     qq{ FROM $refertable
                    LEFT JOIN $table
                           ON $refertable.$referfield = $table.$field
                        WHERE $table.$field IS NULL
                          AND $refertable.$referfield IS NOT NULL};
         
        my $sth = $dbh->prepare($query);
        $sth->execute;
378

379
        my $has_bad_references = 0;
380 381 382 383 384 385 386 387 388

        while (my ($value, $key) = $sth->fetchrow_array) {
            next if $exceptions{$value};
            my $alert = "Bad value &quot;$value&quot; found in $refertable.$referfield";
            if ($keyname) {
                if ($keyname eq 'bug_id') {
                    $alert .= ' (bug ' . BugLink($key) . ')';
                } else {
                    $alert .= " ($keyname == '$key')";
389 390
                }
            }
391 392
            Alert($alert);
            $has_bad_references = 1;
393
        }
394 395
        # References to non existent bugs can be safely removed, bug 288461
        if ($table eq 'bugs' && $has_bad_references) {
396 397 398 399 400 401 402
            print qq{<a href="sanitycheck.cgi?remove_invalid_bug_references=1">
                     Remove invalid references to non existent bugs.</a><p>\n};
        }
        # References to non existent attachments can be safely removed.
        if ($table eq 'attachments' && $has_bad_references) {
            print qq{<a href="sanitycheck.cgi?remove_invalid_attach_references=1">
                     Remove invalid references to non existent attachments.</a><p>\n};
403
        }
404 405 406
    }
}

407 408 409
CrossCheck('classifications', 'id',
           ['products', 'classification_id']);

410 411 412
CrossCheck("keyworddefs", "id",
           ["keywords", "keywordid"]);

413
CrossCheck("fielddefs", "id",
414 415
           ["bugs_activity", "fieldid"],
           ['profiles_activity', 'fieldid']);
416

417 418
CrossCheck("flagtypes", "id",
           ["flags", "type_id"]);
419 420 421

CrossCheck("bugs", "bug_id",
           ["bugs_activity", "bug_id"],
422
           ["bug_group_map", "bug_id"],
423 424 425 426 427
           ["attachments", "bug_id"],
           ["cc", "bug_id"],
           ["longdescs", "bug_id"],
           ["dependencies", "blocked"],
           ["dependencies", "dependson"],
428
           ['flags', 'bug_id'],
429
           ["votes", "bug_id"],
430 431 432
           ["keywords", "bug_id"],
           ["duplicates", "dupe_of", "dupe"],
           ["duplicates", "dupe", "dupe_of"]);
433

434 435
CrossCheck("groups", "id",
           ["bug_group_map", "group_id"],
436
           ['category_group_map', 'group_id'],
437 438
           ["group_group_map", "grantor_id"],
           ["group_group_map", "member_id"],
439
           ["group_control_map", "group_id"],
440
           ["namedquery_group_map", "group_id"],
441 442
           ["user_group_map", "group_id"]);

443 444 445 446 447
CrossCheck("namedqueries", "id",
           ["namedqueries_link_in_footer", "namedquery_id"],
           ["namedquery_group_map", "namedquery_id"],
          );

448
CrossCheck("profiles", "userid",
449 450
           ['profiles_activity', 'userid'],
           ['profiles_activity', 'who'],
451 452
           ['email_setting', 'user_id'],
           ['profile_setting', 'user_id'],
453 454
           ["bugs", "reporter", "bug_id"],
           ["bugs", "assigned_to", "bug_id"],
455
           ["bugs", "qa_contact", "bug_id"],
456
           ["attachments", "submitter_id", "bug_id"],
457 458
           ['flags', 'setter_id', 'bug_id'],
           ['flags', 'requestee_id', 'bug_id'],
459 460
           ["bugs_activity", "who", "bug_id"],
           ["cc", "who", "bug_id"],
461
           ['quips', 'userid'],
462 463
           ["votes", "who", "bug_id"],
           ["longdescs", "who", "bug_id"],
464
           ["logincookies", "userid"],
465
           ["namedqueries", "userid"],
466
           ["namedqueries_link_in_footer", "user_id"],
467
           ['series', 'creator', 'series_id'],
468 469
           ["watch", "watcher"],
           ["watch", "watched"],
470
           ['whine_events', 'owner_userid'],
471
           ["tokens", "userid"],
472
           ["user_group_map", "user_id"],
473
           ["components", "initialowner", "name"],
474
           ["components", "initialqacontact", "name"]);
475

476 477 478 479 480
CrossCheck("products", "id",
           ["bugs", "product_id", "bug_id"],
           ["components", "product_id", "name"],
           ["milestones", "product_id", "value"],
           ["versions", "product_id", "value"],
481
           ["group_control_map", "product_id"],
482 483
           ["flaginclusions", "product_id", "type_id"],
           ["flagexclusions", "product_id", "type_id"]);
484

485
# Check the former enum types -mkanat@bugzilla.org
486
CrossCheck("bug_status", "value",
487
            ["bugs", "bug_status", "bug_id"]);
488 489

CrossCheck("resolution", "value",
490
            ["bugs", "resolution", "bug_id"]);
491 492

CrossCheck("bug_severity", "value",
493
            ["bugs", "bug_severity", "bug_id"]);
494 495

CrossCheck("op_sys", "value",
496
            ["bugs", "op_sys", "bug_id"]);
497 498

CrossCheck("priority", "value",
499
            ["bugs", "priority", "bug_id"]);
500 501

CrossCheck("rep_platform", "value",
502
            ["bugs", "rep_platform", "bug_id"]);
503

504 505 506 507 508 509 510 511 512 513
CrossCheck('series', 'series_id',
           ['series_data', 'series_id']);

CrossCheck('series_categories', 'id',
           ['series', 'category']);

CrossCheck('whine_events', 'id',
           ['whine_queries', 'eventid'],
           ['whine_schedules', 'eventid']);

514 515 516
CrossCheck('attachments', 'attach_id',
           ['attach_data', 'id']);

517
###########################################################################
518
# Perform double field referential (cross) checks
519
###########################################################################
520
 
521 522 523 524 525 526 527 528 529 530 531 532 533 534
# This checks that a compound two-field foreign key has a valid primary key
# value.  NULL references are acceptable and cause no problem.
#
# The first parameter is the primary key table name.
# The second parameter is the primary key first field name.
# The third parameter is the primary key second field name.
# Each successive parameter represents a foreign key, it must be a list
# reference, where the list has:
#   the first value is the foreign key table name
#   the second value is the foreign key first field name.
#   the third value is the foreign key second field name.
#   the fourth value is optional and represents a field on the foreign key
#     table to display when the check fails

535 536 537 538
sub DoubleCrossCheck {
    my $table = shift @_;
    my $field1 = shift @_;
    my $field2 = shift @_;
539
    my $dbh = Bugzilla->dbh;
540 541 542 543 544 545 546 547
 
    Status("Checking references to $table.$field1 / $table.$field2");
 
    while (@_) {
        my $ref = shift @_;
        my ($refertable, $referfield1, $referfield2, $keyname) = @$ref;
 
        Status("... from $refertable.$referfield1 / $refertable.$referfield2");
548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563

        my $d_cross_check = $dbh->selectall_arrayref(qq{
                        SELECT DISTINCT $refertable.$referfield1, 
                                        $refertable.$referfield2 } .
                       ($keyname ? qq{, $refertable.$keyname } : q{}) .
                      qq{ FROM $refertable
                     LEFT JOIN $table
                            ON $refertable.$referfield1 = $table.$field1
                           AND $refertable.$referfield2 = $table.$field2 
                         WHERE $table.$field1 IS NULL 
                           AND $table.$field2 IS NULL 
                           AND $refertable.$referfield1 IS NOT NULL 
                           AND $refertable.$referfield2 IS NOT NULL});

        foreach my $check (@$d_cross_check) {
            my ($value1, $value2, $key) = @$check;
564
            my $alert = "Bad values &quot;$value1&quot;, &quot;$value2&quot; found in " .
565 566 567 568 569 570 571 572 573 574 575
                "$refertable.$referfield1 / $refertable.$referfield2";
            if ($keyname) {
                if ($keyname eq 'bug_id') {
                   $alert .= ' (bug ' . BugLink($key) . ')';
                }
                else {
                    $alert .= " ($keyname == '$key')";
                }
            }
            Alert($alert);
        }
576 577 578
    }
}

579 580 581 582
DoubleCrossCheck('attachments', 'bug_id', 'attach_id',
                 ['flags', 'bug_id', 'attach_id'],
                 ['bugs_activity', 'bug_id', 'attach_id']);

583
DoubleCrossCheck("components", "product_id", "id",
584 585 586
                 ["bugs", "product_id", "component_id", "bug_id"],
                 ['flagexclusions', 'product_id', 'component_id'],
                 ['flaginclusions', 'product_id', 'component_id']);
587

588 589 590 591 592 593
DoubleCrossCheck("versions", "product_id", "value",
                 ["bugs", "product_id", "version", "bug_id"]);
 
DoubleCrossCheck("milestones", "product_id", "value",
                 ["bugs", "product_id", "target_milestone", "bug_id"],
                 ["products", "id", "defaultmilestone", "name"]);
594

595 596 597 598
###########################################################################
# Perform login checks
###########################################################################
 
599
Status("Checking profile logins");
600

601 602
my $sth = $dbh->prepare(q{SELECT userid, login_name FROM profiles});
$sth->execute;
603

604
while (my ($id, $email) = $sth->fetchrow_array) {
605 606
    validate_email_syntax($email)
      || Alert "Bad profile email address, id=$id,  &lt;$email&gt;.";
607
}
608

609 610 611
###########################################################################
# Perform vote/keyword cache checks
###########################################################################
612

613 614 615 616 617
sub AlertBadVoteCache {
    my ($id) = (@_);
    Alert("Bad vote cache for bug " . BugLink($id));
}

618
check_votes_or_keywords();
619

620 621
sub check_votes_or_keywords {
    my $check = shift || 'all';
622

623 624 625 626 627
    my $dbh = Bugzilla->dbh;
    my $sth = $dbh->prepare(q{SELECT bug_id, votes, keywords
                                FROM bugs
                               WHERE votes != 0 OR keywords != ''});
    $sth->execute;
628

629 630
    my %votes;
    my %keyword;
631

632 633 634 635 636 637
    while (my ($id, $v, $k) = $sth->fetchrow_array) {
        if ($v != 0) {
            $votes{$id} = $v;
        }
        if ($k) {
            $keyword{$id} = $k;
638 639
        }
    }
640

641 642 643 644
    # If we only want to check keywords, skip checks about votes.
    _check_votes(\%votes) unless ($check eq 'keywords');
    # If we only want to check votes, skip checks about keywords.
    _check_keywords(\%keyword) unless ($check eq 'votes');
645 646
}

647 648
sub _check_votes {
    my $votes = shift;
649

650 651 652 653 654 655
    Status("Checking cached vote counts");
    my $dbh = Bugzilla->dbh;
    my $sth = $dbh->prepare(q{SELECT bug_id, SUM(vote_count)
                                FROM votes }.
                                $dbh->sql_group_by('bug_id'));
    $sth->execute;
656

657
    my $offer_votecache_rebuild = 0;
658

659 660 661 662 663 664 665 666 667 668
    while (my ($id, $v) = $sth->fetchrow_array) {
        if ($v <= 0) {
            Alert("Bad vote sum for bug $id");
        } else {
            if (!defined $votes->{$id} || $votes->{$id} != $v) {
                AlertBadVoteCache($id);
                $offer_votecache_rebuild = 1;
            }
            delete $votes->{$id};
        }
669
    }
670 671 672
    foreach my $id (keys %$votes) {
        AlertBadVoteCache($id);
        $offer_votecache_rebuild = 1;
673 674
    }

675 676
    if ($offer_votecache_rebuild) {
        print qq{<a href="sanitycheck.cgi?rebuildvotecache=1">Click here to rebuild the vote cache</a><p>\n};
677 678 679
    }
}

680 681
sub _check_keywords {
    my $keyword = shift;
682

683 684 685
    Status("Checking keywords table");
    my $dbh = Bugzilla->dbh;
    my $cgi = Bugzilla->cgi;
686

687 688 689
    my %keywordids;
    my $keywords = $dbh->selectall_arrayref(q{SELECT id, name
                                                FROM keyworddefs});
690

691 692 693 694 695 696 697 698 699 700
    foreach (@$keywords) {
        my ($id, $name) = @$_;
        if ($keywordids{$id}) {
            Alert("Duplicate entry in keyworddefs for id $id");
        }
        $keywordids{$id} = 1;
        if ($name =~ /[\s,]/) {
            Alert("Bogus name in keyworddefs for id $id");
        }
    }
701

702 703 704 705 706 707 708 709 710
    my $sth = $dbh->prepare(q{SELECT bug_id, keywordid
                                FROM keywords
                            ORDER BY bug_id, keywordid});
    $sth->execute;
    my $lastid;
    my $lastk;
    while (my ($id, $k) = $sth->fetchrow_array) {
        if (!$keywordids{$k}) {
            Alert("Bogus keywordids $k found in keywords table");
711
        }
712 713
        if (defined $lastid && $id eq $lastid && $k eq $lastk) {
            Alert("Duplicate keyword ids found in bug " . BugLink($id));
714
        }
715 716
        $lastid = $id;
        $lastk = $k;
717 718
    }

719
    Status("Checking cached keywords");
720

721 722
    if (defined $cgi->param('rebuildkeywordcache')) {
        $dbh->bz_lock_tables('bugs write', 'keywords read', 'keyworddefs read');
723
    }
724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750

    my $query = q{SELECT keywords.bug_id, keyworddefs.name
                    FROM keywords
              INNER JOIN keyworddefs
                      ON keyworddefs.id = keywords.keywordid
              INNER JOIN bugs
                      ON keywords.bug_id = bugs.bug_id
                ORDER BY keywords.bug_id, keyworddefs.name};

    $sth = $dbh->prepare($query);
    $sth->execute;

    my $lastb = 0;
    my @list;
    my %realk;
    while (1) {
        my ($b, $k) = $sth->fetchrow_array;
        if (!defined $b || $b != $lastb) {
            if (@list) {
                $realk{$lastb} = join(', ', @list);
            }
            last unless $b;

            $lastb = $b;
            @list = ();
        }
        push(@list, $k);
751
    }
752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781

    my @badbugs = ();

    foreach my $b (keys(%$keyword)) {
        if (!exists $realk{$b} || $realk{$b} ne $keyword->{$b}) {
            push(@badbugs, $b);
        }
    }
    foreach my $b (keys(%realk)) {
        if (!exists $keyword->{$b}) {
            push(@badbugs, $b);
        }
    }
    if (@badbugs) {
        @badbugs = sort {$a <=> $b} @badbugs;
        Alert(scalar(@badbugs) . " bug(s) found with incorrect keyword cache: " .
              BugListLinks(@badbugs));

        my $sth_update = $dbh->prepare(q{UPDATE bugs
                                            SET keywords = ?
                                          WHERE bug_id = ?});

        if (defined $cgi->param('rebuildkeywordcache')) {
            Status("OK, now fixing keyword cache.");
            foreach my $b (@badbugs) {
                my $k = '';
                if (exists($realk{$b})) {
                    $k = $realk{$b};
                }
                $sth_update->execute($k, $b);
782
            }
783 784 785
            Status("Keyword cache fixed.");
        } else {
            print qq{<a href="sanitycheck.cgi?rebuildkeywordcache=1">Click here to rebuild the keyword cache</a><p>\n};
786 787 788
        }
    }

789 790 791
    if (defined $cgi->param('rebuildkeywordcache')) {
        $dbh->bz_unlock_tables();
    }
792
}
793

794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845
###########################################################################
# Check for flags being in incorrect products and components
###########################################################################

Status('Checking for flags being in the wrong product/component');

my $invalid_flags = $dbh->selectall_arrayref(
       'SELECT DISTINCT flags.id, flags.bug_id, flags.attach_id
          FROM flags
    INNER JOIN bugs
            ON flags.bug_id = bugs.bug_id
     LEFT JOIN flaginclusions AS i
            ON flags.type_id = i.type_id
           AND (bugs.product_id = i.product_id OR i.product_id IS NULL)
           AND (bugs.component_id = i.component_id OR i.component_id IS NULL)
         WHERE i.type_id IS NULL');

my @invalid_flags = @$invalid_flags;

$invalid_flags = $dbh->selectall_arrayref(
       'SELECT DISTINCT flags.id, flags.bug_id, flags.attach_id
          FROM flags
    INNER JOIN bugs
            ON flags.bug_id = bugs.bug_id
    INNER JOIN flagexclusions AS e
            ON flags.type_id = e.type_id
         WHERE (bugs.product_id = e.product_id OR e.product_id IS NULL)
           AND (bugs.component_id = e.component_id OR e.component_id IS NULL)');

push(@invalid_flags, @$invalid_flags);

if (scalar(@invalid_flags)) {
    if ($cgi->param('remove_invalid_flags')) {
        Status("OK, now deleting invalid flags.");
        my @flag_ids = map {$_->[0]} @invalid_flags;
        $dbh->bz_lock_tables('flags WRITE');
        # Silently delete these flags, with no notification to requesters/setters.
        $dbh->do('DELETE FROM flags WHERE id IN (' . join(',', @flag_ids) .')');
        $dbh->bz_unlock_tables();
        Status("Invalid flags deleted.");
    }
    else {
        foreach my $flag (@$invalid_flags) {
            my ($flag_id, $bug_id, $attach_id) = @$flag;
            Alert("Invalid flag $flag_id for " .
                  ($attach_id ? "attachment $attach_id in bug " : "bug ") . BugLink($bug_id));
        }
        print qq{<a href="sanitycheck.cgi?remove_invalid_flags=1">Click
                 here to delete invalid flags</a><p>\n};
    }
}

846
###########################################################################
847
# General bug checks
848 849
###########################################################################

850
sub BugCheck {
851
    my ($middlesql, $errortext, $repairparam, $repairtext) = @_;
852
    my $dbh = Bugzilla->dbh;
853 854 855 856
 
    my $badbugs = $dbh->selectcol_arrayref(qq{SELECT DISTINCT bugs.bug_id
                                                FROM $middlesql 
                                            ORDER BY bugs.bug_id});
857

858 859
    if (scalar(@$badbugs)) {
        Alert("$errortext: " . BugListLinks(@$badbugs));
860 861 862 863 864
        if ($repairparam) {
            $repairtext ||= 'Repair these bugs';
            print qq{<a href="sanitycheck.cgi?$repairparam=1">$repairtext</a>.},
                  '<p>';
        }
865
    }
866 867
}

868 869 870 871 872
Status("Checking for bugs with no creation date (which makes them invisible)");

BugCheck("bugs WHERE creation_ts IS NULL", "Bugs with no creation date",
         "repair_creation_date", "Repair missing creation date for these bugs");

873
Status("Checking resolution/duplicates");
874

875 876
BugCheck("bugs INNER JOIN duplicates ON bugs.bug_id = duplicates.dupe " .
         "WHERE bugs.resolution != 'DUPLICATE'",
877
         "Bug(s) found on duplicates table that are not marked duplicate");
878

879 880 881 882
BugCheck("bugs LEFT JOIN duplicates ON bugs.bug_id = duplicates.dupe WHERE " .
         "bugs.resolution = 'DUPLICATE' AND " .
         "duplicates.dupe IS NULL",
         "Bug(s) found marked resolved duplicate and not on duplicates table");
883 884 885

Status("Checking statuses/resolutions");

886
my @open_states = map($dbh->quote($_), BUG_STATE_OPEN);
887 888
my $open_states = join(', ', @open_states);

889 890 891 892
BugCheck("bugs WHERE bug_status IN ($open_states) AND resolution != ''",
         "Bugs with open status and a resolution");
BugCheck("bugs WHERE bug_status NOT IN ($open_states) AND resolution = ''",
         "Bugs with non-open status and no resolution");
893 894 895

Status("Checking statuses/everconfirmed");

896
BugCheck("bugs WHERE bug_status = 'UNCONFIRMED' AND everconfirmed = 1",
897 898 899
         "Bugs that are UNCONFIRMED but have everconfirmed set");
# The below list of resolutions is hardcoded because we don't know if future
# resolutions will be confirmed, unconfirmed or maybeconfirmed.  I suspect
900
# they will be maybeconfirmed, e.g. ASLEEP and REMIND.  This hardcoding should
901 902 903
# disappear when we have customised statuses.
BugCheck("bugs WHERE bug_status IN ('NEW', 'ASSIGNED', 'REOPENED') AND everconfirmed = 0",
         "Bugs with confirmed status but don't have everconfirmed set"); 
904 905 906

Status("Checking votes/everconfirmed");

907 908
BugCheck("bugs INNER JOIN products ON bugs.product_id = products.id " .
         "WHERE everconfirmed = 0 AND votestoconfirm <= votes",
909
         "Bugs that have enough votes to be confirmed but haven't been");
910

911 912 913 914 915 916 917
###########################################################################
# Control Values
###########################################################################

# Checks for values that are invalid OR
# not among the 9 valid combinations
Status("Checking for bad values in group_control_map");
918 919
my $groups = join(", ", (CONTROLMAPNA, CONTROLMAPSHOWN, CONTROLMAPDEFAULT,
CONTROLMAPMANDATORY));
920
my $query = qq{
921 922 923 924 925 926 927 928 929 930
     SELECT COUNT(product_id) 
       FROM group_control_map 
      WHERE membercontrol NOT IN( $groups )
         OR othercontrol NOT IN( $groups )
         OR ((membercontrol != othercontrol)
             AND (membercontrol != } . CONTROLMAPSHOWN . q{)
             AND ((membercontrol != } . CONTROLMAPDEFAULT . q{)
                  OR (othercontrol = } . CONTROLMAPSHOWN . q{)))};
                  
my $c = $dbh->selectrow_array($query);
931 932 933 934 935
if ($c) {
    Alert("Found $c bad group_control_map entries");
}

Status("Checking for bugs with groups violating their product's group controls");
936
BugCheck("bugs
937 938 939 940
         INNER JOIN bug_group_map
            ON bugs.bug_id = bug_group_map.bug_id
          LEFT JOIN group_control_map
            ON bugs.product_id = group_control_map.product_id
941
           AND bug_group_map.group_id = group_control_map.group_id
942
         WHERE ((group_control_map.membercontrol = " . CONTROLMAPNA . ")
943
         OR (group_control_map.membercontrol IS NULL))",
944 945 946 947
         'Have groups not permitted for their products',
         'createmissinggroupcontrolmapentries',
         'Permit the missing groups for the affected products
          (set member control to <code>SHOWN</code>)');
948

949
BugCheck("bugs
950
         INNER JOIN group_control_map
951
            ON bugs.product_id = group_control_map.product_id
952 953 954 955 956
         INNER JOIN groups
            ON group_control_map.group_id = groups.id
          LEFT JOIN bug_group_map
            ON bugs.bug_id = bug_group_map.bug_id
           AND group_control_map.group_id = bug_group_map.group_id
957
         WHERE group_control_map.membercontrol = " . CONTROLMAPMANDATORY . "
958 959
           AND bug_group_map.group_id IS NULL
           AND groups.isactive != 0",
960 961 962
         "Are missing groups required for their products");


963 964 965 966 967 968
###########################################################################
# Unsent mail
###########################################################################

Status("Checking for unsent mail");

969 970 971 972 973 974 975
my $time = $dbh->sql_interval(30, 'MINUTE');
my $badbugs = $dbh->selectcol_arrayref(qq{
                    SELECT bug_id 
                      FROM bugs 
                     WHERE (lastdiffed IS NULL OR lastdiffed < delta_ts)
                       AND delta_ts < now() - $time
                  ORDER BY bug_id});
976 977


978
if (scalar(@$badbugs > 0)) {
979
    Alert("Bugs that have changes but no mail sent for at least half an hour: " .
980
          BugListLinks(@$badbugs));
981

982
    print qq{<a href="sanitycheck.cgi?rescanallBugMail=1">Send these mails</a>.<p>\n};
983 984
}

985 986 987
###########################################################################
# End
###########################################################################
988 989

Status("Sanity check completed.");
990
$template->put_footer();