attachment.cgi 28.6 KB
Newer Older
1
#!/usr/bin/perl -wT
2 3 4
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
5
#
6 7
# This Source Code Form is "Incompatible With Secondary Licenses", as
# defined by the Mozilla Public License, v. 2.0.
8 9 10 11 12 13 14 15

################################################################################
# Script Initialization
################################################################################

# Make it harder for us to do dangerous things in Perl.
use strict;

16
use lib qw(. lib);
17

18
use Bugzilla;
19
use Bugzilla::BugMail;
20
use Bugzilla::Constants;
21
use Bugzilla::Error;
22 23
use Bugzilla::Flag; 
use Bugzilla::FlagType; 
24
use Bugzilla::User;
25
use Bugzilla::Util;
26
use Bugzilla::Bug;
27
use Bugzilla::Field;
28
use Bugzilla::Attachment;
29
use Bugzilla::Attachment::PatchReader;
30
use Bugzilla::Token;
31
use Bugzilla::Keyword;
32

33
use Encode qw(encode find_encoding);
34

35 36 37 38 39 40 41
# For most scripts we don't make $cgi and $template global variables. But
# when preparing Bugzilla for mod_perl, this script used these
# variables in so many subroutines that it was easier to just
# make them globals.
local our $cgi = Bugzilla->cgi;
local our $template = Bugzilla->template;
local our $vars = {};
42

43 44 45 46
################################################################################
# Main Body Execution
################################################################################

47 48 49 50
# All calls to this script should contain an "action" variable whose
# value determines what the user wants to do.  The code below checks
# the value of that variable and runs the appropriate code. If none is
# supplied, we default to 'view'.
51 52

# Determine whether to use the action specified by the user or the default.
53
my $action = $cgi->param('action') || 'view';
54
my $format = $cgi->param('format') || '';
55

56
# You must use the appropriate urlbase/sslbase param when doing anything
57 58 59 60
# but viewing an attachment, or a raw diff.
if ($action ne 'view'
    && (($action !~ /^(?:interdiff|diff)$/) || $format ne 'raw'))
{
61 62
    do_ssl_redirect_if_required();
    if ($cgi->url_is_attachment_base) {
63 64 65 66 67 68 69 70
        $cgi->redirect_to_urlbase;
    }
    Bugzilla->login();
}

# When viewing an attachment, do not request credentials if we are on
# the alternate host. Let view() decide when to call Bugzilla->login.
if ($action eq "view")
71
{
72
    view();
73
}
74 75
elsif ($action eq "interdiff")
{
76
    interdiff();
77 78 79
}
elsif ($action eq "diff")
{
80
    diff();
81
}
82 83
elsif ($action eq "viewall") 
{ 
84
    viewall(); 
85
}
86 87
elsif ($action eq "enter") 
{ 
88 89
    Bugzilla->login(LOGIN_REQUIRED);
    enter(); 
90 91 92
}
elsif ($action eq "insert")
{
93 94
    Bugzilla->login(LOGIN_REQUIRED);
    insert();
95
}
96 97
elsif ($action eq "edit") 
{ 
98
    edit(); 
99 100 101
}
elsif ($action eq "update") 
{ 
102 103
    Bugzilla->login(LOGIN_REQUIRED);
    update();
104
}
105 106 107
elsif ($action eq "delete") {
    delete_attachment();
}
108 109
else 
{ 
110
  ThrowUserError('unknown_action', {action => $action});
111 112 113 114 115 116 117 118
}

exit;

################################################################################
# Data Validation / Security Authorization
################################################################################

119 120 121
# Validates an attachment ID. Optionally takes a parameter of a form
# variable name that contains the ID to be validated. If not specified,
# uses 'id'.
122 123
# If the second parameter is true, the attachment ID will be validated,
# however the current user's access to the attachment will not be checked.
124 125 126 127
# Will throw an error if 1) attachment ID is not a valid number,
# 2) attachment does not exist, or 3) user isn't allowed to access the
# attachment.
#
128 129 130
# Returns an attachment object.

sub validateID {
131 132
    my($param, $dont_validate_access) = @_;
    $param ||= 'id';
133

134 135 136
    # If we're not doing interdiffs, check if id wasn't specified and
    # prompt them with a page that allows them to choose an attachment.
    # Happens when calling plain attachment.cgi from the urlbar directly
137
    if ($param eq 'id' && !$cgi->param('id')) {
138
        print $cgi->header();
139 140 141 142
        $template->process("attachment/choose.html.tmpl", $vars) ||
            ThrowTemplateError($template->error());
        exit;
    }
143
    
144 145 146 147 148 149
    my $attach_id = $cgi->param($param);

    # Validate the specified attachment id. detaint kills $attach_id if
    # non-natural, so use the original value from $cgi in our exception
    # message here.
    detaint_natural($attach_id)
150 151
        || ThrowUserError("invalid_attach_id",
                          { attach_id => scalar $cgi->param($param) });
152
  
153
    # Make sure the attachment exists in the database.
154
    my $attachment = new Bugzilla::Attachment($attach_id)
155
        || ThrowUserError("invalid_attach_id", { attach_id => $attach_id });
156

157 158 159 160 161 162 163 164
    return $attachment if ($dont_validate_access || check_can_access($attachment));
}

# Make sure the current user has access to the specified attachment.
sub check_can_access {
    my $attachment = shift;
    my $user = Bugzilla->user;

165
    # Make sure the user is authorized to access this attachment's bug.
166 167 168 169
    Bugzilla::Bug->check($attachment->bug_id);
    if ($attachment->isprivate && $user->id != $attachment->attacher->id 
        && !$user->is_insider) 
    {
170
        ThrowUserError('auth_failure', {action => 'access',
171 172
                                        object => 'attachment',
                                        attach_id => $attachment->id});
173
    }
174 175 176 177 178 179 180 181 182 183 184 185 186
    return 1;
}

# Determines if the attachment is public -- that is, if users who are
# not logged in have access to the attachment
sub attachmentIsPublic {
    my $attachment = shift;

    return 0 if Bugzilla->params->{'requirelogin'};
    return 0 if $attachment->isprivate;

    my $anon_user = new Bugzilla::User;
    return $anon_user->can_see_bug($attachment->bug_id);
187 188
}

189 190 191
# Validates format of a diff/interdiff. Takes a list as an parameter, which
# defines the valid format values. Will throw an error if the format is not
# in the list. Returns either the user selected or default format.
192
sub validateFormat {
193 194
  # receives a list of legal formats; first item is a default
  my $format = $cgi->param('format') || $_[0];
195
  if (not grep($_ eq $format, @_)) {
196
     ThrowUserError("invalid_format", { format  => $format, formats => \@_ });
197
  }
198

199
  return $format;
200 201
}

202 203
# Validates context of a diff/interdiff. Will throw an error if the context
# is not number, "file" or "patch". Returns the validated, detainted context.
204 205
sub validateContext
{
206 207 208 209
  my $context = $cgi->param('context') || "patch";
  if ($context ne "file" && $context ne "patch") {
    detaint_natural($context)
      || ThrowUserError("invalid_context", { context => $cgi->param('context') });
210
  }
211 212

  return $context;
213 214
}

215 216 217 218
# Gets the attachment object(s) generated by validateID, while ensuring
# attachbase and token authentication is used when required.
sub get_attachment {
    my @field_names = @_ ? @_ : qw(id);
219

220
    my %attachments;
221 222

    if (use_attachbase()) {
223 224 225 226 227 228 229 230 231 232
        # Load each attachment, and ensure they are all from the same bug
        my $bug_id = 0;
        foreach my $field_name (@field_names) {
            my $attachment = validateID($field_name, 1);
            if (!$bug_id) {
                $bug_id = $attachment->bug_id;
            } elsif ($attachment->bug_id != $bug_id) {
                ThrowUserError('attachment_bug_id_mismatch');
            }
            $attachments{$field_name} = $attachment;
233
        }
234 235 236 237 238
        my @args = map { $_ . '=' . $attachments{$_}->id } @field_names;
        my $cgi_params = $cgi->canonicalise_query(@field_names, 't',
            'Bugzilla_login', 'Bugzilla_password');
        push(@args, $cgi_params) if $cgi_params;
        my $path = 'attachment.cgi?' . join('&', @args);
239 240

        # Make sure the attachment is served from the correct server.
241 242 243
        if ($cgi->url_is_attachment_base($bug_id)) {
            # No need to validate the token for public attachments. We cannot request
            # credentials as we are on the alternate host.
244
            if (!all_attachments_are_public(\%attachments)) {
245
                my $token = $cgi->param('t');
246 247 248 249 250 251 252 253 254 255 256 257 258 259
                my ($userid, undef, $token_data) = Bugzilla::Token::GetTokenData($token);
                my %token_data = unpack_token_data($token_data);
                my $valid_token = 1;
                foreach my $field_name (@field_names) {
                    my $token_id = $token_data{$field_name};
                    if (!$token_id
                        || !detaint_natural($token_id)
                        || $attachments{$field_name}->id != $token_id)
                    {
                        $valid_token = 0;
                        last;
                    }
                }
                unless ($userid && $valid_token) {
260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277
                    # Not a valid token.
                    print $cgi->redirect('-location' => correct_urlbase() . $path);
                    exit;
                }
                # Change current user without creating cookies.
                Bugzilla->set_user(new Bugzilla::User($userid));
                # Tokens are single use only, delete it.
                delete_token($token);
            }
        }
        elsif ($cgi->url_is_attachment_base) {
            # If we come here, this means that each bug has its own host
            # for attachments, and that we are trying to view one attachment
            # using another bug's host. That's not desired.
            $cgi->redirect_to_urlbase;
        }
        else {
            # We couldn't call Bugzilla->login earlier as we first had to
278 279
            # make sure we were not going to request credentials on the
            # alternate host.
280
            Bugzilla->login();
281 282 283 284
            my $attachbase = Bugzilla->params->{'attachment_base'};
            # Replace %bugid% by the ID of the bug the attachment 
            # belongs to, if present.
            $attachbase =~ s/\%bugid\%/$bug_id/;
285
            if (all_attachments_are_public(\%attachments)) {
286 287 288 289 290
                # No need for a token; redirect to attachment base.
                print $cgi->redirect(-location => $attachbase . $path);
                exit;
            } else {
                # Make sure the user can view the attachment.
291 292 293
                foreach my $field_name (@field_names) {
                    check_can_access($attachments{$field_name});
                }
294
                # Create a token and redirect.
295
                my $token = url_quote(issue_session_token(pack_token_data(\%attachments)));
296 297 298 299 300
                print $cgi->redirect(-location => $attachbase . "$path&t=$token");
                exit;
            }
        }
    } else {
301
        do_ssl_redirect_if_required();
302 303
        # No alternate host is used. Request credentials if required.
        Bugzilla->login();
304 305 306
        foreach my $field_name (@field_names) {
            $attachments{$field_name} = validateID($field_name);
        }
307 308
    }

309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346
    return wantarray
        ? map { $attachments{$_} } @field_names
        : $attachments{$field_names[0]};
}

sub all_attachments_are_public {
    my $attachments = shift;
    foreach my $field_name (keys %$attachments) {
        if (!attachmentIsPublic($attachments->{$field_name})) {
            return 0;
        }
    }
    return 1;
}

sub pack_token_data {
    my $attachments = shift;
    return join(' ', map { $_ . '=' . $attachments->{$_}->id } keys %$attachments);
}

sub unpack_token_data {
    my @token_data = split(/ /, shift || '');
    my %data;
    foreach my $token (@token_data) {
        my ($field_name, $attach_id) = split('=', $token);
        $data{$field_name} = $attach_id;
    }
    return %data;
}

################################################################################
# Functions
################################################################################

# Display an attachment.
sub view {
    my $attachment = get_attachment();

347
    # At this point, Bugzilla->login has been called if it had to.
348 349 350
    my $contenttype = $attachment->contenttype;
    my $filename = $attachment->filename;

351 352
    # Bug 111522: allow overriding content-type manually in the posted form
    # params.
353 354
    if (defined $cgi->param('content_type')) {
        $contenttype = $attachment->_check_content_type($cgi->param('content_type'));
355
    }
356

357
    # Return the appropriate HTTP response headers.
358
    $attachment->datasize || ThrowUserError("attachment_removed");
359

360
    $filename =~ s/^.*[\/\\]//;
361 362 363 364
    # escape quotes and backslashes in the filename, per RFCs 2045/822
    $filename =~ s/\\/\\\\/g; # escape backslashes
    $filename =~ s/"/\\"/g; # escape quotes

365 366 367 368 369
    # Avoid line wrapping done by Encode, which we don't need for HTTP
    # headers. See discussion in bug 328628 for details.
    local $Encode::Encoding{'MIME-Q'}->{'bpl'} = 10000;
    $filename = encode('MIME-Q', $filename);

370 371
    my $disposition = Bugzilla->params->{'allow_attachment_display'} ? 'inline' : 'attachment';

372 373 374 375 376 377 378
    # Don't send a charset header with attachments--they might not be UTF-8.
    # However, we do allow people to explicitly specify a charset if they
    # want.
    if ($contenttype !~ /\bcharset=/i) {
        # In order to prevent Apache from adding a charset, we have to send a
        # charset that's a single space.
        $cgi->charset(' ');
379 380 381 382 383 384
        if (Bugzilla->feature('detect_charset') && $contenttype =~ /^text\//) {
            my $encoding = detect_encoding($attachment->data);
            if ($encoding) {
                $cgi->charset(find_encoding($encoding)->mime_name);
            }
        }
385
    }
386
    print $cgi->header(-type=>"$contenttype; name=\"$filename\"",
387
                       -content_disposition=> "$disposition; filename=\"$filename\"",
388
                       -content_length => $attachment->datasize);
389
    disable_utf8();
390
    print $attachment->data;
391 392
}

393 394 395
sub interdiff {
    # Retrieve and validate parameters
    my $format = validateFormat('html', 'raw');
396 397 398 399 400 401 402
    my($old_attachment, $new_attachment);
    if ($format eq 'raw') {
        ($old_attachment, $new_attachment) = get_attachment('oldid', 'newid');
    } else {
        $old_attachment = validateID('oldid');
        $new_attachment = validateID('newid');
    }
403 404 405 406
    my $context = validateContext();

    Bugzilla::Attachment::PatchReader::process_interdiff(
        $old_attachment, $new_attachment, $format, $context);
407 408
}

409 410 411
sub diff {
    # Retrieve and validate parameters
    my $format = validateFormat('html', 'raw');
412
    my $attachment = $format eq 'raw' ? get_attachment() : validateID();
413
    my $context = validateContext();
414

415 416 417 418
    # If it is not a patch, view normally.
    if (!$attachment->ispatch) {
        view();
        return;
419 420
    }

421
    Bugzilla::Attachment::PatchReader::process_diff($attachment, $format, $context);
422
}
423

424 425
# Display all attachments for a given bug in a series of IFRAMEs within one
# HTML page.
426
sub viewall {
427
    # Retrieve and validate parameters
428
    my $bug = Bugzilla::Bug->check(scalar $cgi->param('bugid'));
429

430
    my $attachments = Bugzilla::Attachment->get_attachments_by_bug($bug);
431 432
    # Ignore deleted attachments.
    @$attachments = grep { $_->datasize } @$attachments;
433

434 435 436 437 438
    if ($cgi->param('hide_obsolete')) {
        @$attachments = grep { !$_->isobsolete } @$attachments;
        $vars->{'hide_obsolete'} = 1;
    }

439 440 441
    # Define the variables and functions that will be passed to the UI template.
    $vars->{'bug'} = $bug;
    $vars->{'attachments'} = $attachments;
442

443
    print $cgi->header();
444

445 446 447
    # Generate and return the UI (HTML page) from the appropriate template.
    $template->process("attachment/show-multiple.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
448 449
}

450
# Display a form for entering a new attachment.
451
sub enter {
452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489
    # Retrieve and validate parameters
    my $bug = Bugzilla::Bug->check(scalar $cgi->param('bugid'));
    my $bugid = $bug->id;
    Bugzilla::Attachment->_check_bug($bug);
    my $dbh = Bugzilla->dbh;
    my $user = Bugzilla->user;

    # Retrieve the attachments the user can edit from the database and write
    # them into an array of hashes where each hash represents one attachment.
  
    my ($can_edit, $not_private) = ('', '');
    if (!$user->in_group('editbugs', $bug->product_id)) {
        $can_edit = "AND submitter_id = " . $user->id;
    }
    if (!$user->is_insider) {
        $not_private = "AND isprivate = 0";
    }
    my $attach_ids = $dbh->selectcol_arrayref(
        "SELECT attach_id
           FROM attachments
          WHERE bug_id = ?
                AND isobsolete = 0
                $can_edit $not_private
       ORDER BY attach_id",
         undef, $bugid);

    # Define the variables and functions that will be passed to the UI template.
    $vars->{'bug'} = $bug;
    $vars->{'attachments'} = Bugzilla::Attachment->new_from_list($attach_ids);

    my $flag_types = Bugzilla::FlagType::match({
        'target_type'  => 'attachment',
        'product_id'   => $bug->product_id,
        'component_id' => $bug->component_id
    });
    $vars->{'flag_types'} = $flag_types;
    $vars->{'any_flags_requesteeble'} =
        grep { $_->is_requestable && $_->is_requesteeble } @$flag_types;
490
    $vars->{'token'} = issue_session_token('create_attachment');
491 492 493 494 495 496

    print $cgi->header();

    # Generate and return the UI (HTML page) from the appropriate template.
    $template->process("attachment/create.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
497 498
}

499
# Insert a new attachment into the database.
500
sub insert {
501 502
    my $dbh = Bugzilla->dbh;
    my $user = Bugzilla->user;
503

504 505
    $dbh->bz_start_transaction;

506
    # Retrieve and validate parameters
507 508
    my $bug = Bugzilla::Bug->check(scalar $cgi->param('bugid'));
    my $bugid = $bug->id;
509
    my ($timestamp) = $dbh->selectrow_array("SELECT NOW()");
510

511 512
    # Detect if the user already used the same form to submit an attachment
    my $token = trim($cgi->param('token'));
513
    check_token_data($token, 'create_attachment', 'index.cgi');
514

515 516 517 518 519 520 521 522 523 524
    # Check attachments the user tries to mark as obsolete.
    my @obsolete_attachments;
    if ($cgi->param('obsolete')) {
        my @obsolete = $cgi->param('obsolete');
        @obsolete_attachments = Bugzilla::Attachment->validate_obsolete($bug, \@obsolete);
    }

    # Must be called before create() as it may alter $cgi->param('ispatch').
    my $content_type = Bugzilla::Attachment::get_content_type();

525 526 527
    # Get the filehandle of the attachment.
    my $data_fh = $cgi->upload('data');

528 529 530
    my $attachment = Bugzilla::Attachment->create(
        {bug           => $bug,
         creation_ts   => $timestamp,
531
         data          => scalar $cgi->param('attach_text') || $data_fh,
532
         description   => scalar $cgi->param('description'),
533
         filename      => $cgi->param('attach_text') ? "file_$bugid.txt" : scalar $cgi->upload('data'),
534 535 536 537 538
         ispatch       => scalar $cgi->param('ispatch'),
         isprivate     => scalar $cgi->param('isprivate'),
         mimetype      => $content_type,
         });

539 540 541
    # Delete the token used to create this attachment.
    delete_token($token);

542
    foreach my $obsolete_attachment (@obsolete_attachments) {
543 544
        $obsolete_attachment->set_is_obsolete(1);
        $obsolete_attachment->update($timestamp);
545
    }
546

547 548 549 550 551
    my ($flags, $new_flags) = Bugzilla::Flag->extract_flags_from_cgi(
                                  $bug, $attachment, $vars, SKIP_REQUESTEE_ON_ERROR);
    $attachment->set_flags($flags, $new_flags);
    $attachment->update($timestamp);

552
    # Insert a comment about the new attachment into the database.
553
    my $comment = $cgi->param('comment');
554
    $comment = '' unless defined $comment;
555 556 557
    $bug->add_comment($comment, { isprivate => $attachment->isprivate,
                                  type => CMT_ATTACHMENT_CREATED,
                                  extra_data => $attachment->id });
558

559
  # Assign the bug to the user, if they are allowed to take it
560
  my $owner = "";
561
  if ($cgi->param('takebug') && $user->in_group('editbugs', $bug->product_id)) {
562 563 564 565 566
      # When taking a bug, we have to follow the workflow.
      my $bug_status = $cgi->param('bug_status') || '';
      ($bug_status) = grep {$_->name eq $bug_status} @{$bug->status->can_change_to};

      if ($bug_status && $bug_status->is_open
567 568
          && ($bug_status->name ne 'UNCONFIRMED' 
              || $bug->product_obj->allows_unconfirmed))
569
      {
570
          $bug->set_bug_status($bug_status->name);
571 572
          $bug->clear_resolution();
      }
573
      # Make sure the person we are taking the bug from gets mail.
574
      $owner = $bug->assigned_to->login;
575
      $bug->set_assigned_to($user);
576
  }
577 578

  $bug->add_cc($user) if $cgi->param('addselfcc');
579 580 581
  $bug->update($timestamp);

  $dbh->bz_commit_transaction;
582

583
  # Define the variables and functions that will be passed to the UI template.
584
  $vars->{'attachment'} = $attachment;
585 586 587 588
  # We cannot reuse the $bug object as delta_ts has eventually been updated
  # since the object was created.
  $vars->{'bugs'} = [new Bugzilla::Bug($bugid)];
  $vars->{'header_done'} = 1;
589
  $vars->{'contenttypemethod'} = $cgi->param('contenttypemethod');
590

591
  my $recipients =  { 'changer' => $user, 'owner' => $owner };
592 593
  $vars->{'sent_bugmail'} = Bugzilla::BugMail::Send($bugid, $recipients);

594
  print $cgi->header();
595
  # Generate and return the UI (HTML page) from the appropriate template.
596 597
  $template->process("attachment/created.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
598 599
}

600 601 602 603
# Displays a form for editing attachment properties.
# Any user is allowed to access this page, unless the attachment
# is private and the user does not belong to the insider group.
# Validations are done later when the user submits changes.
604
sub edit {
605
  my $attachment = validateID();
606

607
  my $bugattachments =
608
      Bugzilla::Attachment->get_attachments_by_bug($attachment->bug);
609

610 611 612 613 614 615
  my $any_flags_requesteeble =
    grep { $_->is_requestable && $_->is_requesteeble } @{$attachment->flag_types};
  # Useful in case a flagtype is no longer requestable but a requestee
  # has been set before we turned off that bit.
  $any_flags_requesteeble ||= grep { $_->requestee_id } @{$attachment->flags};
  $vars->{'any_flags_requesteeble'} = $any_flags_requesteeble;
616
  $vars->{'attachment'} = $attachment;
617
  $vars->{'attachments'} = $bugattachments;
618

619
  print $cgi->header();
620 621

  # Generate and return the UI (HTML page) from the appropriate template.
622 623
  $template->process("attachment/edit.html.tmpl", $vars)
    || ThrowTemplateError($template->error());
624 625
}

626 627
# Updates an attachment record. Only users with "editbugs" privileges,
# (or the original attachment's submitter) can edit the attachment.
628
# Users cannot edit the content of the attachment itself.
629
sub update {
630 631
    my $user = Bugzilla->user;
    my $dbh = Bugzilla->dbh;
632

633 634 635
    # Start a transaction in preparation for updating the attachment.
    $dbh->bz_start_transaction();

636
    # Retrieve and validate parameters
637
    my $attachment = validateID();
638 639
    my $bug = $attachment->bug;
    $attachment->_check_bug;
640 641 642 643 644 645 646 647 648 649 650 651 652 653
    my $can_edit = $attachment->validate_can_edit($bug->product_id);

    if ($can_edit) {
        $attachment->set_description(scalar $cgi->param('description'));
        $attachment->set_is_patch(scalar $cgi->param('ispatch'));
        $attachment->set_content_type(scalar $cgi->param('contenttypeentry'));
        $attachment->set_is_obsolete(scalar $cgi->param('isobsolete'));
        $attachment->set_is_private(scalar $cgi->param('isprivate'));
        $attachment->set_filename(scalar $cgi->param('filename'));

        # Now make sure the attachment has not been edited since we loaded the page.
        if (defined $cgi->param('delta_ts')
            && $cgi->param('delta_ts') ne $attachment->modification_time)
        {
654
            ($vars->{'operations'}) = $bug->get_activity($attachment->id, $cgi->param('delta_ts'));
655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671

            # The token contains the old modification_time. We need a new one.
            $cgi->param('token', issue_hash_token([$attachment->id, $attachment->modification_time]));

            # If the modification date changed but there is no entry in
            # the activity table, this means someone commented only.
            # In this case, there is no reason to midair.
            if (scalar(@{$vars->{'operations'}})) {
                $cgi->param('delta_ts', $attachment->modification_time);
                $vars->{'attachment'} = $attachment;

                print $cgi->header();
                # Warn the user about the mid-air collision and ask them what to do.
                $template->process("attachment/midair.html.tmpl", $vars)
                  || ThrowTemplateError($template->error());
                exit;
            }
672 673
        }
    }
674 675 676 677 678 679

    # We couldn't do this check earlier as we first had to validate attachment ID
    # and display the mid-air collision page if modification_time changed.
    my $token = $cgi->param('token');
    check_hash_token($token, [$attachment->id, $attachment->modification_time]);

680 681
    # If the user submitted a comment while editing the attachment,
    # add the comment to the bug. Do this after having validated isprivate!
682
    my $comment = $cgi->param('comment');
683
    if (defined $comment && trim($comment) ne '') {
684 685 686
        $bug->add_comment($comment, { isprivate => $attachment->isprivate,
                                      type => CMT_ATTACHMENT_UPDATED,
                                      extra_data => $attachment->id });
687 688
    }

689 690
    $bug->add_cc($user) if $cgi->param('addselfcc');

691 692 693 694 695
    if ($can_edit) {
        my ($flags, $new_flags) =
          Bugzilla::Flag->extract_flags_from_cgi($bug, $attachment, $vars);
        $attachment->set_flags($flags, $new_flags);
    }
696

697
    # Figure out when the changes were made.
698
    my $timestamp = $dbh->selectrow_array('SELECT LOCALTIMESTAMP(0)');
699

700 701 702 703 704 705 706
    if ($can_edit) {
        my $changes = $attachment->update($timestamp);
        # If there are changes, we updated delta_ts in the DB. We have to
        # reflect this change in the bug object.
        $bug->{delta_ts} = $timestamp if scalar(keys %$changes);
    }

707
    # Commit the comment, if any.
708
    $bug->update($timestamp);
709

710 711
    # Commit the transaction now that we are finished updating the database.
    $dbh->bz_commit_transaction();
712

713 714 715 716
    # Define the variables and functions that will be passed to the UI template.
    $vars->{'attachment'} = $attachment;
    $vars->{'bugs'} = [$bug];
    $vars->{'header_done'} = 1;
717
    $vars->{'sent_bugmail'} = 
718
        Bugzilla::BugMail::Send($bug->id, { 'changer' => $user });
719

720
    print $cgi->header();
721

722 723 724
    # Generate and return the UI (HTML page) from the appropriate template.
    $template->process("attachment/updated.html.tmpl", $vars)
      || ThrowTemplateError($template->error());
725
}
726 727 728 729 730 731 732 733 734 735 736 737 738

# Only administrators can delete attachments.
sub delete_attachment {
    my $user = Bugzilla->login(LOGIN_REQUIRED);
    my $dbh = Bugzilla->dbh;

    print $cgi->header();

    $user->in_group('admin')
      || ThrowUserError('auth_failure', {group  => 'admin',
                                         action => 'delete',
                                         object => 'attachment'});

739
    Bugzilla->params->{'allow_attachment_deletion'}
740 741 742
      || ThrowUserError('attachment_deletion_disabled');

    # Make sure the administrator is allowed to edit this attachment.
743
    my $attachment = validateID();
744
    Bugzilla::Attachment->_check_bug($attachment->bug);
745 746 747 748 749 750 751 752 753

    $attachment->datasize || ThrowUserError('attachment_removed');

    # We don't want to let a malicious URL accidentally delete an attachment.
    my $token = trim($cgi->param('token'));
    if ($token) {
        my ($creator_id, $date, $event) = Bugzilla::Token::GetTokenData($token);
        unless ($creator_id
                  && ($creator_id == $user->id)
754
                  && ($event eq 'delete_attachment' . $attachment->id))
755 756
        {
            # The token is invalid.
757
            ThrowUserError('token_does_not_exist');
758 759
        }

760 761
        my $bug = new Bugzilla::Bug($attachment->bug_id);

762 763
        # The token is valid. Delete the content of the attachment.
        my $msg;
764
        $vars->{'attachment'} = $attachment;
765 766 767 768 769 770
        $vars->{'date'} = $date;
        $vars->{'reason'} = clean_text($cgi->param('reason') || '');

        $template->process("attachment/delete_reason.txt.tmpl", $vars, \$msg)
          || ThrowTemplateError($template->error());

771 772 773
        # Paste the reason provided by the admin into a comment.
        $bug->add_comment($msg);

774
        $attachment->remove_from_db();
775 776

        # Now delete the token.
777
        delete_token($token);
778

779 780
        # Insert the comment.
        $bug->update();
781

782
        # Required to display the bug the deleted attachment belongs to.
783
        $vars->{'bugs'} = [$bug];
784 785
        $vars->{'header_done'} = 1;

786
        $vars->{'sent_bugmail'} =
787
            Bugzilla::BugMail::Send($bug->id, { 'changer' => $user });
788

789 790 791 792 793
        $template->process("attachment/updated.html.tmpl", $vars)
          || ThrowTemplateError($template->error());
    }
    else {
        # Create a token.
794
        $token = issue_session_token('delete_attachment' . $attachment->id);
795 796 797 798 799 800 801 802

        $vars->{'a'} = $attachment;
        $vars->{'token'} = $token;

        $template->process("attachment/confirm-delete.html.tmpl", $vars)
          || ThrowTemplateError($template->error());
    }
}