sanitycheck.cgi 29.7 KB
Newer Older
1
#!/usr/bin/perl -wT
2
# -*- Mode: perl; indent-tabs-mode: nil -*-
3
#
4 5 6 7 8 9 10 11 12 13
# The contents of this file are subject to the Mozilla Public
# License Version 1.1 (the "License"); you may not use this file
# except in compliance with the License. You may obtain a copy of
# the License at http://www.mozilla.org/MPL/
#
# Software distributed under the License is distributed on an "AS
# IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
# implied. See the License for the specific language governing
# rights and limitations under the License.
#
14
# The Original Code is the Bugzilla Bug Tracking System.
15
#
16
# The Initial Developer of the Original Code is Netscape Communications
17 18 19 20
# Corporation. Portions created by Netscape are
# Copyright (C) 1998 Netscape Communications Corporation. All
# Rights Reserved.
#
21
# Contributor(s): Terry Weissman <terry@mozilla.org>
22
#                 Matthew Tuck <matty@chariot.net.au>
23
#                 Max Kanat-Alexander <mkanat@bugzilla.org>
24
#                 Marc Schumann <wurblzap@gmail.com>
25

26
use strict;
27

28 29
use lib qw(.);

30
require "globals.pl";
31
use Bugzilla::Constants;
32
use Bugzilla::Util;
33
use Bugzilla::User;
34

35 36 37
###########################################################################
# General subs
###########################################################################
38 39 40

sub Status {
    my ($str) = (@_);
41
    print "$str <p>\n";
42 43
}

44 45
sub Alert {
    my ($str) = (@_);
46
    Status("<font color=\"red\">$str</font>");
47 48
}

49 50
sub BugLink {
    my ($id) = (@_);
51
    return "<a href=\"show_bug.cgi?id=$id\">$id</a>";
52 53
}

54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70
#
# Parameter is a list of bug ids.
#
# Return is a string containing a list of all the bugids, as hrefs,
# followed by a link to them all as a buglist
sub BugListLinks {
    my @bugs = @_;

    # Historically, GetBugLink() wasn't used here. I'm guessing this
    # was because it didn't exist or is too performance heavy, or just
    # plain unnecessary
    my @bug_links = map(BugLink($_), @bugs);

    return join(', ',@bug_links) . " <a href=\"buglist.cgi?bug_id=" .
        join(',',@bugs) . "\">(as buglist)</a>";
}

71 72 73
###########################################################################
# Start
###########################################################################
74

75
Bugzilla->login(LOGIN_REQUIRED);
76

77
my $cgi = Bugzilla->cgi;
78
my $dbh = Bugzilla->dbh;
79
my $template = Bugzilla->template;
80

81 82 83 84 85 86 87 88
# Make sure the user is authorized to access sanitycheck.cgi.  Access
# is restricted to logged-in users who have "editbugs" privileges,
# which is a reasonable compromise between allowing all users to access
# the script (creating the potential for denial of service attacks)
# and restricting access to this installation's administrators (which
# prevents users with a legitimate interest in Bugzilla integrity
# from accessing the script).
UserInGroup("editbugs")
89 90 91
  || ThrowUserError("auth_failure", {group  => "editbugs",
                                     action => "run",
                                     object => "sanity_check"});
92

93
print $cgi->header();
94

95
my @row;
96

97
$template->put_header("Bugzilla Sanity Check");
98

99 100 101 102
###########################################################################
# Fix vote cache
###########################################################################

103
if (defined $cgi->param('rebuildvotecache')) {
104
    Status("OK, now rebuilding vote cache.");
105
    $dbh->bz_lock_tables('bugs WRITE', 'votes READ');
106
    SendSQL("UPDATE bugs SET votes = 0");
107 108
    SendSQL("SELECT bug_id, SUM(vote_count) FROM votes " .
            $dbh->sql_group_by('bug_id'));
109 110 111 112 113 114
    my %votes;
    while (@row = FetchSQLData()) {
        my ($id, $v) = (@row);
        $votes{$id} = $v;
    }
    foreach my $id (keys %votes) {
115
        SendSQL("UPDATE bugs SET votes = $votes{$id} WHERE bug_id = $id");
116
    }
117
    $dbh->bz_unlock_tables();
118
    Status("Vote cache has been rebuilt.");
119 120
}

121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164
###########################################################################
# Create missing group_control_map entries
###########################################################################

if (defined $cgi->param('createmissinggroupcontrolmapentries')) {
    Status(qq{OK, now creating <code>SHOWN</code> member control entries
              for product/group combinations lacking one.});

    my $na    = CONTROLMAPNA;
    my $shown = CONTROLMAPSHOWN;
    my $insertsth = $dbh->prepare(
        qq{INSERT INTO group_control_map (
                       group_id, product_id, entry,
                       membercontrol, othercontrol, canedit
                      )
               VALUES (
                       ?, ?, 0,
                       $shown, $na, 0
                      )});
    my $updatesth = $dbh->prepare(qq{UPDATE group_control_map
                                        SET membercontrol = $shown
                                      WHERE group_id   = ?
                                        AND product_id = ?});
    my $counter = 0;

    # Find all group/product combinations used for bugs but not set up
    # correctly in group_control_map
    my $invalid_combinations = $dbh->selectall_arrayref(
        qq{    SELECT bugs.product_id,
                      bgm.group_id,
                      gcm.membercontrol,
                      groups.name,
                      products.name
                 FROM bugs
           INNER JOIN bug_group_map AS bgm
                   ON bugs.bug_id = bgm.bug_id
           INNER JOIN groups
                   ON bgm.group_id = groups.id
           INNER JOIN products
                   ON bugs.product_id = products.id
            LEFT JOIN group_control_map AS gcm
                   ON bugs.product_id = gcm.product_id
                  AND    bgm.group_id = gcm.group_id
                WHERE COALESCE(gcm.membercontrol, $na) = $na
165 166
          } . $dbh->sql_group_by('bugs.product_id, bgm.group_id',
                                 'gcm.membercontrol, groups.name, products.name'));
167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190

    foreach (@$invalid_combinations) {
        my ($product_id, $group_id, $currentmembercontrol,
            $group_name, $product_name) = @$_;

        $counter++;
        if (defined($currentmembercontrol)) {
            Status(qq{Updating <code>NA/<em>xxx</em></code> group control
                      setting for group <em>$group_name</em> to
                      <code>SHOWN/<em>xxx</em></code> in product
                      <em>$product_name</em>.});
            $updatesth->execute($group_id, $product_id);
        }
        else {
            Status(qq{Generating <code>SHOWN/NA</code> group control setting
                      for group <em>$group_name</em> in product
                      <em>$product_name</em>.});
            $insertsth->execute($group_id, $product_id);
        }
    }

    Status("Repaired $counter defective group control settings.");
}

191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216
###########################################################################
# Fix missing creation date
###########################################################################

if (defined $cgi->param('repair_creation_date')) {
    Status("OK, now fixing missing bug creation dates");

    my $bug_ids = $dbh->selectcol_arrayref('SELECT bug_id FROM bugs
                                            WHERE creation_ts IS NULL');

    my $sth_UpdateDate = $dbh->prepare('UPDATE bugs SET creation_ts = ?
                                        WHERE bug_id = ?');

    # All bugs have an entry in the 'longdescs' table when they are created,
    # even if 'commentoncreate' is turned off.
    my $sth_getDate = $dbh->prepare('SELECT MIN(bug_when) FROM longdescs
                                     WHERE bug_id = ?');

    foreach my $bugid (@$bug_ids) {
        $sth_getDate->execute($bugid);
        my $date = $sth_getDate->fetchrow_array;
        $sth_UpdateDate->execute($date, $bugid);
    }
    Status(scalar(@$bug_ids) . " bugs have been fixed.");
}

217 218 219 220
###########################################################################
# Send unsent mail
###########################################################################

221
if (defined $cgi->param('rescanallBugMail')) {
222 223 224
    require Bugzilla::BugMail;

    Status("OK, now attempting to send unsent mail");
225 226
    SendSQL("SELECT bug_id FROM bugs 
              WHERE (lastdiffed IS NULL OR lastdiffed < delta_ts) AND
227
             delta_ts < now() - " . $dbh->sql_interval(30, 'MINUTE') .
228
            " ORDER BY bug_id");
229 230 231 232 233 234 235 236 237 238 239 240 241 242 243
    my @list;
    while (MoreSQLData()) {
        push (@list, FetchOneColumn());
    }

    Status(scalar(@list) . ' bugs found with possibly unsent mail.');

    foreach my $bugid (@list) {
        Bugzilla::BugMail::Send($bugid);
    }

    if (scalar(@list) > 0) {
        Status("Unsent mail has been sent.");
    }

244
    $template->put_footer();
245 246 247
    exit;
}

248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283
###########################################################################
# Remove all references to deleted bugs
###########################################################################

if (defined $cgi->param('remove_invalid_references')) {
    Status("OK, now removing all references to deleted bugs.");

    $dbh->bz_lock_tables('attachments WRITE', 'bug_group_map WRITE',
                         'bugs_activity WRITE', 'cc WRITE',
                         'dependencies WRITE', 'duplicates WRITE',
                         'flags WRITE', 'keywords WRITE',
                         'longdescs WRITE', 'votes WRITE', 'bugs READ');

    foreach my $pair ('attachments/', 'bug_group_map/', 'bugs_activity/', 'cc/',
                      'dependencies/blocked', 'dependencies/dependson',
                      'duplicates/dupe', 'duplicates/dupe_of',
                      'flags/', 'keywords/', 'longdescs/', 'votes/') {

        my ($table, $field) = split('/', $pair);
        $field ||= "bug_id";

        my $bug_ids =
          $dbh->selectcol_arrayref("SELECT $table.$field FROM $table
                                    LEFT JOIN bugs ON $table.$field = bugs.bug_id
                                    WHERE bugs.bug_id IS NULL");

        if (scalar(@$bug_ids)) {
            $dbh->do("DELETE FROM $table WHERE $field IN (" . join(',', @$bug_ids) . ")");
        }
    }

    $dbh->bz_unlock_tables();
    Status("All references to deleted bugs have been removed.");
}


284
print "OK, now running sanity checks.<p>\n";
285

286 287 288 289
###########################################################################
# Perform referential (cross) checks
###########################################################################

290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305
# This checks that a simple foreign key has a valid primary key value.  NULL
# references are acceptable and cause no problem.
#
# The first parameter is the primary key table name.
# The second parameter is the primary key field name.
# Each successive parameter represents a foreign key, it must be a list
# reference, where the list has:
#   the first value is the foreign key table name.
#   the second value is the foreign key field name.
#   the third value is optional and represents a field on the foreign key
#     table to display when the check fails.
#   the fourth value is optional and is a list reference to values that
#     are excluded from checking.
#
# FIXME: The excluded values parameter should go away - the QA contact
#        fields should use NULL instead - see bug #109474.
306
#        The same goes for series; no bug for that yet.
307

308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328
sub CrossCheck {
    my $table = shift @_;
    my $field = shift @_;

    Status("Checking references to $table.$field");

    while (@_) {
        my $ref = shift @_;
        my ($refertable, $referfield, $keyname, $exceptions) = @$ref;

        $exceptions ||= [];
        my %exceptions = map { $_ => 1 } @$exceptions;

        Status("... from $refertable.$referfield");
        
        SendSQL("SELECT DISTINCT $refertable.$referfield" . ($keyname ? ", $refertable.$keyname" : '') . " " .
                "FROM   $refertable LEFT JOIN $table " .
                "  ON   $refertable.$referfield = $table.$field " .
                "WHERE  $table.$field IS NULL " .
                "  AND  $refertable.$referfield IS NOT NULL");

329
        my $has_bad_references = 0;
330 331 332
        while (MoreSQLData()) {
            my ($value, $key) = FetchSQLData();
            if (!$exceptions{$value}) {
333
                my $alert = "Bad value &quot;$value&quot; found in $refertable.$referfield";
334 335 336 337 338 339 340 341 342
                if ($keyname) {
                    if ($keyname eq 'bug_id') {
                        $alert .= ' (bug ' . BugLink($key) . ')';
                    }
                    else {
                        $alert .= " ($keyname == '$key')";
                    }
                }
                Alert($alert);
343
                $has_bad_references = 1;
344 345
            }
        }
346 347 348 349
        # References to non existent bugs can be safely removed, bug 288461
        if ($table eq 'bugs' && $has_bad_references) {
            print qq{<a href="sanitycheck.cgi?remove_invalid_references=1">Remove invalid references to non existent bugs.</a><p>\n};
        }
350 351 352
    }
}

353 354 355
CrossCheck('classifications', 'id',
           ['products', 'classification_id']);

356 357 358 359
CrossCheck("keyworddefs", "id",
           ["keywords", "keywordid"]);

CrossCheck("fielddefs", "fieldid",
360 361
           ["bugs_activity", "fieldid"],
           ['profiles_activity', 'fieldid']);
362

363 364
CrossCheck("flagtypes", "id",
           ["flags", "type_id"]);
365 366 367

CrossCheck("bugs", "bug_id",
           ["bugs_activity", "bug_id"],
368
           ["bug_group_map", "bug_id"],
369 370 371 372 373
           ["attachments", "bug_id"],
           ["cc", "bug_id"],
           ["longdescs", "bug_id"],
           ["dependencies", "blocked"],
           ["dependencies", "dependson"],
374
           ['flags', 'bug_id'],
375
           ["votes", "bug_id"],
376 377 378
           ["keywords", "bug_id"],
           ["duplicates", "dupe_of", "dupe"],
           ["duplicates", "dupe", "dupe_of"]);
379

380 381
CrossCheck("groups", "id",
           ["bug_group_map", "group_id"],
382
           ['category_group_map', 'group_id'],
383 384
           ["group_group_map", "grantor_id"],
           ["group_group_map", "member_id"],
385
           ["group_control_map", "group_id"],
386 387
           ["user_group_map", "group_id"]);

388
CrossCheck("profiles", "userid",
389 390
           ['profiles_activity', 'userid'],
           ['profiles_activity', 'who'],
391 392
           ['email_setting', 'user_id'],
           ['profile_setting', 'user_id'],
393 394
           ["bugs", "reporter", "bug_id"],
           ["bugs", "assigned_to", "bug_id"],
395
           ["bugs", "qa_contact", "bug_id"],
396
           ["attachments", "submitter_id", "bug_id"],
397 398
           ['flags', 'setter_id', 'bug_id'],
           ['flags', 'requestee_id', 'bug_id'],
399 400
           ["bugs_activity", "who", "bug_id"],
           ["cc", "who", "bug_id"],
401
           ['quips', 'userid'],
402 403
           ["votes", "who", "bug_id"],
           ["longdescs", "who", "bug_id"],
404
           ["logincookies", "userid"],
405
           ["namedqueries", "userid"],
406
           ['series', 'creator', 'series_id', ['0']],
407 408
           ["watch", "watcher"],
           ["watch", "watched"],
409
           ['whine_events', 'owner_userid'],
410
           ["tokens", "userid"],
411
           ["user_group_map", "user_id"],
412
           ["components", "initialowner", "name"],
413
           ["components", "initialqacontact", "name"]);
414

415 416 417 418 419
CrossCheck("products", "id",
           ["bugs", "product_id", "bug_id"],
           ["components", "product_id", "name"],
           ["milestones", "product_id", "value"],
           ["versions", "product_id", "value"],
420
           ["group_control_map", "product_id"],
421 422
           ["flaginclusions", "product_id", "type_id"],
           ["flagexclusions", "product_id", "type_id"]);
423

424
# Check the former enum types -mkanat@bugzilla.org
425
CrossCheck("bug_status", "value",
426
            ["bugs", "bug_status", "bug_id"]);
427 428

CrossCheck("resolution", "value",
429
            ["bugs", "resolution", "bug_id"]);
430 431

CrossCheck("bug_severity", "value",
432
            ["bugs", "bug_severity", "bug_id"]);
433 434

CrossCheck("op_sys", "value",
435
            ["bugs", "op_sys", "bug_id"]);
436 437

CrossCheck("priority", "value",
438
            ["bugs", "priority", "bug_id"]);
439 440

CrossCheck("rep_platform", "value",
441
            ["bugs", "rep_platform", "bug_id"]);
442

443 444 445 446 447 448 449 450 451 452
CrossCheck('series', 'series_id',
           ['series_data', 'series_id']);

CrossCheck('series_categories', 'id',
           ['series', 'category']);

CrossCheck('whine_events', 'id',
           ['whine_queries', 'eventid'],
           ['whine_schedules', 'eventid']);

453
###########################################################################
454
# Perform double field referential (cross) checks
455
###########################################################################
456
 
457 458 459 460 461 462 463 464 465 466 467 468 469 470
# This checks that a compound two-field foreign key has a valid primary key
# value.  NULL references are acceptable and cause no problem.
#
# The first parameter is the primary key table name.
# The second parameter is the primary key first field name.
# The third parameter is the primary key second field name.
# Each successive parameter represents a foreign key, it must be a list
# reference, where the list has:
#   the first value is the foreign key table name
#   the second value is the foreign key first field name.
#   the third value is the foreign key second field name.
#   the fourth value is optional and represents a field on the foreign key
#     table to display when the check fails

471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495
sub DoubleCrossCheck {
    my $table = shift @_;
    my $field1 = shift @_;
    my $field2 = shift @_;
 
    Status("Checking references to $table.$field1 / $table.$field2");
 
    while (@_) {
        my $ref = shift @_;
        my ($refertable, $referfield1, $referfield2, $keyname) = @$ref;
 
        Status("... from $refertable.$referfield1 / $refertable.$referfield2");
        
        SendSQL("SELECT DISTINCT $refertable.$referfield1, $refertable.$referfield2" . ($keyname ? ", $refertable.$keyname" : '') . " " .
                "FROM   $refertable LEFT JOIN $table " .
                "  ON   $refertable.$referfield1 = $table.$field1 " .
                " AND   $refertable.$referfield2 = $table.$field2 " .
                "WHERE  $table.$field1 IS NULL " .
                "  AND  $table.$field2 IS NULL " .
                "  AND  $refertable.$referfield1 IS NOT NULL " .
                "  AND  $refertable.$referfield2 IS NOT NULL");
 
        while (MoreSQLData()) {
            my ($value1, $value2, $key) = FetchSQLData();
 
496
            my $alert = "Bad values &quot;$value1&quot;, &quot;$value2&quot; found in " .
497 498 499 500 501 502 503 504 505 506 507
                "$refertable.$referfield1 / $refertable.$referfield2";
            if ($keyname) {
                if ($keyname eq 'bug_id') {
                   $alert .= ' (bug ' . BugLink($key) . ')';
                }
                else {
                    $alert .= " ($keyname == '$key')";
                }
            }
            Alert($alert);
        }
508 509 510
    }
}

511 512 513 514
DoubleCrossCheck('attachments', 'bug_id', 'attach_id',
                 ['flags', 'bug_id', 'attach_id'],
                 ['bugs_activity', 'bug_id', 'attach_id']);

515
DoubleCrossCheck("components", "product_id", "id",
516 517 518
                 ["bugs", "product_id", "component_id", "bug_id"],
                 ['flagexclusions', 'product_id', 'component_id'],
                 ['flaginclusions', 'product_id', 'component_id']);
519

520 521 522 523 524 525
DoubleCrossCheck("versions", "product_id", "value",
                 ["bugs", "product_id", "version", "bug_id"]);
 
DoubleCrossCheck("milestones", "product_id", "value",
                 ["bugs", "product_id", "target_milestone", "bug_id"],
                 ["products", "id", "defaultmilestone", "name"]);
526

527 528 529 530
###########################################################################
# Perform login checks
###########################################################################
 
531
Status("Checking profile logins");
532

533
SendSQL("SELECT userid, login_name FROM profiles");
534

535
while (my ($id,$email) = (FetchSQLData())) {
536 537
    validate_email_syntax($email)
      || Alert "Bad profile email address, id=$id,  &lt;$email&gt;.";
538
}
539

540 541 542
###########################################################################
# Perform vote/keyword cache checks
###########################################################################
543

544 545 546 547 548 549 550 551
my $offervotecacherebuild = 0;

sub AlertBadVoteCache {
    my ($id) = (@_);
    Alert("Bad vote cache for bug " . BugLink($id));
    $offervotecacherebuild = 1;
}

552
SendSQL("SELECT bug_id, votes, keywords FROM bugs " .
553
        "WHERE votes != 0 OR keywords != ''");
554

555
my %votes;
556
my %bugid;
557
my %keyword;
558 559

while (@row = FetchSQLData()) {
560
    my($id, $v, $k) = (@row);
561 562 563
    if ($v != 0) {
        $votes{$id} = $v;
    }
564 565 566
    if ($k) {
        $keyword{$id} = $k;
    }
567 568 569
}

Status("Checking cached vote counts");
570 571
SendSQL("SELECT bug_id, SUM(vote_count) FROM votes " .
        $dbh->sql_group_by('bug_id'));
572 573 574 575 576 577 578 579 580 581 582 583 584 585

while (@row = FetchSQLData()) {
    my ($id, $v) = (@row);
    if ($v <= 0) {
        Alert("Bad vote sum for bug $id");
    } else {
        if (!defined $votes{$id} || $votes{$id} != $v) {
            AlertBadVoteCache($id);
        }
        delete $votes{$id};
    }
}
foreach my $id (keys %votes) {
    AlertBadVoteCache($id);
586 587
}

588 589 590 591 592
if ($offervotecacherebuild) {
    print qq{<a href="sanitycheck.cgi?rebuildvotecache=1">Click here to rebuild the vote cache</a><p>\n};
}


593 594 595 596 597 598 599 600 601 602
Status("Checking keywords table");

my %keywordids;
SendSQL("SELECT id, name FROM keyworddefs");
while (@row = FetchSQLData()) {
    my ($id, $name) = (@row);
    if ($keywordids{$id}) {
        Alert("Duplicate entry in keyworddefs for id $id");
    }
    $keywordids{$id} = 1;
603
    if ($name =~ /[\s,]/) {
604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627
        Alert("Bogus name in keyworddefs for id $id");
    }
}


SendSQL("SELECT bug_id, keywordid FROM keywords ORDER BY bug_id, keywordid");
my $lastid;
my $lastk;
while (@row = FetchSQLData()) {
    my ($id, $k) = (@row);
    if (!$keywordids{$k}) {
        Alert("Bogus keywordids $k found in keywords table");
    }
    if (defined $lastid && $id eq $lastid && $k eq $lastk) {
        Alert("Duplicate keyword ids found in bug " . BugLink($id));
    }
    $lastid = $id;
    $lastk = $k;
}

Status("Checking cached keywords");

my %realk;

628
if (defined $cgi->param('rebuildkeywordcache')) {
629 630
    $dbh->bz_lock_tables('bugs write', 'keywords read',
                                  'keyworddefs read');
631 632 633
}

SendSQL("SELECT keywords.bug_id, keyworddefs.name " .
634 635 636 637 638
        "FROM keywords " .
        "INNER JOIN keyworddefs " .
        "   ON keyworddefs.id = keywords.keywordid " .
        "INNER JOIN bugs " .
        "   ON keywords.bug_id = bugs.bug_id " .
639 640
        "ORDER BY keywords.bug_id, keyworddefs.name");

641
my $lastb = 0;
642 643
my @list;
while (1) {
644
    my ($b, $k) = FetchSQLData();
645
    if (!defined $b || $b != $lastb) {
646 647 648 649 650 651 652 653 654 655 656 657
        if (@list) {
            $realk{$lastb} = join(', ', @list);
        }
        if (!$b) {
            last;
        }
        $lastb = $b;
        @list = ();
    }
    push(@list, $k);
}

658
my @badbugs = ();
659

660 661
foreach my $b (keys(%keyword)) {
    if (!exists $realk{$b} || $realk{$b} ne $keyword{$b}) {
662
        push(@badbugs, $b);
663 664 665 666
    }
}
foreach my $b (keys(%realk)) {
    if (!exists $keyword{$b}) {
667
        push(@badbugs, $b);
668 669
    }
}
670 671
if (@badbugs) {
    @badbugs = sort {$a <=> $b} @badbugs;
672 673
    Alert(scalar(@badbugs) . " bug(s) found with incorrect keyword cache: " .
          BugListLinks(@badbugs));
674
    if (defined $cgi->param('rebuildkeywordcache')) {
675
        Status("OK, now fixing keyword cache.");
676
        foreach my $b (@badbugs) {
677 678 679 680
            my $k = '';
            if (exists($realk{$b})) {
                $k = $realk{$b};
            }
681
            SendSQL("UPDATE bugs SET keywords = " . SqlQuote($k) .
682 683 684 685 686 687 688 689
                    " WHERE bug_id = $b");
        }
        Status("Keyword cache fixed.");
    } else {
        print qq{<a href="sanitycheck.cgi?rebuildkeywordcache=1">Click here to rebuild the keyword cache</a><p>\n};
    }
}

690
if (defined $cgi->param('rebuildkeywordcache')) {
691
    $dbh->bz_unlock_tables();
692
}
693

694
###########################################################################
695
# General bug checks
696 697
###########################################################################

698
sub BugCheck {
699
    my ($middlesql, $errortext, $repairparam, $repairtext) = @_;
700 701 702 703 704 705 706 707 708 709 710
    
    SendSQL("SELECT DISTINCT bugs.bug_id " .
            "FROM $middlesql " .
            "ORDER BY bugs.bug_id");
    
    my @badbugs = ();
    
    while (@row = FetchSQLData()) {
        my ($id) = (@row);
        push (@badbugs, $id);
    }
711

712
    if (@badbugs) {
713
        Alert("$errortext: " . BugListLinks(@badbugs));
714 715 716 717 718
        if ($repairparam) {
            $repairtext ||= 'Repair these bugs';
            print qq{<a href="sanitycheck.cgi?$repairparam=1">$repairtext</a>.},
                  '<p>';
        }
719
    }
720 721
}

722 723 724 725 726
Status("Checking for bugs with no creation date (which makes them invisible)");

BugCheck("bugs WHERE creation_ts IS NULL", "Bugs with no creation date",
         "repair_creation_date", "Repair missing creation date for these bugs");

727
Status("Checking resolution/duplicates");
728

729 730
BugCheck("bugs INNER JOIN duplicates ON bugs.bug_id = duplicates.dupe " .
         "WHERE bugs.resolution != 'DUPLICATE'",
731
         "Bug(s) found on duplicates table that are not marked duplicate");
732

733 734 735 736
BugCheck("bugs LEFT JOIN duplicates ON bugs.bug_id = duplicates.dupe WHERE " .
         "bugs.resolution = 'DUPLICATE' AND " .
         "duplicates.dupe IS NULL",
         "Bug(s) found marked resolved duplicate and not on duplicates table");
737 738 739

Status("Checking statuses/resolutions");

740
my @open_states = map(SqlQuote($_), BUG_STATE_OPEN);
741 742
my $open_states = join(', ', @open_states);

743 744 745 746
BugCheck("bugs WHERE bug_status IN ($open_states) AND resolution != ''",
         "Bugs with open status and a resolution");
BugCheck("bugs WHERE bug_status NOT IN ($open_states) AND resolution = ''",
         "Bugs with non-open status and no resolution");
747 748 749

Status("Checking statuses/everconfirmed");

750
BugCheck("bugs WHERE bug_status = 'UNCONFIRMED' AND everconfirmed = 1",
751 752 753
         "Bugs that are UNCONFIRMED but have everconfirmed set");
# The below list of resolutions is hardcoded because we don't know if future
# resolutions will be confirmed, unconfirmed or maybeconfirmed.  I suspect
754
# they will be maybeconfirmed, e.g. ASLEEP and REMIND.  This hardcoding should
755 756 757
# disappear when we have customised statuses.
BugCheck("bugs WHERE bug_status IN ('NEW', 'ASSIGNED', 'REOPENED') AND everconfirmed = 0",
         "Bugs with confirmed status but don't have everconfirmed set"); 
758 759 760

Status("Checking votes/everconfirmed");

761 762
BugCheck("bugs INNER JOIN products ON bugs.product_id = products.id " .
         "WHERE everconfirmed = 0 AND votestoconfirm <= votes",
763
         "Bugs that have enough votes to be confirmed but haven't been");
764

765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782
###########################################################################
# Date checks
###########################################################################

sub DateCheck {
    my $table = shift @_;
    my $field = shift @_;
    Status("Checking dates in $table.$field");
    SendSQL("SELECT COUNT( $field ) FROM $table WHERE $field > NOW()");
    my $c = FetchOneColumn();
    if ($c) {
        Alert("Found $c dates in future");
    }
}
    
DateCheck("groups", "last_changed");
DateCheck("profiles", "refreshed_when");

783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806
###########################################################################
# Control Values
###########################################################################

# Checks for values that are invalid OR
# not among the 9 valid combinations
Status("Checking for bad values in group_control_map");
SendSQL("SELECT COUNT(product_id) FROM group_control_map WHERE " .
        "membercontrol NOT IN(" . CONTROLMAPNA . "," . CONTROLMAPSHOWN .
        "," . CONTROLMAPDEFAULT . "," . CONTROLMAPMANDATORY . ")" .
        " OR " .
        "othercontrol NOT IN(" . CONTROLMAPNA . "," . CONTROLMAPSHOWN .
        "," . CONTROLMAPDEFAULT . "," . CONTROLMAPMANDATORY . ")" .
        " OR " .
        "( (membercontrol != othercontrol) " .
          "AND (membercontrol != " . CONTROLMAPSHOWN . ") " .
          "AND ((membercontrol != " . CONTROLMAPDEFAULT . ") " .
            "OR (othercontrol = " . CONTROLMAPSHOWN . ")))");
my $c = FetchOneColumn();
if ($c) {
    Alert("Found $c bad group_control_map entries");
}

Status("Checking for bugs with groups violating their product's group controls");
807
BugCheck("bugs
808 809 810 811
         INNER JOIN bug_group_map
            ON bugs.bug_id = bug_group_map.bug_id
          LEFT JOIN group_control_map
            ON bugs.product_id = group_control_map.product_id
812
           AND bug_group_map.group_id = group_control_map.group_id
813
         WHERE ((group_control_map.membercontrol = " . CONTROLMAPNA . ")
814
         OR (group_control_map.membercontrol IS NULL))",
815 816 817 818
         'Have groups not permitted for their products',
         'createmissinggroupcontrolmapentries',
         'Permit the missing groups for the affected products
          (set member control to <code>SHOWN</code>)');
819

820
BugCheck("bugs
821
         INNER JOIN group_control_map
822
            ON bugs.product_id = group_control_map.product_id
823 824 825 826 827
         INNER JOIN groups
            ON group_control_map.group_id = groups.id
          LEFT JOIN bug_group_map
            ON bugs.bug_id = bug_group_map.bug_id
           AND group_control_map.group_id = bug_group_map.group_id
828
         WHERE group_control_map.membercontrol = " . CONTROLMAPMANDATORY . "
829 830
           AND bug_group_map.group_id IS NULL
           AND groups.isactive != 0",
831 832 833
         "Are missing groups required for their products");


834 835 836 837 838 839 840 841 842
###########################################################################
# Unsent mail
###########################################################################

Status("Checking for unsent mail");

@badbugs = ();

SendSQL("SELECT bug_id " .
843
        "FROM bugs WHERE (lastdiffed IS NULL OR lastdiffed < delta_ts) AND " .
844
        "delta_ts < now() - " . $dbh->sql_interval(30, 'MINUTE') .
845
        " ORDER BY bug_id");
846 847 848 849 850 851 852 853

while (@row = FetchSQLData()) {
    my ($id) = (@row);
    push(@badbugs, $id);
}

if (@badbugs > 0) {
    Alert("Bugs that have changes but no mail sent for at least half an hour: " .
854 855
          BugListLinks(@badbugs));

856
    print qq{<a href="sanitycheck.cgi?rescanallBugMail=1">Send these mails</a>.<p>\n};
857 858
}

859 860 861
###########################################################################
# End
###########################################################################
862 863

Status("Sanity check completed.");
864
$template->put_footer();