Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
bugzilla
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
etersoft
bugzilla
Commits
f0bcee1a
Commit
f0bcee1a
authored
Aug 15, 2006
by
mkanat%bugzilla.org
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Bug 348464: votes.cgi fails with a taint error
Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave
parent
5ce0b3db
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
5 deletions
+5
-5
votes.cgi
votes.cgi
+5
-5
No files found.
votes.cgi
View file @
f0bcee1a
...
...
@@ -74,14 +74,14 @@ ValidateBugID($bug_id) if defined $bug_id;
################################################################################
if
(
$action
eq
"show_bug"
)
{
show_bug
();
show_bug
(
$bug_id
);
}
elsif
(
$action
eq
"show_user"
)
{
show_user
();
show_user
(
$bug_id
);
}
elsif
(
$action
eq
"vote"
)
{
record_votes
()
if
Bugzilla
->
params
->
{
'usevotes'
};
show_user
();
show_user
(
$bug_id
);
}
else
{
ThrowCodeError
(
"unknown_action"
,
{
action
=>
$action
});
...
...
@@ -91,10 +91,10 @@ exit;
# Display the names of all the people voting for this one bug.
sub
show_bug
{
my
(
$bug_id
)
=
@_
;
my
$cgi
=
Bugzilla
->
cgi
;
my
$dbh
=
Bugzilla
->
dbh
;
my
$template
=
Bugzilla
->
template
;
my
$bug_id
=
$cgi
->
param
(
'bug_id'
);
ThrowCodeError
(
"missing_bug_id"
)
unless
defined
$bug_id
;
...
...
@@ -115,11 +115,11 @@ sub show_bug {
# Display all the votes for a particular user. If it's the user
# doing the viewing, give them the option to edit them too.
sub
show_user
{
my
(
$bug_id
)
=
@_
;
my
$cgi
=
Bugzilla
->
cgi
;
my
$dbh
=
Bugzilla
->
dbh
;
my
$user
=
Bugzilla
->
user
;
my
$template
=
Bugzilla
->
template
;
my
$bug_id
=
$cgi
->
param
(
'bug_id'
);
# If a bug_id is given, and we're editing, we'll add it to the votes list.
$bug_id
||=
""
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment