Commit f0bcee1a authored by mkanat%bugzilla.org's avatar mkanat%bugzilla.org

Bug 348464: votes.cgi fails with a taint error

Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=LpSolit, a=justdave
parent 5ce0b3db
...@@ -74,14 +74,14 @@ ValidateBugID($bug_id) if defined $bug_id; ...@@ -74,14 +74,14 @@ ValidateBugID($bug_id) if defined $bug_id;
################################################################################ ################################################################################
if ($action eq "show_bug") { if ($action eq "show_bug") {
show_bug(); show_bug($bug_id);
} }
elsif ($action eq "show_user") { elsif ($action eq "show_user") {
show_user(); show_user($bug_id);
} }
elsif ($action eq "vote") { elsif ($action eq "vote") {
record_votes() if Bugzilla->params->{'usevotes'}; record_votes() if Bugzilla->params->{'usevotes'};
show_user(); show_user($bug_id);
} }
else { else {
ThrowCodeError("unknown_action", {action => $action}); ThrowCodeError("unknown_action", {action => $action});
...@@ -91,10 +91,10 @@ exit; ...@@ -91,10 +91,10 @@ exit;
# Display the names of all the people voting for this one bug. # Display the names of all the people voting for this one bug.
sub show_bug { sub show_bug {
my ($bug_id) = @_;
my $cgi = Bugzilla->cgi; my $cgi = Bugzilla->cgi;
my $dbh = Bugzilla->dbh; my $dbh = Bugzilla->dbh;
my $template = Bugzilla->template; my $template = Bugzilla->template;
my $bug_id = $cgi->param('bug_id');
ThrowCodeError("missing_bug_id") unless defined $bug_id; ThrowCodeError("missing_bug_id") unless defined $bug_id;
...@@ -115,11 +115,11 @@ sub show_bug { ...@@ -115,11 +115,11 @@ sub show_bug {
# Display all the votes for a particular user. If it's the user # Display all the votes for a particular user. If it's the user
# doing the viewing, give them the option to edit them too. # doing the viewing, give them the option to edit them too.
sub show_user { sub show_user {
my ($bug_id) = @_;
my $cgi = Bugzilla->cgi; my $cgi = Bugzilla->cgi;
my $dbh = Bugzilla->dbh; my $dbh = Bugzilla->dbh;
my $user = Bugzilla->user; my $user = Bugzilla->user;
my $template = Bugzilla->template; my $template = Bugzilla->template;
my $bug_id = $cgi->param('bug_id');
# If a bug_id is given, and we're editing, we'll add it to the votes list. # If a bug_id is given, and we're editing, we'll add it to the votes list.
$bug_id ||= ""; $bug_id ||= "";
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment