player_thread: check command before waiting during pause

While paused, the player thread re-locks its mutex and waits for a signal. This is racy: when the command is set while the thread is waiting for the lock, it may wait forever. This patch adds another command check before player_wait().

player_thread: check command before waiting during pause
408d52fe · Max Kellermann · b9013944 · 408d52fe
Commit 408d52fe authored Nov 02, 2009 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

player_thread.c src/player_thread.c +3 -1

No files found.
--- a/src/player_thread.c
+++ b/src/player_thread.c
@@ -819,7 +819,9 @@ static void do_play(struct decoder_control *dc)

 		if (player.paused) {
 			player_lock();
-			player_wait();
+
+			if (pc.command == PLAYER_COMMAND_NONE)
+				player_wait();
 			continue;
 		} else if (music_pipe_size(player.pipe) > 0) {
 			/* at least one music chunk is ready - send it