command: don't clobber next list value when preparsing

This only breaks "update" under list command mode and no other commands. This can be done more optimally without the extra heap allocation via xstrdup(); but is uncommon enough to not matter.

command: don't clobber next list value when preparsing
5f0ed72c · Eric Wong · Max Kellermann · 11245dc1 · 5f0ed72c
Commit 5f0ed72c authored Sep 29, 2008 by Eric Wong Committed by Max Kellermann Sep 29, 2008
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 3 deletions

command.c src/command.c +6 -3

No files found.
--- a/src/command.c
+++ b/src/command.c
@@ -1422,16 +1422,19 @@ static CommandEntry *getCommandEntryAndCheckArgcAndPermission(struct client *cli

 static CommandEntry *getCommandEntryFromString(char *string, int permission)
 {
-	CommandEntry *cmd;
+	CommandEntry *cmd = NULL;
 	char *argv[COMMAND_ARGV_MAX] = { NULL };
-	int argc = buffer2array(string, argv, COMMAND_ARGV_MAX);
+	char *duplicated = xstrdup(string);
+	int argc = buffer2array(duplicated, argv, COMMAND_ARGV_MAX);

 	if (0 == argc)
-		return NULL;
+		goto out;

 	cmd = getCommandEntryAndCheckArgcAndPermission(0, permission,
 						       argc, argv);

+out:
+	free(duplicated);
 	return cmd;
 }