output/alsa: always redo DrainInternal() after writing

Draining isn't finished just because the period_buffer has run empty. It is only finished after snd_pcm_drain() has succeeded.

output/alsa: always redo DrainInternal() after writing
c9260215 · Max Kellermann · 543776d9 · c9260215 · c9260215
Commit c9260215 authored Jun 28, 2019 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

NEWS NEWS +1 -0

AlsaOutputPlugin.cxx src/output/plugins/AlsaOutputPlugin.cxx +1 -1

No files found.
--- a/NEWS
+++ b/NEWS
@@ -5,6 +5,7 @@ ver 0.21.11 (not yet released)
  - wildmidi: log error if library initialization fails
 * output
  - alsa: fix busy loop while draining
+  - alsa: fix missing drain call
  - alsa, osx: fix distortions with DSD_U32 and DoP on 32 bit CPUs
 * protocol
  - fix "list" with multiple "group" levels

--- a/src/output/plugins/AlsaOutputPlugin.cxx
+++ b/src/output/plugins/AlsaOutputPlugin.cxx
@@ -766,7 +766,7 @@ AlsaOutput::DrainInternal()
 		/* need to call CopyRingToPeriodBuffer() and
 		   WriteFromPeriodBuffer() again in the next
 		   iteration, so don't finish the drain just yet */
-		return period_buffer.IsEmpty();
+		return false;
 	}

 	if (!written)