pulse_mixer: use local pa_cvolume variable for set_volume()

Don't mess with pulse_mixer.volume for setting the volume. This variable should only be used to transfer the current volume from sink_input_vol() to pulse_mixer_get_volume().

pulse_mixer: use local pa_cvolume variable for set_volume()
d448392f · Max Kellermann · 8258457b · d448392f
Commit d448392f authored Mar 27, 2009 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

pulse_mixer.c src/mixer/pulse_mixer.c +3 -2

No files found.
--- a/src/mixer/pulse_mixer.c
+++ b/src/mixer/pulse_mixer.c
@@ -342,12 +342,13 @@ pulse_mixer_set_volume(struct mixer *mixer, unsigned volume)

 	if (pm->online) {
 		pa_operation *o;
+		struct pa_cvolume cvolume;

-		pa_cvolume_set(&pm->volume, pm->volume.channels,
+		pa_cvolume_set(&cvolume, pm->volume.channels,
 				(pa_volume_t)volume * PA_VOLUME_NORM / 100 + 0.5);

 		o = pa_context_set_sink_input_volume(pm->context, pm->index,
-						     &pm->volume, NULL, NULL);
+						     &cvolume, NULL, NULL);
 		if (o == NULL) {
 			g_debug("pa_context_set_sink_input_volume() failed");
 			return false;