- 12 Sep, 2008 6 commits
-
-
Max Kellermann authored
Preparing the merge of Eric Wollesen's patch "Refactor and cleanup of shout Ogg and MP3 audio outputs": we declare one of the struct types here, to make the merge smoother.
-
Eric Wollesen authored
The Ogg encoder is slightly less optimal under this configuration. It used to send shout data directly out of its ogg_page structures. Now, in the interest of encapsulation, it copies the data from its ogg_page structures into a buffer provided by the shout audio output plugin (see audioOutput_shout_ogg.c, line 77.) I suspect the performance impact is negligible. [mk: this patch and its description was separated from Eric's patch "Refactor and cleanup of shout Ogg and MP3 audio outputs"]
-
Max Kellermann authored
Begin dividing audioOutput_shout.c: move everything OGG Vorbis related to audioOutput_shout_ogg.c. The header audioOutput_shout.h has to keep its dependency on vorbis/vorbisenc.h, because it needs the vorbis encoder types. For this patch, we have to export several internal functions with generic names to the ABI; these will be removed later when the encoder plugin patches are merged.
-
Max Kellermann authored
Prepare the split of the shout plugin into multiple sources: move all important declarations to audioOutput_shout.h.
-
Max Kellermann authored
Remove unused code which is in comments. Remove that comment about "stolen code", since the plugin has changed much, and it isn't obvious which parts are derived.
-
Max Kellermann authored
-
- 11 Sep, 2008 6 commits
-
-
Max Kellermann authored
If the output device is already open, it may have modified outAudioFormat; in this case, outAudioFormat is still valid, and does not need an overwrite.
-
Max Kellermann authored
As long as the device isn't open, both attributes are not used. Since they will both be initialized in audio_output_open(), we do not need the initialization in audio_output_init().
-
Max Kellermann authored
In the plugin's init() function, outAudioFormat is simply a copy of reqAudioFormat. Use reqAudioFormat instead of outAudioFormat here.
-
Max Kellermann authored
Storing pointers to immutable audio_format structs isn't worth it, because the struct itself isn't much larger than the pointer. Since the shout plugin requires the user to configure a fixed audio format, we can simply copy it in myShout_initDriver().
-
Max Kellermann authored
Eliminate sameInAndOutFormats and check with audio_format_equals() each time it this information is needed. Another 4 bytes saved.
-
Max Kellermann authored
Instead of checking convertAudioFormat, we can simply check if reqAudioFormat is defined. This saves 4 bytes in the struct.
-
- 10 Sep, 2008 14 commits
-
-
Max Kellermann authored
We have git..
-
Max Kellermann authored
-
Max Kellermann authored
Save one allocation, since the whole audio_format struct is nearly the same size as the pointer to it. Check audio_format_defined(af) instead of af!=NULL.
-
Max Kellermann authored
free(NULL) isn't explicitly forbidden, but isn't exactly good style. Check the rare case that the audio buffer isn't initialized yet in closeAudioDevice(). In this case, we also don't have to call flushAudioBuffer().
-
Max Kellermann authored
To make openAudioDevice() smaller and more readable, move code to a static function. Also don't use realloc(), since the old value of the buffer isn't needed anymore, saving a memcpy().
-
Max Kellermann authored
There are too many static variables in audio.c - organize all properties of the audio buffer in a struct. The current audio format is also a property of the buffer, since it describes the buffer's data format.
-
Max Kellermann authored
Passing NULL to this function doesn't make sense, and complicates its implementation. The one caller which might pass NULL should rather check this.
-
Max Kellermann authored
The function isAudioDeviceOpen() is never used.
-
Max Kellermann authored
audio_format_clear() sets an audio_format struct to an cleared (undefined) state, which is both faster and smaller than memset(0). audio_format_defined() checks if the audio_format struct actually has a defined value (i.e. non-zero). Both can be used to avoid pointers to audio_format, replacing the "NULL" value with an "undefined" audio_format.
-
Max Kellermann authored
Remove one comparison by changing branch order.
-
Max Kellermann authored
Since the caller chain doesn't care about the return value (except for COMMAND_RETURN_KILL, COMMAND_RETURN_CLOSE), just return 0 if there is nothing special. This saves one local variable initialization, and one access to it. Also remove one unreachable "return 1" from client_read().
-
Max Kellermann authored
Don't close the client within client_process_line(), return COMMAND_RETURN_CLOSE instead. This is the signal for the caller chain to actually close it. This makes dealing with the client pointer a lot safer, since the caller always knows whether it is still valid.
-
Max Kellermann authored
It's easier to reuse the variable if it has a more generic name.
-
Max Kellermann authored
Don't update client data if it is going to be closed anyway.
-
- 09 Sep, 2008 9 commits
-
-
Max Kellermann authored
Rename it to audio_format_equals() and return "true" if they are equal.
-
Max Kellermann authored
The "!src" check in copyAudioFormat() used to hide bugs - one should never pass NULL to it. There is one caller which might pass NULL, add a check in this caller. Instead of doing mempcy(), we can simply assign the structures, which looks more natural.
-
Max Kellermann authored
Getting rid of CamcelCase, again.
-
Max Kellermann authored
Similar to decoder_control.c, output_control.c will provide functions for controlling the output thread (which will be implemented later).
-
Max Kellermann authored
No CamelCase. Also don't declare typedefs for the methods.
-
Max Kellermann authored
This function is declared, but is neither used nor implemented.
-
Max Kellermann authored
The audio_format argument to timer_new() should be constant, because it is not modified. The same is true for ShoutData.audioFormat.
-
Eric Wong authored
Otherwise we'd be writing to whatever directory that mpd is running in.
-
Eric Wong authored
The way we used non-blocking mode was HORRIBLE. It was non-blocking to ALSA, but we end up blocking in a busy loop that does absolutely NOTHING but retry. We don't check for playback cancellation (like we do in decoders) or anything. This is seriously broken and I can imagine it affects people on fast CPUs more because we do asynchronous output buffering and our ALSA device will always have data ready.
-
- 08 Sep, 2008 5 commits
-
-
Eric Wong authored
Lets not use deprecated functions. It's apparently possible to not care about the sw_params stuff at all!
-
Eric Wong authored
This is safer than the patch in http://www.musicpd.org/mantis/view.php?id=1542 with multiple audio outputs enabled. Sadly, I only noticed that patch/problem when I googled for "snd_config_update_free_global"
-
Eric Wong authored
-
Eric Wong authored
-
Eric Wong authored
We never use it for anything anyways as we release the device entirely on pause.
-