The function flac_cue_track() first calls FLAC__metadata_object_new(),
then overwrites this pointer with FLAC__metadata_get_cuesheet().  This
allocate two FLAC__StreamMetadata objects, but the first pointer is
lost, and never freed.

The FLAC replaygain parser used the "||" operator.  This made the code
stop after the first value which was found.

When one metadata check fails, return quickly.  This removes 2 levels
of indent.

This belongs into "git annotate" or AUTHORS.

It makes no difference right now, but we're about to add an endianness
flag and will want to make sure it's correctly initialised every time.

On 2009/03/17 Max Kellermann<max@duempel.org> wrote:

> There doesn't seem to be an "official" standard.  I'd say: search for
> TITLE[1] first (the most explicit form), then TITLE1, and finally fall
> back to TITLE.  This makes sure MPD supports every possible standard,
> without breaking.

I've also added some additional checks to make sure entry is long
enough.

The cue sheet embedded in a flac file doen't contain any information
about track titles and similar.  There are three possibilities: Use an
external cue sheet that includes these information, use a tag CUESHEET
with a cue sheet including these information or use tags.  I think the
latter is the best option and is already used by other projects.

This updates the copyright header to all be the same, which is
pretty much an update of where to mail request for a copy of the GPL
and the years of the MPD project. This also puts all committers under
'The Music Player Project' umbrella. These entries should go
individually in the AUTHORS file, for consistancy.

So far only seekpoints are supported, so no proper tagging yet
except for track number and track length.
Tagging should be done by parsing the cue sheet which
is often embedded as vorbis comment in flac files.
Furthermore the pathname should be configurable like "%A - %t - %T",
where %A means Artist, %t track number and %T Title or so.

Parse the vorbis comments in libflac's metadata_callback and pass them
as tag struct to the decoder API.

Renamed numOfItems to num_items.

This patch allows mpd to recognise the albumartist tag in the way
foobar2000 and others write it to files.

Splitted flac_copy_vorbis_comment() into flac_copy_comment() and
flac_copy_comment().

Simplify flac_copy_vorbis_comment() by moving the comment
identification code out.

Free the tag object when it turns out to be empty.  This simplifies
several functions and APIs.

Renamed types, functions, variables.

Use GLib's G_GNUC_UNUSED instead of gcc.h's mpd_unused.

Having an array instead of individual variables allows the use of the
replay_gain_mode enum as an array index.

Renamed functions and variables.

Don't pass the "seekable" flag with every decoder_data() invocation.
Since that flag won't change within the file, it is enough to pass it
to decoder_initialized() once per file.

Everybody should use struct input_stream.

These plugins are not input plugins, they are decoder plugins.  No
CamelCase in the directory name.

Don't compile the sources of disabled decoder plugins at all, and
don't attempt to register these.

The last bit of CamelCase in audio_format.h.  Additionally, rename a
bunch of local variables.

Do full C99 integer type conversion in all modules which were not
touched by Eric's merged patch.

chunk_length can be converted to a local variable, because it is
always reset to 0 after it was used.

Since flacSendChunk() is a trivial function and is only used in one
location, move the code there.  The advantage is that calling
decoder_data() directly returns the decoder_command value, so we can
eliminate one decoder_get_command() call.

Support for bit rates except 16 bits (and 8 bits on little endian) has
always been broken.  Since we added optimized functions for 8, 16,
24/32 bits, we can remove the generic flac_convert() function.
Instead of removing it, convert it to a wrapper function for
flac_convert_*().

Same optimization for 8 and 32 bit files, like the previous patch for
16 bit.  Along the way, this patch adds 24 bit FLAC support!

flac_convert_16() runs a lot faster than the generic (and quite buggy)
function flac_convert().  flac_convert_16() is only used for
non-stereo files, since there is already flac_convert_stereo16().

By mistake, I casted the sample value to uint16_t, which is wrong.
This patch simplifies the code by using a int16_t pointer instead of
casting to int16_t* every time.

There is still a lot of duplicated code in flac_plugin.c and
oggflac_plugin.c.  Move code from flac_plugin.c to _flac_common.c, and
use the new function flac_common_write() also in oggflac_plugin.c,
porting lots of optimizations over to it.

Getting rid of CamelCase; not having typedefs also allows us to
forward-declare the structures.

Another big patch which hides internal mpd APIs from decoder plugins:
decoder plugins regularly poll dc->command; expose it with a
decoder_api.h function.

InputPlugin is the API which is implemented by a decoder plugin.  This
belongs to the public API/ABI, so move it to decoder_api.h.  It will
later be renamed to something like "decoder_plugin".