Skip to content

M
mpd
You need to sign in or sign up before continuing.
Switch branch/tag
  1. 15 May, 2007 1 commit
  3. 05 Apr, 2007 1 commit
  5. 18 Mar, 2007 1 commit
  7. 14 Jan, 2007 2 commits
  9. 11 Jan, 2007 1 commit
  11. 26 Aug, 2006 1 commit
    • Eric Wong's avatar
      Replace strdup and {c,re,m}alloc with x* variants to check for OOM errors · 90847fc8
      Eric Wong authored 
      I'm checking for zero-size allocations and assert()-ing them,
so we can more easily get backtraces and debug problems, but we'll
also allow -DNDEBUG people to live on the edge if they wish.

We do not rely on errno when checking for OOM errors because
some implementations of malloc do not set it, and malloc
is commonly overridden by userspace wrappers.

I've spent some time looking through the source and didn't find any
obvious places where we would explicitly allocate 0 bytes, so we
shouldn't trip any of those assertions.

We also avoid allocating zero bytes because C libraries don't
handle this consistently (some return NULL, some not); and it's
dangerous either way.

git-svn-id: https://svn.musicpd.org/mpd/trunk@4690 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      90847fc8
  13. 18 Aug, 2006 1 commit
  15. 10 Aug, 2006 1 commit
  17. 01 Aug, 2006 1 commit
    • Eric Wong's avatar
      Several fixes uncovered with -pedantic · 5aca21a5
      Eric Wong authored 
      playerData.c:
proper error checking

directory.c:
properly check myFgets() for errors
(it returns NULL on error)

inputPlugins/mp3_plugin.c
get rid of commas at the end of enums

interface.c:
we weren't using long long, so strtoll isn't needed
get rid of void-pointer arithmetic

sllist.c:
get rid of void-pointer arithmetic

compress.c:
get rid of C++ comments, some compilers don't accept them

Note that I personally like void pointer arithmetic, but some
ancient compilers don't support them :(

git-svn-id: https://svn.musicpd.org/mpd/trunk@4510 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      5aca21a5
  19. 30 Jul, 2006 2 commits
    • Eric Wong's avatar
      fix some warnings introduced in the big malloc-reduction patch · a331939d
      Eric Wong authored 
      The myfprintf bugs that are fixed here were NOT introduced in the
last patch, it's just that the stricter warning checks from moving
to fprintf caused string format bugs to actually be checked by gcc

git-svn-id: https://svn.musicpd.org/mpd/trunk@4484 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      a331939d
    • Eric Wong's avatar
      interface/connection malloc reductions from mpd-ke · 4cf5d04c
      Eric Wong authored 
      This patch massively reduces the amount of heap allocations at
the interface/command layer.  Most commands with minimal output
should not allocate memory from the heap at all.  Things like
repeatedly polling status, currentsong, and volume changes
should be faster as a result, and more importantly, not a source
of memory fragmentation.

These changes should be safe in that there's no way for a
remote-client to corrupt memory or otherwise do bad stuff to
MPD, but an extra set of eyes to review would be good.  Of
course there's never any warranty :)

No longer do we use FILE * structures in the interface, which means
we don't have to allocate any new memory for most connections.

Now, before you go on about losing the buffering that FILE *
+implies+, remember that myfprintf() never took advantage of
any of the stdio buffering features.

To reduce the diff and make bugs easier to spot in the diff,
I've kept myfprintf in places where we write to files (and not
network interfaces).  Expect myfprintf to go away entirely soon
(we'll use fprintf for writing regular files).

git-svn-id: https://svn.musicpd.org/mpd/trunk@4483 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      4cf5d04c
  21. 20 Jul, 2006 2 commits
  23. 17 Jul, 2006 2 commits
    • Warren Dukes's avatar
      some quick hacks to avoid signedness warnings with gcc4 · 0bf396d6
      Warren Dukes authored 
      git-svn-id: https://svn.musicpd.org/mpd/trunk@4387 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      0bf396d6
    • Eric Wong's avatar
      sparse: ANSI-fy function declarations · a234780a
      Eric Wong authored 
      These are just warnings from sparse, but it makes the output
easier to read.  I ran this through a quick perl script, but
of course verified the output by looking at the diff and making
sure the thing still compiles.

here's the quick perl script I wrote to generate this patch:
----------- 8< -----------
use Tie::File;
defined(my $pid = open my $fh, '-|') or die $!;
if (!$pid) {
open STDERR, '>&STDOUT' or die $!;
exec 'sparse', @ARGV or die $!;
}
my $na = 'warning: non-ANSI function declaration of function';
while (<$fh>) {
print STDERR $_;
if (/^(.+?\.[ch]):(\d+):(\d+): $na '(\w+)'/o) {
my ($f, $l, $pos, $func) = ($1, $2, $3, $4);
$l--;
tie my @x, 'Tie::File', $f or die "$!: $f";
print '-', $x[$l], "\n";
$x[$l] =~ s/\b($func\s*)\(\s*\)/$1(void)/;
print '+', $x[$l], "\n";
untie @x;
}
}

git-svn-id: https://svn.musicpd.org/mpd/trunk@4378 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      a234780a
  25. 14 Jul, 2006 3 commits
  27. 13 Jul, 2006 1 commit
  29. 10 May, 2006 1 commit
  31. 18 Aug, 2005 2 commits
  33. 27 Apr, 2005 1 commit
  35. 19 Mar, 2005 2 commits
  37. 12 Mar, 2005 1 commit
  39. 07 Feb, 2005 1 commit
  41. 22 Dec, 2004 1 commit
  43. 16 Nov, 2004 1 commit
  45. 14 Nov, 2004 3 commits
  47. 11 Nov, 2004 1 commit
  49. 03 Nov, 2004 1 commit
  51. 31 Oct, 2004 1 commit
  53. 28 Oct, 2004 1 commit
  55. 12 Jul, 2004 1 commit
  57. 15 Jun, 2004 1 commit
  59. 05 Jun, 2004 1 commit