1. 14 Aug, 2020 1 commit
  2. 02 Jul, 2020 10 commits
  3. 01 Jul, 2020 23 commits
  4. 26 Jan, 2019 1 commit
    • Yue Wang's avatar
      [OSXOutput] Throw an error when device not found · 42b22187
      Yue Wang authored
      Currently it falls back to system default device (either internal speaker or headphone) when device not found. 
      I believe it is a better to fail in this case, to make it better aligned with platforms (such as alsa).
      42b22187
  5. 31 Oct, 2018 1 commit
  6. 07 Aug, 2018 1 commit
    • Yue Wang's avatar
      Fix various bugs in OS X DSD playback · 2127a482
      Yue Wang authored
      the most notable bugs are 
      
      1. osx_output_set_device_format should use the target asbd rather than AudioFormat. This is because asbd's sample rate calculation reflects the real dop target rate of the DAC, white AudioFormat's sample rate is the original DSD format rate.
      
      2. the original code value the highest rate that's the multiple of the target rate. This cause DOP always have the wrong rate chosen. This is also not necessary for PCM playback --- MPD's goal is bit perfect, and it's meaningless to raise to two or four times the PCM sample rate.
      
      3.  if sample_rate cannot be synchronized, the test for falling back to PCM is wrong. If the file format is in DSD format such fallback is necessary, whatever the params.dop setting is.
      2127a482
  7. 28 Jul, 2018 1 commit
  8. 16 Jul, 2018 1 commit
  9. 14 Jul, 2018 1 commit
    • Yue Wang's avatar
      Update OSXOutputPlugin.cxx · 1d30df9b
      Yue Wang authored
      some device seems to have issue with setting kAudioDevicePropertyVolumeScalar  with kAudioObjectPropertyElementMaster. Use AudioToolbox 's kAudioHardwareServiceDeviceProperty_VirtualMasterVolume instead. 
      
      Ideally, we should get the steoro channels first, and set the kAudioDevicePropertyVolumeScalar for each channel, which is doable as presented in https://github.com/cmus/cmus/blob/master/op/coreaudio.c. I will do a follow up PR after refactor PR.
      1d30df9b