- 16 Oct, 2009 1 commit
-
-
Max Kellermann authored
Don't initialize "vc" and "cs" with FLAC__metadata_object_new(); that value is overwritten by FLAC__metadata_get_tags() and FLAC__metadata_get_cuesheet().
-
- 13 Oct, 2009 1 commit
-
-
Max Kellermann authored
-
- 09 Jul, 2009 1 commit
-
-
Serge Ziryukin authored
External cue sheet file for "file.flac" should be named as "file.flac.cue".
-
- 06 Jul, 2009 1 commit
-
-
Max Kellermann authored
Initialize flac_data.tag right after flac_data_init(). This way, the "goto fail" won't jump to the point where tag_free(NULL) can be called.
-
- 01 Apr, 2009 1 commit
-
-
Max Kellermann authored
Move the declaration of "i" into the "for" loop.
-
- 31 Mar, 2009 4 commits
-
-
Jochen Keil authored
Cuesheets are often saved as vorbis comment flac files (CUESHEET=.. case doesn't matter). We can parse this now and use the information to tag the subtracks (from the embedded cuesheets).
-
Jochen Keil authored
-
Jochen Keil authored
-
Jochen Keil authored
-
- 28 Mar, 2009 1 commit
-
-
Jochen Keil authored
Previous cast to float didn't have any effect because one value is uint and the other is a floating type but the number itself is even.. This caused some tracks to end before they were really at an end.
-
- 16 Mar, 2009 1 commit
-
-
Mario Lenz authored
The cue sheet embedded in a flac file doen't contain any information about track titles and similar. There are three possibilities: Use an external cue sheet that includes these information, use a tag CUESHEET with a cue sheet including these information or use tags. I think the latter is the best option and is already used by other projects.
-
- 13 Mar, 2009 1 commit
-
-
Avuton Olrich authored
This updates the copyright header to all be the same, which is pretty much an update of where to mail request for a copy of the GPL and the years of the MPD project. This also puts all committers under 'The Music Player Project' umbrella. These entries should go individually in the AUTHORS file, for consistancy.
-
- 09 Mar, 2009 1 commit
-
-
Jochen Keil authored
So far only seekpoints are supported, so no proper tagging yet except for track number and track length. Tagging should be done by parsing the cue sheet which is often embedded as vorbis comment in flac files. Furthermore the pathname should be configurable like "%A - %t - %T", where %A means Artist, %t track number and %T Title or so.
-
- 05 Mar, 2009 2 commits
-
-
Max Kellermann authored
After the decoder command was obtained, don't wait until libflac detects EOF (as a side effect), quit the decoder immediately. This check was missing completely.
-
Max Kellermann authored
When the MPD core sends the decoder a command while flac_process_single() is executed, this function fails. Abort the decoder only if not seeking. This fixes a seeking bug.
-
- 01 Mar, 2009 1 commit
-
-
Max Kellermann authored
Parse the vorbis comments in libflac's metadata_callback and pass them as tag struct to the decoder API.
-
- 15 Feb, 2009 1 commit
-
-
Max Kellermann authored
Preparing for per-plugin configuration sections in mpd.conf.
-
- 17 Jan, 2009 1 commit
-
-
Max Kellermann authored
Some plugins used the APE or ID3 tag loader as a fallback when their own methods of loading tags did not work. Move this code out of all decoder plugins, into song_file_update().
-
- 15 Jan, 2009 4 commits
-
-
Max Kellermann authored
Free the tag object when it turns out to be empty. This simplifies several functions and APIs.
-
Max Kellermann authored
-
Max Kellermann authored
Use tag_is_empty() instead.
-
Max Kellermann authored
Renamed types, functions, variables.
-
- 01 Jan, 2009 1 commit
-
-
Max Kellermann authored
Use GLib's G_GNUC_UNUSED instead of gcc.h's mpd_unused.
-
- 24 Nov, 2008 1 commit
-
-
Max Kellermann authored
SEEK_SET is defined by unistd.h. Explicitly include it.
-
- 21 Nov, 2008 2 commits
-
-
Max Kellermann authored
Refuse to play audio formats which are not supported by MPD.
-
Max Kellermann authored
-
- 16 Nov, 2008 1 commit
-
-
Max Kellermann authored
Define the special value "-1" as "unknown size". Previously, there was no indicator for streams with unknown size, which might confuse some decoders.
-
- 11 Nov, 2008 2 commits
-
-
Max Kellermann authored
The stream_decode() and file_decode() methods returned a boolean, indicating whether they were able to decode the song. This is redundant, since we already know that: if decoder_initialized() has been called (and dc.state==DECODE), the plugin succeeded. Change both methods to return void.
-
Max Kellermann authored
Renamed functions and variables.
-
- 10 Nov, 2008 3 commits
-
-
Max Kellermann authored
Instead of having a seprate try_decode() method, let the stream_decode() and file_decode() methods decide whether they are able to decode the song.
-
Max Kellermann authored
The flac plugin wasn't initialized properly when an OGG file was being decoded. For some reason, flac_process_metadata() was explicitly not called for OGG files. Since that seems to fix the issue, make it always call flac_process_metadata().
-
Max Kellermann authored
Since decoder_list.c does not include the libflac headers, it cannot know whether to add the oggflac plugin to the decoder list. Solve this by always enabling the oggflac sub-plugin, even with older libflac versions. When the libflac API cannot support oggflac, disable the plugin at runtime by returning "false" from its init() method.
-
- 09 Nov, 2008 1 commit
-
-
Max Kellermann authored
Disable flac's "oggflac" sub-plugin when libflac does not support ogg-flac files.
-
- 04 Nov, 2008 1 commit
-
-
Max Kellermann authored
Instead of checking the stream_types bit set, we can simply check whether the methods stream_decode() and file_decode() are implemented.
-
- 02 Nov, 2008 1 commit
-
-
Max Kellermann authored
Don't pass the "seekable" flag with every decoder_data() invocation. Since that flag won't change within the file, it is enough to pass it to decoder_initialized() once per file.
-
- 01 Nov, 2008 2 commits
-
-
Max Kellermann authored
The strings were constant, but the pointers weren't. C syntax is somewhat tricky..
-
Max Kellermann authored
All decoder_plugin structs are initialized at compile time, and must never change.
-
- 31 Oct, 2008 1 commit
-
-
Max Kellermann authored
-
- 30 Oct, 2008 1 commit
-
-
Max Kellermann authored
Don't return 0/-1 on success/error, but true/false. Instead of int, use bool for storing flags.
-
- 29 Oct, 2008 1 commit
-
-
Max Kellermann authored
Call ob_clear() in decoder_command_finished() instead of implementing that call in every decoder plugin.
-