Commits · a80168a15b7514d58c7af2dc6d7a2b44a4791108 · Иван Мажукин / mpd

30 Jul, 2006 8 commits

gcc signedness and sparse fixes · a80168a1

authored Jul 30, 2006

git-svn-id: https://svn.musicpd.org/mpd/trunk@4489 09075e82-0dd4-0310-85a5-a0d7c8717e4f

a80168a1

commandError() cleanups, fixup gcc checks · e86fd65c

authored Jul 30, 2006

stripped binary size reduced by 9k on my machine from making
commandError a function. We'll print out error messages slightly
slower before, but the smaller binary is more than worth it.

git-svn-id: https://svn.musicpd.org/mpd/trunk@4488 09075e82-0dd4-0310-85a5-a0d7c8717e4f

e86fd65c

beginnings of a B-tree, currently insertion has been implemented and test · a0c8e365
Warren Dukes authored Jul 30, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4487 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
a0c8e365

command: fix find/search commands from the malloc reduction patch · b38c3fa1

authored Jul 30, 2006

The most we ever use is for search/find, and that limits it to the
number of tags we can have.  Add one for the command, and one extra
to catch errors clients may send us.

Thanks to Qball for reporting this bug

git-svn-id: https://svn.musicpd.org/mpd/trunk@4486 09075e82-0dd4-0310-85a5-a0d7c8717e4f

b38c3fa1

myfprintf: parse paths so we can reopen log files correctly · da2d7e0c
Eric Wong authored Jul 30, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4485 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
da2d7e0c

fix some warnings introduced in the big malloc-reduction patch · a331939d

authored Jul 30, 2006

The myfprintf bugs that are fixed here were NOT introduced in the
last patch, it's just that the stricter warning checks from moving
to fprintf caused string format bugs to actually be checked by gcc

git-svn-id: https://svn.musicpd.org/mpd/trunk@4484 09075e82-0dd4-0310-85a5-a0d7c8717e4f

a331939d

interface/connection malloc reductions from mpd-ke · 4cf5d04c

authored Jul 30, 2006

This patch massively reduces the amount of heap allocations at
the interface/command layer.  Most commands with minimal output
should not allocate memory from the heap at all.  Things like
repeatedly polling status, currentsong, and volume changes
should be faster as a result, and more importantly, not a source
of memory fragmentation.

These changes should be safe in that there's no way for a
remote-client to corrupt memory or otherwise do bad stuff to
MPD, but an extra set of eyes to review would be good.  Of
course there's never any warranty :)

No longer do we use FILE * structures in the interface, which means
we don't have to allocate any new memory for most connections.

Now, before you go on about losing the buffering that FILE *
+implies+, remember that myfprintf() never took advantage of
any of the stdio buffering features.

To reduce the diff and make bugs easier to spot in the diff,
I've kept myfprintf in places where we write to files (and not
network interfaces).  Expect myfprintf to go away entirely soon
(we'll use fprintf for writing regular files).

git-svn-id: https://svn.musicpd.org/mpd/trunk@4483 09075e82-0dd4-0310-85a5-a0d7c8717e4f

4cf5d04c

conf.c: bugfix: print out the number, not the address · 4d5b8509
Eric Wong authored Jul 30, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4482 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
4d5b8509

29 Jul, 2006 2 commits

replace buffer2array() with cstrtok() from mpd-ke · f08342c1

authored Jul 29, 2006

This modifies the string in place, and does not allocate any memory from
the heap. This is considerably smaller than the function it replaces,
and will be instrumental in getting the commands/conf malloc reductions
done.

git-svn-id: https://svn.musicpd.org/mpd/trunk@4481 09075e82-0dd4-0310-85a5-a0d7c8717e4f

f08342c1

command.c: shorten common variable names to argc and argv · f05166a6

authored Jul 29, 2006

Any C programmer with half a clue knows they mean argArrayLength
and argArray, and I find the code much easier to read and work with.

git-svn-id: https://svn.musicpd.org/mpd/trunk@4480 09075e82-0dd4-0310-85a5-a0d7c8717e4f

f05166a6

27 Jul, 2006 7 commits
- "a" -> ) in ChangeLog · 49d580b9
  J. Alexander Treuman authored Jul 27, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4479 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
  49d580b9
- Document which parameters may be specified multiple times in mpd.conf.5 · a741ee86
  J. Alexander Treuman authored Jul 27, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4478 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
  a741ee86
- conf.[ch] whitespace cleanup · ce2fa2e8
  J. Alexander Treuman authored Jul 27, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4477 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
  ce2fa2e8
- Updating compress.[ch] from AudioCompress · a48061ba
  J. Alexander Treuman authored Jul 27, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4476 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
  a48061ba
- Update author of AudioCompress in AUTHORS · 0116c27a
  J. Alexander Treuman authored Jul 27, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4475 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
  0116c27a
- Use AudioCompress for volume normalization · 22b16884
  J. Alexander Treuman authored Jul 27, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4474 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
  22b16884
- Remove libid3tag/libmad copyright from AUTHORS, since it's no longer bundled · bf5336ce
  J. Alexander Treuman authored Jul 27, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4473 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
  bf5336ce
26 Jul, 2006 12 commits

Remove the fifo plugin. It's currently useless for the average user, and making… · 8dcc3d31

authored Jul 26, 2006

Remove the fifo plugin.  It's currently useless for the average user, and making it more presentable isn't something I'm willing to do before 0.12.  It will likely be added back after 0.12, along with some very experimental stuff to make it more usable.

git-svn-id: https://svn.musicpd.org/mpd/trunk@4472 09075e82-0dd4-0310-85a5-a0d7c8717e4f

8dcc3d31

Remove the mp4ff directory from the root dir · 907fe560
Avuton Olrich authored Jul 26, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4471 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
907fe560

Typo fix · 0f78a76f

authored Jul 26, 2006

git-svn-id: https://svn.musicpd.org/mpd/trunk@4470 09075e82-0dd4-0310-85a5-a0d7c8717e4f

0f78a76f

Silence a gcc warning... Properly. · 2fa3e8ab
J. Alexander Treuman authored Jul 26, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4469 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
2fa3e8ab

Silence a gcc warning · faa3debe

authored Jul 26, 2006

git-svn-id: https://svn.musicpd.org/mpd/trunk@4468 09075e82-0dd4-0310-85a5-a0d7c8717e4f

faa3debe

jat's second tip of the day: when you change a ternary operator to an if, don't… · f2088bf8

authored Jul 26, 2006

jat's second tip of the day: when you change a ternary operator to an if, don't forget to take out everything after the :.  And don't forget my first tip either.

git-svn-id: https://svn.musicpd.org/mpd/trunk@4467 09075e82-0dd4-0310-85a5-a0d7c8717e4f

f2088bf8

Try to add the directory, again · 1bddcb6f

authored Jul 26, 2006

git-svn-id: https://svn.musicpd.org/mpd/trunk@4466 09075e82-0dd4-0310-85a5-a0d7c8717e4f

1bddcb6f

Screw this found_* stuff, just wrap parse_*() in an if · a570f8d9
J. Alexander Treuman authored Jul 26, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4465 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
a570f8d9
Don't decode the first frame if it has a xing tag, not only if it has a xing tag with a frame count · 13cca01c
J. Alexander Treuman authored Jul 26, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4464 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
13cca01c

Now commit the actual dir · 95293aad

authored Jul 26, 2006

git-svn-id: https://svn.musicpd.org/mpd/trunk@4463 09075e82-0dd4-0310-85a5-a0d7c8717e4f

95293aad

Use the lame tag's encoder delay/padding to implement gapless mp3 playback · b926dd10
J. Alexander Treuman authored Jul 26, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4462 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
b926dd10

Put mp4ff back into the tree · bf3848ef

authored Jul 26, 2006

git-svn-id: https://svn.musicpd.org/mpd/trunk@4461 09075e82-0dd4-0310-85a5-a0d7c8717e4f

bf3848ef

25 Jul, 2006 6 commits
- Parse lame tag for encoder delay/padding so we can later implement gapless · 1523e8a8
  J. Alexander Treuman authored Jul 25, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4460 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
  1523e8a8
- jat's tip of the day: remember to remove your silly debug messages before committing · a686436c
  J. Alexander Treuman authored Jul 25, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4459 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
  a686436c
- Add support for mp1/2. Thanks to Stephan Beyer for the patch. · 356f16a8
  J. Alexander Treuman authored Jul 25, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4458 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
  356f16a8
- Removing my stupid debug messages for testing xing · 073970ec
  J. Alexander Treuman authored Jul 25, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4457 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
  073970ec
- Reworking xing parsing so lame tags will fit in better · e65fb6e1
  J. Alexander Treuman authored Jul 25, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4456 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
  e65fb6e1
- Thanks for making my code totally unreadable indent! · 0979b0f7
  J. Alexander Treuman authored Jul 25, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4455 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
  0979b0f7
24 Jul, 2006 3 commits

Open the db file before daemonizing/creating the master process, so we can… · e880a878

authored Jul 24, 2006

Open the db file before daemonizing/creating the master process, so we can handle failures gracefully

git-svn-id: https://svn.musicpd.org/mpd/trunk@4454 09075e82-0dd4-0310-85a5-a0d7c8717e4f

e880a878

Do normalization if there's replaygain data but replaygain is off · 48240740
J. Alexander Treuman authored Jul 24, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4445 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
48240740

audioOutput_alsa: better period_size auto-configuration · 24c1f463

authored Jul 24, 2006

We'll try setting an initial value of 50ms, and halve it each
time snd_pcm_hw_params fails with -EPIPE.

This way we'll can use a larger (50ms) period_size whenever a device
supports it, and automatically pick smaller ones if we can't set
larger ones.

This removes the calculation borrowed from libao (svn) as well.

Other minor things:
"Alsa" => "ALSA" in error messages
_US appended to *_TIME constants so we won't get confused
(shank's request)

git-svn-id: https://svn.musicpd.org/mpd/trunk@4438 09075e82-0dd4-0310-85a5-a0d7c8717e4f

24c1f463

23 Jul, 2006 2 commits
- If we're going to create the db file, make sure the parent path is a directory · 76528555
  J. Alexander Treuman authored Jul 23, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4437 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
  76528555
- Make checkDirectoryDB check that the db file is a regular file · c3bc1e5b
  J. Alexander Treuman authored Jul 23, 2006
```
git-svn-id: https://svn.musicpd.org/mpd/trunk@4436 09075e82-0dd4-0310-85a5-a0d7c8717e4f
```
  c3bc1e5b