- 08 Dec, 2009 2 commits
-
-
Max Kellermann authored
This fixes an inconsistency in the stored playlist subsystem: when obtaining the list of playlists (listplaylist, listplaylistinfo), the file names in the playlist directory are converted to UTF-8 (according to filesystem_charset), but when saving or loading playlists, the filesystem_charset setting was ignored.
-
Max Kellermann authored
Call spl_valid_name() in spl_delete().
-
- 24 Apr, 2009 1 commit
-
-
Max Kellermann authored
spl_append_song() can crash when fopen() fails, because it attempts to close the invalid file handle (NULL) in the error handler.
-
- 13 Mar, 2009 1 commit
-
-
Avuton Olrich authored
This updates the copyright header to all be the same, which is pretty much an update of where to mail request for a copy of the GPL and the years of the MPD project. This also puts all committers under 'The Music Player Project' umbrella. These entries should go individually in the AUTHORS file, for consistancy.
-
- 25 Feb, 2009 1 commit
-
-
Max Kellermann authored
"ls" is a bad name for a library which parses URIs. We'll move the rest of the "ls" library later.
-
- 25 Jan, 2009 3 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
Don't declare and export variables specific to stored playlists in playlist.c/playlist.h.
-
Max Kellermann authored
Some code will be a little bit simpler if the dot is part of the string literal.
-
- 18 Jan, 2009 1 commit
-
-
Max Kellermann authored
-
- 08 Jan, 2009 1 commit
-
-
Max Kellermann authored
Don't use fixed static buffers. GLib allocates a new string for us anyway, let's just return this one instead of copying it.
-
- 04 Jan, 2009 4 commits
-
-
Max Kellermann authored
Use GLib's g_build_filename() instead of pfx_dir().
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
For internal checks (i.e. not in command.c), we need to check whether an URI is in the databse, in the local file system or a remote URI with a scheme.
-
- 02 Jan, 2009 1 commit
-
-
Max Kellermann authored
-
- 01 Jan, 2009 2 commits
-
-
Max Kellermann authored
To find out whether a file exists, use g_file_test() instead of stat(), because it is more portable and easier to use.
-
Max Kellermann authored
Don't pass a static buffer to map_spl_utf8_to_fs().
-
- 29 Dec, 2008 1 commit
-
-
Max Kellermann authored
Only include headers which are really needed. os_compat.h aimed to make MPD easily portable, but was never actually made portable.
-
- 28 Dec, 2008 1 commit
-
-
Max Kellermann authored
Replaced myFgets() with fgets() + g_strchomp().
-
- 24 Dec, 2008 1 commit
-
-
Max Kellermann authored
With a large maximum playlist length, the integer multiplication "playlist_max_length * MPD_PATH_MAX" may overflow. Change that to a division. This was not a dangerous bug, since it was only used for a quick estimate.
-
- 16 Dec, 2008 1 commit
-
-
Max Kellermann authored
The function didn't do anything useful, it was just several lines obfuscating that it was only forwarding isRemoteUrl()'s return value.
-
- 31 Oct, 2008 1 commit
-
-
Max Kellermann authored
Added the function map_spl_utf8_to_fs() which replaces utf8_to_fs_playlist_path().
-
- 26 Oct, 2008 1 commit
-
-
Max Kellermann authored
Cast playlist_max_length to off_t before comparing it to stat.st_size.
-
- 23 Oct, 2008 4 commits
-
-
Max Kellermann authored
The "rm" command did not send notifications to idle clients. Add it.
-
Max Kellermann authored
The function deletePlaylist() shouldn't be in playlist.c.
-
Max Kellermann authored
Don't use our deprecated linked list library, use GLib's GPtrArray instead.
-
Max Kellermann authored
Pass index arguments as unsigned integers. They must not be negative, and even if some caller accidently passes -1, it won't pass the bound checks (since it's now 2**32-1).
-
- 22 Oct, 2008 6 commits
-
-
Max Kellermann authored
spl_list() provides an interface for enumerating all stored playlists. This separates the internal playlist logic from the protocol specific function lsPlaylists().
-
Max Kellermann authored
The return value of spl_append_uri() was somewhat buggy: some branches returned ACK_* values, and some an enum playlist_result. Unify this.
-
Max Kellermann authored
Rename addToStoredPlaylist() to spl_append_uri(), and remove the clearStoredPlaylist() macro.
-
Max Kellermann authored
The two functions clearStoredPlaylist() and addToStoredPlaylist() don't belong into playlist.c. clearStoredPlaylist() was a wrapper for spl_clear(), and is converted into a CPP macro for now.
-
Max Kellermann authored
Renamed all public functions, prefix is "spl_".
-
Max Kellermann authored
No CamelCase in file names.
-
- 14 Oct, 2008 3 commits
-
-
Max Kellermann authored
"idle" waits until something noteworthy happens on the server, e.g. song change, playlist modified, database updated. This allows clients to keep up to date without polling.
-
Max Kellermann authored
The mapper library maps directory and song objects to file system paths. With this central library, the code mixture in path.c should be cleaned up, and we will be able to add neat features like aliasing.
-
Max Kellermann authored
playlist_print_song() and playlist_print_uri() handle charset conversion and (optional) music directory prefixing.
-
- 09 Oct, 2008 1 commit
-
-
Max Kellermann authored
Search'n'replace typo..
-
- 08 Oct, 2008 3 commits
-
-
Max Kellermann authored
Yet another CamelCase removal patch.
-
Max Kellermann authored
Taming the directory.c monster, part II: move the database management stuff to database. directory.c should only contain code which works on directory objects.
-
Max Kellermann authored
CamelCase is ugly... rename all functions.
-