Skip to content

M
mpd
Switch branch/tag
  1. 26 Mar, 2008 3 commits
    • Max Kellermann's avatar
      inputPlugins/oggvorbis: removed unused variables · 5a62c5cf
      Max Kellermann authored 
      The local variable eof can actually be replaced with a simple "break".
With a negative ret, the value of chunkpos can be invalidated, I am
not sure if this might have been a bug.

[ew: no, a negative ret will correspond to ret == OV_HOLE and ret
will be reset to zero leaving chunkpos untouched (code cleaned up
to make this more obvious]

git-svn-id: https://svn.musicpd.org/mpd/trunk@7202 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      5a62c5cf
    • Max Kellermann's avatar
      eliminated duplicate initialization · c5b524e3
      Max Kellermann authored 
      Local variables which are never read before the first assignment don't
need initialization.  Saves a few bytes of text.  Also don't reset
variables which are never read until function return.

git-svn-id: https://svn.musicpd.org/mpd/trunk@7199 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      c5b524e3
    • Max Kellermann's avatar
      explicitly downcast · 66fe5806
      Max Kellermann authored 
      Tools like "sparse" check for missing downcasts, since implicit cast
may be dangerous.  Although that does not change the compiler result,
it may make the code more readable (IMHO), because you always see when
there may be data cut off.

git-svn-id: https://svn.musicpd.org/mpd/trunk@7196 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      66fe5806
  3. 20 Mar, 2008 1 commit
  5. 05 Feb, 2008 1 commit
  7. 26 Jan, 2008 3 commits
  9. 03 Jan, 2008 1 commit
    • Eric Wong's avatar
      Cleanup #includes of standard system headers and put them in one place · cb8f1af3
      Eric Wong authored 
      This will make refactoring features easier, especially now that
pthreads support and larger refactorings are on the horizon.

Hopefully, this will make porting to other platforms (even
non-UNIX-like ones for masochists) easier, too.

os_compat.h will house all the #includes for system headers
considered to be the "core" of MPD.  Headers for optional
features will be left to individual source files.

git-svn-id: https://svn.musicpd.org/mpd/trunk@7130 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      cb8f1af3
  11. 01 Jan, 2008 2 commits
  13. 31 Dec, 2007 2 commits
  15. 10 Dec, 2007 1 commit
  17. 06 Dec, 2007 1 commit
  19. 28 Nov, 2007 1 commit
  21. 03 Oct, 2007 1 commit
  23. 17 Sep, 2007 1 commit
  25. 14 Sep, 2007 1 commit
  27. 10 Sep, 2007 1 commit
  29. 05 Sep, 2007 1 commit
  31. 28 Aug, 2007 1 commit
  33. 27 Aug, 2007 1 commit
  35. 22 Aug, 2007 1 commit
    • J. Alexander Treuman's avatar
      inputPlugins/mp3_plugin: parse LAME tags for ReplayGain info · fe4b16ed
      J. Alexander Treuman authored 
      Parse ReplayGain info in LAME tags and use it if no ID3v2 ReplayGain tags
are found.  This is currently a bit unsafe, as apparently some LAME tags
have bogus ReplayGain values.  But I'm finding a lot of MP3s with valid
LAME tags that fail the LAME tag CRC check.  So until I figure out why
that's happening, it's an unreliable method for checking if the LAME tag is
valid.

A big thanks to tmz for writing the original patch.

git-svn-id: https://svn.musicpd.org/mpd/trunk@6798 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      fe4b16ed
  37. 11 Aug, 2007 1 commit
  39. 25 Jun, 2007 3 commits
  41. 24 Jun, 2007 1 commit
  43. 04 Jun, 2007 2 commits
  45. 03 Jun, 2007 1 commit
  47. 22 May, 2007 1 commit
  49. 09 Apr, 2007 1 commit
  51. 05 Apr, 2007 1 commit
  53. 31 Mar, 2007 2 commits
  55. 02 Mar, 2007 1 commit
  57. 14 Jan, 2007 2 commits