msi: Fix a record leak on failure removing a column (Coverity).

19516835 · Nikolay Sivov · Alexandre Julliard · 203d282a · 19516835
Commit 19516835 authored Mar 27, 2014 by Nikolay Sivov Committed by Alexandre Julliard Mar 27, 2014
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

table.c dlls/msi/table.c +3 -0

No files found.
--- a/dlls/msi/table.c
+++ b/dlls/msi/table.c
@@ -1970,7 +1970,10 @@ static UINT TABLE_remove_column(struct tagMSIVIEW *view, LPCWSTR table, UINT num

    r = TABLE_CreateView(tv->db, szColumns, &columns);
    if (r != ERROR_SUCCESS)
+    {
+        msiobj_release(&rec->hdr);
        return r;
+    }

    r = msi_table_find_row((MSITABLEVIEW *)columns, rec, &row, NULL);
    if (r != ERROR_SUCCESS)