quartz/dsoundrender: Don't drop stream_cs in DSoundRender_SendSampleData().

We don't grab stream_cs to change any variables checked here, except to reset flush_event, and that cannot result in a deadlock. The only possible deadlocks here are: (1) between this function and EndOfStream(), which is correct, as the two should presumably be serialized; (2) between this function and EndFlush(); however, in that case we expect BeginFlush() first, which will unblock the streaming thread. Signed-off-by: Zebediah Figura <z.figura12@gmail.com> Signed-off-by: Alexandre Julliard <julliard@winehq.org>

quartz/dsoundrender: Don't drop stream_cs in DSoundRender_SendSampleData().
cf366488 · Zebediah Figura · Alexandre Julliard · 2d6043eb · cf366488
Commit cf366488 authored Nov 30, 2020 by Zebediah Figura Committed by Alexandre Julliard Dec 01, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 2 deletions

dsoundrender.c dlls/quartz/dsoundrender.c +0 -2

No files found.
--- a/dlls/quartz/dsoundrender.c
+++ b/dlls/quartz/dsoundrender.c
@@ -257,9 +257,7 @@ static HRESULT DSoundRender_SendSampleData(struct dsound_render *This,
            hr = S_FALSE;

        if (hr != S_OK) {
-            LeaveCriticalSection(&This->stream_cs);
            ret = WaitForSingleObject(This->flush_event, 10);
-            EnterCriticalSection(&This->stream_cs);
            if (This->sink.flushing || This->filter.state == State_Stopped)
                return This->filter.state == State_Paused ? S_OK : VFW_E_WRONG_STATE;
            if (ret != WAIT_TIMEOUT)